Re: [PATCH V4] Fix pointer cast for 32 bits arch

2015-05-03 Thread Greg Kroah-Hartman
On Thu, Apr 16, 2015 at 08:36:51PM +0200, Peter Senna Tschudin wrote: > On Thu, Apr 16, 2015 at 7:05 PM, Alan Cox wrote: > > On Thu, 2015-04-16 at 20:01 +0300, Dan Carpenter wrote: > >> On Thu, Apr 16, 2015 at 06:14:55PM +0200, Geert Uytterhoeven wrote: > >> > On Thu, Apr 16, 2015 at 3:39 PM, Pete

Re: [PATCH V4] Fix pointer cast for 32 bits arch

2015-04-18 Thread Dan Carpenter
On Sat, Apr 18, 2015 at 03:34:08PM +0200, Peter Senna Tschudin wrote: > > > On Fri, Apr 17, 2015 at 4:10 PM, Alan Cox wrote: > > On Fri, 2015-04-17 at 16:59 +0300, Dan Carpenter wrote: > >> On Fri, Apr 17, 2015 at 02:31:49PM +0100, Alan Cox wrote: > >> > On Fri, 2015-04-17 at 11:20 +0300, Dan Ca

Re: [PATCH V4] Fix pointer cast for 32 bits arch

2015-04-18 Thread Peter Senna Tschudin
On Fri, Apr 17, 2015 at 4:10 PM, Alan Cox wrote: > On Fri, 2015-04-17 at 16:59 +0300, Dan Carpenter wrote: >> On Fri, Apr 17, 2015 at 02:31:49PM +0100, Alan Cox wrote: >> > On Fri, 2015-04-17 at 11:20 +0300, Dan Carpenter wrote: >> > > Actually, my patch seems like a good idea to me but it's one

Re: [PATCH V4] Fix pointer cast for 32 bits arch

2015-04-17 Thread Alan Cox
On Fri, 2015-04-17 at 16:59 +0300, Dan Carpenter wrote: > On Fri, Apr 17, 2015 at 02:31:49PM +0100, Alan Cox wrote: > > On Fri, 2015-04-17 at 11:20 +0300, Dan Carpenter wrote: > > > Actually, my patch seems like a good idea to me but it's one of those > > > things that someone should probably test.

Re: [PATCH V4] Fix pointer cast for 32 bits arch

2015-04-17 Thread Dan Carpenter
On Fri, Apr 17, 2015 at 02:31:49PM +0100, Alan Cox wrote: > On Fri, 2015-04-17 at 11:20 +0300, Dan Carpenter wrote: > > Actually, my patch seems like a good idea to me but it's one of those > > things that someone should probably test. Unless someone can test > > goldfish on a 32 bit system with 6

Re: [PATCH V4] Fix pointer cast for 32 bits arch

2015-04-17 Thread Alan Cox
On Fri, 2015-04-17 at 11:20 +0300, Dan Carpenter wrote: > Actually, my patch seems like a good idea to me but it's one of those > things that someone should probably test. Unless someone can test > goldfish on a 32 bit system with 64 bit dma addresses No such "system" exists. Alan ___

Re: [PATCH V4] Fix pointer cast for 32 bits arch

2015-04-17 Thread Dan Carpenter
Actually, my patch seems like a good idea to me but it's one of those things that someone should probably test. Unless someone can test goldfish on a 32 bit system with 64 bit dma addresses then maybe the thing to is to write the new function but preserve the current behavior. static inline void

Re: [PATCH V4] Fix pointer cast for 32 bits arch

2015-04-17 Thread Dan Carpenter
On Thu, Apr 16, 2015 at 06:05:27PM +0100, Alan Cox wrote: > Its a 64 on 64 or 32 on 32 virtual machine. Goldfish is used for Android > emulation for all the system level phone emulation tools. On the > emulation side it provides an interface for the emulated OS but makes no > effort to emulate it a

Re: [PATCH V4] Fix pointer cast for 32 bits arch

2015-04-16 Thread Peter Senna Tschudin
On Thu, Apr 16, 2015 at 7:05 PM, Alan Cox wrote: > On Thu, 2015-04-16 at 20:01 +0300, Dan Carpenter wrote: >> On Thu, Apr 16, 2015 at 06:14:55PM +0200, Geert Uytterhoeven wrote: >> > On Thu, Apr 16, 2015 at 3:39 PM, Peter Senna Tschudin >> > wrote: >> > > --- a/drivers/staging/goldfish/goldfish_a

Re: [PATCH V4] Fix pointer cast for 32 bits arch

2015-04-16 Thread Alan Cox
On Thu, 2015-04-16 at 20:01 +0300, Dan Carpenter wrote: > On Thu, Apr 16, 2015 at 06:14:55PM +0200, Geert Uytterhoeven wrote: > > On Thu, Apr 16, 2015 at 3:39 PM, Peter Senna Tschudin > > wrote: > > > --- a/drivers/staging/goldfish/goldfish_audio.c > > > +++ b/drivers/staging/goldfish/goldfish_aud

Re: [PATCH V4] Fix pointer cast for 32 bits arch

2015-04-16 Thread Dan Carpenter
On Thu, Apr 16, 2015 at 06:14:55PM +0200, Geert Uytterhoeven wrote: > On Thu, Apr 16, 2015 at 3:39 PM, Peter Senna Tschudin > wrote: > > --- a/drivers/staging/goldfish/goldfish_audio.c > > +++ b/drivers/staging/goldfish/goldfish_audio.c > > @@ -63,7 +63,7 @@ struct goldfish_audio { > > #define AU

Re: [PATCH V4] Fix pointer cast for 32 bits arch

2015-04-16 Thread Geert Uytterhoeven
On Thu, Apr 16, 2015 at 3:39 PM, Peter Senna Tschudin wrote: > --- a/drivers/staging/goldfish/goldfish_audio.c > +++ b/drivers/staging/goldfish/goldfish_audio.c > @@ -63,7 +63,7 @@ struct goldfish_audio { > #define AUDIO_READ(data, addr) (readl(data->reg_base + addr)) > #define AUDIO_WRI

[PATCH V4] Fix pointer cast for 32 bits arch

2015-04-16 Thread Peter Senna Tschudin
As the first argument of gf_write64() was of type unsigned long, and as some calls to gf_write64() were casting the first argument from void * to u64 the compiler and/or sparse were printing warnings for casts of wrong sizes when compiling for i386. This patch changes the type of the first argumen