Actually, my patch seems like a good idea to me but it's one of those
things that someone should probably test.  Unless someone can test
goldfish on a 32 bit system with 64 bit dma addresses then maybe the
thing to is to write the new function but preserve the current behavior.

static inline void gf_write_dma_addr(dma_addr_t addr, void __iomem *portl,
                                     void __iomem *porth)
{
        writel((u32)data, portl);
        /*
         * This should be CONFIG_ARCH_DMA_ADDR_T_64BIT but someone needs to
         * test it.
         */
#ifdef CONFIG_64BIT
        writel(data >> 32, porth);
#endif
}

regards,
dan carpenter

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to