Re: [PATCH 1/3] Drivers: hv: vmbus: do cleanup on all vmbus_open() failure paths

2015-04-21 Thread Vitaly Kuznetsov
Dan Carpenter writes: > On Tue, Apr 21, 2015 at 10:17:52AM +0200, Vitaly Kuznetsov wrote: >> diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c >> index 54da66d..836386f 100644 >> --- a/drivers/hv/channel.c >> +++ b/drivers/hv/channel.c >> @@ -186,11 +186,12 @@ int vmbus_open(struct vmbus_c

Re: [PATCH 1/3] Drivers: hv: vmbus: do cleanup on all vmbus_open() failure paths

2015-04-21 Thread Vitaly Kuznetsov
>> Subject: [PATCH 1/3] Drivers: hv: vmbus: do cleanup on all vmbus_open() >> failure paths >> >> In case there was an error reported in the response to the >> CHANNELMSG_OPENCHANNEL >> call we need to do the cleanup as a vmbus_open() user won't be doing

Re: [PATCH 1/3] Drivers: hv: vmbus: do cleanup on all vmbus_open() failure paths

2015-04-21 Thread Dan Carpenter
On Tue, Apr 21, 2015 at 10:17:52AM +0200, Vitaly Kuznetsov wrote: > diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c > index 54da66d..836386f 100644 > --- a/drivers/hv/channel.c > +++ b/drivers/hv/channel.c > @@ -186,11 +186,12 @@ int vmbus_open(struct vmbus_channel *newchannel, u32 > send

RE: [PATCH 1/3] Drivers: hv: vmbus: do cleanup on all vmbus_open() failure paths

2015-04-21 Thread Dexuan Cui
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Tuesday, April 21, 2015 16:18 > To: KY Srinivasan > Cc: Haiyang Zhang; de...@linuxdriverproject.org; linux- > ker...@vger.kernel.org; Dexuan Cui > Subject: [PATCH 1/3] Drivers: hv: vmb

[PATCH 1/3] Drivers: hv: vmbus: do cleanup on all vmbus_open() failure paths

2015-04-21 Thread Vitaly Kuznetsov
In case there was an error reported in the response to the CHANNELMSG_OPENCHANNEL call we need to do the cleanup as a vmbus_open() user won't be doing it after receiving an error. The cleanup should be done on all failure paths. Signed-off-by: Vitaly Kuznetsov --- drivers/hv/channel.c | 7 -