Re: [PATCH 1/1] Staging: gdm724x: code style improvements

2015-02-13 Thread Tolga Ceylan
On Fri, Feb 13, 2015 at 1:05 AM, Dan Carpenter wrote: > > You're doing too many things at one. This should probably be split into > 7 patches. I will split this up and resubmit. > > >> u16 gdm_cpu_to_dev16(struct gdm_endian *ed, u16 x) >> @@ -39,7 +38,7 @@ u16 gdm_cpu_to_dev16(struct gdm_endia

Re: [PATCH 1/1] Staging: gdm724x: code style improvements

2015-02-13 Thread Dan Carpenter
On Fri, Feb 13, 2015 at 12:56:03AM -0800, Tolga Ceylan wrote: > Corrections based on checkpatch.pl with --strict. > 1) Lines over 80 were corrected > 2) Alignment should match open paranthesis cases corrected > 3) Comparisons such as if (x == NULL) rewritten as if (!x) > 4) CamelCase variables rena

[PATCH 1/1] Staging: gdm724x: code style improvements

2015-02-13 Thread Tolga Ceylan
Corrections based on checkpatch.pl with --strict. 1) Lines over 80 were corrected 2) Alignment should match open paranthesis cases corrected 3) Comparisons such as if (x == NULL) rewritten as if (!x) 4) CamelCase variables renamed 5) Missing spaces between operators added 6) Unnecessary blank lines