Hello Dan.
I've just submitted the patches for the staging git tree (yourself
Cc'ed). I didn't have any objections on your comments, so there isn't
much to add -- except for thank you. :)
Regards,
Eli
On 01/09/14 15:13, Dan Carpenter wrote:
Pretty nice. This is very special purpose hard
Hello, Arend.
On 01/09/14 16:08, Arend van Spriel wrote:
Maybe it would be better to use the DMA-API instead of the PCI wrappers.
I just found out that the PCI wrappers were indeed removed from the
DMA-API.txt documentation back in 2010, saying that "driver writers are
always able to use the
On Mon, Sep 01, 2014 at 10:01:38PM +0300, Eli Billauer wrote:
> Hello Tobias,
>
> Thanks for that heads-up. I'll make a separate patch for MAINTAINERS if and
> when the driver goes out of staging. No point risking the failure to apply
> the major patch because of a clash on MAINTAINERS.
You can s
Hello Tobias,
Thanks for that heads-up. I'll make a separate patch for MAINTAINERS if
and when the driver goes out of staging. No point risking the failure to
apply the major patch because of a clash on MAINTAINERS.
Regards,
Eli
On 01/09/14 15:33, Tobias Klauser wrote:
I shall continue b
Hello, Dan.
Thanks a lot for reviewing the driver. There are indeed a few things
that need fixing. I'll be back with patches and responses in a matter of
a few days.
As for the --strict option, I wasn't aware of it. I learn something new
every time. :)
Thanks again,
Eli
On 01/09/14 15:
On Mon, 2014-09-01 at 15:13 +0300, Dan Carpenter wrote:
> Pretty nice. This is very special purpose hardware and the UAPI for
> this is fine. The documentation seems good. I had some minor style
> comments but nothing major stands out.
>
> These days I quite like the --strict option for checkpa
On 2014-08-31 at 09:57:01 +0200, Eli Billauer wrote:
> This driver has been functional and stable throughout the year it has spent
> in the staging area. It has been patched for minor bugs, coding style issues
> and improvements during this period, so I suppose its time has come.
>
> I shall cont
Pretty nice. This is very special purpose hardware and the UAPI for
this is fine. The documentation seems good. I had some minor style
comments but nothing major stands out.
These days I quite like the --strict option for checkpatch.pl.
for i in $(find drivers/staging/xillybus/ -name \*\.c)
