Hello, Dan.

Thanks a lot for reviewing the driver. There are indeed a few things that need fixing. I'll be back with patches and responses in a matter of a few days.

As for the --strict option, I wasn't aware of it. I learn something new every time. :)

Thanks again,
   Eli

On 01/09/14 15:13, Dan Carpenter wrote:
Pretty nice.  This is very special purpose hardware and the UAPI for
this is fine.  The documentation seems good.  I had some minor style
comments but nothing major stands out.

These days I quite like the --strict option for checkpatch.pl.

for i in $(find drivers/staging/xillybus/ -name \*\.c)
        do ./scripts/checkpatch.pl --strict -f $i
done


_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to