Re: [PATCH] staging: vt6655: fix sparse warning for static declaration

2014-09-26 Thread Dan Carpenter
Ugh... No. It doesn't need this. It's only used in private_ioctl() for the 0xFF ioctl(). We only check wpa_Result.authenticated. The SndEvt_ToAPI define is never set so we can ignore that code. In other words we can simplify the code to look like: if (copy_from_user(&wpa_Resu

[PATCH] staging: vt6655: fix sparse warning for static declaration

2014-09-26 Thread naszar
From: "Vladimir A. Nazarenko" This patch fixes the following sparse warning: drivers/staging/vt6655/ioctl.c:44:12: warning: symbol 'wpa_Result' was not declared. Should it be static? 'wpa_Result' can't be static because it used not only in file where declared (ioctl.c). To resolve this I