Ugh...  No.  It doesn't need this.  It's only used in private_ioctl()
for the 0xFF ioctl().  We only check wpa_Result.authenticated.  The
SndEvt_ToAPI define is never set so we can ignore that code.  In other
words we can simplify the code to look like:

                if (copy_from_user(&wpa_Result, pReq->data, sizeof(wpa_Result)))
                        return -EFAULT;
                if (wpa_Result.authenticated == true)
                        pDevice->fWPA_Authened = true; /* is successful peer */

The ->fWPA_Authened flag is only used in BSSvSecondTxData() to decide if
we can call:

        PSbSendNullPacket(pDevice);

Very puzzling...  It looks to me like this is left over debug code which
should have never been merged, so we can just delete wpa_Result and the
custom 0xFF ioctl.  At least let's not built it up and add more support
functions.

On Sat, Sep 27, 2014 at 02:08:33AM +1100, naszar wrote:
> From: "Vladimir A. Nazarenko" <nas...@ya.ru>

Just fix your email client so this isn't needed.

regards,
dan carpenter

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to