Re: [PATCH] staging: vt6655: fix sparse warning: argument type

2014-12-21 Thread Malcolm Priestley
On 21/12/14 08:17, Jeremiah Mahler wrote: Eddie, all, On Sat, Dec 20, 2014 at 10:27:55PM -0700, Eddie Kovsky wrote: Fixes following warning generated by sparse: drivers/staging/vt6655/baseband.c:2180:45: warning: incorrect type in argument 1 (different address spaces) drivers/staging/vt6655/b

Re: [PATCH] staging: vt6655: fix sparse warning: argument type

2014-12-21 Thread Jeremiah Mahler
Eddie, all, On Sat, Dec 20, 2014 at 10:27:55PM -0700, Eddie Kovsky wrote: > Fixes following warning generated by sparse: > > drivers/staging/vt6655/baseband.c:2180:45: warning: incorrect type in > argument 1 (different address spaces) > drivers/staging/vt6655/baseband.c:2180:45:expected stru

[PATCH] staging: vt6655: fix sparse warning: argument type

2014-12-20 Thread Eddie Kovsky
Fixes following warning generated by sparse: drivers/staging/vt6655/baseband.c:2180:45: warning: incorrect type in argument 1 (different address spaces) drivers/staging/vt6655/baseband.c:2180:45:expected struct vnt_private *priv drivers/staging/vt6655/baseband.c:2180:45:got void [noderef]

Re: [PATCH] staging: vt6655: fix sparse warning for static declaration

2014-09-26 Thread Dan Carpenter
Ugh... No. It doesn't need this. It's only used in private_ioctl() for the 0xFF ioctl(). We only check wpa_Result.authenticated. The SndEvt_ToAPI define is never set so we can ignore that code. In other words we can simplify the code to look like: if (copy_from_user(&wpa_Resu

[PATCH] staging: vt6655: fix sparse warning for static declaration

2014-09-26 Thread naszar
From: "Vladimir A. Nazarenko" This patch fixes the following sparse warning: drivers/staging/vt6655/ioctl.c:44:12: warning: symbol 'wpa_Result' was not declared. Should it be static? 'wpa_Result' can't be static because it used not only in file where declared (ioctl.c). To resolve this I

[PATCH] staging: vt6655: fix sparse warning for static declarations

2014-06-01 Thread James A Shackleford
This patch fixes the following sparse warnings: dpc.c:65:21: warning: symbol 'acbyRxRate' was not declared. Should it be static? dpc.c:272:9: warning: symbol 'MngWorkItem' was not declared. Should it be static? dpc.c:288:1: warning: symbol 'device_receive_frame' was not declared. Should it be st

[PATCH] staging: vt6655: fix sparse warning "cast removes address space of expression"

2014-05-31 Thread James A Shackleford
Add missing __user macro to second parameter of ethtool_ioctl(). This removes the need for the offending (void *) cast of the user space pointer rq->ifr_data. Signed-off-by: James A Shackleford --- drivers/staging/vt6655/device_main.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-

[PATCH] staging: vt6655: fix sparse warning

2014-03-24 Thread ioana . ileana
From: Ioana Ileana Added missing static qualifier Signed-off-by: Ioana Ileana --- drivers/staging/vt6655/datarate.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6655/datarate.c b/drivers/staging/vt6655/datarate.c index c9a89cd..2d760da 100644 --- a/