Re: [PATCH 0/2] fix sparse warnings

2021-02-24 Thread karthek
On Wed, Feb 24, 2021 at 06:06:48PM +0300, Dan Carpenter wrote: > On Wed, Feb 24, 2021 at 08:26:41PM +0530, karthek wrote: > > On Sun, Feb 21, 2021 at 09:00:48PM +0530, karthik alapati wrote: > > > the following patches fixes two byte-order issues > > > and

Re: [PATCH 0/2] fix sparse warnings

2021-02-24 Thread karthek
On Sun, Feb 21, 2021 at 09:00:48PM +0530, karthik alapati wrote: > the following patches fixes two byte-order issues > and fixes these sparse warnings > > > drivers/staging//wimax/i2400m/op-rfkill.c:89:25: warning: incorrect type in > assignment (different base types) > drivers/staging//wimax/i

Re: [PATCH] staging: wlan-ng/p80211 : check userspacebuf size for sanity

2021-02-22 Thread karthek
On Mon, Feb 22, 2021 at 08:43:51PM +0530, karthek wrote: > On Mon, Feb 22, 2021 at 04:59:37PM +0300, Dan Carpenter wrote: > > I have added the Driver Devel list to the CC list. Adding linux-kernel > > is sort of useless. The correct people who are interested in this patch >

Re: [PATCH] staging: wlan-ng/p80211 : check userspacebuf size for sanity

2021-02-22 Thread karthek
7:12:22PM +0530, karthek wrote: > > On Mon, Feb 22, 2021 at 04:21:33PM +0300, Dan Carpenter wrote: > > > On Mon, Feb 22, 2021 at 06:16:24PM +0530, karthek wrote: > > > > currently p80211knetdev_do_ioctl() is testing user passed > > > > struct ifreq for sanity

Re: [PATCH] staging: wimax: fix sparse incorrect type issue

2021-02-21 Thread karthek
On Mon, Feb 22, 2021 at 11:10 AM Dan Carpenter wrote: > > On Sat, Feb 20, 2021 at 05:04:00PM +0530, karthik alapati wrote: > > fix sparse warning by casting to explicit user address-space > > pointer type > > > > Signed-off-by: karthik alapati > > --- > > drivers/staging/wlan-ng/p80211netdev.c |

[PATCH] staging: wimax/i2400m: fix byte-order type issue

2021-02-20 Thread karthek
fix sparse type warning by converting le32 types to host byte-order types before comparison Signed-off-by: karthek --- drivers/staging/wimax/i2400m/fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wimax/i2400m/fw.c b/drivers/staging/wimax/i2400m/fw.c

[PATCH] staging: wimax/i2400m: fix byte-order issue

2021-02-20 Thread karthek
fix sparse byte-order warnings by converting host byte-order types to le32 types Signed-off-by: karthek --- drivers/staging/wimax/i2400m/op-rfkill.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wimax/i2400m/op-rfkill.c b/drivers/staging/wimax/i2400m/op

Re: [PATCH] staging: rtl8723bs: remove obsolete commented out code

2021-02-11 Thread karthek
gt; A: Top-posting. > Q: What is the most annoying thing in e-mail? > > A: No. > Q: Should I include quotations after my reply? > > http://daringfireball.net/2007/07/on_top > > On Thu, Feb 11, 2021 at 04:00:04PM +0530, karthek wrote: > > Should i send them as patch serie

Re: [PATCH] staging: rtl8723bs: fix function comments to follow kernel-doc

2021-02-11 Thread karthek
Sorry On Thu, Feb 11, 2021 at 3:34 PM Greg Kroah-Hartman wrote: > > On Thu, Feb 11, 2021 at 12:48:16AM +0530, karthek wrote: > > check this out > > Why ask us again when you already sent a patch? Do you see any other > developers doing that on the mailing lists? >

Re: [PATCH] staging: rtl8723bs: remove obsolete commented out code

2021-02-11 Thread karthek
Should i send them as patch series? On Thu, Feb 11, 2021 at 1:27 PM Dan Carpenter wrote: > > On Thu, Feb 11, 2021 at 12:40:41AM +0530, karthik alapati wrote: > > @@ -867,10 +845,8 @@ static void PHY_HandleSwChnlAndSetBW8723B( > > if (bSetBandWidth) > > pHalData->bSetChnlBW = t

Re: [PATCH] staging: rtl8723bs: remove obsolete commented out code

2021-02-10 Thread karthek
Hey dan, check this out too ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: rtl8723bs: fix function comments to follow kernel-doc

2021-02-10 Thread karthek
check this out ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: rtl8723bs: fix function comments to follow kernel-doc

2021-02-10 Thread karthek
On Wed, Feb 10, 2021 at 02:38:28PM +0530, karthek wrote: > On Wed, Feb 10, 2021, 2:31 PM Dan Carpenter > wrote: > > > On Wed, Feb 10, 2021 at 02:28:31PM +0530, karthek wrote: > > > On Wed, Feb 10, 2021 at 1:37 PM Dan Carpenter > > wrote: > > &

Re: [PATCH] staging: rtl8723bs: fix function comments to follow kernel-doc

2021-02-10 Thread karthek
On Wed, Feb 10, 2021 at 1:37 PM Dan Carpenter wrote: > > On Wed, Feb 10, 2021 at 02:42:30AM +0530, karthik alapati wrote: > > fix checkpatch.pl warning for "block comments should align the > > * on each line" and make function comments follow kernel-doc > > > > Signed-off-by: karthik alapati > >

Re: [PATCH] staging: rtl8723bs: fix block comments alignment

2021-02-09 Thread karthek
On Wed, Feb 10, 2021 at 10:27:17AM +0300, Dan Carpenter wrote: > On Wed, Feb 10, 2021 at 12:23:17AM +0530, karthik alapati wrote: > > fix checkpatch.pl warning for "block comments should align the * on each > > line" > > > > Signed-off-by: karthik alapati > > --- > > .../staging/rtl8723bs/hal/r

[PATCH] staging: rtl8723bs: fix block comments alignment

2021-02-07 Thread karthek
fix checkpatch.pl warning for "block comments should align the * on each line" Signed-off-by: karthek --- eudyptula challenge thing .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 204 +- 1 file changed, 102 insertions(+), 102 deletions(-) diff --git a/drive