Re: [PATCH v4] staging: gdm724x: Fix DMA from stack

2021-02-11 Thread gre...@linuxfoundation.org
On Thu, Feb 11, 2021 at 01:28:41PM +, David Laight wrote: > > Stack allocated buffers cannot be used for DMA > > on all architectures so allocate hci_packet buffer > > using kmalloc. > > I wonder if the usb stack ought/could support a short bounce > buffer within the memory is already has to a

Re: [PATCH v2 09/12] media: atomisp: Fix PARENTHESIS_ALIGNMENT

2020-12-14 Thread gre...@linuxfoundation.org
On Mon, Dec 14, 2020 at 11:49:56AM +, David Laight wrote: > From: Philipp Gerlesberger > > Sent: 14 December 2020 11:04 > > > > You can sum up the two lines, because the maximum line length of > > 100 columns is not exceeded. > > IIRC the 80 column limit is preferred. Not anymore, checkpatch

Re: [PATCH v4] Add new uio device for PCI with dynamic memory allocation

2020-04-29 Thread gre...@linuxfoundation.org
On Wed, Apr 29, 2020 at 07:51:01AM +, Stahl, Manuel wrote: > On Di, 2020-04-28 at 15:54 +0200, gregkh @ linuxfoundation . org wrote: > > On Thu, Apr 16, 2020 at 06:38:30PM +0200, Manuel Stahl wrote: > > > > > > + * > > > + * Since the driver does not declare any device ids, you must allocate >

Re: [PATCH v4] Add new uio device for PCI with dynamic memory allocation

2020-04-28 Thread gre...@linuxfoundation.org
On Tue, Apr 28, 2020 at 03:47:42PM +, Stahl, Manuel wrote: > > > > > + return err; > > > + } > > > + pci_set_master(pdev); > > > + > > > + dev_info(&pdev->dev, "Legacy IRQ: %i", pdev->irq); > > > > Again, remove, be quiet :) > > Use dev_dbg() or remove completely? If it helps in deb

Re: [PATCH 2/2] uio: Prefer MSI(X) interrupts in PCI drivers

2020-03-04 Thread gre...@linuxfoundation.org
On Wed, Mar 04, 2020 at 03:19:55PM +, Stahl, Manuel wrote: > Hi Greg, > > so somehow this discussion stopped without any instructions how to proceed. What is "this discussion"? > I think this kind of driver helps every FPGA developer to interface > his design via PCIe to a Linux PC. > So if

Re: [PATCH 1/2] staging: octeon: delete driver

2020-02-04 Thread gre...@linuxfoundation.org
On Tue, Feb 04, 2020 at 12:31:16PM -0800, Matthew Wilcox wrote: > On Tue, Feb 04, 2020 at 08:06:14PM +, Chris Packham wrote: > > On Tue, 2020-02-04 at 07:09 +, gre...@linuxfoundation.org wrote: > > > On Tue, Feb 04, 2020 at 04:02:15AM +, Chris Packham wrote: >

Re: [PATCH] staging/octeon: Mark Ethernet driver as BROKEN

2020-02-03 Thread gre...@linuxfoundation.org
On Tue, Feb 04, 2020 at 12:54:26AM +, Chris Packham wrote: > Hi Greg & All, > > On Mon, 2019-12-02 at 19:15 +0100, Greg Kroah-Hartman wrote: > > On Mon, Dec 02, 2019 at 09:36:20AM -0800, Guenter Roeck wrote: > > > On Mon, Dec 02, 2019 at 05:52:31PM +0100, Greg Kroah-Hartman wrote: > > > > On M

Re: [PATCH 2/2] staging: octeon-usb: delete the octeon usb host controller driver

2020-02-03 Thread gre...@linuxfoundation.org
On Tue, Feb 04, 2020 at 04:06:51AM +, Chris Packham wrote: > On Tue, 2019-12-10 at 10:15 +0100, Greg Kroah-Hartman wrote: > > This driver was merged back in 2013 and shows no progress toward every > > being merged into the "correct" part of the kernel. The code doesn't > > even build for anyon

Re: [PATCH 1/2] staging: octeon: delete driver

2020-02-03 Thread gre...@linuxfoundation.org
On Tue, Feb 04, 2020 at 04:02:15AM +, Chris Packham wrote: > I'll pipe up on this thread too > > On Tue, 2019-12-10 at 02:42 -0800, Guenter Roeck wrote: > > On 12/10/19 1:15 AM, Greg Kroah-Hartman wrote: > > > This driver has been in the tree since 2009 with no real movement to get > > > it ou

Re: [RESEND PATCH] staging: exfat: Fix alignment warnings

2020-01-25 Thread gre...@linuxfoundation.org
On Sat, Jan 25, 2020 at 05:49:48PM +0530, Pragat Pandya wrote: > Fix checkpatch warning "Alignment should match open parenthesis". > > Signed-off-by: Pragat Pandya > --- > drivers/staging/exfat/exfat_blkdev.c | 4 ++-- > drivers/staging/exfat/exfat_core.c | 29 ++-- >

Re: [External] Re: staging: Add MA USB Host driver

2020-01-22 Thread gre...@linuxfoundation.org
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I includ

Re: [External] Re: staging: Add MA USB Host driver

2020-01-21 Thread gre...@linuxfoundation.org
On Wed, Jan 22, 2020 at 07:40:59AM +, Vladimir Stankovic wrote: > Hi Greg, > > Our intention was to follow Linux kernel development process and add our > driver to staging first. That's not the "normal" development process at all, where did you read that? staging is only for code that needs

Re: staging: Add MA USB Host driver

2020-01-21 Thread gre...@linuxfoundation.org
On Mon, Jan 20, 2020 at 09:30:43AM +, Vladimir Stankovic wrote: > MA-USB Host driver provides USB connectivity over an available > network, allowing host device to access remote USB devices attached > to one or more MA USB devices (accessible via network). > > This driver has been developed to

Re: [PATCH] drivers: staging: Add support for nCipher HSM devices

2019-12-09 Thread gre...@linuxfoundation.org
On Mon, Dec 09, 2019 at 03:41:51PM +, Kim, David wrote: > Hi Greg, > > Thanks for the speedy reply. I was hoping that setting my client to > plain text only would actually do plain text only but I will try again > with git send-email. > > This is our first driver upstreaming and we targeted s

Re: [PATCH] drivers: staging: Add support for nCipher HSM devices

2019-12-09 Thread gre...@linuxfoundation.org
On Mon, Dec 09, 2019 at 01:56:55PM +, Kim, David wrote: > > Hi everybody, > ​ > This patch introduces a driver for nCipher's Solo and Solo XC range of PCIe > hardware security modules (HSM), which provide key creation/management > and cryptography services. > > Upstreaming the nCipher driver

Re: [PATCH v2 1/3] staging: wfx: replace uintXX_t to uXX and intXX_t to sXX

2019-11-11 Thread gre...@linuxfoundation.org
On Mon, Nov 11, 2019 at 05:04:49PM +, Jerome Pouiller wrote: > I know that uXX is prefered over uintXX_t. However, I dislike to change > 650 lines of code only for this purpose in one batch. It will generate > plenty of conflicts with branches currently in development. Now that the code is

Re: [PATCH] Adjust analogix chip driver location

2019-06-26 Thread gre...@linuxfoundation.org
On Wed, Jun 26, 2019 at 10:44:38AM +, Xin Ji wrote: > Move analogix chip ANX78XX bridge driver into "analogix" directory. > > Signed-off-by: Xin Ji > --- > drivers/gpu/drm/bridge/Kconfig | 10 - > drivers/gpu/drm/bridge/Makefile|3 +- > drivers/g

Re: [PATCH] staging: kpc2000: To make symbols static

2019-06-10 Thread gre...@linuxfoundation.org
On Mon, Jun 10, 2019 at 05:50:01AM +, Rishiraj Manwatkar wrote: > This patch makes 4 symbols static as suggested by Sparse tool. > > Signed-off-by: Rishiraj Manwatkar Your subject line is very odd, what does that really mean? > --- > drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c | 8 +++

Re: [PATCH] staging: isdn: To make hysdn_proc_entry static.

2019-06-09 Thread gre...@linuxfoundation.org
On Sun, Jun 09, 2019 at 12:24:59AM +, Rishiraj Manwatkar wrote: > Made hysdn_proc_entry static as suggested by Sparse tool. Why is this indented? > > Signed-off-by: Rishiraj Manwatkar > --- > drivers/staging/isdn/hysdn/hysdn_procconf.c | 2 +- > 1 file changed, 1 insertion(+), 1 dele

Re: [PATCH v2] kpc_i2c: Remove unused file

2019-05-13 Thread 'gre...@linuxfoundation.org'
On Thu, May 09, 2019 at 02:47:50PM +, Matt Sickler wrote: > >-Original Message- > >From: Dan Carpenter > > > >Add Staging: to the subject. > > Added to my notes so I don't forget it next time. > > >[PATCH v2] Staging: kpc_i2c: Remove unused file fileops.c > > > >On Thu, May 09, 2019

Re: RFC: kpc2000 driver naming

2019-05-06 Thread 'gre...@linuxfoundation.org'
On Mon, May 06, 2019 at 02:38:16PM +, Matt Sickler wrote: > >-Original Message- > >From: 'gre...@linuxfoundation.org' > >On Sun, May 05, 2019 at 10:14:17PM +, Matt Sickler wrote: > >> The I2C and SPI drivers don't depend on anything

Re: RFC: kpc2000 driver naming

2019-05-05 Thread 'gre...@linuxfoundation.org'
On Sun, May 05, 2019 at 10:14:17PM +, Matt Sickler wrote: > > >-Original Message- > >From: 'gre...@linuxfoundation.org' > >On Fri, May 03, 2019 at 10:24:00PM +, Matt Sickler wrote: > >> Hello, > >> > >> Recently G

Re: RFC: kpc2000 driver naming

2019-05-04 Thread 'gre...@linuxfoundation.org'
On Fri, May 03, 2019 at 10:24:00PM +, Matt Sickler wrote: > Hello, > > Recently Greg KH posted the first set of drivers for our PCIe device > (kpc2000) and shortly after that I posted the kpc2000_dma driver. I was > wondering about naming / structure standards in the Linux kernel. > First,

Re: [PATCH v2] staging: kpc2000: Add DMA driver

2019-04-25 Thread 'gre...@linuxfoundation.org'
On Mon, Apr 22, 2019 at 10:05:58PM +, Matt Sickler wrote: > Add Daktronics DMA driver. I've added the SPDX license identifiers, Kconfig > entry, and cleaned up as many of the warnings as I could. > > The AIO support code will be removed in a future patch. > > Signed-off-by: Matt Sickler Lo

Re: [PATCH] staging: kpc2000: Add DMA driver

2019-04-22 Thread 'gre...@linuxfoundation.org'
On Mon, Apr 22, 2019 at 02:37:59PM +, Matt Sickler wrote: > >From 6e70cb81c75ebb0ac7897d07c0f12d80505bb22b Mon Sep 17 00:00:00 2001 > From: Matt Sickler > Date: Mon, 22 Apr 2019 09:24:03 -0500 > Subject: [PATCH] staging: kpc2000: Add DMA driver > > Add Daktronics DMA driver. I've added the S

Re: [PATCH] Staging: greybus: pwm: fixed a coding style issue

2019-03-17 Thread gre...@linuxfoundation.org
On Wed, Mar 13, 2019 at 02:09:15PM +, manuel.ram...@protonmail.com wrote: > Hello, > > this is my very first patch, very simple and check it, so it compiles > properly and also go no errors on the checkpatch script. > From c8a66a3bee14fe89ad2a03545a76953bc880b9e6 Mon Sep 17 00:00:00 2001 > F

Re: [PATCH v2] staging: mt7621-eth/ethtool.c: Correction of SPDX license identifier

2019-01-30 Thread gre...@linuxfoundation.org
On Wed, Jan 30, 2019 at 08:01:13PM +, Carlos Henrique Lima Melara wrote: > On 30/01/2019 13:29, gre...@linuxfoundation.org wrote: > > On Wed, Jan 30, 2019 at 02:48:27PM +, Carlos Henrique Lima Melara wrote: > >>This patch fix the checkpatch.p1 warning: > >>

Re: [PATCH v2] staging: mt7621-eth/ethtool.c: Correction of SPDX license identifier

2019-01-30 Thread gre...@linuxfoundation.org
On Wed, Jan 30, 2019 at 05:38:17PM +0100, Andrew Lunn wrote: > On Wed, Jan 30, 2019 at 02:48:27PM +, Carlos Henrique Lima Melara wrote: > > This patch fix the checkpatch.p1 warning: > > > > WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 > > +/* > > > > It

Re: [PATCH v2] staging: mt7621-eth/ethtool.c: Correction of SPDX license identifier

2019-01-30 Thread gre...@linuxfoundation.org
On Wed, Jan 30, 2019 at 02:48:27PM +, Carlos Henrique Lima Melara wrote: > This patch fix the checkpatch.p1 warning: > > WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 > +/* Why did you not fix up the indentation that was already mentioned? > It i

Re: linux-5.0-rc1/drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c:412]: (style) Expression is always false

2019-01-07 Thread gre...@linuxfoundation.org
On Mon, Jan 07, 2019 at 11:40:08AM +, David Binderman wrote: > > Hello there, > > linux-5.0-rc1/drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c:412]: > (style) Expression is always false because 'else if' condition matches > previous condition at line 410. > > Source code is > >

Re: [PATCH] v2 Staging : Add RIFFA PCIe staging driver

2018-12-04 Thread gre...@linuxfoundation.org
On Tue, Dec 04, 2018 at 08:13:10AM +, Cheng Fei Phung wrote: > > > For further details, please refer to > > https://github.com/KastnerRG/riffa/pull/31 > > That is not permanent, please provide the details here. > > This patch helps to enable bi-directional PCIe communication at PCIe gen2 >

Re: [PATCH] Staging : Add RIFFA PCIe staging driver

2018-12-03 Thread gre...@linuxfoundation.org
On Tue, Dec 04, 2018 at 02:19:38AM +, Cheng Fei Phung wrote: > This patch adds RIFFA PCIe linux driver for > https://github.com/promach/riffa/tree/full_duplex/driver/linux > > This staging driver is modified from this upstream driver at > https://github.com/KastnerRG/riffa/tree/master/driver

Re: [PATCH] [repost] Drivers: hv: vmbus: Offload the handling of channels to two workqueues

2018-12-02 Thread gre...@linuxfoundation.org
On Sun, Dec 02, 2018 at 08:47:03AM +, Dexuan Cui wrote: > Hi Greg, > Please use the attached patch: I rebased the patch to today's char-misc's > char-misc-linus branch. It can also cleanly apply to Linus's master branch > today. I can't use an attached patch, you know better. Please fix up an

Re: [PATCH] [repost] Drivers: hv: vmbus: Offload the handling of channels to two workqueues

2018-12-01 Thread gre...@linuxfoundation.org
On Fri, Nov 30, 2018 at 06:09:54PM +, Dexuan Cui wrote: > > From: KY Srinivasan > > Sent: Friday, November 30, 2018 9:31 AM > > > From: Dexuan Cui > > > Sent: Thursday, November 29, 2018 12:17 AM > > > To: gre...@linuxfoundation.org > > > C

Re: [PATCH] Staging : Add RIFFA PCIe driver

2018-11-30 Thread gre...@linuxfoundation.org
On Tue, Nov 27, 2018 at 05:59:48AM +, Cheng Fei Phung wrote: > This patch adds RIFFA PCIe linux driver for > https://github.com/promach/riffa/tree/full_duplex/driver/linux > > This staging driver is modified from this upstream driver at > https://github.com/KastnerRG/riffa/tree/master/driver

Re: [PATCH] [repost] Drivers: hv: vmbus: Offload the handling of channels to two workqueues

2018-11-28 Thread gre...@linuxfoundation.org
On Thu, Nov 29, 2018 at 04:36:43AM +, Dexuan Cui wrote: > > vmbus_process_offer() mustn't call channel->sc_creation_callback() > directly for sub-channels, because sc_creation_callback() -> > vmbus_open() may never get the host's response to the > OPEN_CHANNEL message (the host may rescind a c

Re: [PATCH] staging: rtl8188eu: Fix off-by-one in core/rtw_mlme_ext.c

2018-11-26 Thread gre...@linuxfoundation.org
On Tue, Nov 27, 2018 at 07:29:07AM +, Yang Xiao wrote: > From: Young_X Please use your "full" name like you did in your from: line of your email > > The error at line 3267 was the result of an off-by-one error in > a for loop in line 3253. > If condition in line 3254 never satis

Re: [PATCH] Staging : Add RIFFA PCIe driver

2018-11-20 Thread gre...@linuxfoundation.org
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? http://daringfireball.net

Re: [PATCH V4] binder: ipc namespace support for android binder

2018-11-15 Thread gre...@linuxfoundation.org
On Thu, Nov 15, 2018 at 02:33:49PM -0800, Andrew Morton wrote: > On Mon, 12 Nov 2018 09:37:51 + chouryzhou(周威) > wrote: > > > Currently android's binder is not isolated by ipc namespace. Since binder > > is a form of IPC and therefore should be tied to ipc namespace. With this > > patch, w

Re: [PATCH v2] staging: vc04_services: bcm2835-audio: Fixed warnings, checks

2018-11-12 Thread gre...@linuxfoundation.org
On Mon, Nov 12, 2018 at 07:45:00PM -0500, Arnold Chand wrote: > Corrected warnings and checks provided by scripts/checkpatch.pl which > includes: alignment of parenthesis, lines over 80 characters and mutex > definition without comment. > > Signed-off-by: Arnold Chand > --- > .../vc04_services/b

Re: [PATCH] staging: vc04_services: bcm2835-audio: Fixed warnings, checks

2018-11-12 Thread gre...@linuxfoundation.org
On Mon, Nov 12, 2018 at 07:29:09PM -0500, Arnold Chand wrote: > Corrected warnings and checks issued by scripts/checkpatch.pl which includes: > alignment of > parenthesis, lines over 80 characters and mutex definition without comment. > Signed-off-by: Arnold Chand --- > .../vc04_services/bcm2835-au

Re: [PATCH] staging: vc04_services: bcm2835-audio: Fixed warnings

2018-11-12 Thread gre...@linuxfoundation.org
On Mon, Nov 12, 2018 at 07:00:20PM -0500, Arnold Chand wrote: > Fixed warnings provided by checkpatch.pl Please be much more specific as to what you changed or "fixed". Please fix this up and resend. thanks, greg k-h ___ devel mailing list de...@linux

Re: [PATCH V2 3/5] Drivers: hv: kvp: Fix the recent regression caused by incorrect clean-up

2018-11-11 Thread gre...@linuxfoundation.org
On Sun, Nov 11, 2018 at 04:18:03AM +, Dexuan Cui wrote: > > From: gre...@linuxfoundation.org > > Sent: Thursday, November 1, 2018 21:54 > > To: Dexuan Cui > > Cc: Michael Kelley ; KY Srinivasan > > ; linux-ker...@vger.kernel.org; > > de...@linux

Re: [PATCH] Staging : Add RIFFA PCIe driver

2018-11-07 Thread gre...@linuxfoundation.org
On Mon, Oct 22, 2018 at 03:41:05AM +, Cheng Fei Phung wrote: > This patch adds RIFFA PCIe linux driver for > https://github.com/promach/riffa/tree/full_duplex/driver/linux > This staging driver is modified from this upstream driver at > https://github.com/KastnerRG/riffa/tree/master/driver/l

Re: [PATCH V2 3/5] Drivers: hv: kvp: Fix the recent regression caused by incorrect clean-up

2018-11-01 Thread gre...@linuxfoundation.org
On Thu, Nov 01, 2018 at 07:22:28PM +, Dexuan Cui wrote: > > From: gre...@linuxfoundation.org > > Sent: Thursday, November 1, 2018 11:57 > > To: Dexuan Cui > > > > On Wed, Oct 31, 2018 at 11:23:54PM +, Dexuan Cui wrote: > > > > From: Michael K

Re: [PATCH V2 3/5] Drivers: hv: kvp: Fix the recent regression caused by incorrect clean-up

2018-11-01 Thread gre...@linuxfoundation.org
On Wed, Oct 31, 2018 at 11:23:54PM +, Dexuan Cui wrote: > > From: Michael Kelley > > Sent: Wednesday, October 24, 2018 08:38 > > From: k...@linuxonhyperv.com Sent: Wednesday, > > October 17, 2018 10:10 PM > > > From: Dexuan Cui > > > > > > In kvp_send_key(), we do need call process_ib_ipinf

Re: [PATCH] Staging : Add RIFFA PCIe driver

2018-10-16 Thread gre...@linuxfoundation.org
On Tue, Oct 16, 2018 at 10:54:28AM +, Cheng Fei Phung wrote: > This patch adds RIFFA PCIe linux driver for > https://github.com/promach/riffa/tree/full_duplex/driver/linux > > TODO: > > 1) this driver needs further speed optimization although it can now achieve > defined PCIe speed grade >

Re: [PATCH] Add RIFFA PCIe driver to staging tree

2018-10-16 Thread gre...@linuxfoundation.org
On Tue, Oct 16, 2018 at 07:41:45AM +, Cheng Fei Phung wrote: > Patch changelog content: > > Add a PCIe linux driver called RIFFA to the linux staging tree. It has full > duplex capability compared to the original RIFFA linux driver that you can > easily find from https://github.com/KastnerRG

Re: [PATCH 2/5] vmbus: add driver_override support

2018-08-13 Thread gre...@linuxfoundation.org
On Mon, Aug 13, 2018 at 07:30:50PM +, Michael Kelley (EOSG) wrote: > From: k...@linuxonhyperv.com Sent: Friday, August > 10, 2018 4:06 PM > > > From: Stephen Hemminger > > > > Add support for overriding the default driver for a VMBus device > > in the same way that it can be done for PCI

Re: [PATCH] Drivers: hv: vmbus: Removed an unnecessary cast from void *

2018-05-15 Thread 'gre...@linuxfoundation.org'
On Tue, May 15, 2018 at 12:25:01AM +, Dexuan Cui wrote: > > In C, we don't need such a cast. > > Fixes: ae20b254306a ("Drivers: hv: vmbus: enable VMBus protocol version 5.0") > Reported-by: Stephen Hemminger > Signed-off-by: Dexuan Cui > Cc: K. Y. Srinivasan > --- > > Thanks Stephen Hemmi

Re: [PATCH] Drivers: hv: vmbus: Removed an unnecessary cast from void *

2018-05-15 Thread 'gre...@linuxfoundation.org'
On Tue, May 15, 2018 at 12:25:01AM +, Dexuan Cui wrote: > > In C, we don't need such a cast. > > Fixes: ae20b254306a ("Drivers: hv: vmbus: enable VMBus protocol version 5.0") > Signed-off-by: Dexuan Cui > Cc: Stephen Hemminger Should be "Reported-by:", I'll go edit this by hand :( ___

Re: [PATCH 5/5] staging: fsl-mc/dpio: Remove dead code

2018-03-08 Thread gre...@linuxfoundation.org
On Tue, Mar 06, 2018 at 06:32:00PM +, Ruxandra Ioana Ciocoi Radulescu wrote: > > -Original Message- > > From: Ruxandra Ioana Ciocoi Radulescu > > Sent: Tuesday, March 6, 2018 7:44 PM > > To: gre...@linuxfoundation.org > > Cc: de...@driverdev.osuosl.org

Re: [PATCH] staging: lustre: Fix sparse, using plain integer as NULL pointer in lov_object_fiemap()

2017-12-06 Thread gre...@linuxfoundation.org
On Mon, Dec 04, 2017 at 12:44:32PM +0200, Andrii Vladyka wrote: > Change 0 to NULL in lov_object_fiemap() in order to fix warning produced by > sparse > > Signed-off-by: Andrii Vladyka > Signed-off-by: Andreas Dilger > --- > > diff --git a/drivers/staging/lustre/lustre/lov/lov_object.c > b/dri

Re: [PATCH v3] staging: fsl-mc: use 32bits to support 64K size mc-portals

2017-11-24 Thread gre...@linuxfoundation.org
On Wed, Nov 22, 2017 at 10:49:50AM +, Laurentiu Tudor wrote: > > > On 11/22/2017 09:48 AM, Bharat Bhushan wrote: > > As per APIs each mc-portal is of 64K size while currently > > 16bits (type u16) is used to store size of mc-portal. > > In these cases upper bit of portal size gets truncated.

Re: [REVIEW REQUEST] staging: unisys: review request for visorbus

2017-11-06 Thread gre...@linuxfoundation.org
On Mon, Nov 06, 2017 at 07:17:11PM +1100, Tobin C. Harding wrote: > On Mon, Nov 06, 2017 at 09:02:21AM +0100, gre...@linuxfoundation.org wrote: > > On Mon, Nov 06, 2017 at 03:30:48PM +1100, Tobin C. Harding wrote: > > > On Mon, Oct 02, 2017 at 05:49:52PM +0200, gre...@l

Re: [REVIEW REQUEST] staging: unisys: review request for visorbus

2017-11-06 Thread gre...@linuxfoundation.org
On Mon, Nov 06, 2017 at 03:30:48PM +1100, Tobin C. Harding wrote: > On Mon, Oct 02, 2017 at 05:49:52PM +0200, gre...@linuxfoundation.org wrote: > > On Mon, Oct 02, 2017 at 03:41:42PM +, Kershner, David A wrote: > > > Hey Greg, we think the code for visorbus is ready to be

Re: [REVIEW REQUEST] staging: unisys: review request for visorbus

2017-11-03 Thread gre...@linuxfoundation.org
On Mon, Oct 02, 2017 at 05:49:52PM +0200, gre...@linuxfoundation.org wrote: > On Mon, Oct 02, 2017 at 03:41:42PM +, Kershner, David A wrote: > > Hey Greg, we think the code for visorbus is ready to be moved out > > of staging, can you review it to see if we have missed anythin

[PATCH] staging: unisys: don't care about debugfs errors

2017-11-03 Thread gre...@linuxfoundation.org
A caller should never care about a debugfs error return value, and it should never abort its normal operation if something "odd" goes on. Fix up the unisys init code to not care if the root debugfs directory for the subsystem is created or not, as no place it is used will matter. Cc: David Kershn

Re: [PATCH 2/2] uio: Prefer MSI(X) interrupts in PCI drivers

2017-10-20 Thread gre...@linuxfoundation.org
On Fri, Oct 06, 2017 at 07:57:00AM -0700, Stephen Hemminger wrote: > On Fri, 6 Oct 2017 13:50:44 + > "Stahl, Manuel" wrote: > > > MSI(X) interrupts are not shared between devices. So when available > > those should be preferred over legacy interrupts. > > > > Signed-off-by: Manuel Stahl > >

Re: [PATCH 2/2] uio: Prefer MSI(X) interrupts in PCI drivers

2017-10-06 Thread gre...@linuxfoundation.org
On Fri, Oct 06, 2017 at 01:33:32PM +, Stahl, Manuel wrote: > > Signed-off-by: Manuel Stahl > --- >  drivers/uio/uio_pci_dmem_genirq.c | 27 --- >  drivers/uio/uio_pci_generic.c | 24 ++-- >  2 files changed, 38 insertions(+), 13 deletions(-) I ca

Re: [REVIEW REQUEST] staging: unisys: review request for visorbus

2017-10-02 Thread gre...@linuxfoundation.org
On Mon, Oct 02, 2017 at 03:41:42PM +, Kershner, David A wrote: > Hey Greg, we think the code for visorbus is ready to be moved out > of staging, can you review it to see if we have missed anything? I think your html email got rejected by the list :( > The files include: > /dri

Re: [PATCH] staging: fsl-mc/dpio: Fix incorrect comparison

2017-09-28 Thread gre...@linuxfoundation.org
On Thu, Sep 28, 2017 at 01:07:48PM +, Ruxandra Ioana Radulescu wrote: > > -Original Message- > > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > > Sent: Thursday, September 28, 2017 3:49 PM > > To: Ruxandra Ioana Radulescu > > Cc:

Re: [PATCH 00/45] staging: unisys: more changes to the code.

2017-08-14 Thread gre...@linuxfoundation.org
On Thu, Aug 10, 2017 at 08:18:54PM +, Kershner, David A wrote: > > -Original Message- > > From: David Kershner [mailto:david.kersh...@unisys.com] > > Sent: Tuesday, August 1, 2017 10:40 AM > > To: gre...@linuxfoundation.org; driverdev-devel@linuxdriverproject.or

Re: [PATCH 3/3] staging: typec: add tcpci_write16_le.

2017-06-23 Thread gre...@linuxfoundation.org
On Mon, Jun 19, 2017 at 10:11:34AM +, ? ? wrote: > From: Pan Li > > Add tcpci_write16_le for pd_message header type __le16. That says what it does, but you need to explain _why_ it is needed as well. thanks, greg k-h ___ devel mailing list de...@

Re: [PATCH 1/3] staging: typec: Replace pd_header_cnt with pd_header_cnt_le

2017-06-23 Thread gre...@linuxfoundation.org
On Mon, Jun 19, 2017 at 10:11:07AM +, ? ? wrote: > From: Pan Li > > Convertn __le to cpu type when access pd_header count. I think you have a typo in this sentance :( ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverp

Re: [PATCH 1/4] staging: typec: Replace pd_header_cnt with pd_header_cnt_le

2017-06-13 Thread gre...@linuxfoundation.org
On Sun, Jun 11, 2017 at 10:53:19AM +, ? ? wrote: > From: Pan Li > > Convertn __le to cpu type when access pd_header count. Please do not indent, and please spell check where ever possible. thanks, greg k-h ___ devel mailing list de...@linuxdr

Re: [PATCH 4/4] staging: typec: Clean endianness of pd_message header access.

2017-06-13 Thread gre...@linuxfoundation.org
On Sun, Jun 11, 2017 at 10:54:42AM +, ? ? wrote: > From: Pan Li > > Makes header access happy by shared the memory between > __le16 and u16. Why are you indenting your changelog line? And I can not understand this sentence, sorry, please be more descriptive about why you are making a ch

Re: [PATCH] Restrict argument of tcpci_read16

2017-06-03 Thread gre...@linuxfoundation.org
On Fri, Jun 02, 2017 at 02:59:32AM +, ? ? wrote: > From: Pan Li > > Pan Li (1): > Restrict read pointer to 16 bit of tcpci_read16. Please fix up your subject line to properly describe what part of the kernel you are modifying. thanks, greg k-h

Re: [PATCH] staging: sm750fb: Combine set GPIO 30 & 31 into one statement

2017-04-28 Thread gre...@linuxfoundation.org
On Tue, Apr 25, 2017 at 03:53:02PM +, Lynn Lei wrote: > Combine two separate set GPIO(30 & 31) operations into one statement. Why? > > Signed-off-by: Lynn Lei > --- > drivers/staging/sm750fb/ddk750_hwi2c.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/

Re: [REGRESSION][Stable][v3.12.y][v4.4.y][v4.9.y][v4.10.y][v4.11-rc1] scsi: storvsc: properly set residual data length on errors

2017-04-03 Thread gre...@linuxfoundation.org
Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Mon, Apr 03, 2017 at 05:57:11PM +, Long Li wrote: > I think we need both going forward. They

Re: [REGRESSION][Stable][v3.12.y][v4.4.y][v4.9.y][v4.10.y][v4.11-rc1] scsi: storvsc: properly set residual data length on errors

2017-03-31 Thread gre...@linuxfoundation.org
Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Thu, Mar 30, 2017 at 09:51:53AM -0400, Cathy Avery wrote: > Hi, > > So which commit is moving

Re: [PATCH 08/29] drivers, md: convert mddev.active from atomic_t to refcount_t

2017-03-08 Thread gre...@linuxfoundation.org
On Wed, Mar 08, 2017 at 09:42:09AM +, Reshetova, Elena wrote: > > On Mon, Mar 06, 2017 at 04:20:55PM +0200, Elena Reshetova wrote: > > > refcount_t type and corresponding API should be > > > used instead of atomic_t when the variable is used as > > > a reference counter. This allows to avoid ac

Re: [PATCH 05/14] netvsc: remove no longer needed receive staging buffers

2017-02-10 Thread gre...@linuxfoundation.org
On Tue, Feb 07, 2017 at 12:32:12AM +, Stephen Hemminger wrote: > The netvsc part is already in net-next. This patch is not needed. > The part that removes the per-channel state can be in another patch. I have no idea what that means to me here, nor what I need to do, so I'm just deleting this

Re: [PATCH] Drivers: hv: vmbus: finally fix hv_need_to_signal_on_read()

2017-01-26 Thread gre...@linuxfoundation.org
On Thu, Jan 26, 2017 at 10:24:32AM +, Dexuan Cui wrote: > > From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > > To: Dexuan Cui > > > > > > v4.4.44 needs 2 patches, i.e. a389fcfd2cb5, and this patch (which is not > > > in > &g

Re: [PATCH] Drivers: hv: vmbus: finally fix hv_need_to_signal_on_read()

2017-01-26 Thread gre...@linuxfoundation.org
On Thu, Jan 26, 2017 at 09:31:32AM +, Dexuan Cui wrote: > > From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > > > > From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > > > > > > > It's interesting v4

Re: [PATCH] Drivers: hv: vmbus: finally fix hv_need_to_signal_on_read()

2017-01-26 Thread gre...@linuxfoundation.org
On Thu, Jan 26, 2017 at 08:27:26AM +, Dexuan Cui wrote: > > From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > > > > > It's interesting v4.4.44 is not impacted, but actually it needs both > > > > > the 2 > > patches:

Re: [PATCH] Drivers: hv: vmbus: finally fix hv_need_to_signal_on_read()

2017-01-25 Thread gre...@linuxfoundation.org
On Thu, Jan 26, 2017 at 07:44:46AM +, Dexuan Cui wrote: > > From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > > > Dexuan Cui wrote: > > > As I checked against the kernels listed on the homapage, > > > the below versions are impact

Re: [PATCH] Drivers: hv: vmbus: finally fix hv_need_to_signal_on_read()

2017-01-25 Thread gre...@linuxfoundation.org
On Thu, Jan 26, 2017 at 06:10:19AM +, Dexuan Cui wrote: > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Wednesday, January 25, 2017 00:08 > > To: Dexuan Cui > > Cc: gre...@linuxfoundation.org; driverdev-devel@linuxdriverproject.org; KY > &

Re: [PATCH 1/3] hyperv: Move hv_pci_dev and related structs to hyperv.h

2016-12-08 Thread gre...@linuxfoundation.org
...@exchange.microsoft.com > > Cc: o...@aepfle.de; gre...@linuxfoundation.org; jasow...@redhat.com; > > Haiyang Zhang ; linux-ker...@vger.kernel.org; > > bjorn.helg...@gmail.com; kbuild-...@01.org; a...@canonical.com; > > de...@linuxdriverproject.org; leann.ogasaw...@canoni

Re: linux-4.9-rc1/drivers/staging/lustre/lustre/osc/osc_request.c:973: always false test ?

2016-10-17 Thread gre...@linuxfoundation.org
On Mon, Oct 17, 2016 at 07:33:33AM +, David Binderman wrote: > Hello there, > > > > linux-4.9-rc1/drivers/staging/lustre/lustre/osc/osc_request.c:973]: (style) > Checking if unsigned variable 'cli.cl_avail_grant' is less than zero. > > > > Source code is > > > >    if (cli->cl_avail_g

Re: Cma mem map to cpu address when allocated in ion driver, why do this design?

2016-09-01 Thread gre...@linuxfoundation.org
On Thu, Sep 01, 2016 at 12:46:32PM +, Yangwei (Yang Wei, Device Chipset Key Technologies Platform Development Dept) wrote: > Hi all, > > When I review ion code in linux-3.18.y, I find a design that may cause > a problem in our product. In the design, cma mem is allocated via the > interface

Re: [PATCH RESEND 00/28] staging: unisys: fix visorbus & visorinput issues raised by tglx

2016-07-27 Thread gre...@linuxfoundation.org
On Wed, Jul 27, 2016 at 05:43:27PM +, Kershner, David A wrote: > > -Original Message- > > From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > > Sent: Thursday, June 16, 2016 3:03 PM > > To: Kershner, David A > > Cc: N

Re: [PATCH RESEND 00/28] staging: unisys: fix visorbus & visorinput issues raised by tglx

2016-06-16 Thread gre...@linuxfoundation.org
On Thu, Jun 16, 2016 at 05:35:58PM +, Kershner, David A wrote: > > > > -Original Message- > > From: Neil Horman [mailto:nhor...@redhat.com] > > Sent: Tuesday, June 14, 2016 9:27 AM > > Subject: Re: [PATCH RESEND 00/28] staging: unisys: fix visorbus & visorinput > > issues raised by tg

Re: [PATCH v11 net-next 0/1] introduce Hyper-V VM Sockets(hv_sock)

2016-05-18 Thread gre...@linuxfoundation.org
On Thu, May 19, 2016 at 12:59:09AM +, Dexuan Cui wrote: > > From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On > > Behalf > > Of Dexuan Cui > > Sent: Tuesday, May 17, 2016 10:46 > > To: David Miller > > Cc: o...@aepfle.de; gre...@linu

Re: [PATCH] staging: comedi: ni_mio_common: fix the ni_write[blw]() functions

2016-03-19 Thread gre...@linuxfoundation.org
On Fri, Mar 18, 2016 at 05:38:45PM +, Hartley Sweeten wrote: > On Wednesday, March 16, 2016 3:22 AM, Ian Abbott wrote: > > On 15/03/16 21:48, H Hartley Sweeten wrote: > >> Memory mapped io (dev->mmio) should not also be writing to the ioport > >> (dev->iobase) registers. Add the missing 'else'

Re: [PATCH 3/6] staging: unisys: visorbus: git rid of gotos in devmajorminor_create_file

2016-03-10 Thread gre...@linuxfoundation.org
On Wed, Mar 09, 2016 at 05:10:28PM +, Sell, Timothy C wrote: > > -Original Message- > > From: Neil Horman [mailto:nhor...@redhat.com] > > Sent: Wednesday, March 09, 2016 11:09 AM > > To: external-ges-uni...@redhat.com > > Cc: gre...@linuxf

Re: [PATCH] staging: dgnc: convert to wait_event_interruptible_timeout

2016-02-07 Thread gre...@linuxfoundation.org
On Thu, Dec 24, 2015 at 01:54:12PM +, Gujulan Elango, Hari Prasath (H.) wrote: > This patch makes use of wait_event_interruptible_timeout to achieve timeout > functionality.This is a TODO mentiond in the comment which is also removed. > It also aligns with what the function is supposed to do a

Re: [PATCH] staging: rtl8192e: prefer using eth_broadcast_addr()

2016-02-07 Thread gre...@linuxfoundation.org
On Wed, Jan 20, 2016 at 01:06:13PM +, Gujulan Elango, Hari Prasath (H.) wrote: > From: Hari Prasath Gujulan Elango When you do this, you need an email address after the name, otherwise git complains and refuses to apply the patch. Please fix up and resend. thanks, greg k-h

Re: [PATCH] staging: wilc1000: Move Macro definition

2016-02-03 Thread gre...@linuxfoundation.org
On Mon, Jan 18, 2016 at 01:42:35PM +, Gujulan Elango, Hari Prasath (H.) wrote: > From: Hari Prasath Gujulan Elango > > This patch move's a macro defined in the middle of a structure > definition to make it more readable. > > Signed-off-by: Hari Prasath Gujulan Elango > --- > drivers/stagi

Re: Missed patch for hfi1 from Gregs tree.

2016-01-28 Thread gre...@linuxfoundation.org
On Thu, Jan 28, 2016 at 03:30:23PM -0500, ira.weiny wrote: > Doug, > > The following patch was not accepted by Greg and does not appear in patchworks > > https://marc.info/?l=linux-rdma&m=145090416416677&w=2 I have a whole stack of staging patches I have yet to get through. Over 1000 at the mom

Re: [RFC PATCH 00/15] staging/rdma/hfi1: Initial patches to add rdmavt support in HFI1

2015-12-22 Thread gre...@linuxfoundation.org
On Tue, Dec 22, 2015 at 02:15:08PM -0500, ira.weiny wrote: > On Mon, Dec 21, 2015 at 05:01:48PM -0800, gre...@linuxfoundation.org wrote: > > On Mon, Dec 21, 2015 at 07:19:43PM -0500, ira.weiny wrote: > > > On Mon, Dec 21, 2015 at 02:02:35PM -0800, gre...@linuxfoundatio

Re: [RFC PATCH 00/15] staging/rdma/hfi1: Initial patches to add rdmavt support in HFI1

2015-12-21 Thread gre...@linuxfoundation.org
On Mon, Dec 21, 2015 at 07:19:43PM -0500, ira.weiny wrote: > On Mon, Dec 21, 2015 at 02:02:35PM -0800, gre...@linuxfoundation.org wrote: > > On Mon, Dec 21, 2015 at 01:12:14AM -0500, ira.weiny wrote: > > > Greg, Doug, > > > > > > As mentioned below, these patc

Re: [RFC PATCH 00/15] staging/rdma/hfi1: Initial patches to add rdmavt support in HFI1

2015-12-21 Thread gre...@linuxfoundation.org
On Mon, Dec 21, 2015 at 01:12:14AM -0500, ira.weiny wrote: > Greg, Doug, > > As mentioned below, these patches depend on the new rdmavt library submitted > to > Doug on linux-rdma. > > We continue to identify (and rework) patches by our other developers which can > be submitted without conflicts

Re: [jubin.j...@intel.com: [PATCH] staging/rdma/hfi1: Fix error in hfi1 driver build]

2015-12-14 Thread gre...@linuxfoundation.org
On Mon, Dec 14, 2015 at 02:36:39PM -0500, ira.weiny wrote: > Greg, > > It looks like you missed this patch for 4.4-rc5 > > Could we get it included for rc6? I'll try, but again, I'm way behind, give me a few more days... thanks, greg k-h ___ devel ma

Re: [PATCH 0/2] Fix 4.4 IB merge window regressions

2015-11-30 Thread gre...@linuxfoundation.org
On Mon, Nov 30, 2015 at 01:05:19PM -0500, ira.weiny wrote: > On Mon, Nov 30, 2015 at 09:34:15AM -0500, Mike Marciniszyn wrote: > > This two patch series fixes regressions for qib and hfi1 > > introduced in the 4.4 merge window. > > > > These are critical for 4.4 and for rebasing the qib/hfi1 > > r

Re: [PATCH v2 1/7] staging/rdma/hfi1: diag.c Correct code style issues

2015-11-17 Thread gre...@linuxfoundation.org
On Tue, Nov 17, 2015 at 03:30:24PM -0500, ira.weiny wrote: > On Tue, Nov 17, 2015 at 10:17:26PM +0530, Sudip Mukherjee wrote: > > On Mon, Nov 16, 2015 at 05:32:34PM -0500, ira.we...@intel.com wrote: > > > From: Jubin John > > > > > > Correct the checks on diag.c with the latest checkpatch > > >

Re: [PATCH 12/13] staging/rdma/hfi1: Read EFI variable for device description

2015-11-11 Thread gre...@linuxfoundation.org
On Wed, Nov 11, 2015 at 03:03:12PM +, Luick, Dean wrote: > > -Original Message- > > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > > Sent: Wednesday, November 11, 2015 8:39 AM > > To: Luick, Dean > > Cc: John, Jubin ; de...@driverdev.osuosl.org;

Re: [PATCH v2 07/22] staging/rdma/hfi1: Fix sparse error in sdma.h file

2015-10-25 Thread gre...@linuxfoundation.org
On Thu, Oct 22, 2015 at 01:01:25PM +0300, Dan Carpenter wrote: > On Wed, Oct 21, 2015 at 04:29:35PM +, Weiny, Ira wrote: > > > > > > On Mon, Oct 19, 2015 at 10:11:22PM -0400, ira.we...@intel.com wrote: > > > > From: Niranjana Vishwanathapura > > > > > > > > Use NULL instead of 0 for pointer a

Re: [PATCH] Staging: dgnc: Simplify a trivial if-return sequence\n From: Parshuram Thombare

2015-09-21 Thread gre...@linuxfoundation.org
On Mon, Sep 21, 2015 at 08:59:30PM +, Thombare, Parshuram (P.) wrote: > Signed-off-by: Parshuram Thombare Your subject is really odd :( ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driv

Re: [PATCH V3] staging: android: lowmemorykiller: imporve lmk to avoid deadlock issue

2015-08-05 Thread gre...@linuxfoundation.org
On Mon, Aug 03, 2015 at 08:26:40AM +, Wang, Biao wrote: > Consider the following case: > Task A trigger lmk with a lock held, while task B try to get this lock, but > unfortunately B is the very culprit task lmk select to kill. Then B will > never be killed, and A will forever select B to kil

  1   2   >