Re: [PATCH v2 2/2] staging: gdm724x: gdm_tty: replaced macro with a function

2020-09-02 Thread antoni.przyby...@wp.pl
On 02.09.2020 18:21, Randy Dunlap wrote: On 9/2/20 9:16 AM, Antoni Przybylik wrote: Changed return type to bool and removed inline specifier. Also added static specifier. why remove the inline specifier? Greg KH wrote to me: And really, no need to make it inline, just make it a normal func

Re: [PATCH] staging: gdm724x: gdm_tty: replaced macro with a function

2020-09-01 Thread antoni.przyby...@wp.pl
On 01.09.2020 19:50, Greg KH wrote: On Tue, Sep 01, 2020 at 06:18:46PM +0200, Antoni Przybylik wrote: This approach is more elegant and prevents some problems related to macros such as operator precedence in expanded expression. Signed-off-by: Antoni Przybylik --- drivers/staging/gdm724x/gd

Fwd: Re: [PATCH] staging: gdm724x: gdm_tty: corrected macro by adding brackets

2020-09-01 Thread antoni.przyby...@wp.pl
On 01.09.2020 13:08, Greg KH wrote: On Tue, Sep 01, 2020 at 12:43:11PM +0200, antoniprzybylik wrote: Such macros are dangerous. Consider following example: #define GDM_TTY_READY(gdm) (gdm && gdm->tty_dev && gdm->port.count) GDM_TTY_READY(a + b) This macro will be expanded in such