Fix spelling errors.
Co-developed-by: Annika Knepper
Signed-off-by: Annika Knepper
Signed-off-by: Andreas Hellmich
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 36 +--
.../staging/rtl8723bs/hal/HalPhyRf_8723B.c| 6 ++--
.../staging/rtl8723bs/hal/rtl8723b_hal_init.c
Fix some line length errors.
Co-developed-by: Annika Knepper
Signed-off-by: Annika Knepper
Signed-off-by: Andreas Hellmich
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 24 +++---
.../staging/rtl8723bs/hal/HalPhyRf_8723B.c| 10 --
.../staging/rtl8723bs/hal
> + if (manual)
> hal_btcoex_SetManualControl(padapter, true);
> - } else{
> + else
> hal_btcoex_SetManualControl(padapter, false);
> - }
aka. hal_btcoex_SetManualControl(padapter, manual);
Andreas.
--
Andreas Schwab, sch...@linux-m68k.org
GPG Key fingerprint = 7578 EB47
On Jun 3, 2018, at 9:59 PM, Alexey Lyashkov wrote:
>
>> On Sun, Jun 03 2018, Dilger, Andreas wrote:
>>
>>> LNet is originally based on a high-performance networking stack called
>>> Portals (v3, http://www.cs.sandia.gov/Portals/), with additions for LNet
&
e protocol into
pNFS made a lot of sense, since this would have only really been available
on Linux, at which point it would be better to use the native Lustre client
rather than funnel everything through pNFS.
However, _just_ using the LNet transport for (p)NFS might make sense. LNet
is largely inde
lso (finally) allow us to get
this code in sync with the out-of-tree code and converge on a single tree.
Cheers, Andreas
> And getting code out of staging is the main goal of that portion of the
> kernel tree. Code should not stagnate and it feels like having this
> code in staging is o
fs client code with simple IP-only networking.
Adding or removing the IB networking makes basically no difference to the
code size. This would also make the client much less useful, since a large
number of sites use Lustre with IB networks.
Cheers, Andreas
signature.asc
Description
but rather Lustre release version
checks. This allows us to remove workarounds like this in the future when
they are no longer needed, rather than accumulating cruft forever. It's like
the separation of NFSv2 vs NFSv3 vs NFSv4.
Cheers, Andreas
--
Andreas Dilger
Lustre Principal Arc
;>> unlikely built in so it's duplicative...
>>
>> Sounds like a good checkpatch case to test for :-)
>
> The likely/unlikely annotations have their place in fast paths so a
> checkpatch warning would get annoying...
I think James was suggesting a
On May 12, 2018, at 00:33, Christophe JAILLET
wrote:
>
> According to error handling path before and after this one, we should go
> to 'out_md_fid' here, instead of 'out_md', if 'obd_connect()' fails.
>
> Signed-off-by: Christophe JAILL
On May 11, 2018, at 07:38, Colin King wrote:
>
> From: Colin Ian King
>
> Trivial fix to spelling mistake in DEBUG_REQ message text
>
> Signed-off-by: Colin Ian King
Reviewed-by: Andreas Dilger
> ---
> drivers/staging/lustre/lustre/ptlrpc/client.c | 2 +-
>
curity risk for future implementations. Also, to improve code
> readability and make static analysis tools happy, which will warn
> about read-verify-re-read type bugs, this issue should be fixed.
There is nothing preventing the user from using struct lov_mds_md_v3 but
filling in lmm_magic
mentId=121776#comment-121776
That said, it might be good to include this information into the
commit comment itself.
Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
lmm_magic.
>
> This patch rechecks the version field lmm_magic in the second copy. If the
> version is not as expected, i.e., LOV_USER_MAGIC_V3, an error code will be
> returned: -EINVAL.
>
> Signed-off-by: Wenwen Wang
Thanks for the updated patch.
Reviewed-by: Andreas Dilger
&g
On Apr 29, 2018, at 07:20, Greg Kroah-Hartman
wrote:
>
> On Sat, Apr 28, 2018 at 04:04:25PM +, Dilger, Andreas wrote:
>> On Apr 27, 2018, at 17:45, Wenwen Wang wrote:
>>> [PATCH] staging: luster: llite: fix potential missing-check bug when
>>> copying lumv
copied, which
is harmless.
> This patch rechecks the version field lmm_magic in the second copy. If the
> version is not as expected, i.e., LOV_USER_MAGIC_V3, an error code will be
> returned: -EINVAL.
This isn't a bad idea in any case, since it verifies the data copied from
users
in calculation).
>
> [1] https://lkml.org/lkml/2018/3/7/621
>
> Signed-off-by: Kees Cook
> Reviewed-by: Rasmus Villemoes
This seems better than the VLA_SAFE() macro, at the cost of an extra kmalloc.
I don't think these code paths are super performance critical.
Reviewed-b
sky. This
is essentially returning the pointer _before_ "name" on the assumption that
it contains the full "prefix.name" string. IMHO, that is not necessarily a
safe assumption to make several layers down in the code.
James, I thought you had a patch for this to use kaspri
On Jan 27, 2018, at 22:24, Sumit Pundir wrote:
>
> Return value of error codes should typically be negative.
> Issue reported by checkpatch.pl
>
> Signed-off-by: Sumit Pundir
Reviewed-by: Andreas Dilger
> ---
> drivers/staging/lustre/lnet/selftest/framework.c | 2 +
destroy_conn() and free as it was intended in original
> commit.
>
> Cc: # v4.6
> Fixes: 4d99b2581eff ("staging: lustre: avoid intensive reconnecting for
> ko2iblnd")
> Signed-off-by: Dmitry Eremin
Reviewed-by: Andreas Dilger
> ---
> Changes in v4:
>-
);
> int class_procfs_clean(void);
>
> /* prng.c */
> -#define ll_generate_random_uuid(uuid_out) get_random_bytes(uuid_out,
> sizeof(class_uuid_t))
> +#define ll_generate_random_uuid(uuid_out) \
> + get_random_bytes(uuid_ou
; }
>>
>> -kfree(conn);
>> +if (free_conn)
>> +kfree(conn);
>
> This looks really odd, don't you think?
I'm not sure what the objection is here? There is an argument to this
this function named "free_conn" w
against unregistered shrinker.
>
> Signed-off-by: Aliaksei Karaliou
Reviewed-by: Andreas Dilger
> ---
> drivers/staging/lustre/lustre/obdclass/lu_object.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/obdclass/lu_ob
/linux/kernel/1506.0/00160.html
>
> 2) There are only few places in the lustre codebase that use such types.
> In the most cases it uses 'u32' and 'u64'.
>
> Signed-off-by: Roman Storozhenko
Reviewed-by: Andreas Dilger
>
> ---
> In the
t; obdclass_init(),
> which at least calls lu_global_fini() before exiting `module_init` on further
> failure,
> but yeah, still lacks proper cleanup inside lu_global_initcall().
> I'll add one more patch in a patch-set so that maintainers may decide what to
> do with that.
u can add:
Signed-off-by: Andreas Dilger
Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
; - if (!page_pools.epp_pools)
> - return -ENOMEM;
> -
> - register_shrinker(&pools_shrinker);
> + if (page_pools.epp_pools) {
> + rc = register_shrinker(&pools_shrinker);
> + if (rc)
> + enc_pools_free();
> +
ch types.
> In the most cases it uses 'u32' and 'u64'.
>
> Signed-off-by: Roman Storozhenko
Reviewed-by: Andreas Dilger
> ---
> In the first version of this patch I replaced 'uint32_t' with '__u32' and
> 'uint64_t' with '_
> On Nov 9, 2017, at 03:57, Roman Storozhenko wrote:
>
> On Thu, Nov 9, 2017 at 1:06 PM, Dilger, Andreas
> wrote:
>> On Nov 3, 2017, at 06:36, Roman Storozhenko wrote:
>>>
>>> On Fri, Nov 03, 2017 at 12:46:18PM +0100, Greg Kroah-Hartman wrote:
>>&
back to you sooner, I was traveling.
I'm not sure what you mean by the .h files aren't used in client code?
I checked all of the headers, and all of the structures that were changed,
and they all looked to be in use.
Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Nov 7, 2017, at 23:15, Greg Kroah-Hartman wrote:
>
> On Wed, Nov 08, 2017 at 12:35:43AM +, Dilger, Andreas wrote:
>> On Nov 7, 2017, at 06:58, Greg Kroah-Hartman
>> wrote:
>>>
>>> It's good to have SPDX identifiers in all files to make it easier
#x27;d prefer not to have a dozen follow-on patches because checkpatch.pl
complains about C++ comments.
Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
ch types.
> In the most cases it uses '__u32' and '__u64'.
>
> Signed-off-by: Roman Storozhenko
Reviewed-by: Andreas Dilger
> ---
> drivers/staging/lustre/lustre/include/lustre_sec.h | 4 ++--
> drivers/staging/lustre/lustre/llite/vvp_dev.c | 2 +-
&
ch types.
> In the most cases it uses '__u32' and '__u64'.
>
> Signed-off-by: Roman Storozhenko
Reviewed-by: Andreas Dilger
> ---
> drivers/staging/lustre/lustre/include/lustre_sec.h | 4 ++--
> drivers/staging/lustre/lustre/llite/vvp_dev.c | 2 +-
&
On Oct 30, 2017, at 23:00, Jeff Layton wrote:
>
> From: Jeff Layton
>
> f_version is only ever used by filesystem-specific code. Generic
> VFS code never uses it.
>
> Nothing in lustre ever looks at it, so just remove this.
>
> Signed-off-by: Jeff Layton
On Oct 12, 2017, at 10:17, Gustavo A. R. Silva wrote:
>
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Addresses-Coverity-ID: 1077598
> Signed-off-by: Gustavo A. R. Silva
Reviewed-by: Andreas Dilger
On Oct 12, 2017, at 10:17, Gustavo A. R. Silva wrote:
>
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva
Reviewed-by: Andreas Dilger
> ---
> drivers/staging/lustre/l
. Silva
Reviewed-by: Andreas Dilger
> ---
> drivers/staging/lustre/lnet/selftest/rpc.c | 13 +
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/lustre/lnet/selftest/rpc.c
> b/drivers/staging/lustre/lnet/selftest/rpc.c
> index 77c22
On Oct 12, 2017, at 10:17, Gustavo A. R. Silva wrote:
>
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva
Reviewed-by: Andreas Dilger
> ---
> drivers/staging
On Oct 12, 2017, at 10:17, Gustavo A. R. Silva wrote:
>
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva
Reviewed-by: Andreas Dilger
> ---
> drivers/stagi
t; Addresses-Coverity-ID: 1271169
> Signed-off-by: Gustavo A. R. Silva
Reviewed-by: Andreas Dilger
> ---
> drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs_s
ent to a separate line?
Not the end of the world though.
Reviewed-by: Andreas Dilger
> ---
> drivers/staging/lustre/lustre/llite/namei.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/llite/namei.c
> b/drivers/staging/lus
On Oct 12, 2017, at 10:17, Gustavo A. R. Silva wrote:
>
>
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva
Reviewed-by: Andreas Dilger
> ---
> drivers/stag
t appear harmful.
Reviewed-by: Andreas Dilger
> ---
> drivers/staging/lustre/lnet/lnet/net_fault.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/lustre/lnet/lnet/net_fault.c
> b/drivers/staging/lustre/lnet/lnet/net_fault.c
> index 03f3d18..7391e16 100644
&
t
not harmful either.
Reviewed-by: Andreas Dilger
> ---
> drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c
> b/drivers/staging/lustre/lnet/klnds/sock
s - 8188eu, 8723bs - that struct lives in
include/rtw_xmit.h). Is a comparable header simply missing?
Regards,
Andreas
On 08/29/17 16:42, Greg KH wrote:
> On Tue, Aug 29, 2017 at 09:10:10AM -0500, Larry Finger wrote:
>> On 08/29/2017 06:30 AM, Andreas Ziegler wrote:
>>> The debugg
The debugging output in deinit_priv is guarded by an #ifdef using
CONFIG_RTL_DEBUG. This symbol does not exist and should be
CONFIG_RTLWIFI_DEBUG instead.
Signed-off-by: Andreas Ziegler
---
drivers/staging/rtlwifi/halmac/rtl_halmac.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
attached a patch which fixes this problem.
Best regards,
Andreas Ziegler
[0]: I called the script like this: './scripts/checkkconfigsymbols.py --force -c
938a0447f094'
From 6c713900ed877c01f94fb76630f9ffd32c73ec88 Mon Sep 17 00:00:00 2001
From: Andreas Ziegler
Date: Tue, 29 Aug 2017 12:5
>
> So what am I supposed to do with this patch?
The patch has been reviewed and you could add them before landing:
Reviewed-by: John L. Hammond
Reviewed-by: frank zago
Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
+), 1 deletion(-)
>
> This file is no longer in the tree :(
With James' recent patch series, this has moved to
include/uapi/linux/lustre/lustre_user.h
Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
to just shorten the comment, if possible, like:
struct ksock_lnet_msg lnetmsg; /* lnet message, empty if NOOP */
Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
ited before semicolon
>
> Signed-off-by: Dmitriy Cherkasov
Reviewed-by: Andreas Dilger
> ---
> v5:
> - fix incomplete patch changelog
> - improve code alignment
> - reword commit message and summary to be more concise
> v4:
> - fix spa
ited before semicolon
>
> Signed-off-by: Dmitriy Cherkasov
Reviewed-by: Andreas Dilger
> ---
> v5:
> - fix incomplete patch changelog
> - improve code alignment
> - reword commit message and summary to be more concise
> v4:
> - fix spa
uot; header was previously used for compatibility between
different kernel
versions, which is why it is now basically empty. It isn't used for userspace
interfaces
as other "compat" headers are in the kernel.
Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
_batch command */
>> +}; /* test summary entry, for
>> + * list_batch command
>> + */
>
> That's odd, what was the *** stuff for?
>
> I'd like to get a lustre maintainer's
-I /usr/include/linux" (in addition to the
normal
"/usr/include") but it will work transparently to the code, regardless of where
the
headers are located or which kernel is being used.
On the maintainability point of view, I'd also think that putting headers into a
separate subdir would also be preferable just to avoid /usr/include/uapi/linux
from
growing huge. There are already several storage-related sybsystems that have
their
headers in a subdirectory, like ceph, cifs, mtd, nfsd, raid, and sunrpc.
Cheers, Andreas
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On May 18, 2017, at 17:13, Mathias Rav wrote:
>
> On Thu, 18 May 2017 14:48:25 +
> "Dilger, Andreas" wrote:
>
>> On May 18, 2017, at 15:53, Greg Kroah-Hartman
>> wrote:
>>>
>>> On Thu, May 04, 2017 at 12:13:38PM -0400, Math
; -if (dummy == end)
>> -return -EINVAL;
>> -
>> -*p = (unsigned int)tmp;
>> -return count;
>> +return kstrtouint_from_user(buffer, count, 0, (unsigned int *)data);
>
> Why not just delete this whole function and have the callers make
t;> +++ b/drivers/staging/lustre/lustre/obdclass/cl_io.c
>> @@ -52,9 +52,9 @@
>> */
>>
>> #define cl_io_for_each(slice, io) \
>> -list_for_each_entry((slice), &io->ci_layers, cis_linkage)
>> + list_for_each_entry((slice), &(io)->ci_layers, c
from
sending
the same patch in the future...
Cheers, Andreas
> Signed-off-by: Rishiraj Manwatkar
> ---
> v1 -> v2: Added mailing list in cc.
> v2 -> v3: Improved Subject line.
> drivers/staging/lustre/lustre/obdclass/cl_io.c | 4 ++--
> 1 file changed, 2 insertions(+),
h should really have been marked "[PATCH v3]", but
hopefully Greg
will still notice this one.
Reviewed-by: Andreas Dilger
> ---
> drivers/staging/lustre/lustre/include/lustre/lustre_idl.h | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/dr
;t think there was any particular reason for "do { } while(0)" here except
force of habit.
Reviewed-by: Andreas Dilger
> ---
> Changes in v2:
>- Kept statements together
>- Kept operator on previous line
>
> .../lustre/include/linux/libcfs/libcfs_private.h | 51
> \
> + "value: %d\n", atomic_read((a)))
Minor nit - in cases like this where you need to split the line anyway, it
is cleaner (IMHO) to keep the whole statement together:
#define LASSERT_ATOMIC_EQ(a, v)
that code when the more
expensive LINVRNT() checking is enabled, but is disabled most of the time.
With an empty expression this wouldn't happen at all, and errors may creep in.
Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
cture
on big-endian systems.
The right fix would be to change the declaration of ldp_hash_start and
ldp_hash_end from
__u64 to __le64, along with ldp_flags and ldp_pad0 (though it should be unused).
Cheers, Andreas
> CHECK drivers/staging/lustre/lustre/mdc/mdc_request.c
> drivers/staging
directly in the code, since that is easy enough to read compared to (1 <<
LNET_MSG_*)
everywhere. There don't seem to be a lot of users, so this wouldn't be a giant
patch.
Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Mar 22, 2017, at 06:12, Dilger, Andreas wrote:
>
> On Mar 21, 2017, at 22:39, Arushi Singhal
> wrote:
>>
>> This patch replaces bit shifting on 1 with the BIT(x) macro.
>> This was done with coccinelle:
[snip]
>> diff --git a/drivers/staging/lustre/ln
On Mar 22, 2017, at 09:53, Arushi Singhal
wrote:
>
> This patch replaces bit shifting on 1 with the BIT(x) macro.
> This was done with coccinelle:
> @@
> constant c;
> @@
>
> -1 << c
> +BIT(c)
>
> Signed-off-by: Arushi Singhal
Reviewed-by: Andreas Di
f2 100644
> --- a/drivers/staging/lustre/lustre/obdclass/lustre_handles.c
> +++ b/drivers/staging/lustre/lustre/obdclass/lustre_handles.c
> @@ -49,7 +49,7 @@ static struct handle_bucket {
> struct list_headhead;
> } *handle_hash;
>
> -#define HANDLE_HASH_SIZE (1 <&l
struct sk_buff *skb, struct
> net_device *dev)
> #endif
> work->word2.s.is_frag = !((ip_hdr(skb)->frag_off == 0) ||
> (ip_hdr(skb)->frag_off ==
> - 1 << 1
unsigned" with "unsigned int"
> Replacing 'unsigned' with 'unsigned int' in vvp_pgcache_id.
Remove double space, and reference function names like vvp_pgcache_id().
> Checkpath.pl passed.
"checkpatch.pl"
Cheers, Andreas
> Signed-off-by: P
re. Unless you really understand the state machine of
> the lustre code I don't recommend these kinds of change
> for lustre.
It may be useful to add a comment to these cases where the while() loop cannot
be
replaced by list_for_each_entry_safe() (with details of why that is the case) to
a
> On Feb 3, 2017, at 03:33, Greg Kroah-Hartman
> wrote:
>
> On Sat, Jan 28, 2017 at 07:04:38PM -0500, James Simmons wrote:
>> From: Andreas Dilger
>>
>> Update the sysfs "version" file to print "lustre: " with
>> the version numbe
> (0)
>
> As Greg suggested, let's just kill off this macro completely instead of
> fixing it. This replaces it with BUILD_BUG_ON(), which means we have
> to negate all the conditions in the process.
>
> Signed-off-by: Arnd Bergmann
I appreciate that you also fix
gt; (0)
>
> Adding a 'default:' label in there shuts up the warning.
>
> Signed-off-by: Arnd Bergmann
Reviewed-by: Andreas Dilger
> ---
> drivers/staging/lustre/include/linux/libcfs/libcfs_private.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
&
On Jan 24, 2017, at 09:40, Ernestas Kulik wrote:
>
> Using octal permissions instead of symbolic ones is preferred.
Typically the reverse is true - using symbolic constants is preferred over
numeric ones.
Where does this recommendation come from?
Cheers, Andreas
> Signed-off-by:
On Dec 23, 2016, at 08:42, Karthik Nayak wrote:
>
> Since the function brw_inject_one_error() is used only within
> brw_test.c, make it static. This was reported as a warning by sparse.
>
> Signed-off-by: Karthik Nayak
Reviewed-by: Andreas Dilger
> ---
> drivers/staging
> -ret =
> +return
> e;
> -return ret;
>
> Signed-off-by: Gustavo A. R. Silva
Reviewed-by: Andreas Dilger
> ---
> drivers/staging/lustre/lustre/lmv/lmv_obd.c | 58 -
> 1 file changed, 16 insertions(+), 42 deletions(-)
>
> diff --gi
.
> This warning is found using checkpatch.pl.
The commit body is good.
Please resubmit with a new summary line, then you can include:
Reviewed-by: Andreas Dilger
Cheers, Andreas
> Signed-off-by: Tabrez khan
> ---
> drivers/staging/lustre/lustre/osc/osc_cache.c | 4 +---
>
isk.h, swab.h, etc.).
That said, if there is an objection to keeping these macros/inline funcs
in the uapi headers, they still need to exist in the kernel and should
be kept in the lustre/include/lustre directory and we'll keep a separate
copy of the macros for us
g blocks of code between files and this doesn't appear cleanly
in the patch then I'd ask for a separate patch.
Cheers, Andreas
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Nov 24, 2016, at 04:10, Dan Carpenter wrote:
>
> We want sizeof(struct lstcon_node) but instead we're getting the sizeof
> a pointer.
>
> Fixes: 8d78f0f2ba76 ("staging: lustre: lnet: cleanup some of the > 80 line
> issues")
> Signed-off-by: Dan
very comparison
with 0 in all of the code, as that can reduce readability in some cases.
I know this patch has already landed, and it isn't the end of the world
either way, but just wanted to forestall similar changes being made through
the rest of the code.
Cheers, Andreas
___
On Nov 24, 2016, at 04:12, Dan Carpenter wrote:
>
> We should free "desc" before returning NULL.
>
> Signed-off-by: Dan Carpenter
Reviewed-by: Andreas Dilger
> diff --git a/drivers/staging/lustre/lustre/ptlrpc/client.c
> b/drivers/staging/lustre/lustre/ptl
overityScan, CID 1375917
Thanks for the patch. Seems this change has gotten a lot of attention,
this is the third patch to the list to fix it. My preference is to
undo the int->unsigned declaration change, for which James has already
submitted a patch.
Cheers, Andreas
> Signed-off-by: C
l_sec will correctly reflect the
actual elapsed time rather than just the number of ticks inside the VM.
Is my understanding of these different clocks correct?
Cheers, Andreas
>
> Signed-off-by: James Simmons
> ---
> drivers/staging/lustre/lustre/ldlm/ldlm_pool.c |6 +++---
>
On Nov 7, 2016, at 02:07, Aya Mahfouz wrote:
>
> On Mon, Nov 7, 2016 at 6:22 AM, Oleg Drokin wrote:
>
>> On Nov 4, 2016, at 4:37 AM, Aya Mahfouz wrote:
>>
>> >
>> > On Thu, Nov 3, 2016 at 1:05 AM, Dilger, Andreas
>> > wrote:
>>
;d agree with Oleg that returning NULL is the preferable solution here.
There are also callers of lustre_cfg_new() in class_config_llog_handler(),
do_lcfg(), and lustre_end_log() that do not check error returns at all that
should be fixed at the same time.
Cheers, Andreas
>>
On Nov 7, 2016, at 12:01, Nicholas Hanley wrote:
>
> Replace 0 with false in tx_pages_mapped = 0 to be consistent with
> the rest of the lustre code.
>
> Signed-off-by: Nicholas Hanley
Reviewed-by: Andreas Dilger
> ---
> drivers/staging/lustre/lnet/klnds/o2iblnd/o2ib
e
>
> Signed-off-by: Andrew Kanner
Reviewed-by: Andreas Dilger
> ---
> drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c
> b/drivers/sta
closely (or from a greater distance, hard to say),
the outer-scope "tx" is used only after this inner-scope "tx", so in
fact there is no benefit to having the inner-scope declaration at all.
Removing it may save a stack variable (depending on how the compiler
optimizes), and shouldn
On Oct 25, 2016, at 10:47, Aya Mahfouz wrote:
>
> On Mon, Oct 17, 2016 at 10:38:31PM +, Dilger, Andreas wrote:
>> On Oct 17, 2016, at 15:46, Aya Mahfouz
>> wrote:
>>>
>>> class_devno_max is an inline function that returns
>>> MAX_OBD_DEVI
(i = 0; i < MAX_OBD_DEVICES; i++)
> obd_devs[i] = NULL;
This block can just be removed entirely. It used to do something useful,
but through a series of changes it has become useless.
Cheers, Andreas
> /* Default the dirty page cache cap to 1/2 of system memory.
&
eg_mr() or hdev->...->dereg_mr() ?
> hdev->ibh_mrs = NULL;
> }
>
> @@ -2316,13 +2316,18 @@ static int kiblnd_hdev_setup_mrs(struct kib_hca_dev
> *hdev)
> if (rc)
> return rc;
>
> - mr = ib_get_dma_mr(hdev->ibh_pd, acflags);
>
, but
not sure whether that is acceptable if the only user is in staging.
Cheers, Andreas
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
ng: context imbalance in 'lock_res_and_lock' - wrong
> count at exit
> l_lock.c:61:6: warning: context imbalance in 'unlock_res_and_lock' -
> unexpected unlock
>
> Signed-off-by: Nayeemahmed Badebade
Reviewed-by: Andreas Dilger
> ---
>
> Changes in v2:
> *
ch marks these functions with 'static'.
>
> Signed-off-by: Baoyou Xie
Reviewed by: Andreas Dilger
> ---
> drivers/staging/lustre/lustre/lmv/lmv_obd.c | 38 -
> 1 file changed, 21 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/sta
On Sep 18, 2016, at 14:21, nayeem wrote:
> On Friday 16 September 2016 01:30 PM, Dilger, Andreas wrote:
>> On Sep 15, 2016, at 12:33, nayeem wrote:
>>> On Wednesday 14 September 2016 10:44 AM, Dilger, Andreas wrote:
>>>> On Sep 12, 2016, at 04:27, Greg KH wrot
On Sep 15, 2016, at 12:33, nayeem wrote:
> On Wednesday 14 September 2016 10:44 AM, Dilger, Andreas wrote:
>> On Sep 12, 2016, at 04:27, Greg KH wrote:
>>>
>>> On Fri, Sep 09, 2016 at 08:50:35PM +0530, Nayeemahmed Badebade wrote:
>>>> Added __acquires
correct, along with the
corresponding "__releases(&lock->l_lock)" at unlock_res_and_lock().
The problem, however, is that "l_resource" is not a lock, but rather a
struct. The call to "lock_res(lock->l_resource)" is actually locking
"lr_loc
1 - 100 of 202 matches
Mail list logo
