Re: [PATCH 05/15] staging: rtl8192u: fix space at the start of lines in r819xU_cmdpkt.h

On 10/10/2013 11:45 AM, Dan Carpenter wrote: On Thu, Oct 10, 2013 at 10:43:51AM +0300, Xenia Ragiadakou wrote: This patch fixes the following checkpatch warning: WARNING: please, no spaces at the start of a line Signed-off-by: Xenia Ragiadakou --- drivers/staging/rtl8192u/r819xU_cmdpkt.h

[PATCH 04/15] staging: rtl8192u: fix comments in r819xU_cmdpkt.h

-by: Xenia Ragiadakou --- drivers/staging/rtl8192u/r819xU_cmdpkt.h | 173 +++ 1 file changed, 82 insertions(+), 91 deletions(-) diff --git a/drivers/staging/rtl8192u/r819xU_cmdpkt.h b/drivers/staging/rtl8192u/r819xU_cmdpkt.h index 2e079c7..f7c68e2 100644 --- a/drivers

[PATCH 2/3] staging: rtl8192u: remove ieee80211_crypt.h

This patch removes ieee80211_crypt.h because this header file is the same as ieee80211/ieee80211_crypt.h and the structures and functions declared in it are used directly only inside ieee80211/. Signed-off-by: Xenia Ragiadakou --- drivers/staging/rtl8192u/ieee80211_crypt.h | 86

[PATCH 3/3] staging: rtl8192u: copy dot11d.h in ieee80211/dot11d.h and remove it

structures and functions that defines are used directly only inside ieee80211/. Signed-off-by: Xenia Ragiadakou --- drivers/staging/rtl8192u/dot11d.h | 100 drivers/staging/rtl8192u/ieee80211/dot11d.h | 39 +-- 2 files changed, 20 insertions(+), 119

[PATCH 1/3] staging: rtl8192u: remove r8180_pm.c and r8180_pm.h

This patch removes r8180_pm.h and r8180_pm.c from rtl8192u because they are not used anywhere in the driver. Signed-off-by: Xenia Ragiadakou --- drivers/staging/rtl8192u/r8180_pm.c | 48 - drivers/staging/rtl8192u/r8180_pm.h | 28 -- 2

[PATCH 13/15] staging: rtl8192u: add space after ', ' in r819xU_HTType.h

This patch fixes the following checkpatch error: ERROR: space required after that ',' Signed-off-by: Xenia Ragiadakou --- drivers/staging/rtl8192u/r819xU_HTType.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r819xU_HTType.h b/drive

[PATCH 10/15] staging: rtl8192u: fix space around braces in r819xU_HTType.h

This patch fixes the white space around braces in r819xU_HTType.h according to the linux kernel coding style. Signed-off-by: Xenia Ragiadakou --- drivers/staging/rtl8192u/r819xU_HTType.h | 62 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a

[PATCH 14/15] staging: rtl8192u: add parenthesis around complex macros in r819xU_HTType.h

This patch fixes the following checkpatch error: ERROR: Macros with complex values should be enclosed in parenthesis Signed-off-by: Xenia Ragiadakou --- drivers/staging/rtl8192u/r819xU_HTType.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u

[PATCH 11/15] staging: rtl8192u: fix comments in r819xU_HTType.h

This patch fixes comments in r819xU_HTType.h by: * replacing // commments with /* */ comments * removing author and date information from comments * removing unnecessary comments This is done to improve code readability. Signed-off-by: Xenia Ragiadakou --- drivers/staging/rtl8192u

[PATCH 05/15] staging: rtl8192u: fix space at the start of lines in r819xU_cmdpkt.h

This patch fixes the following checkpatch warning: WARNING: please, no spaces at the start of a line Signed-off-by: Xenia Ragiadakou --- drivers/staging/rtl8192u/r819xU_cmdpkt.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8192u

[PATCH 02/15] staging: rtl8192u: add space after } and , in r819xU_cmdpkt.h

This patch fixes white space after } and , so that the code becomes more readable and conforms to the linux kernel coding style. Signed-off-by: Xenia Ragiadakou --- drivers/staging/rtl8192u/r819xU_cmdpkt.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a

[PATCH 09/15] staging: rtl8192u: use __packed instead of __attribute__((packed))

This patch fixes the following checkpatch warning: WARNING: __packed is preferred over __attribute__((packed)) Signed-off-by: Xenia Ragiadakou --- drivers/staging/rtl8192u/r819xU_HTType.h | 4 ++-- drivers/staging/rtl8192u/r819xU_cmdpkt.h | 4 ++-- drivers/staging/rtl8192u/r819xU_phy.h| 2

[PATCH 15/15] staging: rtl8192u: fix line size in r819xU_HTType.h

This patch fixes the following checkpatch warning in r819xU_HTType.h: WARNING: line over 80 characters Signed-off-by: Xenia Ragiadakou --- drivers/staging/rtl8192u/r819xU_HTType.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r819xU_HTType.h b

[PATCH 12/15] staging: rtl8192u: fix alignment in r819xU_HTType.h

This patch fixes some alignment issues in r819xU_HTType.h to impreove code readability. Signed-off-by: Xenia Ragiadakou --- drivers/staging/rtl8192u/r819xU_HTType.h | 174 +++ 1 file changed, 87 insertions(+), 87 deletions(-) diff --git a/drivers/staging/rtl8192u

[PATCH 01/15] staging: rtl8192u: remove #ifdef JOHN_

This patch removes the guards #ifdef JOHN_HWSEC, #ifdef JOHN_DUMP_TXDESC and because the code inside them calls some undefined functions (e.g read_rtl8225, rtl8187_read_phy etc). Signed-off-by: Xenia Ragiadakou --- drivers/staging/rtl8192u/r8192U.h | 8 -- drivers/staging/rtl8192u

[PATCH 03/15] staging: rtl8192u: fix line size in r819xU_cmdpkt.h

This patch reduces the line length below 80 chars to improve code readability. Signed-off-by: Xenia Ragiadakou --- drivers/staging/rtl8192u/r819xU_cmdpkt.h | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/drivers/staging/rtl8192u/r819xU_cmdpkt.h

[PATCH 08/15] staging: rtl8192u: fix open brace position in r819xU_cmdpkt.h

This patch fixes the following checkpatch warning and error: WARNING: missing space after enum definition ERROR: open brace '{' following enum go on the same line Signed-off-by: Xenia Ragiadakou --- drivers/staging/rtl8192u/r819xU_cmdpkt.h | 5 ++--- 1 file changed, 2 insertions(+), 3

[PATCH 06/15] staging: rtl8192u: fix space after ( in r819xU_cmdpkt.h

This patch removes prohibited space after ( in r819xU_cmdpkt.h according to the linux kernel coding style convention. Signed-off-by: Xenia Ragiadakou --- drivers/staging/rtl8192u/r819xU_cmdpkt.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u

[PATCH 07/15] staging: rtl8192u: fix alignment in r819xU_cmdpkt.h

This patch fixes alignment issues in r819xU_cmdpkt.h to improve code readability. Signed-off-by: Xenia Ragiadakou --- drivers/staging/rtl8192u/r819xU_cmdpkt.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192u/r819xU_cmdpkt.h b/drivers

[PATCH 08/14] staging: rtl8192u: remove code inside #ifdef RTL8190P/RTL8192E in r819xU_phy.c

This patch removes the unused code inside #ifdef RTL8190P and #ifdef RTL8192E guards since RTL8190P and RTL8192E are not defined. Signed-off-by: Xenia Ragiadakou --- drivers/staging/rtl8192u/r819xU_phy.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8192u

[PATCH 12/14] staging: rtl8192u: remove #ifndef RTL8192U and the code inside it

This patch removes the unused code inside #ifndef RTL8192U header guard and the guard itself, since RTL8192U is defined. Signed-off-by: Xenia Ragiadakou --- drivers/staging/rtl8192u/r8192U_dm.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b

[PATCH 11/14] staging: rtl8192u: remove #ifndef RTL8190P guard from r8192U_dm.c

This patch removes #ifndef RTL8190P header guard since RTL8190P is not defined anywhere in rtl8192u code. Signed-off-by: Xenia Ragiadakou --- drivers/staging/rtl8192u/r8192U_dm.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging

[PATCH 05/14] staging: rtl8192u: remove dm_check_rfctrl_gpio()

This patch removes dm_check_rfctrl_gpio() because it does nothing when RTL8192U is defined. Signed-off-by: Xenia Ragiadakou --- drivers/staging/rtl8192u/r8192U_dm.c | 42 1 file changed, 42 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b

[PATCH 01/14] staging: rtl8192u: remove unused code from cmpk_message_handle_tx()

The file r819xU_cmdpkt.c includes header r8192U.h which defines RTL8192U. This patch removes from cmpk_message_handle_tx() the part of the code that is never used because it resides outside the header guard #ifdef RTL8192U. Signed-off-by: Xenia Ragiadakou --- drivers/staging/rtl8192u

[PATCH 06/14] staging: rtl8192u: remove #ifdef RTL8192U guard in r8192U_dm.c

This patch removes #ifdef RTL8192U header guards from r8192U_dm.c, since RTL8192U is defined in the included r8192U.h header. Signed-off-by: Xenia Ragiadakou --- drivers/staging/rtl8192u/r8192U_dm.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b

[PATCH 09/14] staging: rtl8192u: remove code inside #ifdef RTL8190P in r819xU_firmware.c

This patch removes the unused code that resides inside #ifdef RTL8190P since RTL8190P is not defined. Signed-off-by: Xenia Ragiadakou --- drivers/staging/rtl8192u/r819xU_firmware.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/staging/rtl8192u/r819xU_firmware.c b

[PATCH 10/14] staging: rtl8192u: remove code inside #ifdef RTL8190P in r8192U_dm.c

This patch removes the unused code that resides inside #ifdef RTL8190P header guard since RTL8190P is not defined. Signed-off-by: Xenia Ragiadakou --- drivers/staging/rtl8192u/r8192U_dm.c | 137 +++ 1 file changed, 12 insertions(+), 125 deletions(-) diff --git a

[PATCH 03/14] staging: rtl8192u: remove unused code in fw_download_code()

This patch removes the code that resides outside #ifdef RTL8192U, since RTL8192U is defined in r8192U.h and removes, also, the header guard itself. Signed-off-by: Xenia Ragiadakou --- drivers/staging/rtl8192u/r819xU_firmware.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers

[PATCH 14/14] staging: rt8192u: remove #ifdef RTL8192U in r8192U.h

This patch removes #ifdef RTL8192U header guard and the code that falls outside it, since RTL8192U is defined. Signed-off-by: Xenia Ragiadakou --- drivers/staging/rtl8192u/r8192U.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U.h b/drivers/staging

[PATCH 04/14] staging: rtl8192u: check dev_alloc_skb() return value in fw_download_code()

This patch adds a check whether skb allocation, in fw_download_code(), was successful. Signed-off-by: Xenia Ragiadakou --- drivers/staging/rtl8192u/r819xU_firmware.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/rtl8192u/r819xU_firmware.c b/drivers/staging/rtl8192u

[PATCH 13/14] staging: rtl8192u: remove code inside #ifdef RTL8190P in r8190_rtl8256.h

This patch removes the unused code inside #ifdef RTL8190P header guard, since RTL8190P is not defined. Signed-off-by: Xenia Ragiadakou --- drivers/staging/rtl8192u/r8190_rtl8256.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.h b/drivers/staging

[PATCH 07/14] staging: rtl8192u: remove unused dm_gpio_change_rf_callback()

This patch removes dm_gpio_change_rf_callback() because it is not called anywhere and it resides inside an #ifdef RTL8192E guard while RTL8192E is not defined. Signed-off-by: Xenia Ragiadakou --- drivers/staging/rtl8192u/r8192U_dm.c | 73 1 file changed, 73

[PATCH 02/14] staging: rtl8192u: remove cmpk_message_handle_tx()

cmpk_message_handle_tx() does not do anything else other than returning true, it can be safely removed. Signed-off-by: Xenia Ragiadakou --- drivers/staging/rtl8192u/r8192U_dm.c | 8 drivers/staging/rtl8192u/r819xU_cmdpkt.c | 27 --- drivers/staging/rtl8192u/r819xU_cmdpkt.h