On 10/10/2013 11:45 AM, Dan Carpenter wrote:
On Thu, Oct 10, 2013 at 10:43:51AM +0300, Xenia Ragiadakou wrote:
This patch fixes the following checkpatch warning:
WARNING: please, no spaces at the start of a line

Signed-off-by: Xenia Ragiadakou <burzalod...@gmail.com>
---
  drivers/staging/rtl8192u/r819xU_cmdpkt.h | 18 +++++++++---------
  1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/rtl8192u/r819xU_cmdpkt.h 
b/drivers/staging/rtl8192u/r819xU_cmdpkt.h
index f7c68e2..9845e9a 100644
--- a/drivers/staging/rtl8192u/r819xU_cmdpkt.h
+++ b/drivers/staging/rtl8192u/r819xU_cmdpkt.h
@@ -165,15 +165,15 @@ typedef struct tag_tx_rate_history {
typedef enum tag_command_packet_directories
  {
-    RX_TX_FEEDBACK = 0,
-    RX_INTERRUPT_STATUS                = 1,
-    TX_SET_CONFIG                              = 2,
-    BOTH_QUERY_CONFIG                  = 3,
-    RX_TX_STATUS                               = 4,
-    RX_DBGINFO_FEEDBACK                = 5,
-    RX_TX_PER_PKT_FEEDBACK             = 6,
-    RX_TX_RATE_HISTORY         = 7,
-    RX_CMD_ELE_MAX
+       RX_TX_FEEDBACK = 0,
+       RX_INTERRUPT_STATUS             = 1,
+       TX_SET_CONFIG                           = 2,
+       BOTH_QUERY_CONFIG                       = 3,
+       RX_TX_STATUS                            = 4,
+       RX_DBGINFO_FEEDBACK             = 5,
+       RX_TX_PER_PKT_FEEDBACK          = 6,
+       RX_TX_RATE_HISTORY              = 7,
+       RX_CMD_ELE_MAX
Better if all these line up nicely.  Ie:

+       RX_INTERRUPT_STATUS             = 1,
+       TX_SET_CONFIG                   = 2,
+       BOTH_QUERY_CONFIG               = 3,
+       RX_TX_STATUS                    = 4,
+       RX_DBGINFO_FEEDBACK             = 5,
+       RX_TX_PER_PKT_FEEDBACK          = 6,
+       RX_TX_RATE_HISTORY              = 7,
+       RX_CMD_ELE_MAX


Could you just resend this one without redoing any of the others?  You
could probably edit directly in the mail client.

regards,
dan carpenter


Hi Dan,

Thx for reviewing! I fix this in the follow-on patch [PATCH 07/15] that address alignment issues.

regards,
ksenia
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to