On 02/08/20 1:43 pm, Marc Dietrich wrote:
> Hello Rohit,
>
> On Sat, 25 Jul 2020, Rohit K Bharadwaj wrote:
>
>> changed usage of slave (which is deprecated) to secondary without breaking
>> the driver
>>
>> Tested-by: Dan Carpenter
>> Acked-by
On 26/07/20 3:12 pm, Mauro Carvalho Chehab wrote:
> Em Sun, 26 Jul 2020 14:35:12 +0530
> Rohit K Bharadwaj escreveu:
>
>> this patch fixes style of open brace after functions and if statements
>>
>> Signed-off-by: Rohit K Bharadwaj
>
>> @@ -119,8 +121,9 @@
On 26/07/20 2:42 pm, Greg KH wrote:
> On Sun, Jul 26, 2020 at 02:35:10PM +0530, Rohit K Bharadwaj wrote:
>> this patch fixes the coding style of block comments.
>>
>> Signed-off-by: Rohit K Bharadwaj
>> ---
>> v3: change patch subject prefix
>> v2: split pat
this patch fixes the line length exceeded error from checkpatch.pl
Signed-off-by: Rohit K Bharadwaj
---
v3: change patch subject prefix
v2: split patch into sequence of patches
v1: fix all coding style issues in single patch
drivers/staging/media/atomisp/pci/sh_css_firmware.c | 3 ++-
1 file
this patch fixes the error from checkpatch.pl which says that trailing
statements after if keyword to be on next line
Signed-off-by: Rohit K Bharadwaj
---
v3: change patch subject prefix
v2: split patch into sequence of patches
v1: fix all coding style issues in single patch
drivers/staging
this patch fixes style of open brace after functions and if statements
Signed-off-by: Rohit K Bharadwaj
---
v3: change patch subject prefix
v2: split patch into sequence of patches
v1: fix all coding style issues in single patch
.../media/atomisp/pci/sh_css_firmware.c | 29
this patch fixes the coding style of block comments.
Signed-off-by: Rohit K Bharadwaj
---
v3: change patch subject prefix
v2: split patch into sequence of patches
v1: fix all coding style issues in single patch
.../media/atomisp/pci/sh_css_firmware.c | 28 +--
1 file
On 26/07/20 2:18 pm, Rohit K Bharadwaj wrote:
> this patch fixes the coding style of block comments.
>
> Signed-off-by: Rohit K Bharadwaj
> ---
> v2: split patch into sequence of patches
> v1: fix all coding style issues in single patch
>
> .../media/atomisp/pci/sh_c
this patch fixes the coding style of block comments.
Signed-off-by: Rohit K Bharadwaj
---
v2: split patch into sequence of patches
v1: fix all coding style issues in single patch
.../media/atomisp/pci/sh_css_firmware.c | 28 +--
1 file changed, 19 insertions(+), 9
this patch fixes the warnings and errors generated after running checkpatch.pl
on pci/sh_css_firmware.c
Signed-off-by: Rohit K Bharadwaj
---
.../media/atomisp/pci/sh_css_firmware.c | 62 +++
1 file changed, 36 insertions(+), 26 deletions(-)
diff --git a/drivers/staging
On 25/07/20 6:20 pm, Michał Mirosław wrote:
> On Sat, Jul 25, 2020 at 06:01:19PM +0530, Rohit K Bharadwaj wrote:
>> On 25/07/20 5:31 pm, Michał Mirosław wrote:
>>> On Sat, Jul 25, 2020 at 11:59:39AM +0530, Rohit K Bharadwaj wrote:
>>>> changed usage of slave (whi
On 25/07/20 5:31 pm, Michał Mirosław wrote:
> On Sat, Jul 25, 2020 at 11:59:39AM +0530, Rohit K Bharadwaj wrote:
>> changed usage of slave (which is deprecated) to secondary without breaking
>> the driver
>
> The relevant I2C and SMBus standards use master/slave termi
On 25/07/20 2:12 am, Marc Dietrich wrote:
>
> Hi Rohit,
>
> On Fri, 24 Jul 2020, Rohit K Bharadwaj wrote:
>
>> On 24/07/20 10:06 pm, Marc Dietrich wrote:
>>>
>>>
>>> On Fri, 24 Jul 2020, Marc Dietrich wrote:
>>>
>>>> Hi Rohit
changed usage of slave (which is deprecated) to secondary without breaking the
driver
Tested-by: Dan Carpenter
Acked-by: Marc Dietrich
Signed-off-by: Rohit K Bharadwaj
---
v4: undo the changes (which broke the driver) to this line: if
(of_property_read_u32(dev->of_node, "slave-addr
On 24/07/20 10:06 pm, Marc Dietrich wrote:
>
>
> On Fri, 24 Jul 2020, Marc Dietrich wrote:
>
>> Hi Rohit,
>>
>> On Fri, 24 Jul 2020, Rohit Bharadwaj wrote:
>>
>>> On 24/07/20 1:58 pm, Greg KH wrote:
>>>> On Fri, Jul 24, 2020 at 01:44:27PM
On 24/07/20 7:39 pm, Dan Carpenter wrote:
> On Fri, Jul 24, 2020 at 10:06:34AM +0530, Rohit K Bharadwaj wrote:
>> @@ -784,7 +784,7 @@ static int tegra_nvec_probe(struct platform_device *pdev)
>> platform_set_drvdata(pdev, nvec);
>> nvec->dev = dev;
>>
&g
On 24/07/20 1:58 pm, Greg KH wrote:
> On Fri, Jul 24, 2020 at 01:44:27PM +0530, Rohit Bharadwaj wrote:
>> On 24/07/20 10:06 am, Rohit K Bharadwaj wrote:
>>> changed usage of slave (deprecated) to secondary
>>>
>>> Signed-off-by: Rohit K Bharadwaj
>>>
On 24/07/20 10:06 am, Rohit K Bharadwaj wrote:
> changed usage of slave (deprecated) to secondary
>
> Signed-off-by: Rohit K Bharadwaj
> ---
> v3: change patch subject, add version history
> v2: add changelog text in body of mail
> v1: fix style issues by changing usage
On 23/07/20 10:36 pm, Greg KH wrote:
> On Thu, Jul 23, 2020 at 08:45:13PM +0530, Rohit K Bharadwaj wrote:
>> changed usage of slave (deprecated) to secondary
>>
>> Signed-off-by: Rohit K Bharadwaj
>> ---
>> drivers/staging/nvec/nvec.c | 12 ++--
>&
changed usage of slave (deprecated) to secondary
Signed-off-by: Rohit K Bharadwaj
---
v3: change patch subject, add version history
v2: add changelog text in body of mail
v1: fix style issues by changing usage of slave to secondary
drivers/staging/nvec/nvec.c | 12 ++--
1 file changed
changed usage of slave (deprecated) to secondary
Signed-off-by: Rohit K Bharadwaj
---
drivers/staging/nvec/nvec.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index 360ec0407740..5d7b66719a39 100644
Signed-off-by: Rohit K Bharadwaj
---
drivers/staging/nvec/nvec.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index 360ec0407740..5d7b66719a39 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers
On Sun, Mar 01, 2020 at 11:49:22AM +, Jonathan Cameron wrote:
> On Sat, 29 Feb 2020 19:35:45 +0530
> Rohit Sarkar wrote:
>
> > Since there are no uses of the old GPIO API, remove the item from
> > the TODO.
> >
> > Changelog
> > v3: Remove new items ad
Since there are no uses of the old GPIO API, remove the item from
the TODO.
Changelog
v3: Remove new items added.
v2: Add work item mentioned by Alexandru in
https://marc.info/?l=linux-iio&m=158261515624212&w=2
Signed-off-by: Rohit Sarkar
---
drivers/staging/iio/TODO | 8 +---
Since there are no uses of the old GPIO API, remove the item from the
TODO and some new items.
Changes from v1:
Add work item mentioned by Alexandru in
https://marc.info/?l=linux-iio&m=158261515624212&w=2
Signed-off-by: Rohit Sarkar
---
drivers/staging/iio/TODO | 18 --
://marc.info/?l=linux-iio&m=158256721009892&w=2
Thanks,
Rohit
Signed-off-by: Rohit Sarkar
---
drivers/staging/iio/TODO | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/iio/TODO b/drivers/staging/iio/TODO
index 1b8ebf2c1b69..783878f25f08 1006
Now that snprintf is replaced by scnprintf n >= MAX_WPA_IE_LEN doesn't
make sense as the maximum value n can take is MAX_WPA_IE_LEN.
Signed-off-by: Rohit Sarkar
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a
.
>
> regards,
> dan carpenter
I feel the same way. Plus we would also avoid looping unnecessarily if
"n" exceeds the threshold. Will send a patch asap.
regards,
rohit
___
devel mailing list
de...@linuxdriverproject.org
http://driver
I guess I will
remove the redundant check then.
thanks,
rohit
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
remove the loop or break when n ==
MAX_WPA_IE_LEN - 1.
regards,
rohit
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Tue, Oct 01, 2019 at 11:45:14AM +0300, Dan Carpenter wrote:
> > diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > index b08b9a191a34..ff5edcaba64d 100644
> > --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > +++ b/drivers/st
On Wed, Sep 25, 2019 at 10:32:02AM +0200, Crt Mori wrote:
> Hi Rohit,
> There are many companies for hobbyists which sell sensors included in
> IIO subsystem and for sure some electronic component store in your
> local area. Price of sensor can be from 0.10 USD to 10 USD. Then you
would I get this from?
Thanks,
Rohit
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Sun, Sep 15, 2019 at 10:53:00AM +0100, Jonathan Cameron wrote:
> On Sat, 14 Sep 2019 02:06:27 +0530
> Rohit Sarkar wrote:
>
> > Bcc:
> > Subject: [PATCH] staging: iio: adis16240: remove unused include
> > Reply-To:
> Something odd happened here with patch
Bcc:
Subject: [PATCH] staging: iio: adis16240: remove unused include
Reply-To:
'#include' isn't being used anywhere. Remove it.
Signed-off-by: Rohit Sarkar
---
drivers/staging/iio/accel/adis16240.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/iio/accel
On Wed, Sep 11, 2019 at 08:24:22PM +0300, Dan Carpenter wrote:
> On Wed, Sep 11, 2019 at 08:33:00PM +0530, Rohit Sarkar wrote:
> > There are a lot of usages of "snprintf" throughout the staging
> > directory (315 to be exact)
> > Would it be worthwhile to find one
On Wed, Sep 11, 2019 at 05:46:12PM +0300, Dan Carpenter wrote:
> On Wed, Sep 11, 2019 at 07:55:43PM +0530, Rohit Sarkar wrote:
> > On Wed, Sep 11, 2019 at 04:17:25PM +0200, Stefan Wahren wrote:
> > > Hi Rohit,
> > >
> > > On 11.09.19 15:51, Rohit Sarkar wrote:
On Wed, Sep 11, 2019 at 04:17:25PM +0200, Stefan Wahren wrote:
> Hi Rohit,
>
> On 11.09.19 15:51, Rohit Sarkar wrote:
> > When the number of bytes to be printed exceeds the limit snprintf
> > returns the number of bytes that would have been printed (if there was
> >
When the number of bytes to be printed exceeds the limit snprintf
returns the number of bytes that would have been printed (if there was
no truncation). This might cause issues, hence use scnprintf which
returns the actual number of bytes printed to buffer always
Signed-off-by: Rohit Sarkar
Resending as I made a typo in Larry's email id.
On Wed, Sep 11, 2019 at 12:19:31AM +0530, Rohit Sarkar wrote:
> When the number of bytes to be printed exceeds the limit snprintf
> returns the number of bytes that would have been printed (if there was
> no truncation). This migh
When the number of bytes to be printed exceeds the limit snprintf
returns the number of bytes that would have been printed (if there was
no truncation). This might cause issues, hence use scnprintf which
returns the actual number of bytes printed to buffer always.
Signed-off-by: Rohit Sarkar
When the number of bytes to be printed exceeds the limit snprintf
returns the number of bytes that would have been printed (if there was
no truncation). This might cause issues, hence use scnprintf which
returns the actual number of bytes printed to buffer always.
Signed-off-by: Rohit Sarkar
Fixes a typo in the documentation.
Signed-off-by: Rohit Sarkar
---
drivers/staging/pi433/Documentation/pi433.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/pi433/Documentation/pi433.txt
b/drivers/staging/pi433/Documentation/pi433.txt
index 21cffdb86ecf
On Tue, Nov 06, 2018 at 09:12:45PM +0100, Greg KH wrote:
> On Tue, Nov 06, 2018 at 04:33:47PM +0530, Rohit Sarkar wrote:
> > Replace S_IRUGO with 0444. Issue found by checkpatch.
> >
> > Signed-off-by: Rohit Sarkar
> > ---
> > drivers/staging/gasket/gasket_sys
r being placed in
drivers/staging/media.
I'll add some references to this conversation, so a new reviewer gets some
context of what
was discussed. In the meanwhile I will look into re-writing this to utilize the
M2M V4L2 API.
> Regards,
>
> Hans
Best Regards,
Rohit
> --
Changing return type from int to loff_t. Actual return type of the
function (vfs_llseek) is loff_t (long long). Here due to implicit
converion from long long to int, result will be implementation defined.
Signed-off-by: Rohit Kumar
---
drivers/staging/android/ashmem.c | 2 +-
1 file changed, 1
int, result will be implementation defined.
Signed-off-by: Rohit Kumar
---
drivers/staging/android/ashmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
index 86580b6..a1a0025 100644
--- a/drivers/staging
ioctl_xm2mvsc.h
- The char driver that consumes the IP layer in xm2m_vscale.c
Signed-off-by: Rohit Athavale
---
drivers/staging/Kconfig | 2 +
drivers/staging/Makefile | 1 +
drivers/staging/xm2mvscale/Kconfig| 11 +
drivers/staging
.c to see if it makes sense.
- Another question would be the right place to keep the driver,
in drivers/staging/media or drivers/staging/
- Dropped empty mmap_open, mmap_close ops.
- Removed incorrect DMA_SHARED_BUFFER select from Kconfig
v1 - Initial version
Rohit Athavale (3):
st
This commit adds the binding doc for the DT that the driver expects.
Driver has been tested against Zynq US+ board.
Signed-off-by: Rohit Athavale
---
.../devicetree/bindings/xm2mvscaler.txt| 25 ++
1 file changed, 25 insertions(+)
create mode 100644
drivers
This commit highlights the key functionalities that will be
improved upon in a future patch set.
Signed-off-by: Rohit Athavale
---
drivers/staging/xm2mvscale/TODO | 18 ++
1 file changed, 18 insertions(+)
create mode 100644 drivers/staging/xm2mvscale/TODO
diff --git a/drivers
Hi Dan,
Thanks for taking a look. I have added a tweak to add to the patch series.
Will CC linux-media on the V2 and add a note about this in the cover letter.
Best Regards,
Rohit
> -Original Message-
> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> Sent: Wednesday,
polyphases filters to perform
video scaling. The driver will be used by an application like a
gstreamer plugin.
Rohit Athavale (3):
staging: xm2mvscale: Driver support for Xilinx M2M Video Scaler
staging: xm2mvscale: Add TODO for the driver
Documentation: devicetree: bindings: Add DT binding
This commit adds the binding doc for the DT that the driver expects.
Driver has been tested against Zynq US+ board.
Signed-off-by: Rohit Athavale
---
.../devicetree/bindings/xm2mvscaler.txt| 25 ++
1 file changed, 25 insertions(+)
create mode 100644
drivers
ioctl_xm2mvsc.h
- The char driver that consumes the IP layer in xm2m_vscale.c
Signed-off-by: Rohit Athavale
---
drivers/staging/Kconfig | 2 +
drivers/staging/Makefile | 1 +
drivers/staging/xm2mvscale/Kconfig| 12 +
drivers/staging
This commit highlights the key functionalities that will be
improved upon in a future patch set.
Signed-off-by: Rohit Athavale
---
drivers/staging/xm2mvscale/TODO | 15 +++
1 file changed, 15 insertions(+)
create mode 100644 drivers/staging/xm2mvscale/TODO
diff --git a/drivers
Kindly review the patch. Patchv2 had refcount issue which is fixed here.
On Tue, 12 Jan 2016 09:31:46 +0530
Rohit kumar wrote:
> Currently we can only import dma buf fd's to get ion_handle.
> Adding support to import dma buf handles to support kernel
> specific use cases.
>
a_buf. This patch exposes api to
retrieve the ion handle from dma_buf for similar use cases. With this
patch, we can integrate ION within DRM-GEM for buffer management and
dma_buf sharing.
Signed-off-by: Rohit kumar
---
v2: Updated commit message with use case explanation, as suggested by
Hi Sumit,
On Thu, 07 Jan 2016 19:43:09 +0530
Sumit Semwal wrote:
> Hi Rohit,
>
> On 6 January 2016 at 12:41, Rohit kumar wrote:
> > Currently we can only import dma buf fd's to get ion_handle.
> > Adding support to import dma buf handles to support kernel
> >
a_buf. This patch exposes api to
retrieve the ion handle from dma_buf for similar use cases. With this
patch, we can integrate ION within DRM-GEM for buffer management and
dma_buf sharing.
Signed-off-by: Rohit kumar
---
v2: Updated commit message with use case explanation, as suggested by
Sorry to resend the patch without [RESEND] tag. Actually I had missed
to add de...@driverdev.osuosl.org, linux-ker...@vger.kernel.org in
mail last time.
I will update the commit message with the explanation and send the
PATCHv2 soon.
Thanks,
Rohit
On Tue, 05 Jan 2016 10:12:39 -0800
Laura
Currently we can only import dma buf fd's to get ion_handle.
Adding support to import dma buf handles to support kernel
specific use cases.
Signed-off-by: Rohit kumar
---
Currently, ION is the memory manager for graphics in android. However,
in other linux platforms such as Tizen, DRM-G
This patch fixes error handling case when buffer->pages allocation
fails. Also, it removes unreachable code of checking ret variable
although it is not updated.
Signed-off-by: Rohit kumar
---
drivers/staging/android/ion/ion.c | 14 +-
1 file changed, 5 insertions(+), 9 deleti
63 matches
Mail list logo
