Re: [PATCH RFC 2/6] mm: convert PG_balloon to PG_offline

On Wed, Nov 14, 2018 at 11:49:15PM +0100, David Hildenbrand wrote: > On 14.11.18 23:23, Matthew Wilcox wrote: > > On Wed, Nov 14, 2018 at 10:17:00PM +0100, David Hildenbrand wrote: > >> Rename PG_balloon to PG_offline. This is an indicator that the page is > >> logically offline, the content stale

Re: [PATCH] staging: sm750fb: Fix printk() style warning

On Mon, Oct 10, 2016 at 07:31:46AM -0700, Edward Lipinsky wrote: > > Thanks, that makes sense. I tried deleting the if statement and printk() > from ddk750_help.c, and adding the following in lynxfb_pci_probe() after > calling hw_sm750_map() and checking for errors: > > if (sm750_dev->revid == 0

Re: [PATCH] staging: sm750fb: Fix printk() style warning

On Thu, Oct 06, 2016 at 09:27:36PM -0700, Edward Lipinsky wrote: > On Sun, Oct 02, 2016 at 08:13:01PM +0200, Greg KH wrote: > > On Sun, Oct 02, 2016 at 11:05:05AM -0700, Edward Lipinsky wrote: > > > This patch fixes the checkpatch.pl warning: > > > > > > WARNING: printk() should include KERN_ faci

[PATCH 3/5] staging: sm750fb: replace absDiff with kernel standard abs macro

already has 'abs', use it instead of custom absDiff Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_chip.c | 3 ++- drivers/staging/sm750fb/sm750_help.h | 8 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750

[PATCH 2/5] staging: sm750: change definition of multi-bit register fields

Use stratigh-forward of multi-bit register fields Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_reg.h | 907 +- drivers/staging/sm750fb/sm750_accel.h | 62 +-- 2 files changed, 484 insertions(+), 485 deletions(-) diff --git a/drivers/staging

[PATCH 4/5] staging: sm750fb: move MHz() and roundedDiv() close to their usage

The MHz() and roundedDiv macros are used only by ddk750_chip.c, so move their definition there. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_chip.c | 4 drivers/staging/sm750fb/sm750_help.h | 7 --- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a

[PATCH 5/5] staging: sm750fb: remove sm750_help.h

This header only contains unused FIELD_*() macros and friends and may be removed Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_help.h | 1 - drivers/staging/sm750fb/sm750_accel.c | 1 - drivers/staging/sm750fb/sm750_cursor.c | 1 - drivers/staging/sm750fb/sm750_help.h

[PATCH 0/5] staging: sm750fb: complete changing register defines

rid of FIELD_*() macros. Mike Rapoport (5): staging: sm750fb: use BIT() macro for single-bit fields definition staging: sm750: change definition of multi-bit register fields staging: sm750fb: replace absDiff with kernel standard abs macro staging: sm750fb: move MHz() and roundedDiv

[PATCH 1/5] staging: sm750fb: use BIT() macro for single-bit fields definition

Replace complex definition of single-bit fields with BIT() macro for the registers that are not currently referenced by the driver. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_reg.h | 1071 + drivers/staging/sm750fb/sm750_accel.h | 36 +- 2

[PATCH 21/21] staging: sm750fb: change definition of CRT_FB_ADDRESS fields

Use stratight-forward definition of CRT_FB_ADDRESS register fields and use open-coded implementation for register manipulation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_reg.h | 10 +++--- drivers/staging/sm750fb/sm750_hw.c | 4 ++-- 2 files changed, 5 insertions

[PATCH 18/21] staging: sm750fb: change definition of DE_STRETCH_FORMAT fields

Use stratight-forward definition of DE_STRETCH_FORMAT register fields and use open-coded implementation for register manipulation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750_accel.c | 24 +++- drivers/staging/sm750fb/sm750_accel.h | 31

[PATCH 19/21] staging: sm750fb: change definition of DE_WINDOW_WIDTH fields

Use stratight-forward definition of DE_WINDOW_WIDTH register fields and use open-coded implementation for register manipulation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750_accel.c | 15 +-- drivers/staging/sm750fb/sm750_accel.h | 5 +++-- 2 files changed, 12

[PATCH 13/21] staging: sm750fb: change definition of DE_SOURCE fields

Use stratight-forward definition of DE_SOURCE register fields and use open-coded implementation for register manipulation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750_accel.c | 9 - drivers/staging/sm750fb/sm750_accel.h | 11 +-- 2 files changed, 9 insertions

[PATCH 15/21] staging: sm750fb: change definition of DE_DIMENSION fields

Use stratight-forward definition of DE_DIMENSION register fields and use open-coded implementation for register manipulation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750_accel.c | 12 ++-- drivers/staging/sm750fb/sm750_accel.h | 5 +++-- 2 files changed, 9 insertions

[PATCH 20/21] staging: sm750fb: change definition of CRT_FB_WIDTH fields

Use stratight-forward definition of CRT_FB_WIDTH register fields and use open-coded implementation for register manipulation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_reg.h | 5 +++-- drivers/staging/sm750fb/sm750_hw.c | 9 - 2 files changed, 7 insertions(+), 7

[PATCH 17/21] staging: sm750fb: change definition of DE_PITCH fields

Use stratight-forward definition of DE_PITCH register fields and use open-coded implementation for register manipulation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750_accel.c | 23 +++ drivers/staging/sm750fb/sm750_accel.h | 5 +++-- 2 files changed, 14

[PATCH 16/21] staging: sm750fb: change definition of DE_CONTROL fields

Use stratight-forward definition of DE_CONTROL register fields and use open-coded implementation for register manipulation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750_accel.c | 45 +- drivers/staging/sm750fb/sm750_accel.h | 112

[PATCH 14/21] staging: sm750fb: change definition of DE_DESTINATION fields

Use stratight-forward definition of DE_DESTINATION register fields and use open-coded implementation for register manipulation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750_accel.c | 15 ++- drivers/staging/sm750fb/sm750_accel.h | 9 - 2 files changed, 10

[PATCH 06/21] staging: sm750fb: change definition of CRT_VERTICAL_SYNC fields

Use stratight-forward definition of CRT_VERTICAL_SYNC register fields and use open-coded implementation for register manipulation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_mode.c | 7 +-- drivers/staging/sm750fb/ddk750_reg.h | 5 +++-- 2 files changed, 8 insertions

[PATCH 07/21] staging: sm750fb: change definition of PANEL_HORIZONTAL_SYNC fields

Use stratight-forward definition of PANEL_HORIZONTAL_SYNC register fields and use open-coded implementation for register manipulation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_mode.c | 7 +-- drivers/staging/sm750fb/ddk750_reg.h | 5 +++-- 2 files changed, 8

[PATCH 12/21] staging: sm750fb: change definition of HWC_COLOR_{12, 3} fields

Use straight-forward definition of HWC_COLOR_{12,3} register fields instead of magic numbers Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750_cursor.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_cursor.c b/drivers

[PATCH 01/21] staging: sm750fb: change definition of CRT_AUTO_CENTERING_TL fields

Use stratight-forward definition of CRT_AUTO_CENTERING_TL register fields Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_mode.c | 4 +--- drivers/staging/sm750fb/ddk750_reg.h | 4 ++-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/sm750fb

[PATCH 11/21] staging: sm750fb: change definition of HWC_LOCATION fields

Use BIT() macro for single-bit fields of HWC_LOCATION register and define HWC_LOCATION_{X,Y}_MASK for masking the address bits. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750_cursor.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers

[PATCH 10/21] staging: sm750fb: change definition of HWC_ADDRESS fields

Use BIT() macro for single-bit fields of HWC_ADDRESS register and define HWC_ADDRESS_ADDRESS_MASK for masking the address bits. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750_cursor.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/drivers

[PATCH 02/21] staging: sm750fb: change definition of CRT_AUTO_CENTERING_BR fields

Use stratight-forward definition of CRT_AUTO_CENTERING_BR register fields and use open-coded implementation for register manipulation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_mode.c | 5 +++-- drivers/staging/sm750fb/ddk750_reg.h | 5 +++-- 2 files changed, 6 insertions

[PATCH 05/21] staging: sm750fb: change definition of CRT_VERTICAL_TOTAL fields

Use stratight-forward definition of CRT_VERTICAL_TOTAL register fields and use open-coded implementation for register manipulation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_mode.c | 7 +-- drivers/staging/sm750fb/ddk750_reg.h | 5 +++-- 2 files changed, 8 insertions

[PATCH 03/21] staging: sm750fb: change definition of CRT_HORIZONTAL_TOTAL fields

Use stratight-forward definition of CRT_HORIZONTAL_TOTAL register fields and use open-coded implementation for register manipulation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_mode.c | 7 +-- drivers/staging/sm750fb/ddk750_reg.h | 5 +++-- 2 files changed, 8 insertions

[PATCH 04/21] staging: sm750fb: change definition of CRT_HORIZONTAL_SYNC fields

Use stratight-forward definition of CRT_HORIZONTAL_SYNC register fields and use open-coded implementation for register manipulation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_mode.c | 7 +-- drivers/staging/sm750fb/ddk750_reg.h | 5 +++-- 2 files changed, 8 insertions

[PATCH 08/21] staging: sm750fb: change definition of PANEL_VERTICAL_TOTAL fields

Use stratight-forward definition of PANEL_VERTICAL_TOTAL register fields and use open-coded implementation for register manipulation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_mode.c | 7 +-- drivers/staging/sm750fb/ddk750_reg.h | 5 +++-- 2 files changed, 8 insertions

[PATCH 09/21] staging: sm750fb: change definition of PANEL_VERTICAL_SYNC fields

Use stratight-forward definition of PANEL_VERTICAL_SYNC register fields and use open-coded implementation for register manipulation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_mode.c | 7 +-- drivers/staging/sm750fb/ddk750_reg.h | 5 +++-- 2 files changed, 8 insertions

[PATCH 00/21] staging: sm750fb: change some register fields defines

Hi, This is the third set of patches that aim to replace custom defines for register fields. The ultimate goal is to have MSB:LSB notation for register fields and FIELD_* macros removed. Mike Rapoport (21): staging: sm750fb: change definition of CRT_AUTO_CENTERING_TL fields staging: sm750fb

[PATCH 16/30] staging: sm750fb: use BIT macro for PANEL_DISPLAY_CTRL single-bit fields

Replace complex definition of PANEL_DISPLAY_CTRL register fields with BIT() macro and use open-coded implementation for register manipulations. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_chip.c| 6 +-- drivers/staging/sm750fb/ddk750_display.c | 24 +- drivers

[PATCH 10/30] staging: sm750fb: programModeRegisters: rename local vairables

Remove HungarianCamelCase notation. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_mode.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c index

[PATCH 00/30] staging: sm750fb: change some register fields defines

Hi, This is the second set of patches that aim to replace custom defines for register fields. The ultimate goal is to have MSB:LSB notation for register fields and FIELD_* macros removed. Mike Rapoport (30): staging: sm750fb: formatPllReg: rename ulPllReg to reg staging: sm750fb

[PATCH 26/30] staging: sm750fb: use BIT macro for CRT_DISPLAY_CTRL single-bit fields

Replace complex definition of CRT_DISPLAY_CTRL register fields with BIT() macro and use open-coded implementation for register manipulation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_display.c | 2 +- drivers/staging/sm750fb/ddk750_mode.c| 3 +-- drivers/staging

[PATCH 30/30] staging: sm750fb: change definition of PANEL_HORIZONTAL_TOTAL fields

Use stratight-forward defintion of PANEL_HORIZONTAL_TOTAL register fields and use open-coded implementation for register manipulations Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_mode.c | 9 ++--- drivers/staging/sm750fb/ddk750_reg.h | 5 +++-- 2 files changed, 9

[PATCH 28/30] staging: sm750fb: use BIT macro for I2C_CTRL fields

Replace complex definition of I2C_CTRL register fields with BIT() macro and use open-coded implementation for register manipulation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_hwi2c.c | 19 +++ drivers/staging/sm750fb/ddk750_reg.h | 20

[PATCH 29/30] staging: sm750fb: use BIT macro for I2C_STATUS fields

Replace complex definition of I2C_STATUS register fields with BIT() macro and use open-coded implementation for register manipulation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_hwi2c.c | 4 +--- drivers/staging/sm750fb/ddk750_reg.h | 18 -- 2 files

[PATCH 22/30] staging: sm750fb: change definition of PANEL_WINDOW_HEIGHT fields

Use stratight-forward defintion of PANEL_WINDOW_HEIGHT register fields and use open-coded implementation for register manipulations Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_reg.h | 5 +++-- drivers/staging/sm750fb/sm750_hw.c | 8 +--- 2 files changed, 8 insertions

[PATCH 27/30] staging: sm750fb: change definition of CRT_DISPLAY_CTRL multi-bit fields

Use more straight-forward definitions for multi-bit fields of CRT_DISPLAY_CTRL register and use open-coded implementation for register manipulation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_display.c | 4 ++- drivers/staging/sm750fb/ddk750_mode.c| 18

[PATCH 23/30] staging: sm750fb: change definition of PANEL_PLANE_TL fields

Use stratight-forward defintion of PANEL_PLANE_TL register fields Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_reg.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_reg.h b/drivers/staging/sm750fb/ddk750_reg.h index

[PATCH 25/30] staging: sm750fb: use BIT macro for DMA_ABORT_INTERRUPT single-bit fields

Replace complex definition of DMA_ABORT_INTERRUPT register fields with BIT() macro and use open-coded implementation for register manipulation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_chip.c | 2 +- drivers/staging/sm750fb/ddk750_reg.h | 20 2 files

[PATCH 21/30] staging: sm750fb: change definition of PANEL_WINDOW_WIDTH fields

Use stratight-forward defintion of PANEL_WINDOW_WIDTH register fields and use open-coded implementation for register manipulations Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_reg.h | 5 +++-- drivers/staging/sm750fb/sm750_hw.c | 7 --- 2 files changed, 7 insertions

[PATCH 20/30] staging: sm750fb: change definition of PANEL_FB_WIDTH fields

Use stratight-forward defintion of PANEL_FB_WIDTH register fields and use open-coded implementation for register manipulations Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_reg.h | 5 +++-- drivers/staging/sm750fb/sm750_hw.c | 8 2 files changed, 7 insertions(+), 6

[PATCH 24/30] staging: sm750fb: change definition of PANEL_PLANE_BR fields

Use stratight-forward defintion of PANEL_PLANE_BR register fields and use open-coded implementation for register manipulations Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_reg.h | 5 +++-- drivers/staging/sm750fb/sm750_hw.c | 7 --- 2 files changed, 7 insertions(+), 5

[PATCH 19/30] staging: sm750fb: change definition of PANEL_FB_ADDRESS fields

Use BIT() macro for single-bit fields of PANEL_FB_ADDRESS register and define PANEL_FB_ADDRESS_ADDRESS_MASK for masking the address bits. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_reg.h | 10 +++--- drivers/staging/sm750fb/sm750_hw.c | 8 +++- 2 files changed, 6

[PATCH 18/30] staging: sm750fb: change definition of PANEL_DISPLAY_CTRL multi-bit fields

Use more straight-forward definitions for multi-bit fields of PANEL_DISPLAY_CTRL register and use open-coded implementation for register manipulation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_display.c | 4 +++- drivers/staging/sm750fb/ddk750_reg.h | 27

[PATCH 17/30] staging: sm750fb: remove PANEL_DISPLAY_CTRL_TFT_DISP defines

The PANEL_DISPLAY_CTRL_TFT_DISP definitions artificially encode PANEL_DISPLAY_CTRL_DUAL_DISPLAY and PANEL_DISPLAY_CTRL_DOUBLE_PIXEL bits combinations. Replace the PANEL_DISPLAY_CTRL_TFT_DISP usage with direct use of the bits defined in the datasheet. Signed-off-by: Mike Rapoport --- drivers

[PATCH 15/30] staging: sm750fb: hw_sm750_setBLANK: reduce printk verbosity

pr_debug would be enough Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750_hw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c index c0c2f1c..52fd250 100644 --- a/drivers/staging

[PATCH 14/30] staging: sm750fb: refactor setDisplayControl function

The enable/disbable sequence in setDisplayControl function is duplicated for primary and secondary display controllers. The function can be refactored so that the common part of register access will be shared for both controllers. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb

[PATCH 13/30] staging: sm750fb: merge reserved bits of PANEL/CRT_DISPLAY_CTRL registers

Use single mask for reserved bits in PANEL_DISPLAY_CTRL and CRT_DISPLAY_CTRL registers. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_display.c | 11 ++- drivers/staging/sm750fb/ddk750_mode.c| 7 ++- drivers/staging/sm750fb/ddk750_reg.h | 29

[PATCH 09/30] staging: sm750fb: change definition of VGA_CONFIGURATION multi-bit field

Use more straight-forward definitions for multi-bit field of VGA_CONFIGURATION register. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/ddk750_reg.h b/drivers/staging/sm750fb

[PATCH 11/30] staging: sm750fb: setDisplayControl: rename local vairables

Remove HungarianCamelCase notation. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_display.c | 50 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_display.c b/drivers/staging/sm750fb

[PATCH 04/30] staging: sm750fb: use PLL_CTRL_POWER defines for CRT_PLL_CTRL

Use PLL_CTRL_POWER definitions for CRT_PLL_CTRL register access Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_display.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_display.c b/drivers/staging/sm750fb/ddk750_display.c

[PATCH 12/30] staging: sm750fb: share common bits in display control registers

The display control registers for primary and secondary display share some of the bits and those bits can be defined in a single place and then used for manipulations of the relevant registers. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_chip.c| 6 +-- drivers/staging

[PATCH 05/30] staging: sm750fb: use BIT macro for PLL_CTRL single-bit fields

Replace complex defintion of PLL_CTRL fields with BIT() macro and use open-coded implementation for PLL register manipulations. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_chip.c| 5 + drivers/staging/sm750fb/ddk750_display.c | 6 ++ drivers/staging/sm750fb

[PATCH 07/30] staging: sm750fb: drop redundant defines for PLL_CTRL fields

The PLL_CTRL fields have common defines for several PLL control registers and re-defining the same values per register is not needed. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_reg.h | 64 1 file changed, 64 deletions(-) diff --git a

[PATCH 08/30] staging: sm750fb: use BIT macro for VGA_CONFIGURATION single-bit fields

Replace complex defintion of VGA_CONFIGURATION register fields with BIT() macro and use open-coded implementation for VGA_CONFIGURATION manipulations. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_chip.c | 3 +-- drivers/staging/sm750fb/ddk750_reg.h | 8 ++-- 2 files

[PATCH 06/30] staging: sm750fb: change defintion of PANEL_PLL_CTRL multi-bit fields

Use more straight-forward definitions for multi-bit field of PANEL_PLL_CTRL register and use open-coded implementation for register manipulations. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_chip.c | 24 +++- drivers/staging/sm750fb/ddk750_reg.h | 15

[PATCH 03/30] staging: sm750fb: rename PANEL_PLL_CTRL_* fields to PLL_CTRL_*

Several PLL control registers have the same layout and therefore the field definitions may be shared for those registers. Renaming definitions of PANEL_PLL_CTRL_* fields to more generic PLL_CTRL_* will allow reusing these definitions for other PLL control registers. Signed-off-by: Mike Rapoport

[PATCH 02/30] staging: sm750fb: formatPllReg: fix comment formatting

Fix comment alignment and formatting to follow kernel coding style Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_chip.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c

[PATCH 01/30] staging: sm750fb: formatPllReg: rename ulPllReg to reg

Remove HungarianCamelCase notation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_chip.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c index a9a8884..6ab26a9 100644 --- a

[PATCH RESEND 17/18] staging: sm750fb: use BIT macro for POWER_MODE_CTRL single-bit fields

Replace complex definition of POWER_MODE_CTRL register fields with BIT() macro and use open-coded implementation for register manipulations. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_power.c | 10 -- drivers/staging/sm750fb/ddk750_reg.h | 12 +++- 2 files

[PATCH RESEND 18/18] staging: sm750fb: change definition of POWER_MODE_CTRL multi-bit field

Use more straight-forward definitions for multi-bit field of POWER_MODE_CTRL register and use open-coded implementation for register manipulations. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_power.c | 13 + drivers/staging/sm750fb/ddk750_reg.h | 8 2

[PATCH RESEND 12/18] staging: sm750fb: use BIT macro for CURRENT_GATE single-bit fields

Replace complex definition of CURRENT_GATE register fields with BIT() macro and use open-coded implementation for register manipulations. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_chip.c | 3 +-- drivers/staging/sm750fb/ddk750_power.c | 18 +++--- drivers/staging

[PATCH RESEND 14/18] staging: sm750fb: change definition of CURRENT_GATE multi-bit fields

Use more straight-forward definitions for multi-bit fields of CURRENT_GATE register and use open-coded implementation for register manipulation. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_chip.c | 20 +-- drivers/staging/sm750fb/ddk750_reg.h | 36

[PATCH RESEND 16/18] staging: sm750fb: change definition of MODE0_GATE multi-bit fields

Use more straight-forward definitions for multi-bit fields of MODE0_GATE register. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_reg.h | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_reg.h b/drivers

[PATCH RESEND 10/18] staging: sm750fb: use BIT macro for GPIO_MUX single-bit fields

Replace complex definition of GPIO_MUX register fields with BIT() macro and use open-coded implementation for register manipulations. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_hwi2c.c | 7 +- drivers/staging/sm750fb/ddk750_reg.h | 128

[PATCH RESEND 13/18] staging: sm750fb: set{Memory, Master}Clock: rename ulReg to reg

Remove HungarianCamelCase notation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_chip.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c index

[PATCH RESEND 15/18] staging: sm750fb: use BIT macro for MODE0_GATE single-bit fields

Replace complex definition of MODE0_GATE register fields with BIT() macro and use open-coded implementation for register manipulations. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_chip.c | 2 +- drivers/staging/sm750fb/ddk750_reg.h | 44

[PATCH RESEND 07/18] staging: sm750fb: ddk750_initHw: rename ulReg to reg

Remove HungarianCamelCase notation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_chip.c | 52 +-- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c

[PATCH RESEND 00/18] staging: sm750fb: change some register fields defines

Hi, This is the first set of patches that aim to replace custom defines for register fields. The ultimate goal is to have MSB:LSB notation for register fields and FIELD_* macros removed. Mike Rapoport (18): staging: sm750fb: hw_sm750(le)_deWait: rename dwVal to val staging: sm750fb: use BIT

[PATCH RESEND 02/18] staging: sm750fb: use BIT macro for DE_STATE1 single-bit field

Replace complex definition of DE_STATE1 field and usage of FIELD_SET with BIT() macro and open-coded register value modifications Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_reg.h | 4 +--- drivers/staging/sm750fb/sm750_hw.c | 4 ++-- 2 files changed, 3 insertions(+), 5

[PATCH RESEND 11/18] staging: sm750fb: change definition of MISC_CTRL multi-bit fields

Use more straight-forward definitions for multi-bit fields of MISC_CTRL register and use open-coded implementation for register manipulations. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_chip.c | 2 +- drivers/staging/sm750fb/ddk750_reg.h | 28

[PATCH RESEND 09/18] staging: sm750fb: ddk750_sii164: fix defines for i2c{Read, Write}reg

For case when USE_HW_I2C is not defined, i2c{Read,Write}reg was wrongly defined to use old function names. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_sii164.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b

[PATCH RESEND 06/18] staging: sm750fb: change definition of SYSTEM_CTRL multi-bit fields

Use more straight-forward definitions for multi-bit fields of SYSTEM_CTRL register and replace FIELD_GET/SET for these fields with open-coded implementation. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_power.c | 2 +- drivers/staging/sm750fb/ddk750_reg.h | 20

[PATCH RESEND 03/18] staging: sm750fb: use BIT macro for DE_STATE2 single-bit fields

Replace complex definition of DE_STATE1 fields and usage of FIELD_GET with BIT() macro and open-coded register value modifications Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_reg.h | 12 +++- drivers/staging/sm750fb/sm750_hw.c | 8 2 files changed, 7

[PATCH RESEND 08/18] staging: sm750fb: use BIT macro for MISC_CTRL single-bit fields

Replace complex definition of MISC_CTRL register fields with BIT() macro and use open-coded implementation for register manipulations. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_chip.c | 4 +- drivers/staging/sm750fb/ddk750_power.h | 11 ++ drivers/staging/sm750fb

[PATCH RESEND 01/18] staging: sm750fb: hw_sm750(le)_deWait: rename dwVal to val

Remove HungarianCamelCase notation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750_hw.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c index 41822c6..f9908d9 100644

[PATCH RESEND 04/18] staging: sm750fb: remove unused DE_STATE2_DE_RESERVED

Definition of reserved fields in a register is not interesting Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_reg.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_reg.h b/drivers/staging/sm750fb/ddk750_reg.h index db13bdf..38ebe95 100644

[PATCH RESEND 05/18] staging: sm750fb: use BIT macro for SYSTEM_CTRL single-bit fields

Replace complex definition of SYSTEM_CTRL fields and usage of FIELD_GET/SET with BIT() macro and open-coded register value modifications Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_display.c | 24 -- drivers/staging/sm750fb/ddk750_reg.h | 76

[PATCH RESEND v4 5/7] staging: sm750fb: introduce sm750fb_frambuffer_release

Use a function to unregister framebuffer info and release its resources. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb

[PATCH RESEND v4 7/7] staging: sm750fb: lynxfb_pci_probe: remove some pr_info

Several pr_info statements in lynxfb_pci_probe seem like debug leftovers and may be removed. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index

[PATCH RESEND v4 6/7] staging: sm750fb: introduce sm750fb_frambuffer_alloc

Split framebuffer allocation and registration into a dedicated function to simplify lynxfb_pci_probe Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c | 98 + 1 file changed, 41 insertions(+), 57 deletions(-) diff --git a/drivers/staging

[PATCH RESEND v4 0/7] staging: sm750fb: refactor lynxfb_pci_probe

Hi, These patches refactor the lynxfb_pci_probe. v4 changes: * address Dan's comments v3 changes: * rebased on current Greg's staging-testing v2 changes: * add pci_disable_device on the cleanup path * return actual error rather than ENODEV Mike Rapoport (7): staging: sm750fb: d

[PATCH RESEND v4 3/7] staging: sm750fb: lynxfb_pci_remove: remove unused variable

The par variable in lynxfb_pci_remove is only assigned a value and never used afterwards. Remove it. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index

[PATCH RESEND v4 4/7] staging: sm750fb: replace dual member of sm750_dev with fb_count

Will be used in futher refactoring of driver _probe and _remove methods. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c | 24 +--- drivers/staging/sm750fb/sm750.h | 2 +- 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/drivers/staging

[PATCH RESEND v4 2/7] staging: sm750fb: lynxfb_pci_probe: return actual errors

The lynxfb_pci_probe always returned -ENODEV in case of error. Modify it so that actual error code will be propogated to the caller. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c | 37 + 1 file changed, 17 insertions(+), 20 deletions

[PATCH RESEND v4 1/7] staging: sm750fb: disable PCI device if lynxfb_pci_probe fails

In case of error during lynxfb_pci_probe, the function returned without calling pci_disable_device. Fix it by adding pci_disable_device on the error cleanup path. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging

Re: [PATCH 00/18] staging: sm750fb: change some register fields defines

On Mon, Nov 16, 2015 at 09:59:49AM +0200, Mike Rapoport wrote: > Hi, > > This is the first set of patches that aim to replace custom defines for > register fields. The ultimate goal is to have MSB:LSB notation for register > fields and FIELD_* macros removed. I'd highly appr

Re: [PATCH v4 0/7] staging: sm750fb: refactor lynxfb_pci_probe

On Sun, Nov 08, 2015 at 11:52:16AM +0200, Mike Rapoport wrote: > Hi, > > These patches refactor the lynxfb_pci_probe Any comments on this? Should I resend? > v4 changes: > * address Dan's comments > > v3 changes: > * rebased on current Greg's stagin

[PATCH 17/18] staging: sm750fb: use BIT macro for POWER_MODE_CTRL single-bit fields

Replace complex definition of POWER_MODE_CTRL register fields with BIT() macro and use open-coded implementation for register manipulations. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_power.c | 10 -- drivers/staging/sm750fb/ddk750_reg.h | 12 +++- 2 files

[PATCH 12/18] staging: sm750fb: use BIT macro for CURRENT_GATE single-bit fields

Replace complex definition of CURRENT_GATE register fields with BIT() macro and use open-coded implementation for register manipulations. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_chip.c | 3 +-- drivers/staging/sm750fb/ddk750_power.c | 18 +++--- drivers/staging

[PATCH 13/18] staging: sm750fb: set{Memory, Master}Clock: rename ulReg to reg

Remove HungarianCamelCase notation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_chip.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c index

[PATCH 09/18] staging: sm750fb: ddk750_sii164: fix defines for i2c{Read, Write}reg

For case when USE_HW_I2C is not defined, i2c{Read,Write}reg was wrongly defined to use old function names. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_sii164.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b

[PATCH 11/18] staging: sm750fb: change definition of MISC_CTRL multi-bit fields

Use more straight-forward definitions for multi-bit fields of MISC_CTRL register and use open-coded implementation for register manipulations. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_chip.c | 2 +- drivers/staging/sm750fb/ddk750_reg.h | 28

[PATCH 10/18] staging: sm750fb: use BIT macro for GPIO_MUX single-bit fields

Replace complex definition of GPIO_MUX register fields with BIT() macro and use open-coded implementation for register manipulations. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_hwi2c.c | 7 +- drivers/staging/sm750fb/ddk750_reg.h | 128

[PATCH 01/18] staging: sm750fb: hw_sm750(le)_deWait: rename dwVal to val

Remove HungarianCamelCase notation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750_hw.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c index 41822c6..f9908d9 100644

[PATCH 16/18] staging: sm750fb: change definition of MODE0_GATE multi-bit fields

Use more straight-forward definitions for multi-bit fields of MODE0_GATE register. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_reg.h | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_reg.h b/drivers

[PATCH 03/18] staging: sm750fb: use BIT macro for DE_STATE2 single-bit fields

Replace complex definition of DE_STATE1 fields and usage of FIELD_GET with BIT() macro and open-coded register value modifications Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_reg.h | 12 +++- drivers/staging/sm750fb/sm750_hw.c | 8 2 files changed, 7

  1   2   3   >