On 07/01/2015 10:31 PM, Jes Sorensen wrote:
> Michel von Czettritz writes:
>> Writing the output of cpu_to_le32 to an u32 or *(u32*) is an implicit
>> cast and results in an sparse warning.
>>
>> Since param and mask won't be changed, the implicit cast can
On 07/01/2015 10:08 AM, Sudip Mukherjee wrote:
> On Wed, Jul 01, 2015 at 10:50:42AM +0300, Dan Carpenter wrote:
>> On Wed, Jul 01, 2015 at 12:42:24PM +0530, Sudip Mukherjee wrote:
>>> On Tue, Jun 30, 2015 at 11:54:59PM +0200, Michel von Czettritz wrote:
>>>> The
The return value of FillH2CCmd in rtl8723a_set_rssi_cmd and
rtl8723a_set_raid_cmd is never checked. Both functions always return
_SUCCESS.
Both functions now return the return value of FillH2CCmd.
Signed-off-by: Michel von Czettritz
---
drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 8
Writing the output of cpu_to_le32 to an u32 or *(u32*) is an implicit
cast and results in an sparse warning.
Since param and mask won't be changed, the implicit cast can be avoided
by creating local variables.
Signed-off-by: Michel von Czettritz
---
drivers/staging/rtl8723au/hal/rtl8723a_
param. rtl8723a_set_rssi_cmd is never used as a
function pointer, nor does it seem to conform to any API.
Signed-off-by: Michel von Czettritz
---
drivers/staging/rtl8723au/hal/odm.c | 2 +-
drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 6 +++---
drivers/staging/rtl8723au/include
Initialy fixing a sparse warning, resulted in 3 small patches cleaning
rtl8723a_set_rssi_cmd an rtl8723a_set_raid_cmd up a bit.
Both functions now avoid implicit casts, return actual values, and
rtl8723a_set_rssi_cmd cannot write in unallocated memory any more.
Michel von Czettritz (3
As suggested by Sudip this patch removes the redundant 1360x768@60
option from the fb_videomode struct array.
The removed option and the option one it differ in a typo and a flag.
Signed-off-by: Michel von Czettritz
---
drivers/staging/sm750fb/sm750.c | 3 ---
1 file changed, 3 deletions
will stay the same,
and due to C99 'vmode' is initialized to zero too.
Therefore this doesn't have any implications for runtime-behavior,
but seems to be semantically wrong.
The Patch simply changes the | to a coma. Please check if this is correct.
Signed-off-by: Michel von Czettr
