Not referenced anymore since commit 9fe7b29c6cc1 ("staging: rtl8188eu:
remove unused field bRxRSSIDisplay in struct adapter").
Cc: Greg Kroah-Hartman
Cc: Larry Finger
Cc: Ivan Safonov
Cc: de...@driverdev.osuosl.org
Signed-off-by: Luca Ceresoli
---
Changes v1 -> v2:
- reba
Not referenced anymore since the removal of field bRxRSSIDisplay in
struct adapter.
Cc: Greg Kroah-Hartman
Cc: Larry Finger
Cc: Ivan Safonov
Cc: de...@driverdev.osuosl.org
Signed-off-by: Luca Ceresoli
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 17 -
1 file changed
that is being
removed, so remove it as well.
Also fix coding style issues in the touched lines.
Cc: Greg Kroah-Hartman
Cc: Larry Finger
Cc: Ivan Safonov
Cc: de...@driverdev.osuosl.org
Signed-off-by: Luca Ceresoli
---
drivers/staging/rtl8188eu/core/rtw_recv.c| 75 +++-
well.
Cc: Greg Kroah-Hartman
Cc: Larry Finger
Cc: Ivan Safonov
Cc: de...@driverdev.osuosl.org
Signed-off-by: Luca Ceresoli
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 3 ---
drivers/staging/rtl8188eu/include/drv_types.h | 1 -
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 2 --
3 fil
proper way) the mentioned
debugging features, they can still fetch this code from the git
history.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Kyle Kuffermann
Cc: Binoy Jayan
Cc: Arnd Bergmann
Cc: "Rémy Oudompheng"
Cc: Ivan Safonov
Cc: Jakub Sitnicki
Cc: Alexey Khoro
These functions were only mentioned in the rtw_proc_init_one()
function in drivers/staging/rtl8188eu/os_dep/os_intfs.c, which was
under #if 0 and has now been removed completely.
As they are not used anywhere, and also violate the coding style
rules, remove them.
Signed-off-by: Luca Ceresoli
Cc
These functions have been declared without any implementation since
the first commit (58c434013a22fccfdb14abc2bb8408ca29073b76) and there
has been no mention of them in following commits.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Kyle Kuffermann
Cc: de...@driverdev.osuosl.org
Cc
These functions have been declared without any implementation since
the first commit (364e30ebd2dbaccba430c603da03e68746eb932a) and there
has been no mention of them in following commits.
Signed-off-by: Luca Ceresoli
Cc: Larry Finger
Cc: Jes Sorensen
Cc: Greg Kroah-Hartman
Cc: linux-wirel
Since the removal of rtw_proc_init_one() the proc filesystem is not
mentioned in this driver. So this include becomes useless.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Arnd Bergmann
Cc: Binoy Jayan
Cc: Anish Bhatt
Cc: "Rémy Oudompheng"
Cc: Alexey Khoroshilov
This function is only used inside rtw_recv.c. Which is quite logical,
since it's a timer callback: it is passed as the _fn argument to
setup_timer(). So it is internal to rtw_recv.c and should be static.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Bhaktipriya Shridhar
Cc:
Dear Kalle,
thanks for your feedback.
On 02/09/2016 18:18, Kalle Valo wrote:
> Luca Ceresoli writes:
>
>> These functions have been declared without any implementation since
>> the first commit (364e30ebd2dbaccba430c603da03e68746eb932a) and there
>> has been no ment
Since the removal of rtw_proc_init_one() the proc filesystem is not
mentioned in this driver. So this include becomes useless.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Arnd Bergmann
Cc: Binoy Jayan
Cc: Anish Bhatt
Cc: "Rémy Oudompheng"
Cc: Alexey Khoroshilov
These functions were only mentioned in the rtw_proc_init_one()
function in drivers/staging/rtl8188eu/os_dep/os_intfs.c, which was
under #if 0 and has now been removed completely.
As they are not used anywhere, and also violate the coding style
rules, remove them.
Signed-off-by: Luca Ceresoli
Cc
proper way) the mentioned
debugging features, they can still fetch this code from the git
history.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Kyle Kuffermann
Cc: Binoy Jayan
Cc: Arnd Bergmann
Cc: "Rémy Oudompheng"
Cc: Ivan Safonov
Cc: Jakub Sitnicki
Cc: Alexey Khoro
These functions have been declared without any implementation since
the first commit (58c434013a22fccfdb14abc2bb8408ca29073b76) and there
has been no mention of them in following commits.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Kyle Kuffermann
Cc: de...@driverdev.osuosl.org
Cc
This function is only used inside rtw_recv.c. Which is quite logical,
since it's a timer callback: it is passed as the _fn argument to
setup_timer(). So it is internal to rtw_recv.c and should be static.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Bhaktipriya Shridhar
Cc:
These functions have been declared without any implementation since
the first commit (364e30ebd2dbaccba430c603da03e68746eb932a) and there
has been no mention of them in following commits.
Signed-off-by: Luca Ceresoli
Cc: Larry Finger
Cc: Jes Sorensen
Cc: Greg Kroah-Hartman
Cc: linux-wirel
Dear Andy,
thanks for your review.
On 28/08/2016 14:28, Andy Shevchenko wrote:
> On Sat, 2016-08-27 at 14:40 +0200, Luca Ceresoli wrote:
>
> Put here few words _why_ you are doing this.
I'm doing it because this function is only used inside rtw_recv.c. Which
is quite logical
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Bhaktipriya Shridhar
Cc: Andy Shevchenko
Cc: Geliang Tang
Cc: Jakub Sitnicki
Cc: Ivan Safonov
Cc: Kyle Kuffermann
Cc: linux-ker...@vger.kernel.org
---
drivers/staging/rtl8188eu/core/rtw_recv.c | 4 ++--
1 file changed, 2 insertions
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Kyle Kuffermann
Cc: linux-ker...@vger.kernel.org
---
drivers/staging/rtl8188eu/include/recv_osdep.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/recv_osdep.h
b/drivers/staging/rtl8188eu/include
These functions were only mentioned in the rtw_proc_init_one()
function in drivers/staging/rtl8188eu/os_dep/os_intfs.c, which was
under #if 0 and has now been removed completely.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Kyle Kuffermann
Cc: Chris Elliott
Cc: Ivan Safonov
Cc
The proc filesystem is not used in this driver.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Arnd Bergmann
Cc: Binoy Jayan
Cc: Anish Bhatt
Cc: "Rémy Oudompheng"
Cc: Alexey Khoroshilov
Cc: Kyle Kuffermann
Cc: linux-ker...@vger.kernel.org
---
drivers/staging/rtl8188
want to implement (in a proper way) the mentioned
debugging features, they can still fetch these functions from the git
history.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Kyle Kuffermann
Cc: Binoy Jayan
Cc: Arnd Bergmann
Cc: "Rémy Oudompheng"
Cc: Ivan Safonov
Cc: Jaku
Signed-off-by: Luca Ceresoli
Cc: Larry Finger
Cc: Jes Sorensen
Cc: Greg Kroah-Hartman
Cc: linux-wirel...@vger.kernel.org
Cc: linux-ker...@vger.kernel.org
---
drivers/staging/rtl8723au/include/recv_osdep.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/rtl8723au/include
Dear Greg,
Greg Kroah-Hartman wrote:
On Wed, Dec 02, 2015 at 10:54:00PM +0100, Luca Ceresoli wrote:
Fix checkpatch issue:
CHECK: spaces preferred around that '*' (ctx:VxV)
Signed-off-by: Luca Ceresoli
Cc: Larry Finger
Cc: Greg Kroah-Hartman
Odd, I don't think I&#
There is such a field both in struct mlme_ext_info and in struct
registry_priv. Rename both.
Also fix checkpatch issue in the lines touched:
WARNING: line over 80 characters
Signed-off-by: Luca Ceresoli
Cc: Larry Finger
Cc: Greg Kroah-Hartman
---
drivers/staging/rtl8188eu/core
Using the ternary operator allows to more concisely write the same
code, and to stay within 80 characters without even increasing the
number of lines.
Signed-off-by: Luca Ceresoli
Cc: Larry Finger
Cc: Greg Kroah-Hartman
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 8
1 file
field of struct registry_priv.
Raises a new checkpatch issue, which is fixed in a later commit:
CHECK: Avoid CamelCase:
Signed-off-by: Luca Ceresoli
Cc: Larry Finger
Cc: Greg Kroah-Hartman
---
drivers/staging/rtl8188eu/include/drv_types.h | 2 +-
drivers/staging/rtl8188eu/os_dep/os_intfs.c
The first argument to memset() is (void *), the explicit typecasts are
not needed. They just make code less readable.
Signed-off-by: Luca Ceresoli
Cc: Larry Finger
Cc: Greg Kroah-Hartman
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 4 ++--
drivers/staging/rtl8188eu/core/rtw_efuse.c
This line is connented since the initial import in commit 7b464c9fa5cc
("staging: r8188eu: Add files for new driver - part 4") and there's no
comment stating how it could ever be useful.
Signed-off-by: Luca Ceresoli
Cc: Larry Finger
Cc: Greg Kroah-Hartman
---
drivers/staging
Fix checkpatch issue:
CHECK: spaces preferred around that '*' (ctx:VxV)
Signed-off-by: Luca Ceresoli
Cc: Larry Finger
Cc: Greg Kroah-Hartman
---
drivers/staging/rtl8188eu/core/rtw_efuse.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8
ine over 80 characters
CHECK: Unnecessary parentheses around
Note: some of the modified lines are still over 80 characters because they
are not fixable by just adding newlines. They will be fixed in a later
patch.
Signed-off-by: Luca Ceresoli
Cc: Larry Finger
Cc: Greg Kroah-Hartman
---
pmlmeinfo->ADDBA_req is accessed three times in this function, but it
contributes to generating lines above 80 characters that are not easy to
split in a nice way.
Extract a pointer to it to make code slightly more concise and fix some
lines over 80 characters.
Signed-off-by: Luca Ceresoli
rtw_set_ie() is a memcpy-like function, taking addresses of memory buffers
among its parameters. Similarly to memcpy, change the parameters to be
void*. This will allow to get rid of typecasts whenever it is called.
Signed-off-by: Luca Ceresoli
Cc: Larry Finger
Cc: Greg Kroah-Hartman
This comment gives pretty much the same information as the name of the
function that it immediately precedes.
Signed-off-by: Luca Ceresoli
Cc: Larry Finger
Cc: Greg Kroah-Hartman
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers
Dear Larry,
Larry Finger wrote:
On 09/14/2015 05:34 PM, Luca Ceresoli wrote:
Dear Larry, All,
Luca Ceresoli wrote:
Dear Larry,
thanks for your review.
Larry Finger wrote:
On 08/28/2015 03:45 PM, Luca Ceresoli wrote:
Some of the report_*() functions are internal and will be declared
static
Dear Larry, All,
Luca Ceresoli wrote:
Dear Larry,
thanks for your review.
Larry Finger wrote:
On 08/28/2015 03:45 PM, Luca Ceresoli wrote:
Some of the report_*() functions are internal and will be declared
static,
and their declaration removed from rtw_mlme_ext.h, in a later commit.
This
Signed-off-by: Luca Ceresoli
Cc: Larry Finger
Cc: Greg Kroah-Hartman
---
drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_mlme_ext.h
b/drivers/staging/rtl8188eu/include/rtw_mlme_ext.h
index cc3857dbfe09
Dear Larry,
Larry Finger wrote:
On 08/28/2015 03:45 PM, Luca Ceresoli wrote:
Signed-off-by: Luca Ceresoli
Cc: Larry Finger
Cc: Greg Kroah-Hartman
Empty commit messages are generally not accepted.
Meaning something like this?
commit 96ac283d6490932ff5097259c18a4d03bdddb010
Author
Dear Larry,
thanks for your review.
Larry Finger wrote:
On 08/28/2015 03:45 PM, Luca Ceresoli wrote:
Some of the report_*() functions are internal and will be declared
static,
and their declaration removed from rtw_mlme_ext.h, in a later commit.
This would break compilation, since they are
Even though it is declared in an include file, it is used only in
rtw_cmd.c.
There's even a preprocessor guard to make sure it is not visible in other
modules. It is now useless, so remove it.
Signed-off-by: Luca Ceresoli
Cc: Larry Finger
Cc: Greg Kroah-Hartman
---
drivers/staging/rtl8
Since rtw_cmd_callback has been moved to rtw_cmd.c these are internal
functions. Remove their declaration in rtw_cmd.h and make them static.
Signed-off-by: Luca Ceresoli
Cc: Larry Finger
Cc: Greg Kroah-Hartman
---
drivers/staging/rtl8188eu/core/rtw_cmd.c| 18 --
drivers
They are just wrappers to the standard semaphore functions.
Signed-off-by: Luca Ceresoli
Cc: Larry Finger
Cc: Greg Kroah-Hartman
---
drivers/staging/rtl8188eu/core/rtw_pwrctrl.c| 20 ++--
drivers/staging/rtl8188eu/include/rtw_pwrctrl.h | 15 ---
drivers/staging
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Jes Sorensen
Cc: Larry Finger
---
drivers/staging/rtl8723au/include/rtw_cmd.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8723au/include/rtw_cmd.h
b/drivers/staging/rtl8723au/include/rtw_cmd.h
index
are
referenced, without the need for forward declarations.
Also move near the beginning of the file the collect_bss_info() and
process_80211d(), since they are called from the report_*() functions.
This commit only reorders code, there is no content change.
Signed-off-by: Luca Ceresoli
Cc: Larry
rtw_init_cmd_priv() always returns _SUCCESS, which is fine since it
only calls void initializers. Thus, make it void and remove code
checking for its return value.
Signed-off-by: Luca Ceresoli
Cc: Larry Finger
Cc: Greg Kroah-Hartman
---
drivers/staging/rtl8188eu/core/rtw_cmd.c| 3
rtw_init_cmd_priv() is called in one place only, and from another file.
Signed-off-by: Luca Ceresoli
Cc: Larry Finger
Cc: Greg Kroah-Hartman
---
drivers/staging/rtl8188eu/core/rtw_cmd.c| 13 -
drivers/staging/rtl8188eu/include/rtw_cmd.h | 11 ++-
2 files changed, 10
Signed-off-by: Luca Ceresoli
Cc: Larry Finger
Cc: Greg Kroah-Hartman
---
drivers/staging/rtl8188eu/include/osdep_service.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/osdep_service.h
b/drivers/staging/rtl8188eu/include/osdep_service.h
index
arry, plus Jes for one patch,
that he also promptly acked -- thanks Jes). You already received these
patches at the first round and you are getting them again. You can safely
delete either this or the other copy, they are identical.
Luca Ceresoli (16):
staging: rtl8188eu: rtw_mlme_ext.c: reorder
These are internal functions. Remove their declaration in rtw_mlme_ext.h
and make them static.
Signed-off-by: Luca Ceresoli
Cc: Larry Finger
Cc: Greg Kroah-Hartman
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c| 11 ++-
drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 6
It's just a wrapper tp down_interruptible().
Signed-off-by: Luca Ceresoli
Cc: Larry Finger
Cc: Greg Kroah-Hartman
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +-
drivers/staging/rtl8188eu/include/osdep_service.h | 2 --
drivers/staging/rtl8188eu/include/rtw_pwrctrl.h
...one of which is not even implemented.
Signed-off-by: Luca Ceresoli
Cc: Larry Finger
Cc: Greg Kroah-Hartman
---
drivers/staging/rtl8188eu/core/rtw_cmd.c| 7 ---
drivers/staging/rtl8188eu/include/rtw_cmd.h | 4
2 files changed, 11 deletions(-)
diff --git a/drivers/staging
Even though it is declared in an include file, it is used only in
rtw_cmd.c.
There's even a preprocessor guard to make sure it is not visible in other
modules. It is now useless, so remove it.
Signed-off-by: Luca Ceresoli
Cc: Larry Finger
Cc: Greg Kroah-Hartman
---
drivers/staging/rtl8
compilation, since the callbacks are are referenced
(via rtw_cmd_callback) before their definition.
Reorder these functions so that symbols are defined before they are
referenced, without the need for forward declarations.
This commit only reorders code, there is no content change.
Signed-off-by: Luca
All usages of this macro have been removed in earlier commits, so get rid
of it.
Signed-off-by: Luca Ceresoli
Cc: Larry Finger
Cc: Greg Kroah-Hartman
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_cmd.c
b
This macro has no added value, it makes uselessly code more verbose.
Signed-off-by: Luca Ceresoli
Cc: Larry Finger
Cc: Greg Kroah-Hartman
---
drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 31
1 file changed, 15 insertions(+), 16 deletions(-)
diff --git a/drivers
-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
---
drivers/staging/rtl8188eu/hal/hal_intf.c | 16
drivers/staging/rtl8188eu/include/hal_intf.h | 5 -
2 files changed, 21 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/hal_intf.c
b/drivers/staging
rtw_hal_write_rfreg() is never referenced, so remove it.
It used to be the only place where the write_rfreg callback was
called, so get rid of the function pointer as well.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
---
drivers/staging/rtl8188eu/hal/hal_intf.c
rtw_hal_set_def_var() is never referenced, so remove it.
It used to be the only place where the SetHalDefVarHandler callback was
called, so get rid of the function pointer as well.
Also remove the callback itself, SetHalDefVar8188EUsb(), which was not
called anywhere else.
Signed-off-by: Luca
If CONFIG_88EU_AP_MODE is undefined, issue_asocrsp() is never referenced.
Fixes warning:
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:891:13: warning:
‘issue_asocrsp’ defined but not used [-Wunused-function]
Signed-off-by: Luca Ceresoli
Fixes: 782eddd748d9 ("staging: rtl8188eu: une
If CONFIG_88EU_AP_MODE is undefined, OnAuth() is never referenced.
Fixes warning:
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:2725:21: warning: ‘OnAuth’
defined but not used [-Wunused-function]
Signed-off-by: Luca Ceresoli
Fixes: 68345dd7bc26 ("staging: rtl8188eu: rtw_mlme_ext.c: une
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c
b/drivers/staging/rtl8188eu/core/rtw_ap.c
index 2b09972..581af88 100644
is_valid_p2p_probereq is initialized to false and never modified. Code
depending on it is dead code. Remove all of it.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 6 --
1 file changed, 6 deletions(-)
diff --git
These are internal functions. Remove their declaration in rtw_mlme_ext.h
and make them static.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c| 57 +++-
drivers/staging/rtl8188eu/include
The is_valid_p2p_probereq is never referenced in the function body.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core
These are internal functions. Remove their declaration in rtw_mlme_ext.h
and make them static.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c| 60
drivers/staging/rtl8188eu/include
The is_valid_p2p_probereq is never referenced in the function body.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Jes Sorensen
Cc: Larry Finger
---
drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers
Also remove them from .h files.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
---
drivers/staging/rtl8188eu/include/osdep_intf.h | 2 --
drivers/staging/rtl8188eu/include/recv_osdep.h | 3 ---
drivers/staging/rtl8188eu/os_dep/os_intfs.c| 15 +--
3
eu/include/osdep_service.h.
Change rtw_start_drv_threads() to return a proper 0-or-error value.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
Cc: Dan Carpenter
---
I think _SUCCESS and _FAIL should be totally eradicated and replaced with
proper error codes and my inten
The loadparam() function cannot fail, it's called only once and its return
value is ignored there.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
Cc: Florian Schilhabel
---
drivers/staging/rtl8712/os_intfs.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
x27;m sending it mostly to get review before diving in the entire job.
Luca
[0]
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-May/069295.html
Luca Ceresoli (10):
staging: rtl8712: remove useless comment
staging: rtl8712: remove unneeded forward declaration
staging: rt
"step 2" does mean much as there is no "step 1" stated anywhere...
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
Cc: Jes Sorensen
---
drivers/staging/rtl8723au/os_dep/os_intfs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/stag
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
Cc: Florian Schilhabel
---
drivers/staging/rtl8712/os_intfs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8712/os_intfs.c
b/drivers/staging/rtl8712/os_intfs.c
index fd78d22..27a875b 100644
--- a
Fixes checkpatch warnings:
WARNING: Missing a blank line after declarations
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
---
Changes since v1:
- Fix a misplaced empty line (reported by Larry Finger).
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 3 +++
1 file
Even though these are not reported by checkpatch, they are coding style issues.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu
"step 2" does mean much as there is no "step 1" stated anywhere...
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
Cc: Florian Schilhabel
---
drivers/staging/rtl8712/os_intfs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/r
The loadparam() function cannot fail, it's called only once and its return
value is ignored there.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/dr
The loadparam() function cannot fail, it's called only once and its return
value is ignored there.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
Cc: Jes Sorensen
---
drivers/staging/rtl8723au/os_dep/os_intfs.c | 3 +--
1 file changed, 1 insertion(+), 2 dele
Dear Dan,
Dan Carpenter wrote:
On Thu, May 14, 2015 at 12:08:49AM +0200, Luca Ceresoli wrote:
I think _SUCCESS and _FAIL should be totally eradicated and replaced with
proper error codes and my intent is to do it all over the codebase.
However, since that would be a massive change, I'm se
Dear Larry,
Larry Finger wrote:
On 05/13/2015 05:08 PM, Luca Ceresoli wrote:
Several functions in this driver return a boolean: _SUCCESS = 1 on
success,
_FAIL = 0 on error, defined in
drivers/staging/rtl8188eu/include/osdep_service.h.
The common practice in the Linux kernel is to return 0 on
Dear Larry,
Larry Finger wrote:
On 05/13/2015 05:08 PM, Luca Ceresoli wrote:
Fixes checkpatch warnings:
WARNING: Missing a blank line after declarations
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 3 +++
1
value also
describes the kind of error that happened, while a boolean squashes all errors
down a unique value.
Change rtw_start_drv_threads() to return a proper 0-or-error value.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
---
I think _SUCCESS and _FAIL should be
"step 2" does mean much as there is no "step 1" stated anywhere...
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
Cc: Jes Sorensen
---
drivers/staging/rtl8723au/os_dep/os_intfs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/stag
Even though these are not reported by checkpatch, they are coding style issues.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu
The loadparam() function cannot fail, it's called only once and its return
value is ignored there.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
Cc: Florian Schilhabel
---
drivers/staging/rtl8712/os_intfs.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
The loadparam() function cannot fail, it's called only once and its return
value is ignored there.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
Cc: Jes Sorensen
---
drivers/staging/rtl8723au/os_dep/os_intfs.c | 3 +--
1 file changed, 1 insertion(+), 2 dele
The loadparam() function cannot fail, it's called only once and its return
value is ignored there.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/dr
Also remove them from .h files.
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
---
drivers/staging/rtl8188eu/include/osdep_intf.h | 2 --
drivers/staging/rtl8188eu/include/recv_osdep.h | 3 ---
drivers/staging/rtl8188eu/os_dep/os_intfs.c| 15 +--
3
Fixes checkpatch warnings:
WARNING: Missing a blank line after declarations
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
Cc: Florian Schilhabel
---
drivers/staging/rtl8712/os_intfs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8712/os_intfs.c
b/drivers/staging/rtl8712/os_intfs.c
index fd78d22..27a875b 100644
--- a
"step 2" does mean much as there is no "step 1" stated anywhere...
Signed-off-by: Luca Ceresoli
Cc: Greg Kroah-Hartman
Cc: Larry Finger
Cc: Florian Schilhabel
---
drivers/staging/rtl8712/os_intfs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/r
"step 2" does mean much as there is no "step 1" stated anywhere...
Signed-off-by: Luca Ceresoli
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
b/drivers/staging/rtl8188eu/os_
Signed-off-by: Luca Ceresoli
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 20 +---
1 file changed, 13 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
b/drivers/staging/rtl8188eu/os_dep/os_intfs.c
index 9cd3a84..ba7565f 100644
--- a
This code is commented since the initial commit. Probably it is a remnant of
old code.
Signed-off-by: Luca Ceresoli
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
b/drivers
Signed-off-by: Luca Ceresoli
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
b/drivers/staging/rtl8188eu/os_dep/os_intfs.c
index e5e9235..9cd3a84 100644
--- a/drivers/staging
The comment "/* open system */" is repeated verbatim in several places where
dot11AuthAlgrthm_Open is referenced, but not where it is declared.
Move it to be only at its declaration.
This also fixes some "line over 80 characters" checkpatch warnings.
Signed-off-by: Luca Ce
Signed-off-by: Luca Ceresoli
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 38 ++---
1 file changed, 29 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
b/drivers/staging/rtl8188eu/os_dep/os_intfs.c
index 61b8572..c944b14 100644
There are identical comments near the static variable declaration, around
lines 118~120.
Signed-off-by: Luca Ceresoli
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
b/drivers
Fixes sparse warnings like:
warning: symbol '...' was not declared. Should it be static?
Signed-off-by: Luca Ceresoli
Cc: Peng Tao
Cc: Jinshan Xiong
Cc: Srikrishan Malik
Cc: hpdd-disc...@lists.01.org
Cc: de...@driverdev.osuosl.org
Cc: linux-ker...@vger.kernel.org
---
drivers/stag
Fixes sparse warnings like:
warning: symbol '...' was not declared. Should it be static?
Signed-off-by: Luca Ceresoli
Cc: Peng Tao
Cc: Jinshan Xiong
Cc: Srikrishan Malik
Cc: hpdd-disc...@lists.01.org
Cc: de...@driverdev.osuosl.org
Cc: linux-ker...@vger.kernel.org
---
drivers/stag
1 - 100 of 109 matches
Mail list logo
