Dear Larry,

Larry Finger wrote:
On 08/28/2015 03:45 PM, Luca Ceresoli wrote:
Signed-off-by: Luca Ceresoli <l...@lucaceresoli.net>
Cc: Larry Finger <larry.fin...@lwfinger.net>
Cc: Greg Kroah-Hartman <gre...@linux.com>

Empty commit messages are generally not accepted.

Meaning something like this?

  commit 96ac283d6490932ff5097259c18a4d03bdddb010
  Author: Chaehyun Lim <chaehyun....@gmail.com>
  Date:   Tue Aug 11 10:32:39 2015 +0900

      staging: wilc1000: wilc_memory.h: remove unused define

      Remove unused define macro that is never used.

      Signed-off-by: Chaehyun Lim <chaehyun....@gmail.com>
      Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>

There are several examples like this in the kernel git history.

Fine, I'll expand my commit messages accordingly.

But I don't see what added value this brings to the commit title.
I really would like to understand why this is a good practice. Can you
point me to an explanation (links are welcome)?

Thanks.

--
Luca
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to