Hello Dan.
On 2015년 09월 15일 15:54, Dan Carpenter wrote:
The > should be >= here or we read beyond the end of the array.
You are right. :)
Thanks a lot.
Johnny.
Fixes: d42ab0838d04 ('staging: wilc1000: use id value as argument')
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/wilc1
+0900, Tony Cho wrote:
From: Johnny Kim
The driver communicates with the chipset via the address of handlers
to distinguish async data frame. The SendConfigPkt function gets the
pointer address indicating the handlers as the last argument, but this
requires redundant typecasting and does not support
On 2015년 09월 04일 00:47, Greg KH wrote:
On Thu, Sep 03, 2015 at 04:00:08PM +0900, johnny.kim wrote:
Hello Greg.
On 2015년 09월 03일 10:33, Greg KH wrote:
On Thu, Aug 20, 2015 at 04:32:52PM +0900, Tony Cho wrote:
From: Johnny Kim
The driver communicates with the chipset via the address of
Hello Greg.
On 2015년 09월 03일 10:33, Greg KH wrote:
On Thu, Aug 20, 2015 at 04:32:52PM +0900, Tony Cho wrote:
From: Johnny Kim
The driver communicates with the chipset via the address of handlers
to distinguish async data frame. The SendConfigPkt function gets the
pointer address indicating
Hello Dan.
On 2015년 08월 18일 18:12, Dan Carpenter wrote:
On Tue, Aug 18, 2015 at 12:10:53PM +0900, Johnny Kim wrote:
Hello Dan.
On 2015년 08월 13일 23:49, Dan Carpenter wrote:
On Thu, Aug 13, 2015 at 01:41:23PM +0900, Tony Cho wrote:
+static u32 get_id_from_handler(tstrWILC_WFIDrv *handler
| id >= NUM_CONCURRENT_IFC)
return NULL;
return wfidrv_list[id];
}
regards,
dan carpenter
Regards.
Johnny Kim.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hello Julian.
On 2015년 08월 10일 15:47, Julian Calaby wrote:
Hi Tony and Johnny,
On Mon, Aug 10, 2015 at 3:58 PM, Tony Cho wrote:
From: Johnny Kim
The driver communicates with the chipset via the address of handlers
to distinguish async data frame. The SendConfigPkt function gets the
pointer
On 2015년 07월 10일 15:25, Julian Calaby wrote:
Hi Johnny,
On Fri, Jul 10, 2015 at 3:55 PM, Johnny Kim wrote:
Last argument of wilc_wlan_cfg_get function is actually structure's address.
This should be changed to be compatible with 64bit machine.
Because wilc_wlan_cfg_get function is mapp
On 2015년 07월 10일 15:20, Julian Calaby wrote:
Hi Johnny,
On Fri, Jul 10, 2015 at 3:55 PM, Johnny Kim wrote:
A argument of wilc_wlan_cfg_commit() is address of structure.
But because the size is restricted to 32bit, it is not correct
for 64bit machine.
So, this changes the interger value to
gu8FlushedJoinReqDrvHandler variable is be using to save structure pointer.
But because that is restricted to 32bit and has needless casting,
the varibale should be changed to pointer of same type.
Signed-off-by: Johnny Kim
---
drivers/staging/wilc1000/host_interface.c | 16
1
argument to void type pointer.
Signed-off-by: Johnny Kim
---
drivers/staging/wilc1000/coreconfigurator.c | 4 +-
drivers/staging/wilc1000/coreconfigurator.h | 2 +-
drivers/staging/wilc1000/host_interface.c | 102 ++--
3 files changed, 54 insertions(+), 54 deletions
A argument of wilc_wlan_cfg_commit() is address of structure.
But because the size is restricted to 32bit, it is not correct
for 64bit machine.
So, this changes the interger value to obvious structure pointer.
Signed-off-by: Johnny Kim
---
drivers/staging/wilc1000/wilc_wlan.c | 8
1
re is defined after wilc_wlan_oup_t.wlan_cfg_get
is defined. So, this patch changes the argument to void type pointer.
Signed-off-by: Johnny Kim
---
drivers/staging/wilc1000/coreconfigurator.c | 2 +-
drivers/staging/wilc1000/wilc_wlan.c| 2 +-
drivers/staging/wilc1000/wilc_wlan_if.h
re is defined after wilc_wlan_oup_t.wlan_cfg_set
is defined. So, this patch changes the argument to void type pointer.
Signed-off-by: Johnny Kim
---
drivers/staging/wilc1000/coreconfigurator.c | 2 +-
drivers/staging/wilc1000/linux_wlan.c | 2 +-
drivers/staging/wilc1000/wilc_wlan.c
patches related with this patch.
Best regards.
Johnny.
Johnny Kim (3):
staging: wilc1000: wilc_wlan_cfg_commit(): replace integer with
pointer
staging: wilc1000: wilc_wlan_cfg_get(): replace integer with void
pointer
staging: wilc1000: wilc_wlan_cfg_set(): replace integer with void
On 2015년 06월 11일 09:40, Greg KH wrote:
On Wed, Jun 10, 2015 at 05:06:44PM +0900, Johnny Kim wrote:
-static int wilc_wlan_cfg_commit(int type, uint32_t drvHandler)
+static int wilc_wlan_cfg_commit(int type, size_t drvHandler)
Shouldn't this just be a void *? And if so, why not the
This remove compile warnings about printk format.
Signed-off-by: Johnny Kim
---
drivers/staging/wilc1000/host_interface.c | 8
drivers/staging/wilc1000/linux_wlan.c | 2 +-
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8
3 files changed, 9 insertions
This patch is for the initialization of the local variables.
Signed-off-by: Johnny Kim
---
drivers/staging/wilc1000/linux_wlan.c | 2 +-
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging
The driver take pointer value to integer value for message packet.
So, The driver was fixed to save and load the address
on 64-bit machine.
Signed-off-by: Johnny Kim
---
drivers/staging/wilc1000/host_interface.c | 24
drivers/staging/wilc1000/wilc_wlan.c | 19
This replace the argument of the function to the independent data type
in system.
Signed-off-by: Johnny Kim
---
drivers/staging/wilc1000/coreconfigurator.c | 4 +-
drivers/staging/wilc1000/coreconfigurator.h | 2 +-
drivers/staging/wilc1000/host_interface.c | 132
, the others
will be sent soon.
Johnny.
Johnny Kim (4):
staging: wilc1000: modify data type
staging: wilc1000: add syntax for 64-bit machine
staging: wilc1000: modify printk format
staging: wilc1000: remove uninitialized warnings
drivers/staging/wilc1000/coreconfigurator.c | 4
On 2015년 06월 02일 14:20, Greg KH wrote:
On Tue, Jun 02, 2015 at 01:53:31PM +0900, Greg KH wrote:
On Mon, Jun 01, 2015 at 09:06:33PM +0200, Arnd Bergmann wrote:
Hi Greg,
Next try, I've rebased on top of your staging-testing branch
and fixed the two build errors.
While I had done my normal buil
Add myself as maintainer for atmel wilc1000
Signed-off-by: Johnny Kim
Signed-off-by: Rachel Kim
Signed-off-by: Dean Lee
Signed-off-by: Chris Park
Acked-by: Nicolas Ferre
---
Changes in v3:
- fix the permissions.
- fix the folder tree.
- forget to add the mailing-list during the previous
Add myself as maintainer for atmel wilc1000
Signed-off-by: Johnny Kim
Signed-off-by: Rachel Kim
Signed-off-by: Dean Lee
Signed-off-by: Chris Park
---
MAINTAINERS | 10 ++
1 file changed, 10 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 1b8263c..e4252b5 100644
--- a
24 matches
Mail list logo
