Hi,
How are you doing?
I have mailed you a couple of times from last week.
We provide customer leads generation and we can generate you new business
leads and increase your sales.
Please reply today so we can go over options for you.
Thanks,
Jason Williams
four to the rdma tree, thanks
Jason
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
be a good idea.
I remember using clang-modernize in the past to fix issues very
similar to this, if clang machinery can generate the warning, can't
something like clang-tidy directly generate the patch?
You can send me a patch for drivers/infiniband/* as well
Thanks,
Jason
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Tue, Jun 16, 2020 at 12:54 PM Joe Perches wrote:
>
> On Mon, 2020-06-15 at 21:57 -0400, Waiman Long wrote:
> > v4:
> > - Break out the memzero_explicit() change as suggested by Dan Carpenter
> > so that it can be backported to stable.
> > - Drop the "crypto: Remove unnecessary memzero_
Fix the following coccicheck warning:
drivers/staging/rtl8723bs/hal/hal_btcoex.c:410:59-64: WARNING:
conversion to bool not needed here
Signed-off-by: Jason Yan
---
drivers/staging/rtl8723bs/hal/hal_btcoex.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging
Now that rtw_spt_band_free() is only a direct wrapper of kfree, we can
remove it and just use kfree().
Signed-off-by: Jason Yan
---
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep
在 2020/4/28 20:28, Greg KH 写道:
On Mon, Apr 27, 2020 at 11:23:37AM +0800, Jason Yan wrote:
And also remove the NULL check before kfree() because kfree() can handle
NULL pointers correctly.
Fix the following gcc warning:
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:157:6: warning
Fix some warnings of '-Wunused-but-set-variable'.
Jason Yan (7):
staging: rtl8723bs: os_dep: remove set but not used 'uintRet'
staging: rtl8723bs: os_dep: remove set but not used 'size'
Staging: rtl8723bs: core: remove set but not used 'ptxservq'
Fix the following gcc warning:
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:2564:22: warning:
variable ‘uintRet’ set but not used [-Wunused-but-set-variable]
unsigned int uintRet = 0;
^~~
Reported-by: Hulk Robot
Signed-off-by: Jason Yan
---
drivers/staging
Fix the following gcc warning:
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:1087:33: warning: variable
‘algthm’ set but not used [-Wunused-but-set-variable]
unsigned int seq, len, status, algthm, offset;
^~
Reported-by: Hulk Robot
Signed-off-by: Jason Yan
Fix the following gcc warning:
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:1173:18: warning: variable
‘listen_interval’ set but not used [-Wunused-but-set-variable]
u16 capab_info, listen_interval;
^~~
Reported-by: Hulk Robot
Signed-off-by: Jason Yan
Fix the following gcc warning:
drivers/staging/rtl8723bs/core/rtw_mlme.c:2920:6: warning: variable
‘pframe’ set but not used [-Wunused-but-set-variable]
u8 *pframe;
^~
Reported-by: Hulk Robot
Signed-off-by: Jason Yan
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 3 +--
1 file
Fix the following gcc warning:
drivers/staging/rtl8723bs/core/rtw_sta_mgt.c:556:19: warning: variable
‘ptxservq’ set but not used [-Wunused-but-set-variable]
struct tx_servq *ptxservq;
^~~~
Reported-by: Hulk Robot
Signed-off-by: Jason Yan
---
drivers/staging/rtl8723bs
Fix the following gcc warning:
drivers/staging/rtl8723bs/core/rtw_mlme.c:1100:24: warning: variable
‘pwrpriv’ set but not used [-Wunused-but-set-variable]
struct pwrctrl_priv *pwrpriv;
^~~
Reported-by: Hulk Robot
Signed-off-by: Jason Yan
---
drivers/staging
: Hulk Robot
Signed-off-by: Jason Yan
---
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 11 ---
1 file changed, 11 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
index 1ba85a43f05a..b037868fbf22 100644
Sorry, it has already been fixed by YueHaibing. Please ignore this.
在 2020/4/26 17:43, Jason Yan 写道:
Fix the following gcc warning:
drivers/staging/rtl8723bs/hal/sdio_halinit.c:547:24: warning: variable
‘pregistrypriv’ set but not used [-Wunused-but-set-variable]
struct registry_priv
Fix the following gcc warning:
drivers/staging/rtl8723bs/hal/sdio_halinit.c:547:24: warning: variable
‘pregistrypriv’ set but not used [-Wunused-but-set-variable]
struct registry_priv *pregistrypriv;
^
Reported-by: Hulk Robot
Signed-off-by: Jason Yan
在 2020/4/20 21:07, Greg KH 写道:
On Mon, Apr 20, 2020 at 08:41:51PM +0800, Jason Yan wrote:
Fix the following coccicheck warning:
drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c:223:14-36: WARNING: Use
correct pointer type argument for sizeof
Signed-off-by: Jason Yan
---
drivers/staging
Fix the following coccicheck warning:
drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c:223:14-36: WARNING: Use
correct pointer type argument for sizeof
Signed-off-by: Jason Yan
---
v2->v3: Add this description of v1->v2.
v1->v2: Use sizeof(*p->func) instead of sizeof(struct rt2
Fix the following coccicheck warning:
drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c:223:14-36: WARNING: Use
correct pointer type argument for sizeof
Signed-off-by: Jason Yan
---
drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
在 2020/4/20 20:19, Dan Carpenter 写道:
On Mon, Apr 20, 2020 at 08:37:55PM +0800, Jason Yan wrote:
Fix the following coccicheck warning:
drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c:223:14-36: WARNING: Use
correct pointer type argument for sizeof
Signed-off-by: Jason Yan
---
drivers
Fix the following coccicheck warning:
drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c:223:14-36: WARNING: Use
correct pointer type argument for sizeof
Signed-off-by: Jason Yan
---
drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Fix the following gcc warning:
drivers/staging/rtl8723bs/hal/odm.c:10:18: warning: ‘dB_Invert_Table’
defined but not used [-Wunused-const-variable=]
static const u16 dB_Invert_Table[8][12] = {
^~~
Reported-by: Hulk Robot
Signed-off-by: Jason Yan
---
drivers
/hal_btcoex.c:15:26: warning:
‘BtProfileString’ defined but not used [-Wunused-const-variable=]
static const char *const BtProfileString[] = {
^~~
Reported-by: Hulk Robot
Signed-off-by: Jason Yan
---
drivers/staging/rtl8723bs/hal/hal_btcoex.c | 43
On 4/13/20 3:15 PM, Waiman Long wrote:
As said by Linus:
A symmetric naming is only helpful if it implies symmetries in use.
Otherwise it's actively misleading.
In "kzalloc()", the z is meaningful and an important part of what the
caller wants.
In "kzfree()", the z is actively d
Fix the following gcc warning:
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:2356:16:
warning: variable ‘local_entity_uc’ set but not used
[-Wunused-but-set-variable]
int local_uc, local_entity_uc;
^~~
Reported-by: Hulk Robot
Signed-off-by: Jason
fix race condition between
> mmget_not_zero()/get_task_mm() and core dumping")'
>
> Thanks to Jason for pointing this.
>
> Signed-off-by: Ajay Kaher
> ---
> drivers/infiniband/hw/mlx4/main.c | 4 +++-
> drivers/infiniband/hw/mlx5/main.c | 3 +++
> 2 files change
without page backing.
Gah, this addr gets fed into io_remap_pfn_range/remap_pfn_range too..
Potnuri, you should fix this..
You probably need to use dma_mmap_from_dev_coherent() in the mmap ?
Jason
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
is functionally equivalent to get_user_pages_fast so
* get_user_pages_fast should be used instead if specific gup_flags
* (e.g. FOLL_FORCE) are not required.
*/
Needs some attention as the recommendation is now nonsense.
Honestly a proper explanation of why two functions exist would be
gre
On Mon, Sep 24, 2018 at 10:18:52PM +0200, Arnd Bergmann wrote:
> On Tue, Sep 18, 2018 at 7:59 PM Jason Gunthorpe wrote:
> >
> > On Tue, Sep 18, 2018 at 10:51:08AM -0700, Darren Hart wrote:
> > > On Fri, Sep 14, 2018 at 09:57:48PM +0100, Al Viro wrote:
> > > >
_user * as appropriate.
Then it just works right always and the compiler will help address
Al's concern down the road.
Cheers,
Jason
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
atic const struct file_operations uverbs_mmap_fops = {
> .release = ib_uverbs_close,
> .llseek = no_llseek,
> .unlocked_ioctl = ib_uverbs_ioctl,
> - .compat_ioctl = ib_uverbs_ioctl,
> + .compat_ioctl = generic_compat_ioctl_ptrarg,
> };
>
> static struct ib_c
.compat_ioctl = vtpmx_fops_compat_ioctl,
> -#endif
> + .compat_ioctl = generic_compat_ioctl_ptrarg,
> .llseek = noop_llseek,
> };
For vtpm:
Reviewed-by: Jason Gunthorpe
Arnd, would you consider including a patch as part of/after this
series to make compat_ioctl
Do you have photos for cutting out,or adding clipping path?
We are here to help you for that also including retouching.
Both for product photos and portrait photos.
Yours,
Jason
___
devel mailing list
de...@linuxdriverproject.org
http
Do you have photos for cutting out,or adding clipping path?
We are here to help you for that also including retouching.
Both for product photos and portrait photos.
Yours,
Jason
___
devel mailing list
de...@linuxdriverproject.org
http
fs/Kconfig | 2 +-
> net/9p/Kconfig | 2 +-
> net/rds/Kconfig | 2 +-
> net/sunrpc/Kconfig | 2 +-
> 8 files changed, 8 insertions(+), 8 deletions(-)
Applied to for-rc, thanks
Jason
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
off-by: Arnd Bergmann
>
> Acked-by: Greg Thelen
>
> Sorry for the 9533b292a7ac problem.
> At this point the in release cycle, I think Arnd's revert is best.
>
> If there is interest, I've put a little thought into an alternative fix:
> making INFINIBAND_ADDR_T
us send you full details of the
contract bid.
Thanks
Jason Hammond
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
n/skein_block.c | 323
>
> drivers/staging/skein/skein_block.h | 323
>
> 2 files changed, 323 insertions(+), 323 deletions(-)
Acked-by: Jason Cooper
thx,
Jason.
___
devel mailing
-off-by: Jason Litzinger
---
Note this leaves in place three checkpatch warnings regarding CamelCase.
This was originally presented as an RFC PATCH:
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2017-April/105138.html
For completeness, with respect to item two at the bottom of
get it sent out tonight (tomorrow
latest) after I update my trees and do the usual build/apply/test cycle.
Thanks,
-Jason Litzinger
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Thu, Apr 27, 2017 at 05:03:45PM -0600, Logan Gunthorpe wrote:
>
>
> On 27/04/17 04:11 PM, Jason Gunthorpe wrote:
> > On Thu, Apr 27, 2017 at 03:53:37PM -0600, Logan Gunthorpe wrote:
> > Well, that is in the current form, with more users it would make sense
> > to o
On Thu, Apr 27, 2017 at 03:53:37PM -0600, Logan Gunthorpe wrote:
> On 27/04/17 02:53 PM, Jason Gunthorpe wrote:
> > blkfront is one of the drivers I looked at, and it appears to only be
> > memcpying with the bvec_data pointer, so I wonder why it does not use
> > sg_
> this could be converted to use the sg_miter interface but that's a much
> more invasive change that would require someone who knows this code and
> can properly test it. I'd be very grateful if someone actually took that on.
blkfront is one of the drivers I looked at, and it appears to only be
memcpying with the bvec_data pointer, so I wonder why it does not use
sg_copy_X_buffer instead..
Jason
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
metimes a little bit more
convoluted..
Switching all the trivial cases to use copy might bring more clarity
as to what is actually required for the remaining few users? If there
are only a few then it may no longer matter if the API is not idyllic.
Jason
_
On Tue, Apr 25, 2017 at 10:54:16PM -0600, Jason Litzinger wrote:
> > + strStaParams.ht_capa = *params->ht_capa;
> Doh, that's completely wrong. I had a few iterations of this and sent
No, it wasn't. The PATCH RFC I sent initally is correct. Apologies,
d, sorry for the spam.
-Jason
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
field value copy. Is there any reason not to embed a const
pointer?
Regards,
Jason Litzinger
Signed-off-by: Jason Litzinger
---
Note this leaves in place three checkpatch warnings regarding CamelCase.
drivers/staging/wilc1000/host_interface.c | 20 +++-
drivers/st
tc….
We can share the references of our work on demand.
3 Simple steps to get started:
1. Respond to this Email
2. We will provide an Action Plan and Cost
3. Get your Mobile App Development started
We are waiting for your response.
Best Regards,
Jaso
On Mon, Jan 02, 2017 at 02:54:37PM +0100, Johan Hovold wrote:
> On Tue, Dec 20, 2016 at 02:49:27PM -0600, Jason Hrycay wrote:
> > Add sanity checks for cport_quiesce and cport_clear before invoking the
> > callbacks as these function pointers are not required during the
Add sanity checks for cport_quiesce and cport_clear before invoking the
callbacks as these function pointers are not required during the host
device registration. This follows the logic implemented elsewhere for
various other function pointers.
Signed-off-by: Jason Hrycay
---
drivers/staging
r
discussion of this in the mailing list, but I may have missed it in my
search.
Thanks,
Jason
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Fix checkpatch warnings regarding the use of symbolic permissions.
Where the MOST_CHANNEL_ATTR macro is used, convert to octal
permissions over symbolic.
Where _ATTR is used directly, replace with _ATTR_RW/_ATTR_WO and
update the show/store function names appropriately.
Signed-off-by: Jason
On Thu, Nov 24, 2016 at 03:10:29PM -0700, Jason Litzinger wrote:
> Fix checkpatch warnings regarding the use of symbolic permissions.
>
> Where the MOST_CHANNEL_ATTR macro is used, convert to octal permissions
> over symbolic.
>
> Where _ATTR is used directly, replace with _AT
Fix checkpatch warnings regarding the use of symbolic permissions.
Where the MOST_CHANNEL_ATTR macro is used, convert to octal permissions
over symbolic.
Where _ATTR is used directly, replace with _ATTR_RW/_ATTR_WO and
update the show/store function names appropriately.
Signed-off-by: Jason
bmitting a new version. If no new version is necessary, the maintainer will
add it.
Also, please keep the Cc list from previous versions.
Thx,
Jason.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Hi Walt,
Please ignore our side conversation,
On Sat, Nov 12, 2016 at 03:02:53PM -0500, Walt Feasel wrote:
> Made suggested modifications from checkpatch in reference
> to CHECK: Please don't use multiple blank lines
>
> Signed-off-by: Walt Feasel
Acked-by: Jason Coo
Hi Dan,
On Mon, Nov 14, 2016 at 01:34:15PM +0300, Dan Carpenter wrote:
> Please just delete the blank lines.
Sure, if that's what you guys prefer.
> You aren't that special like a snow flake.
Someone put his grumpy pants on backwards, didn&#x
-
The double lines are deliberate to show a logical separation between the
blocks of code. Ideally, the second blank line would be a comment
describing the following block. However, I'm not smart enough yet to
add correct comments. So, the blank lines remain. :-/
thx,
Jason.
s for details and to see if there is a distributorship
available in your country.
Please include your name and country of residence.
Jason Allen
Contact: aben...@sina.com
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverprojec
arble, granite, concrete,
terrazzo, etc.
Please contact us for details and to see if there is a distributorship
available in your country.
INCLUDE YOUR NAME, COUNTRY and E-MAIL ADDRESS.
$2,000 USD - $4,000 USD INVENTORY INVESTMENT REQUIRED
Jason North
Contact: cesl...@sin
rwise, we'll be waiting a bit.
:-/
I barely have time to keep up with my other maintainer duties, which are
hobby/freetime as well.
There's occasionally been interest in helping out, but it always seems
to peter out prior to the actual move.
thx,
Jason.
__
, I think you've got the whole submission process down
now so you can go ahead and do all the macros.
Just let us know.
thx,
Jason.
> - add / pass test vectors
> - module support
>
> diff --git a/drivers/staging/skein/skein_block.c
> b/drivers/staging/skein/skein_block.c
Oh hell. :)
Go ahead and try to configure git send-mail, or configure Thunderbird
according to Documentation/email-clients.txt. If you want, send it to
me off list first to confirm it's not getting mangled like below.
I think you just won the obfuscated C contest...
thx,
Jason.
On Fri
save and exit
$ git show
confirm one commit has everything
$ git format-patch ...
$ $EDITOR 0001-*.patch
$ git send-email ...
If it gets all fouled up, don't panic. you can checkout 'my_changes'
and it's in it's original state. :-)
hth,
Jason.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Tue, Dec 01, 2015 at 03:38:13PM -0500, Jubin John wrote:
> From: Kaike Wan
>
> This patch fixes a few incorrect header file comments in qp.h
FWIW, within drivers/infiniband we've been moving these comments
to the implementation, not the function pro
Tiles, marble, granite, concrete,
terrazzo, etc.
Please contact us for details and to see if there is a distributorship
available in your country.
Best Regards,
Jason White
Email: vio...@tom.com
INCLUDE YOUR NAME, COUNTRY and E-MAIL ADDRESS.
$5,000 USD - $20,000 USD INVENTORY INVESTMENT REQ
ging/skein/skein_api.h | 48
> +++
> 1 file changed, 24 insertions(+), 24 deletions(-)
Acked-by: Jason Cooper
> diff --git a/drivers/staging/skein/skein_api.h
> b/drivers/staging/skein/skein_api.h
> index 7da8b38..4cf7003 100644
> --- a/driv
Ozwpan is completely unmaintained and potentially a security problem. As
this is a staging driver, it should be removed, since it has been
abandoned. Marking it as orphaned is the first step here.
Signed-off-by: Jason A. Donenfeld
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1
On Mon, Aug 10, 2015 at 3:31 PM, Jason A. Donenfeld wrote:
> Meanwhile Dan
> Carpenter has posted a patch for a security vulnerability in ozwpan
> that hasn't been reviewed or merged.
Sorry, I see that you did in fact pick up this patch, so I retract
that statement.
Nonetheless,
intained driver from the tree. It simply didn't pass the "staging
test".
Regards,
Jason
On Tue, Jun 2, 2015 at 1:35 PM, Jason A. Donenfeld wrote:
> On Tue, Jun 2, 2015 at 3:35 AM, Greg Kroah-Hartman
> wrote:
>> I don't know, but I'm a bit loath to delete
tached?
I'd think of partial reconfiguration as another nested FPGA. The
resets and so forth could be attached to soft controllers in the
unswappable part of the FPGA.
DT nodes have to surround it in some way...
Jason
___
ying you can't use request firmware at all
from a compiled in driver? I don't know much about that flow, sorry.
Having that work would mean the system can have a reasonable in-tree
use case without requiring the out of tree dt overlay stuff.
Jason
__
negotiates things like link width dynamically, and for AXI, DMA
doesn't flow through the same AXI port as the control registers
anyhow.
DT is a very poor fit for a modeling a modern AXI interconnect system,
so there is often some irrelevant lossage..
Jason
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
part of my boot time DT will it just work?
Jason
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
, granite, concrete,
etc.
Typical Applications - Restaurant Kitchen Floors, Hotels, Hospitals,
Office Buildings, etc.
Some of our satisfied customers include: McDonald's, Kroger, Holiday Inn,
Miami Children's Hospital, Pfizer, etc.
Please contact us for additional information.
Jason
E
On Tue, Jun 2, 2015 at 3:35 AM, Greg Kroah-Hartman
wrote:
> I don't know, but I'm a bit loath to delete the driver from the tree as
> then people will just continue to use the version with all of the bugs.
Yea, I understand that. Though, I'm pretty sure that most users of
ozwpan use old forks tie
ed, May 13, 2015 at 8:33 PM, Jason A. Donenfeld wrote:
> On a slightly related note, there are several other vulnerabilities in
> this driver that are worth looking into. When ozwpan receives a packet,
> it casts the packet into a variety of different structs, based on the
> va
On Fri, May 29, 2015 at 2:36 PM, Frans Klaver wrote:
>
> I would say that it is because part of the expression has been placed
> inside parentheses:
>
> a - b + 1 == a - (b - 1)
>
> Guess it makes the decision logic slightly more readable.
Yes, exactly this. It's so that the bounding check co
On Fri, May 29, 2015 at 2:41 PM, Dan Carpenter wrote:
> Acked-by: Dan Carpenter
Acked for the rest of the set too?
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
_address = {
.sll_ifindex = interface_index,
.sll_halen = ETH_ALEN,
.sll_addr = { dest_mac[0], dest_mac[1], dest_mac[2],
dest_mac[3], dest_mac[4], dest_mac[5] }
};
if (sendto(sockfd, &packet, sizeof(packet), 0, (struct sockaddr
*)
if (sendto(sockfd, &connect_packet, sizeof(connect_packet), 0, (struct
sockaddr *)&socket_address, sizeof(socket_address)) < 0) {
perror("sendto");
return 1;
}
usleep(30);
if (sendto(sockfd, &pwn_pack
_mac[0], dest_mac[1], dest_mac[2],
dest_mac[3], dest_mac[4], dest_mac[5] }
};
if (sendto(sockfd, &packet, sizeof(packet), 0, (struct sockaddr
*)&socket_address, sizeof(socket_address)) < 0) {
perror("sendto");
return 1;
}
retu
ction, adding checks to ensure all reads and casts are
within the bounds of the socket buffer.
Jason A. Donenfeld (4):
ozwpan: Use proper check to prevent heap overflow
ozwpan: Use unsigned ints to prevent heap overflow
ozwpan: divide-by-zero leading to panic
ozwpan: unchecked signed subt
o(sockfd, &connect_packet, sizeof(connect_packet), 0, (struct
sockaddr *)&socket_address, sizeof(socket_address)) < 0) {
perror("sendto");
return 1;
}
usleep(30);
if (sendto(sockfd, &pwn_packet, sizeof(pwn_pa
On Thu, May 28, 2015 at 1:04 PM, Dan Carpenter wrote:
> It's really not simpler to understand though.
Greg - do you want me to resubmit a v3 for this, or does it not really
matter and we can address this in another series? Personally, I'm
erring on the side of wanting to get *something* merged so
On Tue, May 26, 2015 at 3:56 PM, Dan Carpenter wrote:
>> elt->length is a u8, so the upper bound is 255.
>
> Yes. I know that, but is 255 correct?
Eventually body->data is passed to oz_hcd_get_desc_cnf along with
data_len. In there, body->data (now called desc) is memcpy'd into a
URB transfer bu
On Tue, May 26, 2015 at 4:06 PM, Dan Carpenter wrote:
> You sure do like wrapping to a high value and testing the result for
> wrapping instead of validating before doing the subtraction...
I do indeed. It seems like asking "did it overflow?" is more
straight-forward and easier to read than tryin
On Tue, May 26, 2015 at 3:32 PM, Dan Carpenter wrote:
> On Tue, May 26, 2015 at 02:17:46PM +0200, Jason A. Donenfeld wrote:
>> + data_len = elt->length -
>> sizeof(struct oz_get_desc_rsp) + 1;
>
> This was in
_mac[0], dest_mac[1], dest_mac[2],
dest_mac[3], dest_mac[4], dest_mac[5] }
};
if (sendto(sockfd, &packet, sizeof(packet), 0, (struct sockaddr
*)&socket_address, sizeof(socket_address)) < 0) {
perror("sendto");
return 1;
}
rx function, adding checks to ensure all reads and casts are
within the bounds of the socket buffer.
Jason A. Donenfeld (4):
ozwpan: Use proper check to prevent heap overflow
ozwpan: Use unsigned ints to prevent heap overflow
ozwpan: divide-by-zero leading to panic
ozwpan: unchecked signed subt
if (sendto(sockfd, &connect_packet, sizeof(connect_packet), 0, (struct
sockaddr *)&socket_address, sizeof(socket_address)) < 0) {
perror("sendto");
return 1;
}
usleep(30);
if (sendto(sockfd, &pwn_pack
_address = {
.sll_ifindex = interface_index,
.sll_halen = ETH_ALEN,
.sll_addr = { dest_mac[0], dest_mac[1], dest_mac[2],
dest_mac[3], dest_mac[4], dest_mac[5] }
};
if (sendto(sockfd, &packet, sizeof(packet), 0, (struct sockaddr
*)
o(sockfd, &connect_packet, sizeof(connect_packet), 0, (struct
sockaddr *)&socket_address, sizeof(socket_address)) < 0) {
perror("sendto");
return 1;
}
usleep(30);
if (sendto(sockfd, &pwn_packet, sizeof(pwn_packet), 0
On May 15, 2015 4:10 PM, "David Laight" wrote:
> Why not just check the length. eg:
> unsigned int data_len = elt->length;
> if (data_len < sizeof(struct oz_get_desc_rsp) + 1)
> break;
Sure.
> >
_address = {
.sll_ifindex = interface_index,
.sll_halen = ETH_ALEN,
.sll_addr = { dest_mac[0], dest_mac[1], dest_mac[2],
dest_mac[3], dest_mac[4], dest_mac[5] }
};
if (sendto(sockfd, &packet, sizeof(packet), 0, (struct sockaddr
*)
in the bounds of the socket buffer.
Jason A. Donenfeld (4):
ozwpan: Use proper check to prevent heap overflow
ozwpan: Use unsigned ints to prevent heap overflow
ozwpan: divide-by-zero leading to panic
ozwpan: unchecked signed subtraction leads to DoS
drivers/staging/ozwpan/ozhcd.c |
if (sendto(sockfd, &connect_packet, sizeof(connect_packet), 0, (struct
sockaddr *)&socket_address, sizeof(socket_address)) < 0) {
perror("sendto");
return 1;
}
usleep(30);
if (sendto(sockfd, &pwn_pack
o(sockfd, &connect_packet, sizeof(connect_packet), 0, (struct
sockaddr *)&socket_address, sizeof(socket_address)) < 0) {
perror("sendto");
return 1;
}
usleep(30);
if (sendto(sockfd, &pwn_packet, sizeof(pwn_packet), 0
_mac[0], dest_mac[1], dest_mac[2],
dest_mac[3], dest_mac[4], dest_mac[5] }
};
if (sendto(sockfd, &packet, sizeof(packet), 0, (struct sockaddr
*)&socket_address, sizeof(socket_address)) < 0) {
perror("sendto");
return 1;
}
1 - 100 of 247 matches
Mail list logo
