[PATCH] staging: rtl8188eu: Fix build error when CFG80211 is not selected

The kbuild test robot reports the following build error for i386-randconfig-c0-09230740: >> ERROR: "ieee80211_hdrlen" [drivers/staging/rtl8188eu/r8188eu.ko] undefined! Add a dependency on CFG80211 to fix it. Signed-off-by: Jakub Sitnicki --- Same issue has also been reported

[PATCH] Monitor interface for rtl8188eu

ore: 43.0 Mbits/sec after: 41.6 Mbits/sec [1] https://lkml.kernel.org/g/1441383439-27007-1-git-send-email-jsitni...@gmail.com [2] https://github.com/lwfinger/rtl8188eu/issues/73#issuecomment-138588729 Jakub Sitnicki (1): staging: rtl8188eu: Introduce monitor interface for IEEE 802.11 frames

[PATCH] staging: rtl8188eu: Introduce monitor interface for IEEE 802.11 frames

show up as a monX network device, which can be used by the userspace programs for monitoring network traffic. It is intended as an exploratory/debugging tool for rtl8188eu driver. Signed-off-by: Jakub Sitnicki --- drivers/staging/rtl8188eu/Makefile | 1 + drivers/staging/rtl8188eu

[PATCH v2 0/4] staging: rtl8188eu: clean up duplicated WLAN_* constants

-email-jsitni...@gmail.com Jakub Sitnicki (4): staging: rtl8188eu: don't duplicate ieee80211 WLAN_EID_* constants staging: rtl8188eu: wrap a long if condition and remove extra parenthesis staging: rtl8188eu: don't duplicate ieee80211 WLAN_AUTH_* constants staging: rtl8188eu: do

[PATCH v2 1/4] staging: rtl8188eu: don't duplicate ieee80211 WLAN_EID_* constants

linux/ieee80211.h already defines constants for information element IDs. Resolve discrepancies in naming and remove the duplicated definitions. Signed-off-by: Jakub Sitnicki --- drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 2 +- drivers/staging/rtl8188eu/include/ieee80211.h | 38

[PATCH v2 2/4] staging: rtl8188eu: wrap a long if condition and remove extra parenthesis

Signed-off-by: Jakub Sitnicki --- drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c index 554c04d..844ed6f 100644 --- a/drivers

[PATCH v2 4/4] staging: rtl8188eu: don't duplicate ieee80211 WLAN_HT_CAP_SM_PS_* constants

linux/ieee80211.h already defines constants for spatial multiplexing power save modes. Remove the duplicated definitions. Signed-off-by: Jakub Sitnicki --- drivers/staging/rtl8188eu/include/wifi.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/include

[PATCH v2 3/4] staging: rtl8188eu: don't duplicate ieee80211 WLAN_AUTH_* constants

linux/ieee80211.h already defines constants for authentication algorithms. Remove the duplicated definitions. Signed-off-by: Jakub Sitnicki --- drivers/staging/rtl8188eu/include/ieee80211.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/ieee80211.h

Re: [PATCH RESEND] staging: rtl8188eu: don't duplicate ieee80211 WLAN_EID_* constants

On Sat, Jul 25, 2015 at 04:30 PM CEST, Dan Carpenter wrote: > On Sat, Jul 25, 2015 at 04:05:52PM +0200, Jakub Sitnicki wrote: >> On Fri, Jul 24, 2015 at 10:39 PM CEST, Greg Kroah-Hartman >> wrote: >> > On Fri, Jul 24, 2015 at 05:12:38PM +0200, Jakub Sitnicki wrote:

Re: [PATCH RESEND] staging: rtl8188eu: don't duplicate ieee80211 WLAN_EID_* constants

On Fri, Jul 24, 2015 at 10:39 PM CEST, Greg Kroah-Hartman wrote: > On Fri, Jul 24, 2015 at 05:12:38PM +0200, Jakub Sitnicki wrote: >> linux/ieee80211.h already defines constants for information element IDs. >> Include it where needed, resolve discrepancies in naming, and remove th

[PATCH RESEND] staging: rtl8188eu: don't duplicate ieee80211 WLAN_EID_* constants

operators. Signed-off-by: Jakub Sitnicki --- drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 4 ++- drivers/staging/rtl8188eu/include/ieee80211.h | 38 -- drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 3 +- 3 files changed, 5 insertions(+), 40 deletions(-) diff

[PATCH RESEND] staging: rtl8188eu: kill unused hal_data_8188e::fw_ractrl flag

Flag is never set. Remove it and the code that is dead because of it. Signed-off-by: Jakub Sitnicki --- drivers/staging/rtl8188eu/hal/odm.c | 11 -- drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c | 21 -- drivers/staging/rtl8188eu/hal/usb_halinit.c

Re: [PATCH] staging: rtl8188eu: don't duplicate ieee80211 WLAN_EID_* constants

On Wed, Jun 24, 2015 at 07:23 AM CEST, Jakub Sitnicki wrote: > linux/ieee80211.h already defines constants for information element IDs. > Include it where needed, resolve discrepancies in naming, and remove the > duplicated definitions. > > While at it, wrap a line that was too

Re: [PATCH] staging: rtl8188eu: kill unused hal_data_8188e::fw_ractrl flag

On Thu, Jun 18, 2015 at 08:31 AM CEST, Jakub Sitnicki wrote: > Flag is never set. Remove it and the code that is dead because of it. > > Signed-off-by: Jakub Sitnicki > --- Looks like this patch got lost in the noise. It still applies & builds

Re: [PATCH 5/6] staging: rtl8188eu: stop using DBG_88E

On Sat, Jul 18, 2015 at 06:46 AM CEST, Sudip Mukherjee wrote: > On Fri, Jul 17, 2015 at 05:33:55PM +0200, Jakub Sitnicki wrote: >> On Thu, Jul 16, 2015 at 01:28 PM CEST, Sudip Mukherjee >> wrote: >> > Stop using DBG_88E which is a custom macro for printing debuggin

Re: [PATCH 5/6] staging: rtl8188eu: stop using DBG_88E

On Thu, Jul 16, 2015 at 01:28 PM CEST, Sudip Mukherjee wrote: > Stop using DBG_88E which is a custom macro for printing debugging > messages. Instead start using pr_debug and in the process define > pr_fmt. In the end, don't we want to use netdev_dbg() everywhere where we work with a struct net_

Re: [PATCH] staging: rtl8188eu: core: find and remove code valid only for 5 HGz.

On Thu, Jul 16, 2015 at 04:04 AM CEST, Sreenath Madasu wrote: > This one of the TODO tasks for staging rtl8188eu driver. I have removed > the code referring to channel > 14 for rtw_ap.c, rtw_ieee80211.c and > rtw_mlme.c files. Please review. > > Signed-off-by: Sreenath Madasu I would consider r

Re: [PATCH v2 04/23] staging: rtl8192e: Remove unused enums

On Tue, Jul 14, 2015 at 10:04 PM CEST, Mateusz Kulikowski wrote: > Remove ack_policy enum and some unused RTL_DEBUG enums. > > Signed-off-by: Mateusz Kulikowski > --- [snip] > diff --git a/drivers/staging/rtl8192e/rtllib_debug.h > b/drivers/staging/rtl8192e/rtllib_debug.h > index 42e88d6..2f4

[PATCH 5/5] staging: rtl8188eu: fold rtl8188e_read_chip_version() into rtl8188e_SetHalODMVar()

Both rtl8188e_read_chip_version() and ReadChipVersion8188E() are used only in one place. Make ReadChipVersion8188E() a void function and eliminate its wrapper - rtl8188e_read_chip_version(). Signed-off-by: Jakub Sitnicki --- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 11 ++- 1

[PATCH 1/5] staging: rtl8188eu: remove RegulatorMode from struct hal_data_8188e

This field is not used anywhere. Also, kill the rt_regulator_mode enum which exists just for this field. Signed-off-by: Jakub Sitnicki --- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 3 --- drivers/staging/rtl8188eu/include/rtl8188e_hal.h | 7 --- 2 files changed, 10 deletions

[PATCH 2/5] staging: rtl8188eu: remove ICtype from struct HAL_VERSION

IC type on RTL8188EU is always 8188E. Remove it and all the macros that check it. Signed-off-by: Jakub Sitnicki --- drivers/staging/rtl8188eu/hal/hal_com.c | 13 + drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 1 - drivers/staging/rtl8188eu/hal/usb_halinit.c | 2

[PATCH 3/5] staging: rtl8188eu: remove RFtype from struct HAL_VERSION

RFtype in struct HAL_VERSION duplicates rf_type in struct hal_data_8188e, and does not change. Remove it and the macros that test it. Signed-off-by: Jakub Sitnicki --- drivers/staging/rtl8188eu/hal/hal_com.c | 12 +--- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 15

[PATCH 0/5] staging: rtl8188eu: Clean up rtl8188e_read_chip_version()

This series of clean-up patches is a result of a review of rtl8188e_read_chip_version(). The motivation for getting it in shape is that this function could serve as read_chip_version function callback in struct rtl_hal_ops, if this driver gets converted to use rtl_usb (rtlwifi). Jakub Sitnicki

[PATCH 4/5] staging: rtl8188eu: remove ROMVer from struct HAL_VERSION

ROM version on RTL8188EU is always 0. Signed-off-by: Jakub Sitnicki --- drivers/staging/rtl8188eu/hal/hal_com.c | 2 +- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 2 -- drivers/staging/rtl8188eu/include/HalVerDef.h | 2 -- 3 files changed, 1 insertion(+), 5 deletions

[PATCH] staging: rtl8188eu: don't duplicate ieee80211 WLAN_CAPABILITY_* constants

linux/ieee80211.h already defines constants for capability bits. Include it where needed, resolve discrepancies in naming, and remove the duplicated definitions. Also, make use of WLAN_CAPABILITY_IS_STA_BSS() macro to check if neither ESS nor IBSS capability bits are set. Signed-off-by: Jakub

[PATCH] staging: rtl8188eu: don't duplicate ieee80211 WLAN_EID_* constants

operators. Signed-off-by: Jakub Sitnicki --- This patch depends on commit 04fbf979b39b ("rtl8188eu: don't duplicate ieee80211 constants for status/reason") in staging-next branch. drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 4 ++- drivers/staging/rtl8188eu/include/ie

Re: [PATCH] staging: rtl8188eu: kill unused hal_data_8188e::fw_ractrl flag

On Thu, Jun 18, 2015 at 10:30 AM CEST, Sudip Mukherjee wrote: > On Thu, Jun 18, 2015 at 08:31:59AM +0200, Jakub Sitnicki wrote: >> Flag is never set. Remove it and the code that is dead because of it. >> >> Signed-off-by: Jakub Sitnicki >> --- > >> >&

[PATCH] staging: rtl8188eu: kill unused hal_data_8188e::fw_ractrl flag

Flag is never set. Remove it and the code that is dead because of it. Signed-off-by: Jakub Sitnicki --- drivers/staging/rtl8188eu/hal/odm.c | 11 -- drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c | 21 -- drivers/staging/rtl8188eu/hal/usb_halinit.c

[PATCH] staging: rtl8188eu: kill unused INCLUDE_MULTI_FUNC_* macros

Also, remove rt_multi_func enum used exclusively by the killed macros. Signed-off-by: Jakub Sitnicki --- drivers/staging/rtl8188eu/include/rtl8188e_hal.h | 13 - 1 file changed, 13 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/rtl8188e_hal.h b/drivers/staging

[PATCH] staging: rtl8188eu: Kill dead calls to kill_pid()

There is no interface to register PIDs of processes the driver should send a signal to. Remove it. Signed-off-by: Jakub Sitnicki --- drivers/staging/rtl8188eu/include/drv_types.h | 1 - drivers/staging/rtl8188eu/include/osdep_service.h | 2 -- drivers/staging/rtl8188eu/include

[PATCH] staging: rtl8188eu: Remove redundant CONFIG_88EU_AP_MODE tests

ODE=n: 94c84035d59285408b866a57b442276d r8188eu.o.before 94c84035d59285408b866a57b442276d r8188eu.o.after Signed-off-by: Jakub Sitnicki --- Patch generated with more context to hopefully make the review easier. drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 14 +- drivers/staging/rtl8188eu