[PATCH 1/6] staging: dpaa2-ethsw: verify the nofifier block

2020-07-21 Thread Ioana Ciornei
just the one intended to). Also, move the function higher in the source file because it will be used in later patches from multiple places. Signed-off-by: Ioana Ciornei --- drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 31 - 1 file changed, 20 insertions(+), 11 deletions(-) diff

[PATCH 2/6] staging: dpaa2-ethsw: don't allow interfaces from different DPSWs to be bridged

2020-07-21 Thread Ioana Ciornei
Error out when the user tries to bridge two switch interfaces that are from different DPSW instances. This is not supported by the hardware and we should reflect this into what the user is aware of. Signed-off-by: Ioana Ciornei --- drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 15 +++ 1

[PATCH 0/6] staging: dpaa2-ethsw: various fixes

2020-07-21 Thread Ioana Ciornei
this. I know this driver should be moved along from staging but we still have the Rx/Tx functionality on switch ports and some general cleanup that we are working towards. This is tackling the second part, no new feature added here. Ioana Ciornei (6): staging: dpaa2-ethsw: verify the nofifier

[PATCH 3/6] staging: dpaa2-ethsw: setup the STP state for all installed VLANs

2020-07-21 Thread Ioana Ciornei
Setup the STP state for all VLANs installed on the port. This is also avoiding the error situation when the DEFAULT_VLAN_ID is not installed on the port (thus the firmware complains that it cannot setup the required STP state). Signed-off-by: Ioana Ciornei --- drivers/staging/fsl-dpaa2/ethsw

[PATCH 6/6] staging: dpaa2-ethsw: check if there is space for a new VLAN

2020-07-21 Thread Ioana Ciornei
] br_switchdev_port_vlan_add+0x50/0x78 [ 6503.657640] __vlan_add+0x2dc/0x758 [ 6503.657642] nbp_vlan_add+0xc0/0x180 [ 6503.657644] br_vlan_info.isra.0+0x68/0x128 [ 6503.657646] br_process_vlan_info+0x224/0x2f8 [ 6503.657647] br_afspec+0x158/0x188 [ 6503.657649] br_setlink+0x1a4/0x290 Signed-off-by: Ioana

[PATCH 4/6] staging: dpaa2-ethsw: destroy workqueue after deregistering the notifiers

2020-07-21 Thread Ioana Ciornei
(since the workqueue did not run). Signed-off-by: Ioana Ciornei --- drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c index 83e6bd4a803b..9114437645a8

[PATCH 5/6] staging: dpaa2-ethsw: read the port state from firmware

2020-07-21 Thread Ioana Ciornei
Rely on the port state seen by the firmware since it will also be the one erroring out when trying to setup anything major when the port is up. Signed-off-by: Ioana Ciornei --- drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 21 - 1 file changed, 20 insertions(+), 1 deletion

RE: [PATCH 0/6] staging: dpaa2-ethsw: cleanup of link state and MAC addresses

2020-07-15 Thread Ioana Ciornei
> Subject: Re: [PATCH 0/6] staging: dpaa2-ethsw: cleanup of link state and MAC > addresses > > On Tue, Jul 14, 2020 at 04:34:25PM +0300, Ioana Ciornei wrote: > > This patch set is cleaning up the link state handling of the switch > > ports in patches 1-4. The last two pa

[PATCH 5/6] staging: dpaa2-ethsw: store version information of the DPSW object

2020-07-14 Thread Ioana Ciornei
Store the major and minor versions of the DPSW object in the ethsw structure. This will be used in a subsequent patch to make sure some commands are only called on the appropriate version of object. Signed-off-by: Ioana Ciornei --- drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 16

[PATCH 1/6] staging: dpaa2-ethsw: fix reported link state

2020-07-14 Thread Ioana Ciornei
On the .ndo_open() callback set netif_carrier_off() until the link state interrupt is received so that the LOWER_UP flag does not show up incorrectly in the output of 'ip link show'. Signed-off-by: Ioana Ciornei --- drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 7 +++ 1 file

[PATCH 0/6] staging: dpaa2-ethsw: cleanup of link state and MAC addresses

2020-07-14 Thread Ioana Ciornei
This patch set is cleaning up the link state handling of the switch ports in patches 1-4. The last two patches are setting up the MAC addresses of the switch ports automatically so that the user is not forced to manually add them before adding them to a bridge. Ioana Ciornei (6): staging: dpaa2

[PATCH 2/6] staging: dpaa2-ethsw: ignore state interrupts when the interface is not running

2020-07-14 Thread Ioana Ciornei
Link state interrupts will be transmitted to the DPSW object even though the user has not yet issued a 'ifconfig up' on a switch interface. Don't act on those interrupts since there are of no interrest. Signed-off-by: Ioana Ciornei --- drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 6

[PATCH 4/6] staging: dpaa2-ethsw: disable switch ports are probe time

2020-07-14 Thread Ioana Ciornei
unter this issue. Signed-off-by: Ioana Ciornei --- drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c index a1917842536e..f283ce195c1e 100644 --- a/drivers/staging/fsl-d

[PATCH 6/6] staging: dpaa2-ethsw: setup MAC address of switch netdevices

2020-07-14 Thread Ioana Ciornei
dpsw_if_get_port_mac_addr() will return all zeroes, generate a random MAC address and use that. This new functionality is dependent on a firmware call which is available only on newer versions, so depending on the running DPSW object version skip this step. Signed-off-by: Ioana Ciornei --- drivers/staging

[PATCH 3/6] staging: dpaa2-ethsw: use netif_running when checking for port up

2020-07-14 Thread Ioana Ciornei
interface even though the link up has not come out yet. Signed-off-by: Ioana Ciornei --- drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c index

RE: [PATCH net] staging: fsl-dpaa2: ethsw: Add missing netdevice check

2019-02-25 Thread Ioana Ciornei
> Subject: Re: [PATCH net] staging: fsl-dpaa2: ethsw: Add missing netdevice > check > > Le 2/23/19 à 12:45 AM, Ioana Ciornei a écrit : > > > >> Subject: [PATCH net] staging: fsl-dpaa2: ethsw: Add missing netdevice > >> check > >> > >>

RE: [PATCH net] staging: fsl-dpaa2: ethsw: Add missing netdevice check

2019-02-23 Thread Ioana Ciornei
> Subject: [PATCH net] staging: fsl-dpaa2: ethsw: Add missing netdevice check > > port_switchdev_event() does not check that the target network device is > actually backed by the ethsw driver, this could be problematic in a stacked > environment case. > Just FYI, I sent a patch set containing

[PATCH] bus: fsl-mc: explicitly define the fsl_mc_command endianness

2018-10-02 Thread Ioana Ciornei
Both the header and the command parameters of the fsl_mc_command are 64-bit little-endian words. Use the appropriate type to explicitly specify their endianness. Signed-off-by: Ioana Ciornei --- include/linux/fsl/mc.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff

[PATCH 1/2] staging: fsl-dpaa2/eth: convert documentation to .rst format

2018-07-31 Thread Ioana Ciornei
Convert the DPAA2 Ethernet driver documentation to .rst format and rename the file accordingly. Also add a SPDX tag to the new rst file. Signed-off-by: Ioana Ciornei --- .../ethernet/{README => ethernet-driver.rst} | 39 +++--- 1 file changed, 19 insertions(+),

[PATCH 2/2] staging: fsl-dpaa2/eth: add SPDX license identifiers

2018-07-31 Thread Ioana Ciornei
The DPAA2 Ethernet driver files use a GPL-2.0+ OR BSD-3-Clause license. Add SPDX tags and delete the full license text, keeping the existing licenses for each file. Add a GPL-2.0 tag for the Makefile. Signed-off-by: Ioana Ciornei --- drivers/staging/fsl-dpaa2/ethernet/Makefile| 1

[PATCH v2 1/2] staging: fsl-dpaa2/eth: document nested structs as per kernel-doc

2018-07-27 Thread Ioana Ciornei
Document nested structs per kernel-doc requirements by moving all comments before the actual struct. Signed-off-by: Ioana Ciornei --- Changes in v2: - remove comments of non-existent fields drivers/staging/fsl-dpaa2/ethernet/dpkg.h | 70 +++- drivers/staging/fsl-dpaa2/ethernet

[PATCH v2 2/2] staging: fsl-dpaa2/ethsw: document nested structs as per kernel-doc

2018-07-27 Thread Ioana Ciornei
Document nested structs per kernel-doc requirements by moving all comments before the actual struct. Signed-off-by: Ioana Ciornei --- Changes in v2: - none drivers/staging/fsl-dpaa2/ethsw/dpsw.h | 27 --- 1 file changed, 12 insertions(+), 15 deletions(-) diff --git a

[PATCH v2 0/2] staging: fsl-dpaa2: document nested structs as per kernel-doc

2018-07-27 Thread Ioana Ciornei
Document nested structs per kernel-doc requirements by moving all comments before the actual struct. Changes in v2: - remove comments of non-existent fields Ioana Ciornei (2): staging: fsl-dpaa2/eth: document nested structs as per kernel-doc staging: fsl-dpaa2/ethsw: document nested structs

[PATCH 1/2] staging: fsl-dpaa2/eth: document nested structs as per kernel-doc

2018-07-27 Thread Ioana Ciornei
Document nested structs per kernel-doc requirements by moving all comments before the actual struct. Signed-off-by: Ioana Ciornei --- drivers/staging/fsl-dpaa2/ethernet/dpkg.h | 70 ++- drivers/staging/fsl-dpaa2/ethernet/dpni.h | 145 ++ 2 files changed

[PATCH 2/2] staging: fsl-dpaa2/ethsw: document nested structs as per kernel-doc

2018-07-27 Thread Ioana Ciornei
Document nested structs per kernel-doc requirements by moving all comments before the actual struct. Signed-off-by: Ioana Ciornei --- drivers/staging/fsl-dpaa2/ethsw/dpsw.h | 27 --- 1 file changed, 12 insertions(+), 15 deletions(-) diff --git a/drivers/staging/fsl

[PATCH 0/2] staging: fsl-dpaa2: document nested structs as per kernel-doc

2018-07-27 Thread Ioana Ciornei
Document nested structs per kernel-doc requirements by moving all comments before the actual struct. Ioana Ciornei (2): staging: fsl-dpaa2/eth: document nested structs as per kernel-doc staging: fsl-dpaa2/ethsw: document nested structs as per kernel-doc drivers/staging/fsl-dpaa2/ethernet

RE: Patch procedure

2016-11-15 Thread Ioana Ciornei
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of feas > Sent: Monday, November 14, 2016 7:16 PM > To: de...@driverdev.osuosl.org; gre...@linuxfoundation.org; linux- > ker...@vger.kernel.org > Subject: Patch procedur