On Jun 1, 2018, at 17:19, NeilBrown wrote:
>
> On Fri, Jun 01 2018, Doug Oucharek wrote:
>
>> Would it makes sense to land LNet and LNDs on their own first? Get
>> the networking house in order first before layering on the file
>> system?
>
> I'd like to turn that question on it's head:
> Do
On May 31, 2018, at 18:54, Greg Kroah-Hartman
wrote:
>
> On Tue, May 29, 2018 at 10:21:45AM -0400, James Simmons wrote:
>> From: "John L. Hammond"
>>
>> Pre 2.10.1 MDTs will crash when they receive a listxattr (MDS_GETXATTR
>> with OBD_MD_FLXATTRLS) RPC for an orphan or dead object. So for
>>
On May 16, 2018, at 02:00, Dan Carpenter wrote:
>
> On Tue, May 15, 2018 at 04:02:55PM +0100, James Simmons wrote:
>>
/*
* Allocate new object. This may result in rather complicated
* operations, including fld queries, inode loading, etc.
*/
o = lu_obje
On May 12, 2018, at 00:33, Christophe JAILLET
wrote:
>
> According to error handling path before and after this one, we should go
> to 'out_md_fid' here, instead of 'out_md', if 'obd_connect()' fails.
>
> Signed-off-by: Christophe JAILLET
Good catch.
Reviewed-by: Andreas Dilger
> ---
> The
On May 11, 2018, at 07:38, Colin King wrote:
>
> From: Colin Ian King
>
> Trivial fix to spelling mistake in DEBUG_REQ message text
>
> Signed-off-by: Colin Ian King
Reviewed-by: Andreas Dilger
> ---
> drivers/staging/lustre/lustre/ptlrpc/client.c | 2 +-
> 1 file changed, 1 insertion(+), 1
On May 3, 2018, at 22:19, Wenwen Wang wrote:
>
> On Tue, May 1, 2018 at 3:46 AM, Dan Carpenter
> wrote:
>> On Mon, Apr 30, 2018 at 05:56:10PM -0500, Wenwen Wang wrote:
>>> However, given that the user data resides in the user space, a malicious
>>> user-space process can race to change the data
On May 3, 2018, at 07:50, David Laight wrote:
>
> From: James Simmons
>> Sent: 02 May 2018 19:22
>> From: Li Xi
>>
>> Most of the time, keys are never changed. So rwlock might be
>> better for the concurrency of key read.
>
> OTOH unless there is contention on the spin lock during reads the
>
On Apr 30, 2018, at 16:56, Wenwen Wang wrote:
>
> In ll_dir_ioctl(), the object lumv3 is firstly copied from the user space
> using Its address, i.e., lumv1 = &lumv3. If the lmm_magic field of lumv3 is
> LOV_USER_MAGIC_V3, lumv3 will be modified by the second copy from the user
> space. The secon
On Apr 29, 2018, at 07:20, Greg Kroah-Hartman
wrote:
>
> On Sat, Apr 28, 2018 at 04:04:25PM +, Dilger, Andreas wrote:
>> On Apr 27, 2018, at 17:45, Wenwen Wang wrote:
>>> [PATCH] staging: luster: llite: fix potential missing-check bug when
>>> copying lumv
On Apr 27, 2018, at 17:45, Wenwen Wang wrote:
> [PATCH] staging: luster: llite: fix potential missing-check bug when copying
> lumv
(typo) s/luster/lustre/
> In ll_dir_ioctl(), the object lumv3 is firstly copied from the user space
> using Its address, i.e., lumv1 = &lumv3. If the lmm_magic fie
On Mar 7, 2018, at 13:54, Kees Cook wrote:
>
> The kernel would like to have all stack VLA usage removed[1]. This switches
> to a simple kasprintf() instead, and in the process fixes an off-by-one
> between the allocation and the sprintf (allocation did not include NULL
> byte in calculation).
>
On Jan 27, 2018, at 14:42, Sven Dziadek wrote:
>
> The functionality of the removed variable length array is already
> implemented by the function xattr_full_name in fs/xattr.c
>
> This fixes the sparse warning:
> warning: Variable length array is used.
>
> Signed-off-by: Sven Dziadek
> ---
>
On Jan 27, 2018, at 22:24, Sumit Pundir wrote:
>
> Return value of error codes should typically be negative.
> Issue reported by checkpatch.pl
>
> Signed-off-by: Sumit Pundir
Reviewed-by: Andreas Dilger
> ---
> drivers/staging/lustre/lnet/selftest/framework.c | 2 +-
> 1 file changed, 1 inser
On Jan 25, 2018, at 06:51, Eremin, Dmitry wrote:
>
> The logic of the original commit 4d99b2581eff ("staging: lustre: avoid
> intensive reconnecting for ko2iblnd") was assumed conditional free of
> struct kib_conn if the second argument free_conn in function
> kiblnd_destroy_conn(struct kib_conn
On Jan 11, 2018, at 10:17, Fabian Huegel wrote:
>
> Fixed four lines that went over the 80 character limit
> to reduce checkpatch warnings.
>
> Signed-off-by: Fabian Huegel
> Signed-off-by: Christoph Volkert
> ---
> drivers/staging/lustre/lustre/include/obd_class.h | 14 ++
> 1 file
> On Jan 16, 2018, at 09:56, Greg Kroah-Hartman
> wrote:
>
> On Tue, Jan 16, 2018 at 03:01:49PM +, Eremin, Dmitry wrote:
>> In the original commit 4d99b2581effe115376402e710fbcb1c3c073769
>
> Please use the documented way to write this:
> 4d99b2581eff ("staging: lustre: avoid intensi
On Dec 23, 2017, at 04:13, Aliaksei Karaliou wrote:
>
> lu_global_fini() explicitly uses knowledge about shrinker's
> internals to make decision about calling of unregister_shrinker().
> Now this check was integrated into unregister_shrinker(),
> so it is safe to call it against unregistered shri
On Dec 19, 2017, at 10:56, Roman Storozhenko wrote:
>
> There are two reasons for replacing 'uint32_t' with 'u32'
> and 'uint64_t' with 'u64':
>
> 1) As Linus Torvalds have said we should use kernel types:
> http://lkml.iu.edu/hypermail//linux/kernel/1506.0/00160.html
>
> 2) There are only few
On Dec 4, 2017, at 11:42, Aliaksei Karaliou wrote:
>
> On 12/04/2017 11:40 AM, Dan Carpenter wrote:
>> On Sun, Dec 03, 2017 at 07:59:07PM +0300, ak wrote:
>>> Thank you for your extensive comments.
>>>
>>> I've also thought about adding more protection into unregister_shrinker(),
>>> but not sur
> On Nov 30, 2017, at 11:30, Andrii Vladyka wrote:
>
> Change 0 to NULL in lov_object_fiemap() in order to fix warning produced by
> sparse
>
> Signed-off-by: Andrii Vladyka
Patches should be inline rather than in an attachment.
That said, the patch looks correct, so you can add:
Signed-of
On Dec 2, 2017, at 11:40, Aliaksei Karaliou wrote:
>
> Lustre code lacks checking the result of register_shrinker()
> in several places. register_shrinker() was tagged __must_check
> recently so that sparse has started reporting it.
Thank you for your patch. Some comments below.
> Signed-off-b
On Nov 17, 2017, at 04:46, Roman Storozhenko wrote:
>
> There are two reasons for that:
> 1) As Linus Torvalds said we should use kernel types:
> http://lkml.iu.edu/hypermail//linux/kernel/1506.0/00160.html
>
> 2) There are only few places in the lustre codebase that use such types.
> In the mos
> On Nov 9, 2017, at 03:57, Roman Storozhenko wrote:
>
> On Thu, Nov 9, 2017 at 1:06 PM, Dilger, Andreas
> wrote:
>> On Nov 3, 2017, at 06:36, Roman Storozhenko wrote:
>>>
>>> On Fri, Nov 03, 2017 at 12:46:18PM +0100, Greg Kroah-Hartman wrote:
>>&
On Nov 3, 2017, at 06:36, Roman Storozhenko wrote:
>
> On Fri, Nov 03, 2017 at 12:46:18PM +0100, Greg Kroah-Hartman wrote:
>> On Sun, Oct 29, 2017 at 08:58:39PM +0300, Roman Storozhenko wrote:
>>> There are two reasons for that:
>>> 1) As Linus Torvalds said we should use kernel types:
>>> http:/
On Nov 7, 2017, at 23:15, Greg Kroah-Hartman wrote:
>
> On Wed, Nov 08, 2017 at 12:35:43AM +, Dilger, Andreas wrote:
>> On Nov 7, 2017, at 06:58, Greg Kroah-Hartman
>> wrote:
>>>
>>> It's good to have SPDX identifiers in all files to make it easier
On Nov 7, 2017, at 06:58, Greg Kroah-Hartman wrote:
>
> It's good to have SPDX identifiers in all files to make it easier to
> audit the kernel tree for correct licenses.
>
> Update the drivers/staging/lustre files files with the correct SPDX
> license identifier based on the license text in the
On Oct 30, 2017, at 01:58, Roman Storozhenko wrote:
>
> There are two reasons for that:
> 1) As Linus Torvalds said we should use kernel types:
> http://lkml.iu.edu/hypermail//linux/kernel/1506.0/00160.html
>
> 2) There are only few places in the lustre codebase that use such types.
> In the mos
On Oct 30, 2017, at 01:58, Roman Storozhenko wrote:
>
> There are two reasons for that:
> 1) As Linus Torvalds said we should use kernel types:
> http://lkml.iu.edu/hypermail//linux/kernel/1506.0/00160.html
>
> 2) There are only few places in the lustre codebase that use such types.
> In the mos
On Oct 30, 2017, at 23:00, Jeff Layton wrote:
>
> From: Jeff Layton
>
> f_version is only ever used by filesystem-specific code. Generic
> VFS code never uses it.
>
> Nothing in lustre ever looks at it, so just remove this.
>
> Signed-off-by: Jeff Layton
Reviewed-by: Andreas Dilger
> ---
On Oct 12, 2017, at 10:17, Gustavo A. R. Silva wrote:
>
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Addresses-Coverity-ID: 1077598
> Signed-off-by: Gustavo A. R. Silva
Reviewed-by: Andreas Dilger
> ---
> drivers/staging
On Oct 12, 2017, at 10:17, Gustavo A. R. Silva wrote:
>
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva
Reviewed-by: Andreas Dilger
> ---
> drivers/staging/lustre/lnet/selftest/conctl.c |
On Oct 12, 2017, at 10:17, Gustavo A. R. Silva wrote:
>
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Addresses-Coverity-ID: 1077604
> Addresses-Coverity-ID: 1077605
> Signed-off-by: Gustavo A. R. Silva
Reviewed-by: Andreas
On Oct 12, 2017, at 10:17, Gustavo A. R. Silva wrote:
>
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva
Reviewed-by: Andreas Dilger
> ---
> drivers/staging/lustre/lustre/ptlrpc/pack_generi
On Oct 12, 2017, at 10:17, Gustavo A. R. Silva wrote:
>
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva
Reviewed-by: Andreas Dilger
> ---
> drivers/staging/lustre/lustre/ldlm/ldlm_request.
On Oct 12, 2017, at 10:17, Gustavo A. R. Silva wrote:
>
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Addresses-Coverity-ID: 1271166
> Addresses-Coverity-ID: 1271167
> Addresses-Coverity-ID: 1271168
> Addresses-Coverity-ID: 1
> On Oct 12, 2017, at 10:17, Gustavo A. R. Silva
> wrote:
>
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva
Not sure why you moved the "for mode = 0" comment to a separate line?
Not the en
On Oct 12, 2017, at 10:17, Gustavo A. R. Silva wrote:
>
>
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva
Reviewed-by: Andreas Dilger
> ---
> drivers/staging/lustre/lnet/selftest/module.c
On Oct 12, 2017, at 10:16, Gustavo A. R. Silva wrote:
>
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva
This could also just be "continue;", but doesn't appear harmful.
Reviewed-by: Andreas
On Oct 12, 2017, at 10:16, Gustavo A. R. Silva wrote:
>
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva
This isn't strictly necessary, since LASSERT() never returns, but
not harmful either.
> On Aug 17, 2017, at 09:47, Greg Kroah-Hartman
> wrote:
>
> On Mon, Aug 14, 2017 at 04:01:17PM +0100, James Simmons wrote:
>>
>>> We want to concatonate join string one, a '/' character, string two and
>>> then a NUL terminator. The destination buffer holds ori_gf->gf_pathlen
>>> characters.
On Aug 17, 2017, at 10:26, Greg KH wrote:
>
> On Wed, Aug 16, 2017 at 05:44:15PM +0300, Cihangir Akturk wrote:
>> When building the kernel for the ARM architecture without setting
>> CONFIG_AEABI, size of struct lov_user_md_v3 and struct lov_mds_md_v3
>> differs, due to different alignment requir
On Jul 12, 2017, at 03:03, Craig Inches wrote:
>
> This fixes a block statement which didnt end with */
>
> Signed-off-by: Craig Inches
> ---
> drivers/staging/lustre/include/linux/lnet/socklnd.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/i
On Jul 7, 2017, at 16:03, Dmitriy Cherkasov wrote:
>
> After removing commented out code, ksocknal_csum() becomes a useless
> wrapper for crc32_le(). Remove it, and instead call crc32_le() directly.
>
> Fixes the following checkpatch warning:
>
> WARNING: space prohibited before semicolon
>
>
On Jul 7, 2017, at 16:03, Dmitriy Cherkasov wrote:
>
> After removing commented out code, ksocknal_csum() becomes a useless
> wrapper for crc32_le(). Remove it, and instead call crc32_le() directly.
>
> Fixes the following checkpatch warning:
>
> WARNING: space prohibited before semicolon
>
>
> On Jul 11, 2017, at 11:08, Greg KH wrote:
>
> On Thu, Jul 06, 2017 at 12:43:15PM +0530, Jaya Durga wrote:
>> Replace all instances of (1 << 27) with BIT(27) to fix
>> checkpatch check messages
>>
>> Signed-off-by: Jaya Durga
>> ---
>> drivers/staging/lustre/lustre/include/lustre_compat.h | 2
On Jul 11, 2017, at 11:14, Greg Kroah-Hartman
wrote:
>
> On Fri, Jul 07, 2017 at 01:47:04AM +, Craig Inches wrote:
>> This fixes multiple block statements found not to match
>> style as per checkpatch
>>
>> Signed-off-by: Craig Inches
>> ---
>> drivers/staging/lustre/include/linux/lnet/lne
On Jan 21, 2017, at 02:24, Greg Kroah-Hartman
wrote:
>
> On Fri, Jan 20, 2017 at 11:33:11PM +, James Simmons wrote:
>>
> On Mon, Dec 19, 2016 at 12:06:47PM -0500, James Simmons wrote:
>> Not for landing. This is the purposed UAPI headers
>> with the removal of unlikely and debug
On May 18, 2017, at 17:13, Mathias Rav wrote:
>
> On Thu, 18 May 2017 14:48:25 +0000
> "Dilger, Andreas" wrote:
>
>> On May 18, 2017, at 15:53, Greg Kroah-Hartman
>> wrote:
>>>
>>> On Thu, May 04, 2017 at 12:13:38PM -0400, Math
On May 18, 2017, at 15:53, Greg Kroah-Hartman
wrote:
>
> On Thu, May 04, 2017 at 12:13:38PM -0400, Mathias Rav wrote:
>> Prefer kstrtouint_from_user to copy_from_user+simple_strtoul.
>>
>> The helper function lprocfs_wr_uint() is only used to implement
>> "dump_granted_max" in debugfs.
>>
>> N
On Apr 18, 2017, at 09:50, g...@kroah.com wrote:
>
> On Sat, Apr 15, 2017 at 01:50:42PM +, Rishiraj Manwatkar wrote:
>> Subject: [Patch v3 1/2] lustre: Parantheses added for Macro argument to
>> avoid precedence issues
(typo) s/Parantheses/parenthesis/ s/Macro/macro/
The Subject line (exclu
On Apr 15, 2017, at 07:50, Rishiraj Manwatkar wrote:
>
> Comparison should have the CONSTANT on the right side of the test
I don't think this change really improves things. For standalone comparisons I
agree
that having the constant on the RHS is best, but here it is like a normal
mathematica
On Apr 15, 2017, at 18:48, skanda.kash...@gmail.com wrote:
>
> From: Skanda Guruanand
>
> The struct lu_dirpage elements in lustre_idl.h file are modified to
> __le64 and __le32 types since the elements are always converted from
> litte endian to processor native format in mdc_request.c file.
>
On Apr 13, 2017, at 03:24, Craig Inches wrote:
>
> This resolves a checkpatch warning that "Single statement macros should
> not use a do {} while (0) loop" by removing the loop and adjusting line
> length accordingly.
>
> Signed-off-by: Craig Inches
I don't think there was any particular reas
On Apr 3, 2017, at 15:13, Craig Inches wrote:
>
> This resolves a checkpatch warning that "Single statement macros should
> not use a do {} while (0) loop" by removing the loop and adjusting line
> length accordingly.
>
> Signed-off-by: Craig Inches
> ---
> .../lustre/include/linux/libcfs/libcf
On Apr 4, 2017, at 03:38, Dan Carpenter wrote:
>
> On Tue, Apr 04, 2017 at 02:45:26PM +0530, Pushkar Jambhlekar wrote:
>> diff --git a/drivers/staging/lustre/lustre/obdclass/cl_page.c
>> b/drivers/staging/lustre/lustre/obdclass/cl_page.c
>> index cd9a40c..71fcc4c 100644
>> --- a/drivers/staging/
On Mar 27, 2017, at 23:40, Skanda Guruanand wrote:
>
> I have tried to fix the endian issues in the mdc_request.c in the
> lustre file system drivers in the staging area. Your feedback is
> welcome.
Sorry, but this patch is totally wrong. This would break the handling of this
structure
on big-
On Mar 24, 2017, at 07:44, Greg Kroah-Hartman
wrote:
>
> On Fri, Mar 24, 2017 at 05:09:53PM +0530, Arushi Singhal wrote:
>> Remove the code which do not have any value.
>>
>> Signed-off-by: Arushi Singhal
>> ---
>> drivers/staging/lustre/lnet/lnet/net_fault.c | 5 -
>> 1 file changed, 5 del
On Mar 22, 2017, at 06:12, Dilger, Andreas wrote:
>
> On Mar 21, 2017, at 22:39, Arushi Singhal
> wrote:
>>
>> This patch replaces bit shifting on 1 with the BIT(x) macro.
>> This was done with coccinelle:
[snip]
>> diff --git a/drivers/staging/lustre/ln
On Mar 22, 2017, at 09:53, Arushi Singhal
wrote:
>
> This patch replaces bit shifting on 1 with the BIT(x) macro.
> This was done with coccinelle:
> @@
> constant c;
> @@
>
> -1 << c
> +BIT(c)
>
> Signed-off-by: Arushi Singhal
Reviewed-by: Andreas Dilger
> ---
> changes in v2
> - remove th
On Mar 21, 2017, at 22:39, Arushi Singhal
wrote:
>
> This patch replaces bit shifting on 1 with the BIT(x) macro.
> This was done with coccinelle:
> @@
> constant c;
> @@
>
> -1 << c
> +BIT(c)
Did you take the time to look at what this Coccinelle script actually did, to
see
if it actually mak
On Mar 22, 2017, at 00:20, Arushi Singhal
wrote:
>
> This patch replaces bit shifting on 1 with the BIT(x) macro.
> This was done with coccinelle:
> @@
> constant c;
> @@
>
> -1 << c
> +BIT(c)
Hi Arushi,
thanks for taking time to contribute to the kernel. There are a few problems
with
this p
On Mar 9, 2017, at 05:22, Pushkar Jambhlekar wrote:
> Subject: Minor coding guideline Fix in lusture module
I suspect the patchbot is unhappy with the subject line not containing anything
useful, and not containing the subsystem name. Something like:
staging/lustre/llite: replace "unsigned" with
On Mar 6, 2017, at 08:20, James Simmons wrote:
>
>>
>> Doubly linked lists which are iterated using list_empty
>> and list_entry macros have been replaced with list_for_each_entry_safe
>> macro.
>> This makes the iteration simpler and more readable.
>>
>> This patch replaces the while loop co
> On Feb 3, 2017, at 03:33, Greg Kroah-Hartman
> wrote:
>
> On Sat, Jan 28, 2017 at 07:04:38PM -0500, James Simmons wrote:
>> From: Andreas Dilger
>>
>> Update the sysfs "version" file to print "lustre: " with
>> the version number.
>>
>> Signed-off-by: Andreas Dilger
>> Intel-bug-id: https
On Feb 2, 2017, at 04:26, Arnd Bergmann wrote:
>
> lustre uses a fake switch() statement as a compile-time assert, but
> unfortunately
> each use of that causes a warning when building with clang:
>
> drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:2907:2: warning: no case
> matching const
On Feb 1, 2017, at 09:52, Arnd Bergmann wrote:
>
> lustre uses a fake switch() statement as a compile-time assert, but
> unfortunately
> each use of that causes a warning when building with clang:
>
> drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:2907:2: warning: no case
> matching const
On Jan 24, 2017, at 09:40, Ernestas Kulik wrote:
>
> Using octal permissions instead of symbolic ones is preferred.
Typically the reverse is true - using symbolic constants is preferred over
numeric ones.
Where does this recommendation come from?
Cheers, Andreas
> Signed-off-by: Ernestas Kuli
On Dec 23, 2016, at 08:42, Karthik Nayak wrote:
>
> Since the function brw_inject_one_error() is used only within
> brw_test.c, make it static. This was reported as a warning by sparse.
>
> Signed-off-by: Karthik Nayak
Reviewed-by: Andreas Dilger
> ---
> drivers/staging/lustre/lnet/selftest/
On Jan 4, 2017, at 22:14, Gustavo A. R. Silva
wrote:
>
> Simplify return logic to avoid unnecessary variable assignments.
> These issues were detected using Coccinelle and the following semantic patch:
>
> @@
> local idexpression ret;
> expression e;
> @@
>
> -ret =
> +return
> e;
> -retur
On Dec 14, 2016, at 14:11, Tabrez khan wrote:
>
> Subject: [PATCH] staging : osc : coding style fix
Thanks for sumbitting your patch.
As a general rule, the patch summary line should try to describe
(as best as possible in a single line) what the patch is actually
fixing. It is true this is a
On Dec 12, 2016, at 13:00, James Simmons wrote:
>
>
>> On Sat, Dec 10, 2016 at 01:06:01PM -0500, James Simmons wrote:
>>> In order for lustre_idl.h to be usable for both user
>>> land and kernel space it has to use the proper
>>> byteorder functions.
>>
>> Why would userspace need/want all of t
> On Dec 5, 2016, at 13:50, Dan Carpenter wrote:
>
> On Fri, Dec 02, 2016 at 02:40:47PM -0500, James Simmons wrote:
>> -__u32 local_flags = 0;
>> +u32 local_flags = 0;
>
>> -if (local_flags != 0) {
>> +if (local_flags) {
>
> Please avoid these unrelated white space changes.
So
On Nov 24, 2016, at 04:10, Dan Carpenter wrote:
>
> We want sizeof(struct lstcon_node) but instead we're getting the sizeof
> a pointer.
>
> Fixes: 8d78f0f2ba76 ("staging: lustre: lnet: cleanup some of the > 80 line
> issues")
> Signed-off-by: Dan Carpenter
Reviewed-by: Andreas Dilger
>
>
On Nov 18, 2016, at 09:48, James Simmons wrote:
>
> Remove the zero comparisions in the libcfs headers.
>
> Signed-off-by: James Simmons
> ---
> .../lustre/include/linux/libcfs/libcfs_crypto.h|2 +-
> .../lustre/include/linux/libcfs/libcfs_fail.h |4 +-
> .../lustre/include/linux
On Nov 24, 2016, at 04:12, Dan Carpenter wrote:
>
> We should free "desc" before returning NULL.
>
> Signed-off-by: Dan Carpenter
Reviewed-by: Andreas Dilger
> diff --git a/drivers/staging/lustre/lustre/ptlrpc/client.c
> b/drivers/staging/lustre/lustre/ptlrpc/client.c
> index ac959ef..80474
On Nov 10, 2016, at 07:19, Colin King wrote:
>
> From: Colin Ian King
>
> Change predecrement compare to post decrement compare to avoid an
> unsigned integer wrap-around comparisomn when decrementing in the while
> loop.
>
> Issue found with static analysis with CoverityScan, CID 1375917
Tha
On Nov 7, 2016, at 19:47, James Simmons wrote:
>
> The ldlm_pool field pl_recalc_time is set to the current
> monotonic clock value but the interval period is calculated
> with the wall clock. This means the interval period will
> always be far larger than the pl_recalc_period, which is
> just a
On Nov 7, 2016, at 02:07, Aya Mahfouz wrote:
>
> On Mon, Nov 7, 2016 at 6:22 AM, Oleg Drokin wrote:
>
>> On Nov 4, 2016, at 4:37 AM, Aya Mahfouz wrote:
>>
>> >
>> > On Thu, Nov 3, 2016 at 1:05 AM, Dilger, Andreas
>> > wrote:
>>
On Nov 6, 2016, at 10:26, Drokin, Oleg wrote:
>
> Hello!
>
> On Nov 6, 2016, at 12:11 PM, Christophe JAILLET wrote:
>
>> 'lustre_cfg_new()' can return ERR_PTR(-ENOMEM).
>> Handle these errors and propagate the error code to the callers.
>>
>> Error handling has been rearranged in 'lustre_proce
On Nov 7, 2016, at 12:01, Nicholas Hanley wrote:
>
> Replace 0 with false in tx_pages_mapped = 0 to be consistent with
> the rest of the lustre code.
>
> Signed-off-by: Nicholas Hanley
Reviewed-by: Andreas Dilger
> ---
> drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 2 +-
> 1 file cha
On Nov 3, 2016, at 16:49, Andrew Kanner wrote:
>
> Removed redundant declaration of variable 'tx' in local scope
> Fixed: sparse warning:
> socklnd_cb.c:2476:41: warning: symbol 'tx' shadows an earlier one
> socklnd_cb.c:2435:25: originally declared here
>
> Signed-off-by: Andrew Kanner
Review
On Nov 3, 2016, at 15:54, Andrew Kanner wrote:
>
> Changed variable 'tx' name in local scope
> Fixed: sparse warning:
> socklnd_cb.c:2476:41: warning: symbol 'tx' shadows an earlier one
> socklnd_cb.c:2435:25: originally declared here
Looking at this more closely (or from a greater distance, har
On Oct 25, 2016, at 10:47, Aya Mahfouz wrote:
>
> On Mon, Oct 17, 2016 at 10:38:31PM +, Dilger, Andreas wrote:
>> On Oct 17, 2016, at 15:46, Aya Mahfouz
>> wrote:
>>>
>>> class_devno_max is an inline function that returns
>>> MAX_OBD_DEVI
On Oct 17, 2016, at 15:46, Aya Mahfouz wrote:
>
> class_devno_max is an inline function that returns
> MAX_OBD_DEVICES. Replace all calls to the function
> by MAX_OBD_DEVICES.
Thanks for your patch, but unfortunately it can't be accepted.
This function was added in preparation of being able to
On Oct 2, 2016, at 20:22, James Simmons wrote:
>
> In the rdma-next tree to be merged for 4.9-rc1 removes
> the IB core function ib_get_dma_mr. This patch migrates
> us way from this former function.
>
> Signed-off-by: James Simmons
> ---
> .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c|
On Sep 19, 2016, at 09:28, Greg Kroah-Hartman
wrote:
>
> On Sun, Sep 18, 2016 at 04:37:29PM -0400, James Simmons wrote:
>> + * Range lock is used to allow multiple threads writing a single shared
>> + * file given each thread is writing to a non-overlapping portion of the
>> + * file.
>> + *
>>
> On Sep 18, 2016, at 23:18, Nayeemahmed Badebade
> wrote:
>
> Added __acquires / __releases sparse locking annotations
> to lock_res_and_lock() and unlock_res_and_lock() functions
> in l_lock.c, to fix below sparse warnings:
>
> l_lock.c:47:22: warning: context imbalance in 'lock_res_and_lock
On Sep 17, 2016, at 06:04, Baoyou Xie wrote:
>
> We get a few warnings when building kernel with W=1:
> drivers/staging/lustre/lustre/lmv/lmv_obd.c:1640:1: warning: no previous
> prototype for 'lmv_locate_target_for_name' [-Wmissing-prototypes]
> drivers/staging/lustre/lustre/lmv/lmv_obd.c:2421:
On Sep 18, 2016, at 14:21, nayeem wrote:
> On Friday 16 September 2016 01:30 PM, Dilger, Andreas wrote:
>> On Sep 15, 2016, at 12:33, nayeem wrote:
>>> On Wednesday 14 September 2016 10:44 AM, Dilger, Andreas wrote:
>>>> On Sep 12, 2016, at 04:27, Greg KH wrot
On Sep 15, 2016, at 12:33, nayeem wrote:
> On Wednesday 14 September 2016 10:44 AM, Dilger, Andreas wrote:
>> On Sep 12, 2016, at 04:27, Greg KH wrote:
>>>
>>> On Fri, Sep 09, 2016 at 08:50:35PM +0530, Nayeemahmed Badebade wrote:
>>>> Added __acquires
On Sep 12, 2016, at 04:27, Greg KH wrote:
>
> On Fri, Sep 09, 2016 at 08:50:35PM +0530, Nayeemahmed Badebade wrote:
>> Added __acquires / __releases sparse locking annotations
>> to lock_res_and_lock and unlock_res_and_lock functions in
>> l_lock.c, to fix below sparse warnings:
>>
>> l_lock.c:4
On Aug 22, 2016, at 10:57, James Simmons wrote:
>
> The function mdc_adjust_dirpages is only called on platforms which
> don't have pages 4K in size which is why kbuild only reported this
> for platforms like the Alpha. The problem was a typo in ordering of
> variables in the beginning of a while
On 2016/06/08, 16:50, "James Simmons" wrote:
>The lloop device was original developed to work around
>the lack of direct I/O for the default loop back device.
>Also the lloop device greatly out performed the default
>loop back device. The lloop hasn't been worked on for
>some time and now it no l
On 2016/05/23, 15:06, "James Simmons" wrote:
>
>> Currently, getxattr() and setxattr() check for the xattr names
>> "system.posix_acl_{access,default}" and perform in-place UID / GID
>> namespace mappings in the xattr values. Filesystems then again check for
>> the same xattr names to handle those
On 2016/05/16, 12:16, "James Simmons" wrote:
>
>> This looks wrong - You return -EINVAL from sptlrpc_pack_user_desc, but then
>> the caller checks "!desc". Desc will not be null, since you've returned
>> -EINVAL.
>
>Actually 'if (!desc)' is equal to 'if (desc != 0). Yes it can be confusing.
Ver
On 2016/03/22, 19:49, "lustre-devel on behalf of Greg Kroah-Hartman"
wrote:
>On Tue, Mar 22, 2016 at 06:21:04PM -0400, James Simmons wrote:
>> Latest testing fails when using ko2iblnd. It was tracked down
>> to commit 4671a026616df26000f7d8ad2f2ea4b6de79263c.
>>
>> This reverts commit 4671a02661
On 2016/03/18, 13:28, "lustre-devel on behalf of Dilger, Andreas"
wrote:
>On 2016/03/17, 23:42, "Dan Carpenter" wrote:
>
>>lustre_cfg_new() returns error pointers on error, it never returns NULL.
Hmm, looking at the broader context, I see there are other call
On 2016/03/17, 23:42, "Dan Carpenter" wrote:
>lustre_cfg_new() returns error pointers on error, it never returns NULL.
>
>Signed-off-by: Dan Carpenter
>
>diff --git a/drivers/staging/lustre/lustre/mgc/mgc_request.c
>b/drivers/staging/lustre/lustre/mgc/mgc_request.c
>index 65caffe..b7dc872 100644
On 2016/03/11, 18:29, "lustre-devel on behalf of James Simmons"
wrote:
>Apply a consistent style for comments in the lnet selftest
>code.
>
>Signed-off-by: James Simmons
>---
> drivers/staging/lustre/lnet/selftest/brw_test.c |8 ++--
> drivers/staging/lustre/lnet/selftest/conctl.c| 50
On 2015/12/23, 14:40, "Simmons, James A." wrote:
>>From: Niranjan Dighe
>>
>>Remove IOC_LIBCFS_MEMHOG ioctl functionality as it is no longer needed
>>thereby
>>making functions like - kportal_memhog_alloc(), kportal_memhog_free()
>>and type -
>>struct libcfs_device_userstate unused.
>
>Actually
1 - 100 of 147 matches
Mail list logo
