Re: [Outreachy kernel] [PATCH 1/2] staging: sm750fb: Fix typo in comment

On Tue, 29 Oct 2019, Gabriela Bittencourt wrote: > Fixing typo in word 'and'. > > Signed-off-by: Gabriela Bittencourt Acked-by: Julia Lawall > --- > drivers/staging/sm750fb/sm750_accel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/sm750fb/sm750

[PATCH 2/6] staging: exfat: make alignment match open parenthesis

Fix checkpatch.pl warning: CHECK: Alignment should match open parenthesis Signed-off-by: Roi Martin --- drivers/staging/exfat/exfat_core.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/exfat/exfat_core.c b/drivers/staging/exfat/exfat_c

[PATCH 6/6] staging: exfat: replace kmalloc with kmalloc_array

Replace expressions of the form: kmalloc(count * size, GFP_KERNEL); With: kmalloc_array(count, size, GFP_KERNEL); Signed-off-by: Roi Martin --- drivers/staging/exfat/exfat_core.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/exfat/exf

[PATCH 5/6] staging: exfat: avoid multiple assignments

Fix checkpatch.pl warning: CHECK: multiple assignments should be avoided Signed-off-by: Roi Martin --- drivers/staging/exfat/exfat_core.c | 3 +- drivers/staging/exfat/exfat_super.c | 90 +++-- 2 files changed, 73 insertions(+), 20 deletions(-) diff --git a/dr

[PATCH 1/6] staging: exfat: remove unnecessary parentheses

Fix checkpatch.pl warning: CHECK: Unnecessary parentheses around ... Signed-off-by: Roi Martin --- drivers/staging/exfat/exfat_core.c | 24 drivers/staging/exfat/exfat_super.c | 44 ++--- 2 files changed, 34 insertions(+), 34 deletions(-) diff

[PATCH 3/6] staging: exfat: remove unnecessary new line in if condition

Fix checkpatch.pl warning: CHECK: Logical continuations should be on the previous line Signed-off-by: Roi Martin --- drivers/staging/exfat/exfat_core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/exfat/exfat_core.c b/drivers/staging/exfat/exfat

[PATCH 0/6] staging: exfat: fix multiple coding-style issues

Fix multiple coding-style issues reported by the checkpatch.pl script in the exfat module. Roi Martin (6): staging: exfat: remove unnecessary parentheses staging: exfat: make alignment match open parenthesis staging: exfat: remove unnecessary new line in if condition staging: exfat: replac

[PATCH 4/6] staging: exfat: replace printk(KERN_INFO ...) with pr_info()

Fix checkpatch.pl warning: WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... Signed-off-by: Roi Martin --- drivers/staging/exfat/exfat_super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[PATCH 2/2] staging: sm750fb: Replace multiple spaces with tabs when it suits

Replace multiple spaces before some comments with one tab. Aligning the comment with the function below it. Signed-off-by: Gabriela Bittencourt --- drivers/staging/sm750fb/sm750_accel.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/sm7

[PATCH 1/2] staging: sm750fb: Fix typo in comment

Fixing typo in word 'and'. Signed-off-by: Gabriela Bittencourt --- drivers/staging/sm750fb/sm750_accel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c index 645813a87490..5925d7c7d464 100644 ---

[PATCH 0/2] staging: sm750fb: Fixing codestyle error

Fixing typo and usage of spaces/tabs in file sm750_accel.c Gabriela Bittencourt (2): staging: sm750fb: Fix typo in comment staging: sm750fb: Replace multiple spaces with tabs when it suits drivers/staging/sm750fb/sm750_accel.c | 22 +++--- 1 file changed, 11 insertions(+), 11

[PATCH] staging: vt6655: Fix lines ending with parentheses

Fix lines ending with parentheses. Issue found by checkpatch. Signed-off-by: Cristiane Naves --- drivers/staging/vt6655/card.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c index eba4ee0

Re: [PATCH] staging: fieldbus: anybuss: use devm_platform_ioremap_resource helper

On Tue, Oct 29, 2019 at 01:40:08PM -0400, Sven Van Asbroeck wrote: > On Sat, Oct 26, 2019 at 7:52 PM Cristiane Naves > wrote: > > > > Use devm_platform_ioremap_resource helper which wraps > > platform_get_resource() and devm_ioremap_resource() together. Issue > > found by coccicheck. > > > > Signe

Re: [PATCH v2 1/4] iio: adc: Add support for AD7091R5 ADC

It looks like you're going to have to respin the patchset so I'm adding my nits even though it's a bit late. > +static int ad7091r_set_mode(struct ad7091r_state *st, enum ad7091r_mode mode) > +{ > + int ret; > + > + switch (mode) { > + case AD7091R_MODE_SAMPLE: > + ret = r

Re: [PATCH] staging: fieldbus: anybuss: use devm_platform_ioremap_resource helper

On Sat, Oct 26, 2019 at 7:52 PM Cristiane Naves wrote: > > Use devm_platform_ioremap_resource helper which wraps > platform_get_resource() and devm_ioremap_resource() together. Issue > found by coccicheck. > > Signed-off-by: Cristiane Naves > --- > drivers/staging/fieldbus/anybuss/arcx-anybus.c

Re: [PATCH 3/4] dt-binding: iio: Add documentation for AD7091R5

On Mon, Oct 21, 2019 at 08:06:07PM +0300, Beniamin Bia wrote: > Documentation for AD7091R5 ADC was added. > > Signed-off-by: Beniamin Bia > --- > .../bindings/iio/adc/adi,ad7091r5.yaml| 53 +++ > 1 file changed, 53 insertions(+) > create mode 100644 > Documentation/devi

Re: [PATCH 1/2] Staging: gasket: implement apex_get_status() to check driver status

On Tue, Oct 29, 2019 at 09:10:07AM +0100, Greg KH wrote: > On Tue, Oct 29, 2019 at 12:59:25AM +0200, Samuil Ivanov wrote: > > >From the TODO: > > - apex_get_status() should actually check status > > > > The function now checkes the status of the driver > > > > Signed-off-by: Samuil Ivanov > > --

[PATCH v2 2/3] staging: rts5208: Eliminate the use of Camel Case in files xd

Cleans up checks of "Avoid CamelCase" in file xd.h and xd.c Signed-off-by: Gabriela Bittencourt --- drivers/staging/rts5208/xd.c | 8 drivers/staging/rts5208/xd.h | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rts5208/xd.c b/drivers/staging/rt

[PATCH v2 3/3] staging: rts5208: Eliminate the use of Camel Case in file sd.h

Cleans up checks of "Avoid CamelCase" in file sd.h Signed-off-by: Gabriela Bittencourt --- drivers/staging/rts5208/sd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rts5208/sd.h b/drivers/staging/rts5208/sd.h index dc9e8cad7a74..f4ff62653b56 100644 --- a/dr

[PATCH v2 1/3] staging: rts5208: Eliminate the use of Camel Case in files ms

Cleans up checks of "Avoid CamelCase" in file ms.h and ms.c Signed-off-by: Gabriela Bittencourt --- drivers/staging/rts5208/ms.c | 86 ++-- drivers/staging/rts5208/ms.h | 70 ++--- 2 files changed, 78 insertions(+), 78 deletions(-) diff --

[PATCH v2 0/3] staging: rts5208: Eliminate the use of Camel Case

Cleans up checks of "Avoid CamelCase" in tree rts5208 Gabriela Bittencourt (3): staging: rts5208: Eliminate the use of Camel Case in files ms staging: rts5208: Eliminate the use of Camel Case in files xd staging: rts5208: Eliminate the use of Camel Case in file sd.h drivers/staging/rts5208

[PATCH v2 4/4] MAINTAINERS: add entry for AD7091R5 driver

Add Beniamin Bia as a maintainer for AD7091R5 ADC. Signed-off-by: Beniamin Bia --- Changes in v2: -nothing changed MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2e01d0f0b0e5..7f1e4b88688f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -893

[PATCH v2 3/4] dt-binding: iio: Add documentation for AD7091R5

Documentation for AD7091R5 ADC was added. Signed-off-by: Beniamin Bia --- Changes in v2: -nothing changed .../bindings/iio/adc/adi,ad7091r5.yaml| 53 +++ 1 file changed, 53 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml diff

[PATCH v2 2/4] iio: adc: ad7091r5: Add scale and external VREF support

From: Paul Cercueil The scale can now be obtained with the "in_voltage_scale" file. By default, the scale returned corresponds to the internal VREF of 2.5V. It is possible to use an external VREF (through the REFIN/REFOUT pin of the chip), by passing a regulator to the driver. The scale will the

[PATCH v2 1/4] iio: adc: Add support for AD7091R5 ADC

From: Paul Cercueil AD7091 is 4-Channel, I2C, Ultra Low Power,12-Bit ADC. Datasheet: Link: https://www.analog.com/media/en/technical-documentation/data-sheets/ad7091r-5.pdf Signed-off-by: Paul Cercueil Co-developed-by: Beniamin Bia Signed-off-by: Beniamin Bia --- Changes in v2: -blank lines

Re: [PATCH v3] ARM: dts: tegra30: Connect SMMU with Video Decoder Engine

On Sun, Jun 23, 2019 at 08:07:24PM +0300, Dmitry Osipenko wrote: > Enable IOMMU support for the video decoder. > > Signed-off-by: Dmitry Osipenko > --- > > No changes since v1. > > arch/arm/boot/dts/tegra30.dtsi | 1 + > 1 file changed, 1 insertion(+) Applied to for-5.5/arm/dt, thanks. Thier

Re: [PATCH v3] ARM: tegra: Enable Tegra VDE driver in tegra_defconfig

On Sun, Jun 23, 2019 at 08:07:25PM +0300, Dmitry Osipenko wrote: > The video decoder driver was tested by time and works absolutely fine. > The reason why it is in staging is because it doesn't provide common V4L > interface yet, this shouldn't stop driver enabling in the defconfig since > our user

Re: [PATCH] staging: fieldbus: make use of devm_platform_ioremap_resource

On Tue, Oct 29, 2019 at 4:03 AM Greg Kroah-Hartman wrote: > > This has been in my tree already for a while, can you verify it is all > ok? > All good. I see you took Cristiane's version, not hariprasad's or YueHaibing's. As long as one version lands, all is well :) ___

[PATCH v2 1/4] staging: KPC2000: kpc2000_spi.c: Fix style issues (missing blank line)

Resolved: "CHECK: Please use a blank line after.." from checkpatch.pl Signed-off-by: Chandra Annamaneni --- Previous versions of these patches were not split into different patches, did not have different patch numbers and did not have the keyword staging. drivers/staging/kpc2000/kpc2000_spi.c

[PATCH v2 3/4] staging: KPC2000: kpc2000_spi.c: Fix style issues (alignment)

Resolved: "CHECK: Alignment should match open parenthesis" from checkpatch Signed-off-by: Chandra Annamaneni --- Previous versions of these patches were not split into different patches, did not have different patch numbers and did not have the keyword staging. drivers/staging/kpc2000/kpc2000_s

[PATCH v2 4/4] staging: KPC2000: kpc2000_spi.c: Fix style issues (Unnecessary parenthesis)

Resolved: CHECK: Unnecessary parentheses around table[i] Signed-off-by: Chandra Annamaneni --- Previous versions of these patches were not split into different patches, did not have different patch numbers and did not have the keyword staging. drivers/staging/kpc2000/kpc2000_spi.c | 2 +- 1 fil

[PATCH v2 2/4] staging: KPC2000: kpc2000_spi.c: Fix style issues (misaligned brace)

Resolved: ERROR: else should follow close brace '}' Signed-off-by: Chandra Annamaneni --- Previous versions of these patches were not split into different patches, did not have different patch numbers and did not have the keyword staging. The previous version of this patch had the wrong descrip

Re: [PATCH 1/2] Staging: gasket: implement apex_get_status() to check driver status

On Tue, Oct 29, 2019 at 12:59:25AM +0200, Samuil Ivanov wrote: > >From the TODO: > - apex_get_status() should actually check status > > The function now checkes the status of the driver > > Signed-off-by: Samuil Ivanov > --- > drivers/staging/gasket/apex_driver.c | 3 +++ > 1 file changed, 3 in

Re: [PATCH] staging: fieldbus: make use of devm_platform_ioremap_resource

On Mon, Oct 28, 2019 at 05:11:26PM -0400, Sven Van Asbroeck wrote: > Hi Greg, friendly reminder... Did you miss the patch review below, or > is there a reason > why this isn't getting queued? > > There seems to be a crowd chasing down this type of warnings, resulting > in multiple duplicates. Thi