**SPAM** Please treat as a matter of very urgent importance.

2019-10-25 Thread William Johnson
Please be informed that all the processes for the smooth transfer into your account has been completed hence the payment is ready please confirm the receipt of this message immediately for more details. Regards, William Johnson. -

Re: [Outreachy kernel] [RESEND PATCH] staging: gasket: Fix lines ending with a '('

2019-10-25 Thread Julia Lawall
On Fri, 25 Oct 2019, Cristiane Naves wrote: > Fix lines ending with a '('. Issue found by checkpatch. You sent another patch on this file (the one I acked) and they are notin a series, so Greg won't know how to apply them. Please collect the whole thing again, and either put both changes in t

Re: [Outreachy kernel] [RESEND PATCH] staging: gasket: Fix line ending with a '('

2019-10-25 Thread Julia Lawall
On Fri, 25 Oct 2019, Cristiane Naves wrote: > Fix line ending with a '(' > > Signed-off-by: Cristiane Naves Acked-by: Julia Lawall > --- > drivers/staging/gasket/gasket_ioctl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/gasket/gasket_ioctl

**SPAM** Please treat as a matter of very urgent importance.

2019-10-25 Thread William Johnson
Please be informed that all the processes for the smooth transfer into your account has been completed hence the payment is ready please confirm the receipt of this message immediately for more details. Regards, William Johnson. -

**SPAM** Please treat as a matter of very urgent importance.

2019-10-25 Thread William Johnson
Please be informed that all the processes for the smooth transfer into your account has been completed hence the payment is ready please confirm the receipt of this message immediately for more details. Regards, William Johnson. -

Re: [RESEND PATCH 1/2] staging: rtl8712: Fix Alignment of open parenthesis

2019-10-25 Thread Joe Perches
On Fri, 2019-10-25 at 22:09 -0300, Cristiane Naves wrote: > Fix alignment should match open parenthesis.Issue found by checkpatch. Beyond doing style cleanups, please always try to make the code more readable. > diff --git a/drivers/staging/rtl8712/rtl8712_recv.c > b/drivers/staging/rtl8712/rtl8

[RESEND PATCH 2/2] staging: rtl8712: Remove lines before a close brace

2019-10-25 Thread Cristiane Naves
Fix Blank lines aren't necessary before a close brace '}'. Issue found by checkpatch. Signed-off-by: Cristiane Naves --- drivers/staging/rtl8712/rtl8712_recv.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rtl8712/rtl8712_recv.c in

[RESEND PATCH 1/2] staging: rtl8712: Fix Alignment of open parenthesis

2019-10-25 Thread Cristiane Naves
Fix alignment should match open parenthesis.Issue found by checkpatch. Signed-off-by: Cristiane Naves --- drivers/staging/rtl8712/rtl8712_recv.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/

[RESEND PATCH 0/2] Cleanup in rtl8712

2019-10-25 Thread Cristiane Naves
Cleanup in rtl8712 Cristiane Naves (2): staging: rtl8712: Fix Alignment of open parenthesis staging: rtl8712: Remove lines before a close brace drivers/staging/rtl8712/rtl8712_recv.c | 32 +++- 1 file changed, 15 insertions(+), 17 deletions(-) -- 2.7.4

[RESEND PATCH] staging: gasket: Fix line ending with a '('

2019-10-25 Thread Cristiane Naves
Fix line ending with a '(' Signed-off-by: Cristiane Naves --- drivers/staging/gasket/gasket_ioctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gasket/gasket_ioctl.c b/drivers/staging/gasket/gasket_ioctl.c index 240f9bb..d1b3e9a 100644 --- a/drivers/s

[RESEND PATCH] staging: gasket: Fix lines ending with a '('

2019-10-25 Thread Cristiane Naves
Fix lines ending with a '('. Issue found by checkpatch. Signed-off-by: Cristiane Naves --- drivers/staging/gasket/gasket_ioctl.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/gasket/gasket_ioctl.c b/drivers/staging/gasket/gasket_ioctl.c index d

Re: [PATCH 1/3] Staging: qlge: Rename prefix of a function to qlge

2019-10-25 Thread Dan Carpenter
On Fri, Oct 25, 2019 at 05:28:42PM +0300, Samuil Ivanov wrote: > Dan you are correct it is a bit of a hodge podge :) > I think that it is better to have a bigger patches that will rename > more functions, but I don't this it is good to have all the > functions renamed in one patch. > > Just in the

Re: [PATCH 1/3] Staging: qlge: Rename prefix of a function to qlge

2019-10-25 Thread Samuil Ivanov
On Fri, Oct 25, 2019 at 01:19:05PM +0300, Dan Carpenter wrote: > On Fri, Oct 25, 2019 at 12:29:39AM +0300, Samuil Ivanov wrote: > > diff --git a/drivers/staging/qlge/qlge.h b/drivers/staging/qlge/qlge.h > > index 6ec7e3ce3863..e9f1363c5bf2 100644 > > --- a/drivers/staging/qlge/qlge.h > > +++ b/driv

Re: [PATCH 1/3] Staging: qlge: Rename prefix of a function to qlge

2019-10-25 Thread Dan Carpenter
On Fri, Oct 25, 2019 at 12:29:39AM +0300, Samuil Ivanov wrote: > diff --git a/drivers/staging/qlge/qlge.h b/drivers/staging/qlge/qlge.h > index 6ec7e3ce3863..e9f1363c5bf2 100644 > --- a/drivers/staging/qlge/qlge.h > +++ b/drivers/staging/qlge/qlge.h > @@ -2262,7 +2262,7 @@ int ql_write_mpi_reg(stru

Re: [PATCH 04/15] staging: exfat: Clean up return codes - FFS_PERMISSIONERR

2019-10-25 Thread Dan Carpenter
On Thu, Oct 24, 2019 at 12:27:47PM -0400, Valdis Klētnieks wrote: > On Thu, 24 Oct 2019 09:23:33 -0700, Joe Perches said: > > On Thu, 2019-10-24 at 11:53 -0400, Valdis Kletnieks wrote: > > > > if (err) { > > > - if (err == FFS_PERMISSIONERR) > > > + if (err == -EPERM) > > >

[PATCH 2/5] staging: wlan-ng: shorten lines over 80 characters in hfa384x.h

2019-10-25 Thread Tim Collier
Shorten several lines reported as over 80 characters by checkpatch.pl. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/hfa384x.h | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index

[PATCH 5/5] staging: wlan-ng: remove unused field from struct hfa384x_usbctlx

2019-10-25 Thread Tim Collier
The variant field in struct hfa384x_usbctlx is not referenced anywhere in the driver, so remove it. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/hfa384x.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 8

[PATCH 4/5] staging: wlan-ng: fix compilation for USB debugging

2019-10-25 Thread Tim Collier
Fix compilation errors (remove references to 2 undefined fields in the URB struct) when DEBUG_USB is defined for the wlan-ng driver. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/hfa384x_usb.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/

[PATCH 0/5] staging: wlang-ng: coding style changes/cleanups

2019-10-25 Thread Tim Collier
Remove unnecessary casts from void* to structure pointer. Fix compilation with DEBUG_USB macro defined. Remove unused field from usb ctlx structure. Formatting changes suggested by checkpatch. Tim Collier (5): staging: wlan-ng: remove unnecessary casts from prism2usb.c staging: wlan-ng: sho

[PATCH 3/5] staging: wlan-ng: correct parameter alignment in hfa384x.h

2019-10-25 Thread Tim Collier
Realign parameter in function declaration to fix checkpatch.pl warning that parameter needed to be aligned with the opening parenthesis of the declaration. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/hfa384x.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 1/5] staging: wlan-ng: remove unnecessary casts from prism2usb.c

2019-10-25 Thread Tim Collier
usb_get_intfdata returns a void pointer. It is not necessary to explicitly cast to the desired type and removing the casts is consistent with most use of usb_get_intfdata. Signed-off-by: Tim Collier --- drivers/staging/wlan-ng/prism2usb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(