On Fri, 2019-10-25 at 22:09 -0300, Cristiane Naves wrote: > Fix alignment should match open parenthesis.Issue found by checkpatch.
Beyond doing style cleanups, please always try to make the code more readable. > diff --git a/drivers/staging/rtl8712/rtl8712_recv.c > b/drivers/staging/rtl8712/rtl8712_recv.c [] > @@ -61,13 +61,13 @@ void r8712_init_recv_priv(struct recv_priv *precvpriv, > precvbuf->ref_cnt = 0; > precvbuf->adapter = padapter; > list_add_tail(&precvbuf->list, > - &(precvpriv->free_recv_buf_queue.queue)); > + &(precvpriv->free_recv_buf_queue.queue)); Please remove the unnecessary parentheses too > precvbuf++; > } > precvpriv->free_recv_buf_queue_cnt = NR_RECVBUFF; > tasklet_init(&precvpriv->recv_tasklet, > - (void(*)(unsigned long))recv_tasklet, > - (unsigned long)padapter); > + (void(*)(unsigned long))recv_tasklet, > + (unsigned long)padapter); It's probably better to change the recv_tasklet function declaration to use the more common style of static void recv_tasklet(unsigned long priv) and do the cast in the recv_tasklet function. _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
