Re: [Outreachy kernel] [PATCH] staging: sm750fb: align arguments with open parenthesis

2019-10-11 Thread Julia Lawall
On Fri, 11 Oct 2019, Gabriela Bittencourt wrote: > Cleans up checks of "Alignment should match open parenthesis" in tree sm750fb > > Signed-off-by: Gabriela Bittencourt > --- > drivers/staging/sm750fb/ddk750_display.c | 2 +- > drivers/staging/sm750fb/sm750_accel.c| 2 +- > drivers/stag

Re: [PATCH] staging: sm750fb: align arguments with open parenthesis

2019-10-11 Thread Joe Perches
On Fri, 2019-10-11 at 22:19 -0300, Gabriela Bittencourt wrote: > Cleans up checks of "Alignment should match open parenthesis" in tree sm750fb [] > diff --git a/drivers/staging/sm750fb/sm750_accel.c > b/drivers/staging/sm750fb/sm750_accel.c [] > @@ -289,7 +289,7 @@ static unsigned int deGetTranspa

[PATCH] staging: sm750fb: align arguments with open parenthesis

2019-10-11 Thread Gabriela Bittencourt
Cleans up checks of "Alignment should match open parenthesis" in tree sm750fb Signed-off-by: Gabriela Bittencourt --- drivers/staging/sm750fb/ddk750_display.c | 2 +- drivers/staging/sm750fb/sm750_accel.c| 2 +- drivers/staging/sm750fb/sm750_accel.h| 8 drivers/staging/sm750f

Re: [Outreachy kernel] [PATCH] staging: vc04_services: fix warnings of lines should not end with open parenthesis

2019-10-11 Thread Joe Perches
On Fri, 2019-10-11 at 23:23 +0200, Julia Lawall wrote: > On Fri, 11 Oct 2019, Jules Irenge wrote: > > Fix warning of lines should not end with open parenthesis. > > Issue detected by checkpatch tool. [] > > diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c > > b/drivers/st

Re: [Outreachy kernel] [PATCH] staging: vc04_services: fix warning of Logical continuations should be on the previous line

2019-10-11 Thread Julia Lawall
On Fri, 11 Oct 2019, Jules Irenge wrote: > Fix warning of logical continuations should be on the previous line. > Issue detected by checkpatch tool. There seem to be several changes mixed together in this patch. Don't have a subject line that is identical to a line in the log message. The sub

[PATCH] staging: vc04_services: fix warning of Logical continuations should be on the previous line

2019-10-11 Thread Jules Irenge
Fix warning of logical continuations should be on the previous line. Issue detected by checkpatch tool. Signed-off-by: Jules Irenge --- .../bcm2835-camera/bcm2835-camera.c | 41 --- 1 file changed, 17 insertions(+), 24 deletions(-) diff --git a/drivers/staging/vc04_ser

Re: [Outreachy kernel] [PATCH] staging: vc04_services: fix warnings of lines should not end with open parenthesis

2019-10-11 Thread Julia Lawall
On Fri, 11 Oct 2019, Jules Irenge wrote: > Fix warning of lines should not end with open parenthesis. > Issue detected by checkpatch tool. > > Signed-off-by: Jules Irenge > --- > .../bcm2835-camera/bcm2835-camera.c | 38 --- > 1 file changed, 16 insertions(+), 22 del

[PATCH] staging: vc04_services: fix warnings of lines should not end with open parenthesis

2019-10-11 Thread Jules Irenge
Fix warning of lines should not end with open parenthesis. Issue detected by checkpatch tool. Signed-off-by: Jules Irenge --- .../bcm2835-camera/bcm2835-camera.c | 38 --- 1 file changed, 16 insertions(+), 22 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2

Re: [PATCH] staging: isdn: remove assignment in if conditionals

2019-10-11 Thread Wambui Karuga
On Fri, Oct 11, 2019 at 02:00:20PM +0300, Dan Carpenter wrote: > This ISDN stuff is going to be deleted soon. Just leave it as is. > > regards, > dan carpenter > Noted, thanks wambui karuga ___ devel mailing list de...@linuxdriverproject.org http://dr

Re: [Outreachy kernel] Re: [PATCH v3 1/4] staging: rtl8723bs: Remove comparisons to NULL in conditionals

2019-10-11 Thread Wambui Karuga
On Fri, Oct 11, 2019 at 02:08:47PM +0200, Greg KH wrote: > On Fri, Oct 11, 2019 at 02:07:17PM +0200, Greg KH wrote: > > On Fri, Oct 11, 2019 at 01:54:04PM +0300, Dan Carpenter wrote: > > > On Thu, Oct 10, 2019 at 04:15:29PM +0300, Wambui Karuga wrote: > > > > psetauthparm = rtw_zmalloc(size

[PATCH v3] staging: wfx: fix potential vulnerability to spectre

2019-10-11 Thread Jerome Pouiller
From: Jérôme Pouiller array_index_nospec() should be applied after a bound check. Fixes: 9bca45f3d692 ("staging: wfx: allow to send 802.11 frames") Reported-by: kbuild test robot Reported-by: Dan Carpenter Signed-off-by: Jérôme Pouiller --- v2: cut down commit-id to 12 characters v3: fix miss

staging: wlan-ng: Checking a kmemdup() call in prism2sta_inf_hostscanresults()

2019-10-11 Thread Markus Elfring
Hello, I have tried another script for the semantic patch language out. This source code analysis approach points out that the implementation of the function “prism2sta_inf_hostscanresults” contains still an unchecked call of the function “kmemdup”. https://git.kernel.org/pub/scm/linux/kernel/git/

Re: [PATCH] staging: wfx: fix potential vulnerability to spectre

2019-10-11 Thread Dan Carpenter
On Fri, Oct 11, 2019 at 12:35:36PM +, Jerome Pouiller wrote: > On Friday 11 October 2019 14:10:35 CEST Greg Kroah-Hartman wrote: > > On Fri, Oct 11, 2019 at 10:15:54AM +, Jerome Pouiller wrote: > > > From: Jérôme Pouiller > > > > > > array_index_nospec() should be applied after a bound che

Re: [PATCH v2 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding

2019-10-11 Thread Laurent Pinchart
Hi Andrzej, On Fri, Oct 11, 2019 at 01:21:43PM +0200, Andrzej Hajda wrote: > On 11.10.2019 04:21, Xin Ji wrote: > > The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed > > for portable device. It converts MIPI to DisplayPort 1.3 4K. > > > > You can add support to your board with bi

Re: [PATCH] staging: wfx: fix potential vulnerability to spectre

2019-10-11 Thread Jerome Pouiller
On Friday 11 October 2019 14:10:35 CEST Greg Kroah-Hartman wrote: > On Fri, Oct 11, 2019 at 10:15:54AM +, Jerome Pouiller wrote: > > From: Jérôme Pouiller > > > > array_index_nospec() should be applied after a bound check. > > > > Fixes: 9bca45f3d6924f19f29c0d019e961af3f41bdc9e ("staging: wfx:

[PATCH v2] staging: wfx: fix potential vulnerability to spectre

2019-10-11 Thread Jerome Pouiller
From: Jérôme Pouiller array_index_nospec() should be applied after a bound check. Fixes: 9bca45f3d692 ("staging: wfx: allow to send 802.11 frames") Reported-by: kbuild test robot Reported-by: Dan Carpenter Signed-off-by: Jérôme Pouiller --- v2: cut down commit-id to 12 characters drivers/st

Re: [PATCH] staging: wfx: fix potential vulnerability to spectre

2019-10-11 Thread Greg Kroah-Hartman
On Fri, Oct 11, 2019 at 10:15:54AM +, Jerome Pouiller wrote: > From: Jérôme Pouiller > > array_index_nospec() should be applied after a bound check. > > Fixes: 9bca45f3d6924f19f29c0d019e961af3f41bdc9e ("staging: wfx: allow to send > 802.11 frames") No need for the full sha1, this should be

Re: [PATCH v3 1/4] staging: rtl8723bs: Remove comparisons to NULL in conditionals

2019-10-11 Thread Greg KH
On Fri, Oct 11, 2019 at 02:07:17PM +0200, Greg KH wrote: > On Fri, Oct 11, 2019 at 01:54:04PM +0300, Dan Carpenter wrote: > > On Thu, Oct 10, 2019 at 04:15:29PM +0300, Wambui Karuga wrote: > > > psetauthparm = rtw_zmalloc(sizeof(struct setauth_parm)); > > > - if (psetauthparm == NULL) { > > > -

Re: [PATCH v3 1/4] staging: rtl8723bs: Remove comparisons to NULL in conditionals

2019-10-11 Thread Greg KH
On Fri, Oct 11, 2019 at 01:54:04PM +0300, Dan Carpenter wrote: > On Thu, Oct 10, 2019 at 04:15:29PM +0300, Wambui Karuga wrote: > > psetauthparm = rtw_zmalloc(sizeof(struct setauth_parm)); > > - if (psetauthparm == NULL) { > > - kfree(pcmd); > > + if (!psetauthparm) { > > +

[PATCH] staging: fbtft: fbtft-core: Fix last line displayed on fbcon

2019-10-11 Thread Alexandru Ardelean
From: Michael Hennerich For the special case when fbtft_mkdirty() is called with with -1 for the y coordinate, the height is truncated by 1. This isn't required, and causes the last line to not update. Signed-off-by: Michael Hennerich Signed-off-by: Alexandru Ardelean --- drivers/staging/fbt

Re: [PATCH v2 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding

2019-10-11 Thread Andrzej Hajda
On 11.10.2019 04:21, Xin Ji wrote: > The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed > for portable device. It converts MIPI to DisplayPort 1.3 4K. > > You can add support to your board with binding. > > Example: > anx7625_bridge: encoder@58 { > compatible =

Re: [PATCH] staging: isdn: remove assignment in if conditionals

2019-10-11 Thread Dan Carpenter
This ISDN stuff is going to be deleted soon. Just leave it as is. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [Outreachy kernel] [PATCH 1/5] staging: octeon: remove typedef declaration for cvmx_wqe_t

2019-10-11 Thread Dan Carpenter
On Fri, Oct 11, 2019 at 11:59:52AM +0300, Wambui Karuga wrote: > On Fri, Oct 11, 2019 at 08:18:25AM +0200, Julia Lawall wrote: > > > > > > On Fri, 11 Oct 2019, Wambui Karuga wrote: > > > > > Remove typedef declaration from struct cvmx_wqe_t in > > > > You can remove the _t from the name as well

Re: [PATCH v3 1/4] staging: rtl8723bs: Remove comparisons to NULL in conditionals

2019-10-11 Thread Dan Carpenter
On Thu, Oct 10, 2019 at 04:15:29PM +0300, Wambui Karuga wrote: > psetauthparm = rtw_zmalloc(sizeof(struct setauth_parm)); > - if (psetauthparm == NULL) { > - kfree(pcmd); > + if (!psetauthparm) { > + kfree((unsigned char *)pcmd); This new cast is unnecessary a

Re: [PATCH v2 0/2] Add initial support for slimport anx7625

2019-10-11 Thread Dan Carpenter
On Fri, Oct 11, 2019 at 02:20:47AM +, Xin Ji wrote: > Hi all, > > The following series add initial support for the Slimport ANX7625 > transmitter, a > ultra-low power Full-HD 4K MIPI to DP transmitter designed for portable > device. > > This is the initial version, any mistakes, please let

[PATCH] staging: wfx: fix error handling in wfx_tx_get_raw_link_id()

2019-10-11 Thread Jerome Pouiller
From: Jérôme Pouiller Since wfx_tx_get_raw_link_id() return an unsigned, it makes no sense to return a negative value. "15" is a better value since it is used by firmware for stations that have not yet associated link-ids. Note that this should never happens since driver set max_ap_assoc_sta to

[PATCH] staging: wfx: fix potential vulnerability to spectre

2019-10-11 Thread Jerome Pouiller
From: Jérôme Pouiller array_index_nospec() should be applied after a bound check. Fixes: 9bca45f3d6924f19f29c0d019e961af3f41bdc9e ("staging: wfx: allow to send 802.11 frames") Reported-by: kbuild test robot Reported-by: Dan Carpenter Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/wf

Re: [PATCH] KPC2000: kpc2000_spi.c: Fix style issues (line length)

2019-10-11 Thread Dan Carpenter
On Thu, Oct 10, 2019 at 02:54:59PM +, Matt Sickler wrote: > > static struct mtd_partition p2kr0_spi1_parts[] = { > >- { .name = "SLOT_4", .size = 7798784,.offset = 0, > > }, > >- { .name = "SLOT_5", .size = 7798784,.offset = >

Re: [PATCH 2/5] staging: octeon: remove typedef declaration for cvmx_helper_link_info_t

2019-10-11 Thread Wambui Karuga
On Fri, Oct 11, 2019 at 11:02:13AM +0200, Greg KH wrote: > On Fri, Oct 11, 2019 at 09:02:39AM +0300, Wambui Karuga wrote: > > -typedef union { > > +union cvmx_helper_link_info_t { > > I agree with Julia, all of the "_t" needs to be dropped as that is > pointless. It's a holdover from the original

Re: [PATCH 0/5] Remove declarations of new typedef in

2019-10-11 Thread Wambui Karuga
On Fri, Oct 11, 2019 at 11:01:00AM +0200, Greg KH wrote: > On Fri, Oct 11, 2019 at 09:02:37AM +0300, Wambui Karuga wrote: > > This patchset removes various typedef declarations of new data types > > in drivers/staging/octeon/octeon-stubs.h. > > The series also changes their old uses with the new de

Re: [PATCH 2/5] KPC2000: kpc2000_spi.c: Fix style issues (missing blank line)

2019-10-11 Thread Greg KH
A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Fri, Oct 11, 2019 at 02:

Re: [PATCH 2/5] staging: octeon: remove typedef declaration for cvmx_helper_link_info_t

2019-10-11 Thread Greg KH
On Fri, Oct 11, 2019 at 09:02:39AM +0300, Wambui Karuga wrote: > -typedef union { > +union cvmx_helper_link_info_t { I agree with Julia, all of the "_t" needs to be dropped as that is pointless. It's a holdover from the original name where "_t" was trying to say that this is a typedef. Gotta lov

Re: [PATCH 0/5] Remove declarations of new typedef in

2019-10-11 Thread Greg KH
On Fri, Oct 11, 2019 at 09:02:37AM +0300, Wambui Karuga wrote: > This patchset removes various typedef declarations of new data types > in drivers/staging/octeon/octeon-stubs.h. > The series also changes their old uses with the new declaration > format. The subject line of this email seems to be l

Re: [Outreachy kernel] [PATCH 1/5] staging: octeon: remove typedef declaration for cvmx_wqe_t

2019-10-11 Thread Wambui Karuga
On Fri, Oct 11, 2019 at 08:18:25AM +0200, Julia Lawall wrote: > > > On Fri, 11 Oct 2019, Wambui Karuga wrote: > > > Remove typedef declaration from struct cvmx_wqe_t in > > You can remove the _t from the name as well. Should I remove the _t from all the enums/structs? > > > drivers/staging/oct

Re: [PATCH v2 0/2] Add initial support for slimport anx7625

2019-10-11 Thread Xin Ji
Hi Andrzej, OK, I'll increment patchset version number next time. Thanks, Xin On Fri, Oct 11, 2019 at 08:12:53AM +0200, Andrzej Hajda wrote: > On 11.10.2019 04:20, Xin Ji wrote: > > Hi all, > > > > The following series add initial support for the Slimport ANX7625 > > transmitter, a > > ultra-low

[PATCH] staging: isdn: remove assignment in if conditionals

2019-10-11 Thread Wambui Karuga
Remove variable assignment in if statements in drivers/staging/isdn/avm/b1.c. Issues reported by checkpatch.pl as: ERROR: do not use assignment in if condition Also refactor code around some if statements to remove comparisons to NULL and unnecessary braces in single statement blocks. Signed-off-