On Fri, 2019-10-11 at 23:23 +0200, Julia Lawall wrote:
> On Fri, 11 Oct 2019, Jules Irenge wrote:
> > Fix warning of lines should not end with open parenthesis.
> > Issue detected by checkpatch tool.
[]
> > diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c
> > b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c
[]
> > @@ -337,9 +337,8 @@ static void buffer_cb(struct vchiq_mmal_instance
> > *instance,
> > if (is_capturing(dev)) {
> > v4l2_dbg(1, bcm2835_v4l2_debug, &dev->v4l2_dev,
> > "Grab another frame");
> > - vchiq_mmal_port_parameter_set(
> > - instance,
> > - dev->capture.camera_port,
> > + vchiq_mmal_port_parameter_set(instance,
> > + dev->capture.camera_port,
> > MMAL_PARAMETER_CAPTURE,
> > &dev->capture.frame_count,
> > sizeof(dev->capture.frame_count));
>
> You can't reduce the indentation on the function call. It has to stay
> clearly in the if branch.
>
> If you adjust the indentation of some of the arguments, you have to do so
> to all of the arguments.
>
> Similar issues arise below. There may be no way to make some of the calls
> look nice without a more severe reorganization of the code.
My suggestion would be to shorten the vchiq_mmal_port_parameter_set
function name (29 chars is just too long) and pass dev instead of
dev->instance as the first argument to this function.
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
