Re: [PATCH 0/4] staging: mt7621-pci: Use gpio perst instead builtin behaviour

2019-06-19 Thread Sergio Paracuellos
Hi Greg, On Thu, Jun 20, 2019 at 2:40 AM Greg Ungerer wrote: > > Hi Sergio, > > On 19/6/19 5:44 pm, Sergio Paracuellos wrote: > > Some boards seems to ignore builtin perst configuration and use gpio > > instead. This approach seems to be more common. Hence, update the driver > > to properly use g

[PATCH] staging: rtl8723bs: hal: hal_btcoex: Remove variables pHalData and pU1Tmp

2019-06-19 Thread Hariprasad Kelam
Remove pHalData variable as it is set but unused in function. Remove pU1Tmp and replace this with pu8 Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/ha

Re: [PATCH v3 0/7] Hexdump Enhancements

2019-06-19 Thread Joe Perches
On Thu, 2019-06-20 at 11:14 +1000, Alastair D'Silva wrote: > On Wed, 2019-06-19 at 17:35 -0700, Joe Perches wrote: > > On Thu, 2019-06-20 at 09:15 +1000, Alastair D'Silva wrote: > > > On Wed, 2019-06-19 at 09:31 -0700, Joe Perches wrote: > > > > On Mon, 2019-06-17 at 12:04 +1000, Alastair D'Silva w

Re: [PATCH v3 0/7] Hexdump Enhancements

2019-06-19 Thread Alastair D'Silva
On Wed, 2019-06-19 at 17:35 -0700, Joe Perches wrote: > On Thu, 2019-06-20 at 09:15 +1000, Alastair D'Silva wrote: > > On Wed, 2019-06-19 at 09:31 -0700, Joe Perches wrote: > > > On Mon, 2019-06-17 at 12:04 +1000, Alastair D'Silva wrote: > > > > From: Alastair D'Silva > > > > > > > > Apologies fo

Re: [PATCH v3 0/7] Hexdump Enhancements

2019-06-19 Thread Joe Perches
On Thu, 2019-06-20 at 09:15 +1000, Alastair D'Silva wrote: > On Wed, 2019-06-19 at 09:31 -0700, Joe Perches wrote: > > On Mon, 2019-06-17 at 12:04 +1000, Alastair D'Silva wrote: > > > From: Alastair D'Silva > > > > > > Apologies for the large CC list, it's a heads up for those > > > responsible >

Re: [PATCH 0/4] staging: mt7621-pci: Use gpio perst instead builtin behaviour

2019-06-19 Thread Greg Ungerer
Hi Sergio, On 19/6/19 5:44 pm, Sergio Paracuellos wrote: Some boards seems to ignore builtin perst configuration and use gpio instead. This approach seems to be more common. Hence, update the driver to properly use gpio perst via gpio descriptor's API. For more information refer to [1]. Even w

Re: [PATCH v3 0/7] Hexdump Enhancements

2019-06-19 Thread Alastair D'Silva
On Wed, 2019-06-19 at 09:31 -0700, Joe Perches wrote: > On Mon, 2019-06-17 at 12:04 +1000, Alastair D'Silva wrote: > > From: Alastair D'Silva > > > > Apologies for the large CC list, it's a heads up for those > > responsible > > for subsystems where a prototype change in generic code causes a > >

Re: [PATCH V5 00/16] use sg helper to operate scatterlist

2019-06-19 Thread Martin K. Petersen
Bart, > Do you perhaps plan to push out these patches at a later time? It > seems like that branch has not been updated recently: I had a test failure on this end, that's why I didn't push. Appears to be hardware-related, though. Still looking into it. -- Martin K. Petersen Oracle Linux

Re: [PATCH V5 00/16] use sg helper to operate scatterlist

2019-06-19 Thread Bart Van Assche
On 6/18/19 5:29 PM, Martin K. Petersen wrote: I applied this series with a bunch of edits and clarifying comments. It was quite the nightmare to rebase 5.3/scsi-queue to satisfy the ordering requirements, locate the scattered fixes, tweak tags, etc. Hope I got everything right. Hi Martin, Do y

[PATCH] staging: rtl8723bs: HalBtc8723b1Ant: fix Using comparison to true is error prone

2019-06-19 Thread Hariprasad Kelam
This patch fixes below issue reported by checkpatch CHECK: Using comparison to true is error prone CHECK: Using comparison to false is error prone Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) d

[PATCH] staging: vt6656: fix indentation on break statement

2019-06-19 Thread Colin King
From: Colin Ian King The break statement is indented one level too deep, fix this. Signed-off-by: Colin Ian King --- drivers/staging/vt6656/card.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6656/card.c b/drivers/staging/vt6656/card.c index 08fc03d8740

[PATCH] staging: rtl8723bs: os_dep: fix indentation on break statement

2019-06-19 Thread Colin King
From: Colin Ian King The break statement is indented one level too deep, fix this. Signed-off-by: Colin Ian King --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/stag

Re: [PATCH v3 0/7] Hexdump Enhancements

2019-06-19 Thread Joe Perches
On Mon, 2019-06-17 at 12:04 +1000, Alastair D'Silva wrote: > From: Alastair D'Silva > > Apologies for the large CC list, it's a heads up for those responsible > for subsystems where a prototype change in generic code causes a change > in those subsystems. > > This series enhances hexdump. Still

Re: use exact allocation for dma coherent memory

2019-06-19 Thread Jason Gunthorpe
On Mon, Jun 17, 2019 at 10:33:42AM +0200, Christoph Hellwig wrote: > > drivers/infiniband/hw/cxgb4/qp.c > >129 static int alloc_host_sq(struct c4iw_rdev *rdev, struct t4_sq *sq) > >130 { > >131 sq->queue = dma_alloc_coherent(&(rdev->lldi.pdev->dev), > > sq->memsize, > >1

[PATCH 3/4] rts5208: Fix usleep_range is preferred over udelay

2019-06-19 Thread Lukas Schneider
This patch fixes the issue reported by checkpatch: CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt It's save to sleep here instead of using busy waiting, because we are not in an atomic context. Signed-off-by: Lukas Schneider Signed-off-by: Jannik Moritz

[PATCH 4/4] rts5208: Fix usleep range is preferred over udelay

2019-06-19 Thread Lukas Schneider
This patch fixes the issue reported by checkpatch: CHECK: usleep_range is preferred over udelay; see Doucmentation/timers/timers-howto.txt It's save to sleep here instead of using busy waiting, because we are not in an atomic context. Signed-off-by: Lukas Schneider Signed-off-by: Jannik Moritz

[PATCH 2/4] rts5208: Fix usleep_range is preferred over udelay

2019-06-19 Thread Lukas Schneider
This patch fixes the issue reported by checkpatch: CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt It's save to sleep here instead of using busy waiting, because we are not in an atomic context. Signed-off-by: Lukas Schneider Signed-off-by: Jannik Moritz

[PATCH 1/4] rts5208: Fix usleep_range is preferred over udelay

2019-06-19 Thread Lukas Schneider
This patch fixes the issue reported by checkpatch: CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt It's save to sleep here instead of using busy waiting, because we are not in an atomic context. Signed-off-by: Lukas Schneider Signed-off-by: Jannik Moritz

[PATCH] staging: rtl8188eu: remove unused code

2019-06-19 Thread Michael Straube
Remove unused and/or commented code from rtw_wlan_util.c. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c b/drivers/staging/rtl8188eu/core/rtw_wlan_util.c in

[PATCH 2/4] staging: mt7621-pci: use gpio perst instead of builtin behaviour

2019-06-19 Thread Sergio Paracuellos
Some boards seems to ignore the PERST builtin behaviour to properly perform a pcie line reset. Use gpio PERST behaviour instead which seems to be more common. Fixes: bd1a05bd87ad ("staging: mt7621-pci: use PERST_N instead of gpio control") Signed-off-by: Sergio Paracuellos --- drivers/staging/mt

[PATCH 1/4] staging: mt7621-pci: fix two messages in driver code

2019-06-19 Thread Sergio Paracuellos
There are two messages in driver code which are not correct. Fix both of them to clarify boot runs. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-pci/pci-mt7621.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c b/dri

[PATCH 3/4] staging: mt7621-dts: add gpio perst to pcie bindings node

2019-06-19 Thread Sergio Paracuellos
Driver has been changed to use perts gpio reset instead of perst builtin behaviour. Update device tree accordly. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-dts/mt7621.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/mt7621-dts/mt7621.dtsi b/drivers/st

[PATCH 0/4] staging: mt7621-pci: Use gpio perst instead builtin behaviour

2019-06-19 Thread Sergio Paracuellos
Some boards seems to ignore builtin perst configuration and use gpio instead. This approach seems to be more common. Hence, update the driver to properly use gpio perst via gpio descriptor's API. For more information refer to [1]. Even with this set of patches applied, there still seems to have s

[PATCH 4/4] staging: mt7621-pci: dt-bindings: add perst-gpio to sample bindings

2019-06-19 Thread Sergio Paracuellos
Both driver and device tree have been updated to use GPIO perst. Update bindings documentation also. Signed-off-by: Sergio Paracuellos --- drivers/staging/mt7621-pci/mediatek,mt7621-pci.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/mt7621-pci/mediatek,mt7621-pci.txt

[PATCH] staging: rts5208: Remove function soft_reset_sd_card()

2019-06-19 Thread Nishka Dasgupta
Remove function soft_reset_sd_card, as all it does is call reset_sd. Modify call sites of the former to call the latter instead. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/staging/rts5208/sd.c | 7 +-- drivers/staging/rts5208/sd.h | 1 - 2 files changed, 1 insert