Re: [PATCH] staging: Note that simple_strtoul can't simply be replaced by kstrtoul

2019-02-23 Thread Greg KH
On Sat, Feb 23, 2019 at 08:42:19PM +0100, Samuel Thibault wrote: > We often receive patches which erroneously try to use kstrtoul in these > places. > > Signed-off-by: Samuel Thibault Awe, it's fun to try to see people do this and not really think about the consequences :) Anyway, seriously, th

[PATCH AUTOSEL 4.4 04/26] IB/{hfi1, qib}: Fix WC.byte_len calculation for UD_SEND_WITH_IMM

2019-02-23 Thread Sasha Levin
From: Brian Welty [ Upstream commit 904bba211acc2112fdf866e5a2bc6cd9ecd0de1b ] The work completion length for a receiving a UD send with immediate is short by 4 bytes causing application using this opcode to fail. The UD receive logic incorrectly subtracts 4 bytes for immediate value. These byt

Re: [PATCH] staging : speakup: replace ---help--- with help in Kconfig

2019-02-23 Thread Samuel Thibault
Hello, and thanks for your patch, Bharath Vedartham, le dim. 24 févr. 2019 01:51:17 +0530, a ecrit: > @@ -148,7 +148,7 @@ config SPEAKUP_SYNTH_KEYPC > > config SPEAKUP_SYNTH_LTLK > tristate "DoubleTalk LT/LiteTalk synthesizer support" > help--- > +help I'd say while at it, align it w

[PATCH] staging : speakup: replace ---help--- with help in Kconfig

2019-02-23 Thread Bharath Vedartham
Fix the checkpatch.pl warning to replace ---help--- with help in Kconfig. Signed-off-by: Bharath Vedartham --- drivers/staging/speakup/Kconfig | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/staging/speakup/Kconfig b/drivers/staging/

Re: [PATCH] staging: speakup: Replace simple_strtoul with kstrtoul

2019-02-23 Thread Bharath Vedartham
On Sat, Feb 23, 2019 at 08:37:50PM +0100, Samuel Thibault wrote: > Bharath Vedartham, le dim. 24 févr. 2019 01:01:21 +0530, a ecrit: > > simple_strtoul is obsolete. Change it to kstrtoul. Kernel is building > > and booting successfully. > > Please recheck your patch, temp is used after the simple_

Re: [PATCH] staging: speakup: Replace simple_strtoul with kstrtoul

2019-02-23 Thread Samuel Thibault
Bharath Vedartham, le dim. 24 févr. 2019 01:01:21 +0530, a ecrit: > simple_strtoul is obsolete. Change it to kstrtoul. Kernel is building > and booting successfully. Please recheck your patch, temp is used after the simple_strtoul call. Samuel ___ devel

[PATCH] staging: Note that simple_strtoul can't simply be replaced by kstrtoul

2019-02-23 Thread Samuel Thibault
We often receive patches which erroneously try to use kstrtoul in these places. Signed-off-by: Samuel Thibault --- drivers/staging/speakup/kobjects.c|2 ++ drivers/staging/speakup/main.c|1 + drivers/staging/speakup/varhandlers.c |1 + 3 files changed, 4 insertions(+) --

[PATCH] staging: speakup: Replace simple_strtoul with kstrtoul

2019-02-23 Thread Bharath Vedartham
simple_strtoul is obsolete. Change it to kstrtoul. Kernel is building and booting successfully. Signed-off-by: Bharath Vedartham --- drivers/staging/speakup/kobjects.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/spe

Re: [PATCH V3 00/10] X86/KVM/Hyper-V: Add HV ept tlb range list flush support in KVM

2019-02-23 Thread Tianyu Lan
On Sat, Feb 23, 2019 at 2:26 AM Paolo Bonzini wrote: > > On 22/02/19 16:06, lantianyu1...@gmail.com wrote: > > From: Lan Tianyu > > > > This patchset is to introduce hv ept tlb range list flush function > > support in the KVM MMU component. Flushing ept tlbs of several address > > range can be do

Re: [PATCH] x86/Hyper-V: Fix definition HV_MAX_FLUSH_REP_COUNT

2019-02-23 Thread Tianyu Lan
On Fri, Feb 22, 2019 at 10:32 PM Greg KH wrote: > > On Fri, Feb 22, 2019 at 06:48:44PM +0800, lantianyu1...@gmail.com wrote: > > From: Lan Tianyu > > > > The max flush rep count of HvFlushGuestPhysicalAddressList hypercall > > is equal with how many entries of union hv_gpa_page_range can be popul

Re: [PATCH net-next 4/8] mlxsw: spectrum_switchdev: Handle SWITCHDEV_PORT_ATTR_SET

2019-02-23 Thread Ido Schimmel
On Fri, Feb 22, 2019 at 03:59:22PM -0800, Florian Fainelli wrote: > Following patches will change the way we communicate setting a port's > attribute and use a notifier to perform those tasks. > > Prepare mlxsw to support receiving notifier events targeting > SWITCHDEV_PORT_ATTR_SET and utilize th

Re: [PATCH net-next 1/8] switchdev: Add SWITCHDEV_PORT_ATTR_SET

2019-02-23 Thread Ido Schimmel
On Fri, Feb 22, 2019 at 03:59:19PM -0800, Florian Fainelli wrote: > In preparation for allowing switchdev enabled drivers to veto specific > attribute settings from within the context of the caller, introduce a > new switchdev notifier type for port attributes. > > Suggested-by: Ido Schimmel > Si

Re: [PATCH net-next 7/8] net: switchdev: Replace port attr set SDO with a notification

2019-02-23 Thread Ido Schimmel
On Fri, Feb 22, 2019 at 03:59:25PM -0800, Florian Fainelli wrote: > Drop switchdev_ops.switchdev_port_attr_set. Drop the uses of this field > from all clients, which were migrated to use switchdev notification in > the previous patches. > > Add a new function switchdev_port_attr_notify() that send

RE: [PATCH net] staging: fsl-dpaa2: ethsw: Add missing netdevice check

2019-02-23 Thread Ioana Ciornei
> Subject: [PATCH net] staging: fsl-dpaa2: ethsw: Add missing netdevice check > > port_switchdev_event() does not check that the target network device is > actually backed by the ethsw driver, this could be problematic in a stacked > environment case. > Just FYI, I sent a patch set containing

Re: [PATCH] staging/ks7070: Removed unused varibale

2019-02-23 Thread Greg KH
On Sat, Feb 23, 2019 at 03:09:42AM -0500, YU Bo wrote: > On Sat, Feb 23, 2019 at 08:43:20AM +0100, Greg KH wrote: > > On Sat, Feb 23, 2019 at 01:39:39AM -0500, Bo YU wrote: > > > From: Bo Yu > > > > > > Compiling the kernel with W=1 results in the following warning: > > > > > > drivers/staging/k

Re: [PATCH] staging/ks7070: Removed unused varibale

2019-02-23 Thread YU Bo
On Sat, Feb 23, 2019 at 08:43:20AM +0100, Greg KH wrote: On Sat, Feb 23, 2019 at 01:39:39AM -0500, Bo YU wrote: From: Bo Yu Compiling the kernel with W=1 results in the following warning: drivers/staging/ks7010/ks_hostif.c:465:6: warning: variable ‘mib_val_type’ set but not used [-Wunused-but

Re: [PATCH v4] staging: nrf24: add new driver for 2.4GHz radio transceiver

2019-02-23 Thread Greg Kroah-Hartman
On Fri, Feb 22, 2019 at 09:20:56PM +0100, Marcin Ciupak wrote: > On Tue, Feb 19, 2019 at 11:20:10AM +0100, Greg Kroah-Hartman wrote: > > On Wed, Feb 13, 2019 at 08:40:35PM +0100, Marcin Ciupak wrote: > > > This patch adds driver for Nordic Semiconductor nRF24L01+ radio > > > transceiver. > > > > >