We often receive patches which erroneously try to use kstrtoul in these
places.

Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org>
---
 drivers/staging/speakup/kobjects.c    |    2 ++
 drivers/staging/speakup/main.c        |    1 +
 drivers/staging/speakup/varhandlers.c |    1 +
 3 files changed, 4 insertions(+)

--- a/drivers/staging/speakup/kobjects.c
+++ b/drivers/staging/speakup/kobjects.c
@@ -154,6 +154,7 @@ static ssize_t chars_chartab_store(struc
                        continue;
                }
 
+               /* Do not replace with kstrtoul: here we need temp to be 
updated */
                index = simple_strtoul(cp, &temp, 10);
                if (index > 255) {
                        rejected++;
@@ -787,6 +788,7 @@ static ssize_t message_store_helper(cons
                        continue;
                }
 
+               /* Do not replace with kstrtoul: here we need temp to be 
updated */
                index = simple_strtoul(cp, &temp, 10);
 
                while ((temp < linefeed) && (*temp == ' ' || *temp == '\t'))
--- a/drivers/staging/speakup/main.c
+++ b/drivers/staging/speakup/main.c
@@ -1979,6 +1979,7 @@ oops:
                return 1;
        }
 
+       /* Do not replace with kstrtoul: here we need cp to be updated */
        goto_pos = simple_strtoul(goto_buf, &cp, 10);
 
        if (*cp == 'x') {
--- a/drivers/staging/speakup/varhandlers.c
+++ b/drivers/staging/speakup/varhandlers.c
@@ -328,6 +328,7 @@ char *spk_s2uchar(char *start, char *des
 {
        int val;
 
+       /* Do not replace with kstrtoul: here we need start to be updated */
        val = simple_strtoul(skip_spaces(start), &start, 10);
        if (*start == ',')
                start++;
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to