Thank you for your review Larry
> Before you send V3
Oh, v3 was already sent a few moments before your message.
> Before you send V3, are you sure this is the correct fix? As "frame_type" is
> input as u16, it seems to me that the frame_type member of struct
> wilc_reg_frame
> should be __le16,
We see you have photos for editing, please send us more details we will
start to work on it.
We are professional of image editing, such as clipping path, and
retouching.
You can send us 1 or 2 photos, we will do test editing for you.
Thanks,
Benny
__
On Sat, Jan 05, 2019 at 05:20:37PM +, Jonathan Cameron wrote:
> +CC Jeremy who is also working with this device.
>
> On Sun, 23 Dec 2018 19:32:24 +0530
> Shreeya Patel wrote:
>
> > Both i2c and spi drivers have functions for reading and writing
> > to/from registers. Remove this redundant an
From: Kimberly Brown Sent: Friday, January 4, 2019 8:35
PM
> static inline void set_channel_pending_send_size(struct vmbus_channel *c,
>u32 size)
> {
> + if (size) {
> + ++c->out_full_total;
> +
> + if (!c->out_full_f
On Sat, 22 Dec 2018 21:58:25 -0500
indigo omega wrote:
> Hello Jonathan,
>
> I'd be happy to help cleanup this driver, and I'd greatly appreciate some
> direction as to what needs to be done.
>
> Thank you,
>
> Amir Ghorbanian
Sure, I'll give the current state a quick review...
Major items
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
fi_cleanup
head: 7fde561511499c5543938f8b9a86887f4b156730
commit: 7fde561511499c5543938f8b9a86887f4b156730 [1/1] fault_inject: clean up
fault_create_debugfs_attr
config: x86_64-randconfig-x013-201901 (attached as .co
On Sat, 22 Dec 2018 21:57:43 -0700
Jeremy Fertic wrote:
> The lsb calculation is not masking the correct bits from the user input.
> Subtract 1 from (1 << offset) to correctly set up the mask to be applied
> to user input.
>
> The lsb register stores its value starting at the bit 7 position.
> a
On Sat, 22 Dec 2018 21:57:42 -0700
Jeremy Fertic wrote:
> The calculation of the current dac value is using the wrong bits of the
> dac lsb register. Create two macros to shift the lsb register value into
> lsb position, depending on whether the dac is 10 or 12 bit. Initialize
> data to 0 so, wit
On Sat, 22 Dec 2018 21:57:41 -0700
Jeremy Fertic wrote:
> The adt7316/7 and adt7516/7 have the option to output voltage proportional
> to temperature on dac a and/or dac b. The default dac resolution in this
> mode is 8 bits with the dac high resolution option enabling 10 bits. None
> of these se
+ CC Shreeya who is working on the same driver.
On Sat, 22 Dec 2018 21:57:40 -0700
Jeremy Fertic wrote:
> The value of dac_bits is used in adt7316_show_DAC() and adt7316_store_DAC(),
> and it should be either 8, 10, or 12 bits depending on the device in use. The
> driver currently only assigns a
+CC Jeremy who is also working with this device.
On Sun, 23 Dec 2018 19:32:24 +0530
Shreeya Patel wrote:
> Both i2c and spi drivers have functions for reading and writing
> to/from registers. Remove this redundant and common code by using
> regmap API.
> Also remove multi_read and multi_write fu
On 1/5/19 3:10 AM, Július Milan wrote:
Fixes the following sparse warnings:
drivers/staging/wilc1000/host_interface.c:2360:30: warning:
incorrect type in assignment (different base types)
expected restricted __le32 [addressable] [assigned] [usertype] frame_type
got restricted __le16
In sd_execute_write_data, the rtsx_send_cmd could fail with ETIMEDOUT
or EIO. The fix adds a check to handle these failures.
Signed-off-by: Aditya Pakki
---
drivers/staging/rts5208/sd.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rts5208/sd.c b/drive
Fixes the following sparse warnings:
drivers/staging/wilc1000/host_interface.c:2360:30: warning:
incorrect type in assignment (different base types)
expected restricted __le32 [addressable] [assigned] [usertype] frame_type
got restricted __le16 [usertype]
Fixes: 147ccfd451024 ("staging:
On Sat, Jan 05, 2019 at 10:10:25AM +0100, Július Milan wrote:
> Fixes the following sparse warnings:
>
> drivers/staging/wilc1000/host_interface.c:2360:30: warning:
> incorrect type in assignment (different base types)
> expected restricted __le32 [addressable] [assigned] [usertype] frame_typ
Fixes the following sparse warnings:
drivers/staging/wilc1000/host_interface.c:2360:30: warning:
incorrect type in assignment (different base types)
expected restricted __le32 [addressable] [assigned] [usertype] frame_type
got restricted __le16 [usertype]
Fixes: 147ccfd451024 ("staging:
On Sat, Jan 05, 2019 at 09:32:56AM +0100, Július Milan wrote:
> sorry, bad mail, see the next one please
Properly version your patches so I know what "next one" really means.
I've dropped all of these patches from my queue now, please resend with
a v2 added to the patch as the documentation says
Fixes the following sparse warnings:
drivers/staging/wilc1000/host_interface.c:2360:30: warning:
incorrect type in assignment (different base types)
expected restricted __le32 [addressable] [assigned] [usertype] frame_type
got restricted __le16 [usertype]
Fixes: 147ccfd451024 ("staging:
Fixes the following sparse warnings:
drivers/staging/wilc1000/host_interface.c:2360:30: warning:
incorrect type in assignment (different base types)
expected restricted __le32 [addressable] [assigned] [usertype] frame_type
got restricted __le16 [usertype]
Fixes: 147ccfd451024 ("staging:
19 matches
Mail list logo
