From: Ajay Singh
Added NULL check before accessing 'hidden_net' pointer inside
wilc_scan() to fix the issue found by static code checker.
Fixes: 8f1a0ac1eba7 ("staging: wilc1000: handle scan operation callback from
cfg80211 context")
Reported-by: Dan Carpenter
Signed-off-by: Ajay Singh
---
d
44d8047f1d8 ("binder: use standard functions to allocate fds")
exposed a pre-existing issue in the binder driver.
fdget() is used in ksys_ioctl() as a performance optimization.
One of the rules associated with fdget() is that ksys_close() must
not be called between the fdget() and the fdput(). The
The function ipu_csi_init_interface() was inverting the F-bit for
NTSC case, in the CCIR_CODE_1/2 registers. The result being that
for NTSC bottom-top field order, the CSI would swap fields and
capture in top-bottom order.
Instead, base field swap on the field order of the input to the CSI,
and th
On 12/13/18 4:59 AM, Philipp Zabel wrote:
Hi Steve,
On Tue, 2018-10-16 at 17:00 -0700, Steve Longerbeam wrote:
The function ipu_csi_init_interface() was inverting the F-bit for
NTSC case, in the CCIR_CODE_1/2 registers. The result being that
for NTSC bottom-top field order, the CSI would swa
On Fri, Dec 14, 2018 at 12:38:15PM -0800, Todd Kjos wrote:
> 44d8047f1d8 ("binder: use standard functions to allocate fds")
> exposed a pre-existing issue in the binder driver.
>
> fdget() is used in ksys_ioctl() as a performance optimization.
> One of the rules associated with fdget() is that ksy
From: Lubomir Rintel
Commit 33f49571d75024b1044cd02689ad2bdb4924cc80 upstream.
WARNING: unmet direct dependencies detected for BACKLIGHT_CLASS_DEVICE
Depends on [n]: HAS_IOMEM [=y] && BACKLIGHT_LCD_SUPPORT [=n]
Selected by [y]:
- FB_OLPC_DCON [=y] && STAGING [=y] && X86 [=y] && OLP
On Fri, Dec 14, 2018 at 09:26:18AM +0300, Dan Carpenter wrote:
> On Thu, Dec 13, 2018 at 03:01:46PM -0700, Jeremy Fertic wrote:
> > On Wed, Dec 12, 2018 at 11:23:16AM +0300, Dan Carpenter wrote:
> > > On Tue, Dec 11, 2018 at 05:54:56PM -0700, Jeremy Fertic wrote:
> > > > @@ -651,10 +649,12 @@ stati
44d8047f1d8 ("binder: use standard functions to allocate fds")
exposed a pre-existing issue in the binder driver.
fdget() is used in ksys_ioctl() as a performance optimization.
One of the rules associated with fdget() is that ksys_close() must
not be called between the fdget() and the fdput(). The
From: kbuild test robot
drivers/staging/most/sound/sound.c:673:21-27: ERROR: application of sizeof to
pointer
sizeof when applied to a pointer typed expression gives the size of
the pointer
Generated by: scripts/coccinelle/misc/noderef.cocci
Fixes: 58bce1efd0e8 ("staging: most: sound: renam
Hi Christian,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on staging/staging-testing]
[also build test WARNING on v4.20-rc6 next-20181214]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https
As discussed at Linux Plumbers Conference 2018 in Vancouver [1] this is the
implementation of binderfs.
/* Abstract */
binderfs is a backwards-compatible filesystem for Android's binder ipc
mechanism. Each ipc namespace will mount a new binderfs instance. Mounting
binderfs multiple times at differ
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../interface/vchiq_arm/vchiq_2835_arm.c| 5 +++--
.../vc04_services/interface/vchiq_arm/vchiq_arm.c | 4 ++--
.../vc04_services/interface/vchiq_arm/vchiq_core.c |
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../vc04_services/interface/vchiq_arm/vchiq_core.c| 11 ++-
.../vc04_services/interface/vchiq_arm/vchiq_core.h| 10 +-
2 files changed, 11 insertions(+), 10
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +-
.../staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h | 6 +++---
2 files changed, 4 insertions(+), 4 dele
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 6 +++---
.../vc04_services/interface/vchiq_arm/vchiq_core.c| 2 +-
.../vc04_services/interface/vchiq_arm/vchiq_
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../interface/vchiq_arm/vchiq_core.c | 16
.../interface/vchiq_arm/vchiq_core.h | 6 +++---
2 files changed, 11 insertions(+), 11 deletion
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 4 ++--
.../staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h | 6 +++---
2 files changed, 5 insertions(+), 5 de
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_core.h| 2 +-
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_if.h | 4 ++--
2 files changed, 3 insertions(+), 3 de
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 2 +-
.../staging/vc04_services/interface/vchiq_arm/vchiq_core.h | 6 +++---
2 files changed, 4 insertions(+), 4 dele
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../interface/vchiq_arm/vchiq_arm.c | 21 ++-
.../interface/vchiq_arm/vchiq_ioctl.h | 6 +++---
2 files changed, 14 insertions(+), 13 deletions(-
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../interface/vchiq_arm/vchiq_2835_arm.c | 4 +-
.../interface/vchiq_arm/vchiq_arm.c | 55 ++-
.../interface/vchiq_arm/vchiq_arm.h | 18 ++
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../interface/vchiq_arm/vchiq_2835_arm.c | 22 ++---
.../interface/vchiq_arm/vchiq_arm.c | 64 +++--
.../interface/vchiq_arm/vchiq_arm.h | 39 -
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../interface/vchiq_arm/vchiq_arm.c | 51 +++
.../interface/vchiq_arm/vchiq_arm.h | 8 +-
.../interface/vchiq_arm/vchiq_core.c | 137 +--
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../interface/vchiq_arm/vchiq_shim.c | 2 +-
.../interface/vchiq_arm/vchiq_util.c | 14 +++---
.../interface/vchiq_arm/vchiq_util.h | 19 +++
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../interface/vchiq_arm/vchiq_2835_arm.c | 2 +-
.../vc04_services/interface/vchiq_arm/vchiq_core.c | 14 +++---
.../vc04_services/interface/vchiq_arm/vchiq_core
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 6 +++---
.../vc04_services/interface/vchiq_arm/vchiq_ioctl.h | 8
2 files changed, 7 insertions(+), 7 de
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 4 ++--
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h | 2 +-
.../staging/vc04_services/interface/vc
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../interface/vchiq_arm/vchiq_arm.c | 20 +++---
.../interface/vchiq_arm/vchiq_core.c | 66 ++-
.../interface/vchiq_arm/vchiq_if.h| 1
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 4 ++--
.../staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h | 6 +++---
2 files changed, 5 insertions(+), 5 de
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 4 ++--
.../staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h | 6 +++---
2 files changed, 5 insertions(+), 5 de
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +-
.../staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 2 +-
.../staging/vc04_services/interface/vchiq_ar
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../interface/vchiq_arm/vchiq_core.c | 24 +--
.../interface/vchiq_arm/vchiq_core.h | 12 +-
2 files changed, 18 insertions(+), 18 deletio
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 8
.../vc04_services/interface/vchiq_arm/vchiq_ioctl.h | 6 +++---
2 files changed, 7 insertions(+), 7 de
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 6 +++---
.../staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h | 6 +++---
2 files changed, 6 insertions(+), 6
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../vc04_services/interface/vchiq_arm/vchiq_core.c | 13 +++--
.../vc04_services/interface/vchiq_arm/vchiq_core.h | 8
2 files changed, 11 insertions(+), 10 del
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../staging/vc04_services/interface/vchi/vchi_common.h| 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchi/v
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../vc04_services/bcm2835-camera/mmal-vchiq.c | 28 +--
.../vc04_services/interface/vchi/vchi.h | 20 ++---
.../interface/vchiq_arm/vchiq_shim.c
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../interface/vchiq_arm/vchiq_arm.c | 44 ++-
1 file changed, 23 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchi
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
drivers/staging/vc04_services/interface/vchi/vchi.h | 12 ++--
.../vc04_services/interface/vchi/vchi_common.h | 4 ++--
2 files changed, 8 insertions(+), 8 deletion
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 10 +-
.../vc04_services/interface/vchiq_arm/vchiq_pagelist.h | 4 ++--
2 files changed, 7 insertions(+), 7 deleti
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../interface/vchiq_arm/vchiq_2835_arm.c | 2 +-
.../vc04_services/interface/vchiq_arm/vchiq_core.c | 8
.../vc04_services/interface/vchiq_arm/vchiq_core.h | 1
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c | 2 +-
drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 2 +-
drivers/staging/vc04_services/interface/vchi
Typedefing structs is not encouraged in the kernel.
Dominic Braun (33):
staging: vc04_services: Remove DUMP_CONTEXT_T typedef
staging: vc04_services: Remove PAGELIST_T typedef
staging: vc04_services: Remove REMOTE_EVENT_T typedef
staging: vc04_services: Remove SERVICE_CREATION_T typedef
Typedefing structs is not encouraged in the kernel.
Signed-off-by: Dominic Braun
Signed-off-by: Tobias Büttner
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_
On Fri, Dec 14, 2018 at 10:11:23AM +0300, Dan Carpenter wrote:
> On Thu, Dec 13, 2018 at 10:59:11PM +0100, Christian Brauner wrote:
> > +/**
> > + * binderfs_new_inode - allocate inode from super block of a binderfs mount
> > + * @ref_inode: inode from wich the super block will be taken
> > + * @us
On Fri, Dec 14, 2018 at 09:33:50AM +, christian.gr...@microchip.com wrote:
> On Fr, 2018-12-14 at 12:10 +0300, Dan Carpenter wrote:
> > On Fri, Dec 14, 2018 at 09:06:01AM +, Christian.Gromm@microchip.c
> > om wrote:
> > >
> > > Message received. Anyway, I would like to resent the current
>
On Fri, Dec 14, 2018 at 09:33:50AM +, christian.gr...@microchip.com wrote:
> On Fr, 2018-12-14 at 12:10 +0300, Dan Carpenter wrote:
> > On Fri, Dec 14, 2018 at 09:06:01AM +, Christian.Gromm@microchip.c
> > om wrote:
> > >
> > > Message received. Anyway, I would like to resent the current
>
On Fr, 2018-12-14 at 12:10 +0300, Dan Carpenter wrote:
> On Fri, Dec 14, 2018 at 09:06:01AM +, Christian.Gromm@microchip.c
> om wrote:
> >
> > Message received. Anyway, I would like to resent the current
> > patch set with the things Dan found fixed. And then looking
> > into Configfs. Would t
On Fri, Dec 14, 2018 at 09:06:01AM +, christian.gr...@microchip.com wrote:
> Message received. Anyway, I would like to resent the current
> patch set with the things Dan found fixed. And then looking
> into Configfs. Would this be ok for you guys?
>
Sure.
regards,
dan carpenter
On Do, 2018-12-13 at 18:55 +0100, Greg KH wrote:
> On Thu, Dec 13, 2018 at 04:32:25PM +, Christian.Gromm@microchip.c
> om wrote:
> >
> > On Do, 2018-12-13 at 13:32 +0100, Greg KH wrote:
> > >
> > > On Thu, Dec 13, 2018 at 02:58:00PM +0300, Dan Carpenter wrote:
> > > >
> > > >
> > > > On Wed
51 matches
Mail list logo
