Typedefing structs is not encouraged in the kernel.

Signed-off-by: Dominic Braun <inf.br...@fau.de>
Signed-off-by: Tobias Büttner <tobias.buett...@fau.de>
---
 .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c   | 2 +-
 .../staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c 
b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
index fae0ab61ceee..7ce7e1a4dafe 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
@@ -1430,7 +1430,7 @@ vchiq_ioctl(struct file *file, unsigned int cmd, unsigned 
long arg)
        } break;
 
        case VCHIQ_IOC_SET_SERVICE_OPTION: {
-               VCHIQ_SET_SERVICE_OPTION_T args;
+               struct vchiq_set_service_option args;
 
                if (copy_from_user(
                        &args, (const void __user *)arg,
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h 
b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h
index 80c246c033b2..56aef490e870 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h
@@ -88,11 +88,11 @@ struct vchiq_get_config {
        struct vchiq_config __user *pconfig;
 };
 
-typedef struct {
+struct vchiq_set_service_option {
        unsigned int handle;
        VCHIQ_SERVICE_OPTION_T option;
        int value;
-} VCHIQ_SET_SERVICE_OPTION_T;
+};
 
 struct vchiq_dump_mem {
        void     *virt_addr;
@@ -121,7 +121,7 @@ struct vchiq_dump_mem {
 #define VCHIQ_IOC_USE_SERVICE          _IO(VCHIQ_IOC_MAGIC,   12)
 #define VCHIQ_IOC_RELEASE_SERVICE      _IO(VCHIQ_IOC_MAGIC,   13)
 #define VCHIQ_IOC_SET_SERVICE_OPTION \
-       _IOW(VCHIQ_IOC_MAGIC,  14, VCHIQ_SET_SERVICE_OPTION_T)
+       _IOW(VCHIQ_IOC_MAGIC,  14, struct vchiq_set_service_option)
 #define VCHIQ_IOC_DUMP_PHYS_MEM \
        _IOW(VCHIQ_IOC_MAGIC,  15, struct vchiq_dump_mem)
 #define VCHIQ_IOC_LIB_VERSION          _IO(VCHIQ_IOC_MAGIC,   16)
-- 
2.17.1

_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to