Re: [PATCH] staging: rtl8192u: fix line over 80 characters

On Sat, 16 Jun 2018, Hyunil Kim wrote: > *fix checkpatch.pl warnings: > WARNING: line over 80 characters Describe what you do and why, rather than just saying "Fix". Often something can be fixed in multiple ways. julia > > Signed-off-by: Hyunil Kim > --- > drivers/staging/rtl8192u/r8192U

[PATCH v2] staging: rtl8712: Adjust if statements to reduce indentation level

Merge two condition of if statements in r8712_surveydone_event_callback() Signed-off-by: Joonhwan Kim --- v2: fix my name without period in email header drivers/staging/rtl8712/rtl871x_mlme.c | 51 +- 1 file changed, 25 insertions(+), 26 deletions(-) diff --git a/driver

[PATCH] staging: rtl8192u: fix line over 80 characters

*fix checkpatch.pl warnings: WARNING: line over 80 characters Signed-off-by: Hyunil Kim --- drivers/staging/rtl8192u/r8192U_core.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c index 74c58

[PATCH] staging: rtl8712: Adjust if statements to reduce indentation level

Merge two condition of if statements in r8712_surveydone_event_callback() Signed-off-by: Joonhwan Kim --- drivers/staging/rtl8712/rtl871x_mlme.c | 51 +- 1 file changed, 25 insertions(+), 26 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/stag

[PATCH] media: staging: atomisp: add a blank line after declarations

fix checkpatch.pl warning: * Missing a blank line after declarations Signed-off-by: Joonhwan Kim --- drivers/staging/media/atomisp/pci/atomisp2/atomisp_ioctl.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_ioctl.c b/drivers/staging

Re: [PATCH 1/2] staging: rtl8192e: remove brace for single statement

Thanks greg. Let me check and send again regards Hyunil Kim On Fri, Jun 15, 2018 at 8:08 PM, Greg KH wrote: > On Sat, Jun 09, 2018 at 03:05:56PM +0900, thtlwlsmsgk...@gmail.com wrote: >> * fix checkpatch.pl warning: >> WARNING: braces { are not necessary for single statement blocks >> >> Signed

Re: [PATCH 2/2] staging: rtl8192e: fix line over 80 characters

Hi Joe. Thanks to your notice. i will check again. Regards, Hyunil Kim. On Sat, Jun 9, 2018 at 3:45 PM, Joe Perches wrote: > On Sat, 2018-06-09 at 15:07 +0900, thtlwlsmsgk...@gmail.com wrote: >> *fix checkpatch.pl warnings: >> WARNING: line over 80 characters > > Consider using a temporary for

Re: [PATCH 1/2] staging: mt7621-spi: change indentation from space to tab

Hi greg, I didn't noticed that. :( Thank you for your attention! Sincerely, JoonHwan 2018-06-15 20:02 GMT+09:00 Greg KH : > On Sat, Jun 09, 2018 at 03:03:27PM +0900, JoonHwan.Kim wrote: >> * fix checkpatch.pl error: >> ERROR: code indent should use tabs where possible >> >> Signed-off-by: Joon

[PATCH v4] staging: rtl8192u: add error handling for usb_alloc_urb

When usb_alloc_urb fails, the lack of error-handling code may cause unexpected results. This patch adds error-handling code after calling usb_alloc_urb. Signed-off-by: Zhouyang Jia --- v1->v2: - Fix memory leak. v2->v3: - Release memory in error path. v3->v4: - Use kcalloc instead of kmalloc_arr

Re: [PATCH v3] staging: rtl8192u: add error handling for usb_alloc_urb

On Fri, Jun 15, 2018 at 10:28 AM, Zhouyang Jia wrote: > When usb_alloc_urb fails, the lack of error-handling code may > cause unexpected results. > > This patch adds error-handling code after calling usb_alloc_urb. > > Signed-off-by: Zhouyang Jia > --- > v1->v2: > - Fix memory leak. > v2->v3: > -

Re: [PATCH v2 2/4] staging: goldfish: Fix checkpatch CHECK in goldfish_audio.c

Sure, I will update the patch with you change. Thank you for reviewing our patches. On Fri, Jun 15, 2018 at 4:22 AM Greg KH wrote: > > On Mon, Jun 04, 2018 at 02:08:20PM -0700, r...@google.com wrote: > > From: Roman Kiryanov > > > > Fix "CHECK: Alignment should match open parenthesis" > > > > Si

[PATCH 4/5] Staging: comedi: comedi_pcmcia.h: fixed missing or malformed SPDX-License-Identifier

Fixed SPDX-License-Identifier comment on first line Signed-off-by: ankit patel --- drivers/staging/comedi/comedi_pcmcia.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/comedi_pcmcia.h b/drivers/staging/comedi/comedi_pcmcia.h index c7d37b38e730..f2f6e

[PATCH 3/5] Staging: comedi: comedi_pci.h: fixed missing or malformed SPDX-License-Identifier

Fixed SPDX-License-Identifier comment on first line Signed-off-by: ankit patel --- drivers/staging/comedi/comedi_pci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/comedi_pci.h b/drivers/staging/comedi/comedi_pci.h index 647a72441b8a..4e069440cbdc 1

[PATCH 5/5] Staging: comedi: comedilib.h: fixed missing or malformed SPDX-License-Identifier

Fixed SPDX-License-Identifier comment on first line Signed-off-by: ankit patel --- drivers/staging/comedi/comedilib.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/comedilib.h b/drivers/staging/comedi/comedilib.h index e98cb9752dbc..0223c9cd9215 1006

[PATCH 2/5] Staging: comedi: comedi_compat32.h: fixed missing or malformed SPDX-License-Identifier

Fixed SPDX-License-Identifier comment on first line Signed-off-by: ankit patel --- drivers/staging/comedi/comedi_compat32.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/comedi_compat32.h b/drivers/staging/comedi/comedi_compat32.h index 3980e6e1bd0d.

[PATCH 1/5] Staging: comedi: comedi.h: fixed missing or malformed SPDX-License-Identifier

Fixed SPDX-License-Identifier comment on first line Signed-off-by: ankit patel --- drivers/staging/comedi/comedi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h index c0bc413f7fe0..bb961ac79b7e 100644 --- a/d

Re: [PATCH v3] staging: rtl8192u: add error handling for usb_alloc_urb

Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.17 next-20180615] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH v4 04/26] docs: fix broken references with multiple hints

On Fri, 15 Jun 2018, Mauro Carvalho Chehab wrote: > The script: > ./scripts/documentation-file-ref-check --fix > > Gives multiple hints for broken references on some files. > Manually use the one that applies for some files. > > Acked-by: Steven Rostedt (VMware) > Signed-off-by: Mauro Car

Re: staging: rtl8192e: Series of coding style changes

On Wed, Jun 06, 2018 at 12:39:55PM +0100, John Whitmore wrote: > Version 6 : Sorry to send this out again but version 5 contained a little less > verbosity then required. > > Again these are just some simple coding style changes to the file, so nothing > of importance. > Received an automated ema

[PATCH v3] staging: rtl8192u: add error handling for usb_alloc_urb

When usb_alloc_urb fails, the lack of error-handling code may cause unexpected results. This patch adds error-handling code after calling usb_alloc_urb. Signed-off-by: Zhouyang Jia --- v1->v2: - Fix memory leak. v2->v3: - Release memory in error path. --- drivers/staging/rtl8192u/r8192U_core.c

Re: [PATCH v2] staging: rtl8192u: add error handling for usb_alloc_urb

On Fri, Jun 15, 2018 at 9:47 AM, Kees Cook wrote: > On Fri, Jun 15, 2018 at 9:33 AM, Greg Kroah-Hartman > wrote: >> On Sat, Jun 16, 2018 at 12:25:23AM +0800, Zhouyang Jia wrote: >>> When usb_alloc_urb fails, the lack of error-handling code may >>> cause unexpected results. >>> >>> This patch adds

Re: [PATCH v2] staging: rtl8192u: add error handling for usb_alloc_urb

On Fri, Jun 15, 2018 at 9:33 AM, Greg Kroah-Hartman wrote: > On Sat, Jun 16, 2018 at 12:25:23AM +0800, Zhouyang Jia wrote: >> When usb_alloc_urb fails, the lack of error-handling code may >> cause unexpected results. >> >> This patch adds error-handling code after calling usb_alloc_urb. >> >> Sign

Re: [PATCH v2] staging: rtl8192u: add error handling for usb_alloc_urb

On Sat, Jun 16, 2018 at 12:25:23AM +0800, Zhouyang Jia wrote: > When usb_alloc_urb fails, the lack of error-handling code may > cause unexpected results. > > This patch adds error-handling code after calling usb_alloc_urb. > > Signed-off-by: Zhouyang Jia > --- > v1->v2: > - Fix memory leak. > --

[PATCH v4 05/26] docs: Fix some broken references

As we move stuff around, some doc references are broken. Fix some of them via this script: ./scripts/documentation-file-ref-check --fix Manually checked if the produced result is valid, removing a few false-positives. Acked-by: Takashi Iwai Acked-by: Masami Hiramatsu Acked-by: Stephen B

[PATCH v4 04/26] docs: fix broken references with multiple hints

The script: ./scripts/documentation-file-ref-check --fix Gives multiple hints for broken references on some files. Manually use the one that applies for some files. Acked-by: Steven Rostedt (VMware) Signed-off-by: Mauro Carvalho Chehab --- Documentation/ABI/obsolete/sysfs-gpio

[PATCH v4 08/26] media: v4l: fix broken video4linux docs locations

There are several places pointing to old documentation files: Documentation/video4linux/API.html Documentation/video4linux/bttv/ Documentation/video4linux/cx2341x/fw-encoder-api.txt Documentation/video4linux/m5602.txt Documentation/video4linux/v4l2-framework.txt Documentation/video4lin

[PATCH] x86/hyper-v: use cheaper HVCALL_FLUSH_VIRTUAL_ADDRESS_{LIST, SPACE} hypercalls when possible

While working on Hyper-V style PV TLB flush support in KVM I noticed that real Windows guests use TLB flush hypercall in a somewhat smarter way: when the flush needs to be performed on a subset of first 64 vCPUs or on all present vCPUs Windows avoids more expensive hypercalls which support sparse C

[PATCH v2] staging: rtl8192u: add error handling for usb_alloc_urb

When usb_alloc_urb fails, the lack of error-handling code may cause unexpected results. This patch adds error-handling code after calling usb_alloc_urb. Signed-off-by: Zhouyang Jia --- v1->v2: - Fix memory leak. --- drivers/staging/rtl8192u/r8192U_core.c | 18 +++--- 1 file changed,

[PATCH] staging: most: fix sparse warning Using plain integer as NULL pointer

This patch fixes following sparse warning: Using plain integer as NULL pointer in drivers/staging/most/dim2/dim2.c Signed-off-by: Marcin Ciupak --- drivers/staging/most/dim2/dim2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/stag

Re: [PATCH] staging: most: do not show interface dependent attrs by default in sysfs

On Fri, Jun 15, 2018 at 01:54:02PM +0200, Christian Gromm wrote: > The channel attribute dbr_size is only relevant for the DIM2 interface. So > is the packets_per_xact for USB. Currently, all attrs are shown by default > in sysfs for any channel. To get a clean content of a channel directory, > thi

[PATCH] staging: most: do not show interface dependent attrs by default in sysfs

The channel attribute dbr_size is only relevant for the DIM2 interface. So is the packets_per_xact for USB. Currently, all attrs are shown by default in sysfs for any channel. To get a clean content of a channel directory, this patch makes the attributes show up only on the channel they belong to.

Re: [PATCH v2 5/5] staging: use BIT_ULL for NL80211_STA_INFO_* attribute types

On Thu, Jun 14, 2018 at 01:13:37PM +0300, Omer Efrat wrote: > Since 'filled' member in station_info changed to u64, BIT_ULL macro > should be used with NL80211_STA_INFO_* attribute types instead of BIT. > > The BIT macro uses unsigned long type which some architectures handle as 32bit > and this r

Re: [PATCH v2 5/5] staging: use BIT_ULL for NL80211_STA_INFO_* attribute types

On Thu, Jun 14, 2018 at 01:09:34PM +0200, Johannes Berg wrote: > On Thu, 2018-06-14 at 13:13 +0300, Omer Efrat wrote: > > Since 'filled' member in station_info changed to u64, BIT_ULL macro > > should be used with NL80211_STA_INFO_* attribute types instead of BIT. > > > > The BIT macro uses unsign

Re: [PATCH v2 2/4] staging: goldfish: Fix checkpatch CHECK in goldfish_audio.c

On Mon, Jun 04, 2018 at 02:08:20PM -0700, r...@google.com wrote: > From: Roman Kiryanov > > Fix "CHECK: Alignment should match open parenthesis" > > Signed-off-by: Roman Kiryanov > --- > Changes in v2: > - Separated macros fixes into a separate change (see 1/4). > > drivers/staging/goldfish/

Re: [PATCH 1/2] staging: rtl8192e: remove brace for single statement

On Sat, Jun 09, 2018 at 03:05:56PM +0900, thtlwlsmsgk...@gmail.com wrote: > * fix checkpatch.pl warning: > WARNING: braces { are not necessary for single statement blocks > > Signed-off-by: Hyunil Kim This does not match your "From:" line in your email headers :( _

Re: [PATCH] staging: rtl8192u: add error handling for usb_alloc_urb

On Mon, Jun 11, 2018 at 04:31:11PM +0800, Zhouyang Jia wrote: > When usb_alloc_urb fails, the lack of error-handling code may > cause unexpected results. > > This patch adds error-handling code after calling usb_alloc_urb. > > Signed-off-by: Zhouyang Jia > --- > drivers/staging/rtl8192u/r8192U_

Re: [PATCH 1/4] Staging:rtl8192e Replace function names by using __func__ identifier

On Wed, Jun 13, 2018 at 02:22:59AM -0400, Janani Sankara Babu wrote: > Sorry , Kindly ignore this patch. I'm dropping this whole series as I can not tell what should, and what should not, be applied. Please fix them all up and resend, as a properly threaded patch series. thanks, greg k-h __

Re: [PATCH 1/2] staging: mt7621-spi: change indentation from space to tab

On Sat, Jun 09, 2018 at 03:03:27PM +0900, JoonHwan.Kim wrote: > * fix checkpatch.pl error: > ERROR: code indent should use tabs where possible > > Signed-off-by: Joonhwan Kim > --- > drivers/staging/mt7621-spi/spi-mt7621.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Someone else s

Re: [PATCH net] hv_netvsc: Fix the variable sizes in ipsecv2 and rsc offload

On Thu, Jun 14, 2018 at 06:29:09PM -0700, Haiyang Zhang wrote: > These structs are not in use right now, but will be used soon. Btw, thank you for adding this information. I was wondering about that in the first version of this patch. It's always useful to know what the effect of a bugfix is eve

Re: [PATCH v3 05/27] docs: Fix some broken references

On 2018/6/15 12:08 AM, Mauro Carvalho Chehab wrote: > As we move stuff around, some doc references are broken. Fix some of > them via this script: > ./scripts/documentation-file-ref-check --fix > > Manually checked if the produced result is valid, removing a few > false-positives. > > Acked