On Mon, Jun 04, 2018 at 02:08:20PM -0700, r...@google.com wrote:
> From: Roman Kiryanov <r...@google.com>
>
> Fix "CHECK: Alignment should match open parenthesis"
>
> Signed-off-by: Roman Kiryanov <r...@google.com>
> ---
> Changes in v2:
> - Separated macros fixes into a separate change (see 1/4).
>
> drivers/staging/goldfish/goldfish_audio.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/goldfish/goldfish_audio.c
> b/drivers/staging/goldfish/goldfish_audio.c
> index 3a4715cd362b..2bec3205326e 100644
> --- a/drivers/staging/goldfish/goldfish_audio.c
> +++ b/drivers/staging/goldfish/goldfish_audio.c
> @@ -308,8 +308,11 @@ static int goldfish_audio_probe(struct platform_device
> *pdev)
> dev_err(&pdev->dev, "platform_get_irq failed\n");
> return -ENODEV;
> }
> - data->buffer_virt = dmam_alloc_coherent(&pdev->dev,
> - COMBINED_BUFFER_SIZE, &buf_addr, GFP_KERNEL);
> + data->buffer_virt =
> + dmam_alloc_coherent(&pdev->dev,
> + COMBINED_BUFFER_SIZE,
> + &buf_addr,
> + GFP_KERNEL);
Ick, what's wrong with a simple:
data->buffer_virt = dmam_alloc_coherent(&pdev->dev,
COMBINED_BUFFER_SIZE,
&buf_addr, GFP_KERNEL);
Much more readable, don't you think?
thanks,
greg k-h
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
