When refactoring the function msdc_init_gpd_bd, an error in the
calculation of the bd.next address was introduced. The offset has to
be added to the base address, not multiplied.
Fixes: 8f2395586cf0 ("staging: mt7621-mmc: Refactor msdc_init_gpd_bd")
Reported-by: NeilBrown
Signed-off-by: Christian
On Wed, Apr 25, 2018 at 01:02:31PM +1000, NeilBrown wrote:
> On Wed, Apr 18 2018, Christian Lütke-Stetzkamp wrote:
>
> > The msdc_init_gpd_bd function is currently hard to read, because of
> > old, commented out code and a while loop, where a for loop is much
> > easier to read. Refactor it to mak
On Tue, Apr 24, 2018 at 09:57:29PM +0200, Kirill Marinushkin wrote:
> In the current implementation, vchi_instance is inited during the first
> call of bcm2835_audio_open_connection(), and is never freed. It causes a
> memory leak when the module `snd_bcm2835` is removed.
>
> Here is how this comm
On Tue, Apr 24, 2018 at 08:51:34PM +0200, Kirill Marinushkin wrote:
> On 04/24/18 20:35, Andy Shevchenko wrote:
> > On Tue, Apr 24, 2018 at 9:27 PM, Kirill Marinushkin
> > wrote:
> >
> >> @Andy
> >>
> >>> AFAIR I gave you a tag and you again missed it.
> >>> Before sending anything just check twic
On Tue, Apr 24 2018, Christian Lütke-Stetzkamp wrote:
> This series contains the patches from previous series which hasn't
> been applied. Most of them are just rebased. Only the commit messages
> of 2 and 3 have been corrected as suggested by reviewers.
Thanks.
I can confirm that these all apply
From: Vijayanand Jitta
An issue is observed where mallocs are failing due to overcommit failure.
The failure happens when there is high ION page pool since ION page
pool is not considered reclaimable by the overcommit calculation code.
This change considers ion pool pages as indirectly reclaimabl
On Wed, Apr 18 2018, Christian Lütke-Stetzkamp wrote:
> The msdc_init_gpd_bd function is currently hard to read, because of
> old, commented out code and a while loop, where a for loop is much
> easier to read. Refactor it to make the code more readable.
>
> Signed-off-by: Christian Lütke-Stetzkam
In the current implementation, vchi_instance is inited during the first
call of bcm2835_audio_open_connection(), and is never freed. It causes a
memory leak when the module `snd_bcm2835` is removed.
Here is how this commit fixes it:
* the VCHI context (including vchi_instance) is created once in
On 04/24/18 20:35, Andy Shevchenko wrote:
> On Tue, Apr 24, 2018 at 9:27 PM, Kirill Marinushkin
> wrote:
>
>> @Andy
>>
>>> AFAIR I gave you a tag and you again missed it.
>>> Before sending anything just check twice if all prerequisites are fulfilled.
>> I think you mix it up. This is a new patch,
On Tue, Apr 24, 2018 at 9:27 PM, Kirill Marinushkin
wrote:
> @Andy
>
>> AFAIR I gave you a tag and you again missed it.
>> Before sending anything just check twice if all prerequisites are fulfilled.
>
> I think you mix it up. This is a new patch, you didn't review it before.
Ah, okay, send new
@Greg
> I have no idea as the patch is long gone from my queue now. If you
> think all is fine, please resend it and I will be glad to review it
> again.
Stefan, Dan and Andy explained me, what caused the compiler warning in my patch,
and why I couldn't reproduce it. I will fix the root cause, an
In the current code there are '#if 0' out references on using a
tasklet instead of delayed_work. Removing these improves readability.
Signed-off-by: Christian Lütke-Stetzkamp
Reviewed-by: NeilBrown
---
drivers/staging/mt7621-mmc/mt6575_sd.h | 1 -
drivers/staging/mt7621-mmc/sd.c| 23 --
The functions msdc_command_resp and msdc_do_request are always called
with the host->lock lock held. By adding annotations, sparse is
informed about that.
Signed-off-by: Christian Lütke-Stetzkamp
Reviewed-by: NeilBrown
---
drivers/staging/mt7621-mmc/sd.c | 2 ++
1 file changed, 2 insertions(+)
Currently the dma direction is manually determined by the read status,
there is a more portable function for it, mmc_get_dma_dir, use it.
Signed-off-by: Christian Lütke-Stetzkamp
Reviewed-by: NeilBrown
---
drivers/staging/mt7621-mmc/sd.c | 9 +
1 file changed, 5 insertions(+), 4 deletio
The card_workqueue field of msdc_host is already if 0'd out and there
are no references to it in the code (not even in unused code), so
remove it.
Signed-off-by: Christian Lütke-Stetzkamp
Reviewed-by: NeilBrown
---
drivers/staging/mt7621-mmc/mt6575_sd.h | 4
1 file changed, 4 deletions(-)
This series contains the patches from previous series which hasn't
been applied. Most of them are just rebased. Only the commit messages
of 2 and 3 have been corrected as suggested by reviewers.
Christian Lütke-Stetzkamp (8):
staging: mt7621-mmc: Fix dereference before check in msdc_drv_pm
sta
Fix checkpatch: multiple assignments should be avoided, to improve
readability.
It aslo moves the second assignment out of the if/else block, that is
valid, because drv_mode is of type msdc_mode, an enum with only those
three elements, so one of the if/ else if statements is always
taken. And the s
In the msdc_drv_pm function the variable mmc is dereferenced before
checked. Reordering fixes that.
Reported-by: Dan Carpenter
Signed-off-by: Christian Lütke-Stetzkamp
Reviewed-by: NeilBrown
---
drivers/staging/mt7621-mmc/sd.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff -
Current code discard the address space information on the base address
of the mmc controller, that causes sparse warnings. It uses the raw
read write function, that is correct for the mips architecture (little
endian), but for portability the non-raw function should be used. Also
the clear/set bit
The dma_map_sg function may merge several sglist entries into one, the
return value has to be saved to consider that. The data->sg_count
field is the position, where it should be saved, like it is done in
other mmc host drivers. Also the count of mapped entries is needed for
the dma setup.
Signed-
Removed the items from WILC1000 TODO list, which are already addressed
to keep it updated. The removed items are already taken care by
previously submitted patches.
Signed-off-by: Ajay Singh
---
If someone feels differently please update for this patch. There are
pending fixes for soft-ap, p2p m
Updated the TODO list by removing items, which are already addressed.
Also remove the code to handle IOCTL(SIOCSIWPRIV) as Wext support is
not present in the driver.
Ajay Singh (2):
staging: wilc1000: remove registering of ndo_do_ioctl callback
staging: wilc1000: updated TODO list
drivers/st
Remove registering of ndo_do_ioctl in wilc_netdev_ops structure.
As RSSI information is already avaliable through cfg80211, so remove
the IOCTL call use to fetch the same information. Wext support is not
present in the driver. Its also done to address the TODO list item
mentioned below:
"use wext-
On Tue, Apr 24, 2018 at 10:44 AM, Kirill Marinushkin
wrote:
> In the current implementation, vchi_instance is inited during the first
> call of bcm2835_audio_open_connection(), and is never freed. It causes a
> memory leak when the module `snd_bcm2835` is removed.
> Signed-off-by: Kirill Marinus
On Tue, Apr 24, 2018 at 08:19:16AM -0700, Andrew Morton wrote:
> > > I want to ask if it is time to start using poorman function overloading
> > > with _b_c_e(). There are millions of allocation functions for example,
> > > all slightly difference, and people will add more. Seeing /proc interfaces
On Tue, 24 Apr 2018 16:23:04 +0200 Christoph Hellwig wrote:
> On Thu, Apr 19, 2018 at 09:57:50PM +0300, Alexey Dobriyan wrote:
> > > git://git.infradead.org/users/hch/misc.git proc_create
> >
> >
> > I want to ask if it is time to start using poorman function overloading
> > with _b_c_e().
This is a note to let you know that I've just added the patch titled
x86/hyperv: Stop suppressing X86_FEATURE_PCID
to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
x86-hyper
This is a note to let you know that I've just added the patch titled
x86/hyperv: Check for required priviliges in hyperv_init()
to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
On Thu, Apr 19, 2018 at 09:41:06PM +0300, Alexey Dobriyan wrote:
> Should be oopsable.
> Once proc_create_data() returns, entry is live, ->open can be called.
Ok, switching to opencoding proc_create_data instead.
___
devel mailing list
de...@linuxdriverp
On Thu, Apr 19, 2018 at 09:50:27PM +0300, Alexey Dobriyan wrote:
> On Thu, Apr 19, 2018 at 02:41:04PM +0200, Christoph Hellwig wrote:
> > Variant of proc_create_data that directly take a struct seq_operations
>
> > --- a/fs/proc/internal.h
> > +++ b/fs/proc/internal.h
> > @@ -45,6 +45,7 @@ struct
On Thu, Apr 19, 2018 at 05:18:18PM +0300, Dan Carpenter wrote:
> > -static const struct file_operations cio_ignore_proc_fops = {
> > - .open= cio_ignore_proc_open,
> > - .read= seq_read,
> > - .llseek = seq_lseek,
> > - .release = seq_release_private,
> > - .write = cio_ignore_
On Thu, Apr 19, 2018 at 10:29:29AM -0500, Corey Minyard wrote:
> On 04/19/2018 07:41 AM, Christoph Hellwig wrote:
>> Use remove_proc_subtree to remove the whole subtree on cleanup instead
>> of a hand rolled list of proc entries, unwind the registration loop into
>> individual calls. Switch to use
On Thu, Apr 19, 2018 at 03:10:27PM +0200, Alexandre Belloni wrote:
> On 19/04/2018 14:41:27+0200, Christoph Hellwig wrote:
> > And stop trying to get a reference on the submodule, procfs code deals
> > with release after and unloaded module and thus removed proc entry.
> >
>
> Are you sure about
On Thu, Apr 19, 2018 at 09:57:50PM +0300, Alexey Dobriyan wrote:
> > git://git.infradead.org/users/hch/misc.git proc_create
>
>
> I want to ask if it is time to start using poorman function overloading
> with _b_c_e(). There are millions of allocation functions for example,
> all slightly dif
Use ether_addr_copy to copy ethernet addresses in function
hostif_sme_multicast_set instead of memcpy.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_hostif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/stagin
This commits refactor a bit hostif_sme_set_pmksa function:
- avoid one level indentation changing if condition.
- use ether_addr_copy to copy bssid addresses.
- move 'i' initialization to declaration place.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_hostif.c | 14 ++--
WPS definition was defined by default in ks_wlan.h header
file. So it makes no sense to have conditional preprocessor
stuff along the code about this.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_wlan.h | 12
drivers/staging/ks7010/ks_wlan_ioctl.h | 2 --
d
This definitions are in linux/wireless.h header so it is not
necessary at all to have this compatibility stuff duplicated here.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_wlan_net.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/ks7010/ks_wlan_net.c
Avoid the use of switch-case block which is not necessary
at all and just use a ternary operator to achieve this.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_wlan_net.c | 13 ++---
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/ks7010/k
This commit improves readability changing custom ethernet
addresses copies in favour of using ether_addr_copy() function.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_hostif.c | 11 ++-
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/ks701
This declaration is declared twice so just remove this one because
the other one is the one which contains static struct initializers.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_wlan_net.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/ks7010/ks_wlan_n
Use ether_addr_equal to compare addresses in ether_addr_equal
function instead of comparing using memcmp.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_hostif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/sta
Avoid very long if condition just changing its style. This makes
checkpatch script not complains about this line.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_wlan_net.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_wlan_net.c
Most cases which are being handled in the switch-case of
ks_wlan_set_mode function are just returning EINVAL. Avoid
the use of switch-case stament and just use a simple if
to handle those. This decrease LOC as well as improves
readability.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks
In order to achieve ethernet address copies, ether_addr_copy()
function exists. So just use it and avoid the byte by byte copy.
This increase readability.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_wlan_net.c | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
dif
Instead of comparing ethernet address using memcmp in function
hostif_data_indication use ether_addr_equal function created
for this function.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_hostif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/stag
The summary text for the GPL is not needed since the SPDX identifier
is a legally binding shorthand that can be used instead.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks7010_sdio.c | 5 +
drivers/staging/ks7010/ks7010_sdio.h | 5 +
drivers/staging/ks7010/ks_hostif
Singles if does not need at all to use brackets in its body
so just remove them which is the preferred style.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_hostif.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drive
Some minor changes have been done in this function to clean
it a bit:
- POWER_MGMT_ACTIVE and default case are the same so
just handle that with the same block of code,
- POWER_MGMT_SAVE1 replaces if-else with a ternary operator.
Signed-off-by: Sergio Paracuellos
---
drivers/stagin
This commits avoid some if-else code extracting common code before
its use and making use of a new variable 'size' which is assigned
using a ternary operator. This improves readability.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_hostif.c | 25 +++--
1 fil
This patch series includes continue with cleanups for
this driver. This requires the previous remaining serie
to be applied.
Sergio Paracuellos (18):
staging: ks7010: avoid some if-else code in get_current_ap function
staging: ks7010: join some debug traces in get_current_ap function
staging
There is a lot of netdev_dbg calls related with the access point
in this function and all of them can be joined in only one call.
This makes code a bit simplier.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_hostif.c | 26 ++
1 file changed, 14 insertion
Function hostif_data_indication checks some hardcoded values in a
switch-case block. This values are defined in uapi/linux/llc.h
header. Just use them and avoid a comment in the code improving
readability a bit.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/ks7010/ks_hostif.c | 5 +++--
Hi,
On 24-04-18 15:15, Luc Van Oostenryck wrote:
The method struct drm_connector_helper_funcs::mode_valid is defined
as returning an 'enum drm_mode_status' but the driver implementation
for this method uses an 'int' for it.
Fix this by using 'enum drm_mode_status' in the driver too.
Signed-off
Hi,
On 24-04-18 15:18, Luc Van Oostenryck wrote:
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, but the implementation in this
driver returns an 'int'.
Fix this by returning 'netdev_tx_t' in this driver too.
Signed-off-by: Luc Van Oos
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, but the implementation in this
driver returns an 'int'.
Fix this by returning 'netdev_tx_t' in this driver too.
Signed-off-by: Luc Van Oostenryck
---
drivers/staging/wilc1000/linux_wlan.c
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, but the implementation in this
driver returns an 'int'.
Fix this by returning 'netdev_tx_t' in this driver too.
Signed-off-by: Luc Van Oostenryck
---
drivers/staging/wlan-ng/p80211netdev.c
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, but the implementation in this
driver returns an 'int'.
Fix this by returning 'netdev_tx_t' in this driver too.
Signed-off-by: Luc Van Oostenryck
---
drivers/staging/rtl8723bs/os_dep/ioctl
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, but the implementation in this
driver returns an 'int'.
Fix this by returning 'netdev_tx_t' in this driver too.
Signed-off-by: Luc Van Oostenryck
---
drivers/staging/ks7010/ks_wlan_net.c |
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, but the implementation in this
driver returns an 'int'.
Fix this by returning 'netdev_tx_t' in this driver too.
Signed-off-by: Luc Van Oostenryck
---
drivers/staging/unisys/visornic/visorn
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, but the implementation in this
driver returns an 'int'.
Fix this by returning 'netdev_tx_t' in this driver too.
Signed-off-by: Luc Van Oostenryck
---
drivers/staging/gdm724x/gdm_lte.c | 2
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, but the implementation in this
driver returns an 'int'.
Fix this by returning 'netdev_tx_t' in this driver too.
Signed-off-by: Luc Van Oostenryck
---
drivers/net/hyperv/netvsc_drv.c | 2 +-
The method struct drm_connector_helper_funcs::mode_valid is defined
as returning an 'enum drm_mode_status' but the driver implementation
for this method uses an 'int' for it.
Fix this by using 'enum drm_mode_status' in the driver too.
Signed-off-by: Luc Van Oostenryck
---
drivers/staging/vboxvi
On Tue, Apr 24, 2018 at 09:44:59AM +0200, Kirill Marinushkin wrote:
> In the current implementation, vchi_instance is inited during the first
> call of bcm2835_audio_open_connection(), and is never freed. It causes a
> memory leak when the module `snd_bcm2835` is removed.
>
> Here is how this comm
Hi Julia
Thank you for the patch.
On 03/08/17 13:26, Julia Lawall wrote:
> The data protected is video_out2 and the lock that is released is
> &video_out2->dma_queue_lock, so it seems that that lock should be
> taken as well.
I agree - this certainly looks like there was a copy/paste error perha
Hi Philipp,
On Mon 23 Apr 2018 at 15:46, Philipp Zabel wrote:
On Mon, 2018-04-23 at 14:47 +0100, Rui Miguel Silva wrote:
This patch adds the device tree nodes for csi, video
multiplexer and mipi-csi
besides the graph connecting the necessary endpoints to make
the media capture
entities to work
Hi Philipp,
On Mon 23 Apr 2018 at 15:48, Philipp Zabel wrote:
On Mon, 2018-04-23 at 14:47 +0100, Rui Miguel Silva wrote:
Add imx7 capture subsystem to imx-media core to allow the use
some of the
existing modules for i.MX5/6 with i.MX7 SoC.
Since i.MX7 does not have an IPU unset the ipu_present
Hi Kirill,
Am 24.04.2018 um 02:35 schrieb Kirill Marinushkin:
On 04/23/18 15:50, Greg Kroah-Hartman wrote:
On Tue, Apr 17, 2018 at 07:00:28AM +0200, Kirill Marinushkin wrote:
In the current implementation, vchi_instance is inited during the first
call of bcm2835_audio_open_connection(), and is
In the current implementation, vchi_instance is inited during the first
call of bcm2835_audio_open_connection(), and is never freed. It causes a
memory leak when the module `snd_bcm2835` is removed.
Here is how this commit fixes it:
* the VCHI context (including vchi_instance) is created once in
On Tue, Apr 24, 2018 at 02:35:50AM +0200, Kirill Marinushkin wrote:
> On 04/23/18 15:50, Greg Kroah-Hartman wrote:
> > On Tue, Apr 17, 2018 at 07:00:28AM +0200, Kirill Marinushkin wrote:
> >> In the current implementation, vchi_instance is inited during the first
> >> call of bcm2835_audio_open_con
70 matches
Mail list logo
