On Nov 17, 2017, at 04:46, Roman Storozhenko wrote:
>
> There are two reasons for that:
> 1) As Linus Torvalds said we should use kernel types:
> http://lkml.iu.edu/hypermail//linux/kernel/1506.0/00160.html
>
> 2) There are only few places in the lustre codebase that use such types.
> In the mos
> -Original Message-
> From: Christoph Hellwig [mailto:h...@infradead.org]
> Sent: Friday, November 17, 2017 2:18 PM
> To: Kershner, David A
> Cc: gre...@linuxfoundation.org; jes.soren...@gmail.com; linux-
> ker...@vger.kernel.org; driverdev-devel@linuxdriverproject.org; *S-Par-
> Maintain
On Thu, Nov 16, 2017 at 09:56:50AM -0800, Todd Kjos wrote:
> +static struct files_struct *binder_get_files_struct(struct binder_proc *proc)
> +{
> + return get_files_struct(proc->tsk);
> +}
Hell, _no_. You should never, ever use the result of get_files_struct() for
write access. It's strict
Please don' tcreate new subdirectories under include/linux
if you don't have to.
Also who outside of unisys has reviewed this whole code?
Instead of a move please send an actual patchset to add the new files
so people can review it just like any other code.
___
Hi,
On Fri, Nov 17, 2017 at 11:45:06AM -0600, Steven J. Hill wrote:
> On 11/17/2017 04:06 AM, James Hogan wrote:
> > On Fri, Nov 17, 2017 at 09:50:10AM +0200, Aaro Koskinen wrote:
> >> Commit edf188bee1d9 ("MIPS: Octeon: Remove usage of cvmx_wait()
> >> everywhere.") deleted cvmx_wait() but forgot
From: Colin Ian King
The break statement is indented one level too many, fix this.
Signed-off-by: Colin Ian King
---
drivers/staging/ccree/ssi_aead.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ccree/ssi_aead.c b/drivers/staging/ccree/ssi_aead.c
index ba
On 11/17/2017 04:06 AM, James Hogan wrote:
> On Fri, Nov 17, 2017 at 09:50:10AM +0200, Aaro Koskinen wrote:
>> Commit edf188bee1d9 ("MIPS: Octeon: Remove usage of cvmx_wait()
>> everywhere.") deleted cvmx_wait() but forgot to update OCTEON USB
>> staging driver. Fix that to allow driver build.
>>
>
The s-Par header files that are referenced by all s-Par drivers, are being
moved into include/linux/visorbus. Move the visorbus driver out of staging
and modify the configuration and makefiles so they now reference the new
file, this required moving some lines from drivers/staging/unisys/Kconfig
o
This patch series fixes an issue that was reported by Dan Carpenter, moves
the necessary include files to include/linux/visorbus and then moves the
visorbus driver from drivers/staging/unisys to drivers/visorbus.
Greg, thanks for the review of visorbus and for the assistance to get the
driver to t
From: Tim Sell
Add necessary casting to several places where we were doing 32-bit
arithmetic (unsigned) to produce a 64-bit (unsigned long) result, to
prevent the theoretical possibility of a 32-bit overflow during the
arithmetic.
FYI, these are unsigned long:
ctx->param_bytes
c
On 11/17/2017 08:50 AM, Colin King wrote:
From: Colin Ian King
dev_alloc_skb can potentially return NULL, so add a null check to
avoid a null pointer dereference on skb
Acked-by: Larry Finger
Larry
Detected by CoverityScan, CID#1454558 ("Dereference on null return")
Fixes: 7e5b796cde7e
From: Colin Ian King
dev_alloc_skb can potentially return NULL, so add a null check to
avoid a null pointer dereference on skb
Detected by CoverityScan, CID#1454558 ("Dereference on null return")
Fixes: 7e5b796cde7e ("staging: r8822be: Add the driver code")
Signed-off-by: Colin Ian King
---
d
From: Laurentiu Tudor
Replace strcmp() based device type checks with the standard device
model type.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/dprc-driver.c | 4 ++--
drivers/staging/fsl-mc/bus/fsl-mc-allocator.c | 20 ++--
drivers/staging/fsl-mc/bus/f
From: Laurentiu Tudor
No need to use EXPORT_SYMBOL() so switch to the GPL variant.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/dpio/dpio-service.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/fsl-mc/bus/dpio/dpio-s
From: Laurentiu Tudor
These WARN_ONs shouldn't trigger unless something went very wrong.
Since the driver is in a stable state let's remove these debug
WARN_ONs.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/dprc-driver.c | 8
drivers/staging/fsl-mc/bus/f
From: Laurentiu Tudor
The MC bus has different types of devices and this is supported by
device model. This patch adds initial support for device types
(defines them, adds helpers and sets the device type).
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 67 +++
From: Laurentiu Tudor
The bus driver is mixing EXPORT_SYMBOL()/EXPORT_SYMBOL_GPL() usage.
Change it to consistently use EXPORT_SYMBOL_GPL().
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/dpbp.c | 16
drivers/staging/fsl-mc/bus/dpcon.c | 14 +++---
dr
From: Laurentiu Tudor
A lot of error checks are doubled by debug WARN_ONs. Given that the
driver was thoroughly debugged and is in a stable state, it's time to
drop them.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/dprc-driver.c | 20 ++---
drivers/staging/fsl-mc/bu
From: Laurentiu Tudor
These couple of functions are not yet used so lets remove them
for now and add them back when/if needed.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/dpio/dpio-service.c | 58 --
drivers/staging/fsl-mc/include/dpaa2-io.h | 4
From: Laurentiu Tudor
These functions are only used within this driver so no need for
EXPORT_SYMBOL().
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/dpio/dpio-service.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/fsl-mc/bus/dpio/dpio-service.c
b/drive
From: Laurentiu Tudor
There's an unfinished implementation of reference counting for dpaa2_io
structure using atomics. Since it's unused lets remove it for now and,
if needed at a later time, make use of krefs instead of rolling our
own refcounting.
Signed-off-by: Laurentiu Tudor
---
drivers/s
From: Laurentiu Tudor
Couple of API functions are not used so lets drop them together with
the associated structures and defines.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/dpcon-cmd.h | 6 ---
drivers/staging/fsl-mc/bus/dpcon.c | 69 --
There are two reasons for that:
1) As Linus Torvalds said we should use kernel types:
http://lkml.iu.edu/hypermail//linux/kernel/1506.0/00160.html
2) There are only few places in the lustre codebase that use such types.
In the most cases it uses 'u32' and 'u64'.
Signed-off-by: Roman Storozhenko
On Fri, Nov 17, 2017 at 11:40 AM, Thomas Gleixner wrote:
> On Fri, 17 Nov 2017, Arnd Bergmann wrote:
>> On Fri, Nov 17, 2017 at 10:54 AM, Thomas Gleixner wrote:
>> > On Fri, 17 Nov 2017, Arnd Bergmann wrote:
>> >> On Fri, Nov 17, 2017 at 9:58 AM, Thomas Gleixner
>> >> wrote:
>> >>
>> >> No, sys
On Fri, 17 Nov 2017, Arnd Bergmann wrote:
> On Fri, Nov 17, 2017 at 10:54 AM, Thomas Gleixner wrote:
> > On Fri, 17 Nov 2017, Arnd Bergmann wrote:
> >> On Fri, Nov 17, 2017 at 9:58 AM, Thomas Gleixner
> >> wrote:
> >>
> >> No, syscall that existing 32-bit user space enters would be handled by
>
On Fri, Nov 17, 2017 at 10:54 AM, Thomas Gleixner wrote:
> On Fri, 17 Nov 2017, Arnd Bergmann wrote:
>> On Fri, Nov 17, 2017 at 9:58 AM, Thomas Gleixner wrote:
>>
>> No, syscall that existing 32-bit user space enters would be handled by
>> compat_sys_nanosleep() on both 32-bit and 64-bit kernels
On Fri, Nov 17, 2017 at 09:50:10AM +0200, Aaro Koskinen wrote:
> Commit edf188bee1d9 ("MIPS: Octeon: Remove usage of cvmx_wait()
> everywhere.") deleted cvmx_wait() but forgot to update OCTEON USB
> staging driver. Fix that to allow driver build.
>
> Fixes: edf188bee1d9 ("MIPS: Octeon: Remove usag
On Thu, Nov 16, 2017 at 4:10 PM, Peter Zijlstra wrote:
> Well, I go by the one described in all the real-time computing texts;
> also found on Wikipedia FWIW:
>
> https://en.wikipedia.org/wiki/Priority_inheritance
Guess I was taking inheritance too literally :-)
>
>> This behavior is also rela
On Fri, 17 Nov 2017, Arnd Bergmann wrote:
> On Fri, Nov 17, 2017 at 9:58 AM, Thomas Gleixner wrote:
> > On Fri, 17 Nov 2017, Arnd Bergmann wrote:
> >> On Thu, Nov 16, 2017 at 10:04 AM, Thomas Gleixner
> >> wrote:
> >> > On Wed, 15 Nov 2017, Deepa Dinamani wrote:
> >> >> Would this work for every
On Thu, Nov 16, 2017 at 12:37:02PM -0800, Todd Kjos wrote:
> Sorry about that, do you want a v3 with correct annotations?
Nah, this time is fine :)
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listin
On Fri, Nov 17, 2017 at 9:58 AM, Thomas Gleixner wrote:
> On Fri, 17 Nov 2017, Arnd Bergmann wrote:
>> On Thu, Nov 16, 2017 at 10:04 AM, Thomas Gleixner wrote:
>> > On Wed, 15 Nov 2017, Deepa Dinamani wrote:
>> >> Would this work for everyone?
>> >
>> > Having extra config switches which are sele
On Fri, 17 Nov 2017, Arnd Bergmann wrote:
> On Thu, Nov 16, 2017 at 10:04 AM, Thomas Gleixner wrote:
> > On Wed, 15 Nov 2017, Deepa Dinamani wrote:
> >> Would this work for everyone?
> >
> > Having extra config switches which are selectable by architectures and
> > removed when everything is conve
Commit edf188bee1d9 ("MIPS: Octeon: Remove usage of cvmx_wait()
everywhere.") deleted cvmx_wait() but forgot to update OCTEON USB
staging driver. Fix that to allow driver build.
Fixes: edf188bee1d9 ("MIPS: Octeon: Remove usage of cvmx_wait() everywhere.")
Signed-off-by: Aaro Koskinen
---
drivers
33 matches
Mail list logo
