> -----Original Message----- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Friday, November 17, 2017 2:18 PM > To: Kershner, David A <david.kersh...@unisys.com> > Cc: gre...@linuxfoundation.org; jes.soren...@gmail.com; linux- > ker...@vger.kernel.org; driverdev-devel@linuxdriverproject.org; *S-Par- > Maintainer <sparmaintai...@unisys.com>; erik.arfvid...@gmail.com; > wadgaonkar...@gmail.com > Subject: Re: [PATCH 2/2] drivers: visorbus: move driver out of staging > > Please don' tcreate new subdirectories under include/linux > if you don't have to. >
Thanks for the feedback, the s-Par drivers have 3 include files in the include directory in drivers/staging/unisys/include. The patch currently moves 2 of them, and the third will be moved when the other drivers get out of staging. When I did the move, I thought one directory with three files would be cleaner than just adding three files to include. I will change that. > Also who outside of unisys has reviewed this whole code? > The driver has been in staging for 4 years with significant rework during that period of time. Throughout that time, we have had input from several different engineers, including Dan Carpenter, Jes Sorenson, and Greg KH. In October, I requested a formal review from the community and after the review had completed, Greg gave us the okay to move them out of staging. > Instead of a move please send an actual patchset to add the new files > so people can review it just like any other code. Okay, I'll redo the patchset to show the explicit add of the files to the drivers directory. Thanks, David Kershner
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
