[PATCH] Staging: rtl8192u: ieee80211: ieee80211_module.c: fix style issue

2017-05-06 Thread Riccardo Marotti
From: Riccardo Fixed a brace coding style issue, found via checkpatch. Signed-off-by: Riccardo Marotti --- drivers/staging/rtl8192u/ieee80211/ieee80211_module.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c b/driver

Re: [PATCH] Staging: rtl8192u: ieee80211: ieee80211_module.c: fix style issue

2017-05-06 Thread Riccardo Marotti
On Sun, May 7, 2017 at 5:14 AM, Greg KH wrote: > On Thu, May 04, 2017 at 10:06:51PM +0200, Riccardo wrote: >> Fixed a brace coding style issue, found via checkpatch. >> >> Signed-off-by: Riccardo Marotti > > This name doesn't match the name on the From: line of your email :( > Sorry about that!

Re: [PATCH] Fix spaces ERROR in atomisp_gmin_platform.c

2017-05-06 Thread Dan Carpenter
On Sat, May 06, 2017 at 03:56:23PM +0300, Gideon Sheril wrote: > int atomisp_register_i2c_module(struct v4l2_subdev *subdev, > -struct camera_sensor_platform_data > *plat_data, > -enum intel_v4l2_subdev_type type) > + struct came

[PATCH v4] staging: rtl8723bs: remove re-positioned call to kfree in os_dep/ioctl_cfg80211.c

2017-05-06 Thread Ian W MORRISON
A kernel cloned from git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git and built with the latest RTL8723BS driver included (CONFIG_RTL8723BS=m) fails when booting on an Intel Atom device with the RTL8723BS wifi chipset due to an error in drivers/staging/rtl8723bs/os_dep/ioctl_cf

Re: [PATCH v3] staging: rtl8723bs: remove re-positioned call to kfree in os_dep/ioctl_cfg80211.c

2017-05-06 Thread Greg KH
On Sun, May 07, 2017 at 01:37:39PM +1000, Ian W MORRISON wrote: > A kernel cloned from > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git and built > with the latest RTL8723BS driver included (CONFIG_RTL8723BS=m) fails when > booting on an Intel Atom device with the RTL8723BS wif

Re: [PATCH 1/8] staging: ks7010: avoid CamelCase in fields of struct local_gain_t

2017-05-06 Thread Greg Kroah-Hartman
On Sat, Apr 29, 2017 at 10:58:41PM +0200, Janusz Lisiecki wrote: > Replace CamelCase fields of struct with underscores to comply > with the standard kernel coding style > > Signed-off-by: Janusz Lisiecki > Reviewed-by: Tobin C. Harding Not all of the patches in this series applied to my tree.

[PATCH v3] staging: rtl8723bs: remove re-positioned call to kfree in os_dep/ioctl_cfg80211.c

2017-05-06 Thread Ian W MORRISON
A kernel cloned from git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git and built with the latest RTL8723BS driver included (CONFIG_RTL8723BS=m) fails when booting on an Intel Atom device with the RTL8723BS wifi chipset due to an error in drivers/staging/rtl8723bs/os_dep/ioctl_cfg

Re: [PATCH] staging: fbtft: fbtft-io.c: Fix sparse warning

2017-05-06 Thread Greg Kroah-Hartman
On Sat, Apr 29, 2017 at 08:45:08AM +0200, AbdAllah-MEZITI wrote: > This patch fixes the following sparse warning in fbtft/fbtft-io.c > > CHECK drivers/staging/fbtft/fbtft-io.c > drivers/staging/fbtft/fbtft-io.c:74:29: warning: incorrect type in assignment > (different base types) > drivers/st

Re: [PATCH] staging: vt6656: rtxt.c Fix CODE_INDENT type errors

2017-05-06 Thread Greg KH
On Wed, May 03, 2017 at 01:12:40PM +0100, Salvatore Benedetto wrote: > Fix all CODE_INDENT type errors reported by checkpatch > in rtxt.c > > Signed-off-by: Salvatore Benedetto > --- > drivers/staging/vt6656/rxtx.c | 49 > ++- > 1 file changed, 25 inserti

Re: [PATCH] vt6656: Coding style fixes

2017-05-06 Thread Greg KH
On Thu, May 04, 2017 at 05:33:48PM +0200, Simo Koskinen wrote: > Fixed coding style warnings reported by checkpatch.pl. Which one(s)? you need to be specific here. Please fix up and resend. thanks, greg k-h ___ devel mailing list de...@linuxdriverpro

Re: [PATCH] staging: fix macros with multiple statements in rtl8723bs/core/rtw_security.c

2017-05-06 Thread Greg KH
On Fri, May 05, 2017 at 02:00:43AM +0800, Jamie Huang wrote: > ERROR: Macros with multiple statements should be enclosed in a do - while loop > Detected by scripts/checkpatch.pl -f > > Signed-off-by: Jamie Huang > --- > drivers/staging/rtl8723bs/core/rtw_security.c | 34 > +++---

Re: [PATCH] Staging: rtl8192u: ieee80211: ieee80211_module.c: fix style issue

2017-05-06 Thread Greg KH
On Thu, May 04, 2017 at 10:06:51PM +0200, Riccardo wrote: > Fixed a brace coding style issue, found via checkpatch. > > Signed-off-by: Riccardo Marotti This name doesn't match the name on the From: line of your email :( ___ devel mailing list de...@li

Re: [PATCH] Fix spaces ERROR in atomisp_gmin_platform.c

2017-05-06 Thread Greg KH
On Sat, May 06, 2017 at 03:56:23PM +0300, Gideon Sheril wrote: > staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c: > Fixing style ERRORs related to spaces instead of tabs > and comma/assignment space padding. > > Signed-off-by: Gideon Sheril > --- Now it's too short :) Look at o

Re: [PATCH 1/3] staging: ccree: resolve training whitespace in cc_hal.h

2017-05-06 Thread Greg KH
On Sat, May 06, 2017 at 03:46:54PM -0700, Matthew Giassa wrote: > Removing trailing newlines reported by checkpatch.pl. ie: > ERROR: trailing whitespace (lines 3, 7, 12). > > Warnings no longer present after change. > > Signed-off-by: Matthew Giassa > --- > drivers/staging/ccree/cc_hal.h | 6 ++

Re: [PATCH 0/3] staging: ccree: resolve checkpatch issues.

2017-05-06 Thread Matthew Giassa
* Matthew Giassa [2017-05-06 15:46:53 -0700]: Included is a set of small fixes to resolve all outstanding checkpatch warnings issues for drivers/staging/ccree/cc_hal.h. Two are cosmetic (training whitespace and 80+ character comment), and the other is functional (macro argument previously not w

[PATCH 2/3] staging: ccree: resolve columns over 80 chars in cc_hal.h

2017-05-06 Thread Matthew Giassa
Modified comment to resolve 80+ characters warning from checkpatch. ie: WARNING: line over 80 characters Warnings no longer present after change. Signed-off-by: Matthew Giassa --- drivers/staging/ccree/cc_hal.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/stagi

[PATCH 1/3] staging: ccree: resolve training whitespace in cc_hal.h

2017-05-06 Thread Matthew Giassa
Removing trailing newlines reported by checkpatch.pl. ie: ERROR: trailing whitespace (lines 3, 7, 12). Warnings no longer present after change. Signed-off-by: Matthew Giassa --- drivers/staging/ccree/cc_hal.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/stag

[PATCH 0/3] staging: ccree: resolve checkpatch issues.

2017-05-06 Thread Matthew Giassa
Included is a set of small fixes to resolve all outstanding checkpatch warnings issues for drivers/staging/ccree/cc_hal.h. Two are cosmetic (training whitespace and 80+ character comment), and the other is functional (macro argument previously not wrapped in parentheses). _

[PATCH 3/3] staging: ccree: resolve possible macro issue in cc_hal.h

2017-05-06 Thread Matthew Giassa
Wrapping "offset" in macro definition to resolve checkpatch issue, ie: CHECK: Macro argument 'offset' may be better as '(offset)' to avoid precedence issues Signed-off-by: Matthew Giassa --- drivers/staging/ccree/cc_hal.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/d

Re: [PATCH 3/3] staging: rtl8723bs: fix up for cfg80211_roamed() API change

2017-05-06 Thread kbuild test robot
Hi Stephen, [auto build test ERROR on staging/staging-testing] [cannot apply to v4.11 next-20170505] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Greg-KH/staging-rtl8723bs-merge-fix-for-add-ch

Re: [PATCH 2/3] staging: rtl8723bs: merge fix for "nl80211: allow multiple active scheduled scan requests"

2017-05-06 Thread kbuild test robot
Hi Stephen, [auto build test ERROR on staging/staging-testing] [cannot apply to v4.11 next-20170505] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Greg-KH/staging-rtl8723bs-merge-fix-for-add-ch

Re: [PATCH] staging: lustre: llite: Fix variable length array warning

2017-05-06 Thread Guru Das Srinagesh
On Fri, May 05, 2017 at 01:52:36AM -0700, Joe Perches wrote: > On Thu, 2017-05-04 at 23:41 -0700, Guru Das Srinagesh wrote: > > Fix sparse warning "warning: Variable length array is used." by using > > kmalloc_array to allocate the required amount of memory instead and > > kfree to deallocate memor

Re: [PATCH v2] staging: rtl8723bs: remove re-positioned call to kfree in os_dep/ioctl_cfg80211.c

2017-05-06 Thread Greg KH
On Sat, May 06, 2017 at 03:47:50AM +1000, Ian W MORRISON wrote: > The following patch was sent to linux-wirel...@vger.kernel.org and > various wifi driver developers however I've just realized that I > should have sent it to driverdev-devel@linuxdriverproject.org. It was > reviewed on 01 May with t

Re: [GIT PULL] Staging/IIO driver fixes for 4.12-rc1

2017-05-06 Thread Greg KH
On Sun, May 07, 2017 at 12:21:17AM +1000, Ian W MORRISON wrote: > > On 5/6/17 11:41 PM, Greg KH wrote: > > On Sat, May 06, 2017 at 06:00:24PM +1000, Ian W MORRISON wrote: > > > The kernel when booted with Ubuntu 17.04 results in an unusable system > > > however with the following patch booting is

Re: [GIT PULL] Staging/IIO driver fixes for 4.12-rc1

2017-05-06 Thread Ian W MORRISON
On 5/6/17 11:41 PM, Greg KH wrote: On Sat, May 06, 2017 at 06:00:24PM +1000, Ian W MORRISON wrote: The kernel when booted with Ubuntu 17.04 results in an unusable system however with the following patch booting is successful and the system is usable. The patch and kernel builds have been tested

[PATCH] Staging: greybus: Prefer kcalloc over kzalloc

2017-05-06 Thread karthik
From: Karthik Tummala Fixed following checkpatch.pl warning: * WARNING: Prefer kcalloc over kzalloc with multiply Instead of specifying no.of bytes * size as arugment in kzalloc, prefer kcalloc. Signed-off-by: Karthik Tummala --- drivers/staging/greybus/light.c | 4 ++-- 1 file changed, 2 in

Re: [GIT PULL] Staging/IIO driver fixes for 4.12-rc1

2017-05-06 Thread Greg KH
On Sat, May 06, 2017 at 06:00:24PM +1000, Ian W MORRISON wrote: > The kernel when booted with Ubuntu 17.04 results in an unusable system > however with the following patch booting is successful and the system > is usable. The patch and kernel builds have been tested against on an > Intel Compute St

Re: [PATCH] Staging: rtl8723bs: core: Fixed a brace coding style issue

2017-05-06 Thread Joe Perches
On Sat, 2017-05-06 at 14:00 +0200, Rene Hickersberger wrote: > Fixed a brace coding style issue. [] > diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c > b/drivers/staging/rtl8723bs/core/rtw_cmd.c [] > @@ -863,11 +863,10 @@ u8 rtw_joinbss_cmd(struct adapter *padapter, struct > wlan_network *

[PATCH] Fix spaces ERROR in atomisp_gmin_platform.c

2017-05-06 Thread Gideon Sheril
staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c: Fixing style ERRORs related to spaces instead of tabs and comma/assignment space padding. Signed-off-by: Gideon Sheril --- .../platform/intel-mid/atomisp_gmin_platform.c | 180 ++--- 1 file changed, 89 insertio

[PATCH] Staging: rtl8723bs: core: Fixed a brace coding style issue

2017-05-06 Thread Rene Hickersberger
Fixed a brace coding style issue. Signed-off-by: Rene Hickersberger --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c index 080c81b..ec2e569 10

[PATCH -next] staging/android/ion: remove useless document file

2017-05-06 Thread Yisheng Xie
From: Yisheng Xie After commit 9828282e33a0 ("staging: android: ion: Remove old platform support"), the document about devicetree of ion is no need anymore, so just remove it. Signed-off-by: Yisheng Xie --- .../devicetree/bindings/staging/ion/hi6220-ion.txt | 31 - MAINTAINERS

Re: [PATCH v2 4/7] staging: rtl8723bs: Move braces to same line as conditional

2017-05-06 Thread Bastien Nocera
On Fri, 2017-05-05 at 16:10 -0600, Justin Vreeland wrote: > > Sorry about blank email. > > I'm not 100% happy with it either.  Larry Finger suggested to fix the > overly long lines so I tried to find a decent way to shorten them.  I > think the best way would be to change the function names or p

Re: [GIT PULL] Staging/IIO driver fixes for 4.12-rc1

2017-05-06 Thread Ian W MORRISON
On 6 May 2017 at 07:56, Greg KH wrote: > Note: There will be a merge conflict when you pull this into your tree > in drivers/staging/Kconfig. Sorry about that, it was a stupid mistake > on my part when I added a new driver to staging from the USB tree and I > tried to do it without a merge confl