On Sun, May 07, 2017 at 01:37:39PM +1000, Ian W MORRISON wrote: > A kernel cloned from > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git and built > with the latest RTL8723BS driver included (CONFIG_RTL8723BS=m) fails when > booting on an Intel Atom device with the RTL8723BS wifi chipset due to an > error in drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c. > > The kernel when booted with Ubuntu 17.04 results in an unusable system > however with the following patch booting is successful and the system is > usable. The patch and kernel builds have been tested against on an Intel > Compute Stick (STCK1A32WFC model). > > This version of the patch (version 3) has tabs rather than spaces and no wrap > around. The patch has received one review: > > Patch looks good to me: > Reviewed-by: Hans de Goede <hdego...@redhat.com>
Lots of this should go below in the changelog area of the patch, right? And properly wrap your lines at 72 columns, so we can read it :) > > Regards, > Ian > > From: Ian W Morrison <linux...@linuxium.com.au> > Date: Fri, 28 Apr 2017 02:20:38 +1000 > Subject: [PATCH] staging: rtl8723bs: remove a call to kfree in > os_dep/ioctl_cfg80211.c Why is this here in the middle of the patch changelog? > > Signed-off-by: Ian W Morrison <linux...@linuxium.com.au> No changelog text at all? Take a look at how other patches are on the mailing list, that should give you a good template of what to do here. > --- > drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c > b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c > index f17f4fb..2ee9df5 100644 > --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c > +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c > @@ -3527,7 +3527,6 @@ int rtw_wdev_alloc(struct adapter *padapter, struct > device *dev) > pwdev_priv->power_mgmt = true; > else > pwdev_priv->power_mgmt = false; > - kfree((u8 *)wdev); > > return ret; tabs are there!!!! At least that part works :) thanks, greg k-h _______________________________________________ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
