> I think we can call this question resolved. Remove the comment and
> change the hostif_hdr description to
>
> struct hostif_hdr {
> __be16 size;
> __be16 event;
> } __packed;
>
> Are you happy with this?
Yes, I trust you.
signature.asc
Description: PGP signature
___
Looks good,
Reviewed-by: Christoph Hellwig
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Looks good,
Reviewed-by: Christoph Hellwig
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Wed, Apr 19, 2017 at 01:34:46PM +1000, Tobin C. Harding wrote:
> Hi Wolfram,
>
> May I please ask you with an ks7010 driver endianness question?
>
> Comments on the hostif_hdr data structure (ks_hostif.h) state that the
> target uses little endian byte order.
>
> /*
> * HOST-MAC I/F data str
On Wed, Apr 12, 2017 at 11:25 AM, Ioana Radulescu
wrote:
> Add a list of TODO items for the Ethernet driver
>
> Signed-off-by: Ioana Radulescu
> ---
> v2: Add note
>
> drivers/staging/fsl-dpaa2/ethernet/TODO | 14 ++
> 1 file changed, 14 insertions(+)
> create mode 100644 drivers/st
Hi Wolfram,
May I please ask you with an ks7010 driver endianness question?
Comments on the hostif_hdr data structure (ks_hostif.h) state that the
target uses little endian byte order.
/*
* HOST-MAC I/F data structure
* Byte alignmet Little Endian
*/
struct hostif_hdr {
u16 size;
Hi Logan,
[auto build test ERROR on linus/master]
[also build test ERROR on v4.11-rc7 next-20170418]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Logan-Gunthorpe/dma-buf-Rename-dma-ops-to
On Apr 18, 2017, at 09:50, g...@kroah.com wrote:
>
> On Sat, Apr 15, 2017 at 01:50:42PM +, Rishiraj Manwatkar wrote:
>> Subject: [Patch v3 1/2] lustre: Parantheses added for Macro argument to
>> avoid precedence issues
(typo) s/Parantheses/parenthesis/ s/Macro/macro/
The Subject line (exclu
On Apr 15, 2017, at 07:50, Rishiraj Manwatkar wrote:
>
> Comparison should have the CONSTANT on the right side of the test
I don't think this change really improves things. For standalone comparisons I
agree
that having the constant on the RHS is best, but here it is like a normal
mathematica
Seeing the kunmap_atomic dma_buf_op shares the same name with a macro
in higmem.h, the former can be aliased if any dma-buf user includes
that header.
I'm personally trying to include highmem.h inside scatterlist.h and this
breaks the dma-buf code proper.
Christoph Hellwig suggested [1] renaming
From: Sameer Wadgaonkar
The root issue is that we are not allowed to have items on the
stack being passed to "DMA" like operations. In this case we have
a vmcall and an inline completion of scsi command.
This patch fixes the issue by moving the variables on stack in
do_scsi_nolinuxstat() to heap
Remove POSTCODEs from visorchipset_init and replace them with dev_err when
needed.
Since there are no more POSTCODEs in the code, we can get rid of the data
in the header file as well.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c|
Replace POSTCODEs with dev_err in the function my_device_changestate.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
b/
Replace postcodes with dev_err in the function
setup_crash_device_work_queue.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 33 ---
1 file changed, 14 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/unisys/v
The postcodes in visorchipset_exit were not displaying errors, they can
just be removed.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
Replace the POSTCODEs with dev_err in my_device_create.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 24 +++
1 file changed, 9 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
From: Sameer Wadgaonkar
The root issue is that we are not allowed to have items on the
stack being passed to "DMA" like operations. In this case we have
vmcall operation that was using parameters from the stack.
This patch fixes the issue by moving the variables on stack in
issue_vmcall_io_contr
Remove the POSTCODE logging from bus_configure, replace it with an
error message if we fail dumping the errno.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 14 ++
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git
The if statement was sending us down the happy path with the error path
in the else. This can be simplified by having the if be the error and
just falling through with the good path.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 11
Remove the POSTCODES in visorbus_init. Since there are no more POSTCODES
in visorbus_main.c we can remove the reference to the vmcallinterface
header file.
No need for vmcallinterface in visorbus_main.c
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/vis
Get rid of postcodes from visorbus_main.c that are just informational.
They were not logging errors, we don't need to replace them with
anything.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 21 +-
1 file changed, 2 i
Replace POSTCODES in save_crash_msg with dev_err handling.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 24 +--
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipse
Removed the POSTCODEs from the function bus_create.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 14 ++
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
b/driver
Since kzalloc will display error the postcode becomes redundant, it
can be removed.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
b/driv
Remove POSTCODES from create_visor_device, when we fail log an error
with dev_err.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/unisys/visorbu
Remove postcodes from create_bus_instance. If there is an error log
it with dev_err.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/unisys/visorbu
Get rid of the postcodes from the function chipset_init. They were
being noisy, so don't replace them with errors.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/unisys/v
Allow retry when allocating memory.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
b/drivers/staging/unisys/visorbus/
Shouldn't use uint32 in the kernel, it can be replaced with int here.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
b/driv
Catch and report back errors when visorchannel_write fails.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchannel.c | 35 ---
1 file changed, 16 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/unisys/visorbus/visorchann
Comment was outdated and did not reflect what was actually happening.
Update the comment to reflect reality.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git
Limit the amount that gets pulled from the queue on each try so we don't
get stuck in an infinite loop if something has gone wrong with the s-Par
firmware.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 3 ++-
1 file changed, 2 insertion
The following patch series removes the POSTCODE macros from the codebase,
replacing them with dev_err where needed. It also fixes a problem with the
drivers that were preventing them from working when CONFIG_VMAP_STACK was
set to y.
David Kershner (23):
staging: unisys: visorbus: combine respons
Functions in c files don't need to be inlined, get rid of the keyword.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visornic/visornic_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visornic/visornic_main.c
b/d
Moved the brace to the left to fix the indentation issue.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visorbus/visorchipset.c
b/drivers/staging/
There are several different controlvm response functions, consolidate them
to one so we can simplify error handling.
Signed-off-by: David Kershner
Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 53 +++
1 file changed, 22 insertions(+), 31 deletions(-)
On Tue, Apr 18, 2017 at 01:52:01PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Apr 11, 2017 at 10:19:08AM +0200, Jakub Jedelsky wrote:
> > Fixing warnings found by sparse on rtl8192u/ieee80211.
> >
> > drivers/staging/rtl8192u/ieee80211//ieee80211_rx.c:1318:45: warning:
> > incorrect type in assig
On Tue, Apr 18, 2017 at 08:24:01PM +0200, Johan Svensson wrote:
> Change capability field to __le16 in struct ap_info_t,
> struct link_ap_info_t, and struct local_ap_t.
> This fixes a sparse warning.
What warning is it fixing? And are you sure this is the correct fix?
How did you test it?
thanks
This never got set in the ioctl. Properly set a return value of 0 on
success.
Signed-off-by: Laura Abbott
---
drivers/staging/android/ion/ion.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/android/ion/ion.c
b/drivers/staging/android/ion/ion.c
index 9eeb06f..d6fd350 100644
The current model of Ion heap registration is based on the outdated
model of board files. The replacement for board files (devicetree)
isn't a good replacement for what Ion wants to do. In actuality, Ion
wants to show what memory is available in the system for something else
to figure out what to
Most of the items have been taken care of by a clean up series. Remove
the completed items and add a few new ones.
Signed-off-by: Laura Abbott
---
drivers/staging/android/TODO | 21 -
1 file changed, 4 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/android/TODO
Nobody uses this interface externally. Drop it.
Signed-off-by: Laura Abbott
---
drivers/staging/android/ion/ion.c | 59 ---
1 file changed, 59 deletions(-)
diff --git a/drivers/staging/android/ion/ion.c
b/drivers/staging/android/ion/ion.c
index 7d40233..5a82
ion_handle was introduced as an abstraction to represent a reference to
a buffer via an ion_client. As frameworks outside of Ion evolved, the dmabuf
emerged as the preferred standard for use in the kernel. This has made
the ion_handle an unnecessary abstraction and prone to race
conditions. ion_cli
When CMA was first introduced, its primary use was for DMA allocation
and the only way to get CMA memory was to call dma_alloc_coherent. This
put Ion in an awkward position since there was no device structure
readily available and setting one up messed up the coherency model.
These days, CMA can be
Several of the Ion ioctls were designed in such a way that they
necessitate compat ioctls. We're breaking a bunch of other ABIs and
cleaning stuff up anyway so let's follow the ioctl guidelines and clean
things up while everyone is busy converting things over anyway. As part
of this, also remove th
Once upon a time, phys_addr_t was not everywhere in the kernel. These
days it is used enough places that having a separate Ion type doesn't
make sense. Remove the extra type and just use phys_addr_t directly.
Signed-off-by: Laura Abbott
---
drivers/staging/android/ion/ion.h | 12 ++
Frameworks (e.g. Ion) may want to iterate over each possible CMA area to
allow for enumeration. Introduce a function to allow a callback.
Signed-off-by: Laura Abbott
---
include/linux/cma.h | 2 ++
mm/cma.c| 14 ++
2 files changed, 16 insertions(+)
diff --git a/include/
Now that we have proper caching, stop setting the DMA address manually.
It should be set after properly calling dma_map.
Signed-off-by: Laura Abbott
---
drivers/staging/android/ion/ion.c | 17 +
1 file changed, 1 insertion(+), 16 deletions(-)
diff --git a/drivers/staging/android
Ion current has ion_priv.h and ion.h as header files. ion.h was intended
to be used for public APIs but Ion never ended up really having anything
public. Combine the two headers so there is only one internal header.
Signed-off-by: Laura Abbott
---
v4: minor cleanup suggested by Emil Velikov
---
Frameworks that may want to enumerate CMA heaps (e.g. Ion) will find it
useful to have an explicit name attached to each region. Store the name
in each CMA structure.
Signed-off-by: Laura Abbott
---
arch/powerpc/kvm/book3s_hv_builtin.c | 3 ++-
drivers/base/dma-contiguous.c| 5 +++--
i
Hi,
This is v4 of the series to cleanup to Ion. Greg took some of the patches
that weren't CMA related already. There was a minor bisectability problem
with the CMA APIs so this is a new version to address that. I also
addressed some minor comments on the patch to collapse header files.
Thanks,
L
Change capability field to __le16 in struct ap_info_t,
struct link_ap_info_t, and struct local_ap_t.
This fixes a sparse warning.
Signed-off-by: Johan Svensson
---
drivers/staging/ks7010/ks_hostif.h | 4 ++--
drivers/staging/ks7010/ks_wlan.h | 2 +-
2 files changed, 3 insertions(+), 3 deletion
On 18/04/17 09:50 AM, Konrad Rzeszutek Wilk wrote:
> I am not sure if you know, but you can add on each patch the respective
> maintainer via 'CC'. That way you can have certain maintainers CCed only
> on the subsystems they cover. You put it after (or before) your SoB and
> git send-email happil
On 04/17/2017 07:05 PM, Zengtao (B) wrote:
> Hi Laura:
>
>> -邮件原件-
>> 发件人: Laura Abbott [mailto:labb...@redhat.com]
>> 发送时间: 2017年4月18日 0:14
>> 收件人: Zengtao (B) ; sumit.sem...@linaro.org
>> 抄送: gre...@linuxfoundation.org; a...@android.com;
>> riandr...@android.com; de...@driverdev.osuosl.o
On Tue, Apr 18, 2017 at 09:42:20AM -0600, Logan Gunthorpe wrote:
>
>
> On 18/04/17 08:27 AM, Konrad Rzeszutek Wilk wrote:
> > Interesting that you didn't CC any of the maintainers. Could you
> > do that in the future please?
>
> Please read the cover letter. The distribution list for the patchs
On Sat, Apr 15, 2017 at 01:50:42PM +, Rishiraj Manwatkar wrote:
> Parantheses are added for Macro argument, to avoid precedence issues.
>
> Signed-off-by: Rishiraj Manwatkar
> ---
> v1 -> v2: Added mailing list in cc.
> v2 -> v3: Changed From: to be same as Signed-off-by:.
> drivers/stagin
On 18/04/17 12:44 AM, Daniel Vetter wrote:
> On Thu, Apr 13, 2017 at 04:05:18PM -0600, Logan Gunthorpe wrote:
>> This is a single straightforward conversion from kmap to sg_map.
>>
>> Signed-off-by: Logan Gunthorpe
>
> Acked-by: Daniel Vetter
>
> Probably makes sense to merge through some oth
On Tue, Apr 18, 2017 at 06:29:22PM +0300, Gilad Ben-Yossef wrote:
> On Tue, Apr 18, 2017 at 6:13 PM, Mark Rutland wrote:
> > On Tue, Apr 18, 2017 at 05:07:50PM +0300, Gilad Ben-Yossef wrote:
> >> Arm TrustZone CryptoCell 700 is a family of cryptographic hardware
> >> accelerators. It is supported
On 18/04/17 08:27 AM, Konrad Rzeszutek Wilk wrote:
> Interesting that you didn't CC any of the maintainers. Could you
> do that in the future please?
Please read the cover letter. The distribution list for the patchset
would have been way too large to cc every maintainer (even as limited as
it
On Tue, Apr 18, 2017 at 05:07:50PM +0300, Gilad Ben-Yossef wrote:
> Arm TrustZone CryptoCell 700 is a family of cryptographic hardware
> accelerators. It is supported by a long lived series of out of tree
> drivers, which I am now in the process of unifying and upstreaming.
> This is the first drop
Hi Mark,
On Tue, Apr 18, 2017 at 6:13 PM, Mark Rutland wrote:
> Hi,
>
> On Tue, Apr 18, 2017 at 05:07:50PM +0300, Gilad Ben-Yossef wrote:
>> Arm TrustZone CryptoCell 700 is a family of cryptographic hardware
>> accelerators. It is supported by a long lived series of out of tree
>> drivers, which
Hi,
On Tue, Apr 18, 2017 at 05:07:50PM +0300, Gilad Ben-Yossef wrote:
> Arm TrustZone CryptoCell 700 is a family of cryptographic hardware
> accelerators. It is supported by a long lived series of out of tree
> drivers, which I am now in the process of unifying and upstreaming.
> This is the first
> On Tue, Apr 18, 2017 at 5:40 AM, Reshetova, Elena
> wrote:
> >
> >
> >> On Mon, 6 Mar 2017 15:38:29 -0600
> >> Bjorn Helgaas wrote:
> >>
> >> > [+cc Hyper-V folks, -cc others]
> >> >
> >> > On Mon, Mar 06, 2017 at 04:21:04PM +0200, Elena Reshetova wrote:
> >> > > refcount_t type and correspondi
On Tue, Apr 18, 2017 at 02:13:59PM +, David Laight wrote:
> From: Logan Gunthorpe
> > Sent: 13 April 2017 23:05
> > Straightforward conversion to the new helper, except due to
> > the lack of error path, we have to warn if unmapable memory
> > is ever present in the sgl.
Interesting that you d
From: Logan Gunthorpe
> Sent: 13 April 2017 23:05
> Straightforward conversion to the new helper, except due to
> the lack of error path, we have to warn if unmapable memory
> is ever present in the sgl.
>
> Signed-off-by: Logan Gunthorpe
> ---
> drivers/block/xen-blkfront.c | 33 +++
Arm TrustZone CryptoCell 700 is a family of cryptographic hardware
accelerators. It is supported by a long lived series of out of tree
drivers, which I am now in the process of unifying and upstreaming.
This is the first drop, supporting the new CryptoCell 712 REE.
The code still needs some clean
On Mon, Apr 03, 2017 at 11:57:55AM -0700, Laura Abbott wrote:
> When CMA was first introduced, its primary use was for DMA allocation
> and the only way to get CMA memory was to call dma_alloc_coherent. This
> put Ion in an awkward position since there was no device structure
> readily available an
On Tue, Apr 18, 2017 at 5:40 AM, Reshetova, Elena
wrote:
>
>
>> On Mon, 6 Mar 2017 15:38:29 -0600
>> Bjorn Helgaas wrote:
>>
>> > [+cc Hyper-V folks, -cc others]
>> >
>> > On Mon, Mar 06, 2017 at 04:21:04PM +0200, Elena Reshetova wrote:
>> > > refcount_t type and corresponding API should be
>> >
On Tue, 2017-04-18 at 13:52 +0200, Greg KH wrote:
> On Sat, Apr 15, 2017 at 11:57:26AM +0530, surenderpolsani wrote:
> > kernel coding style doesn't allow the return statement
> > in void function.
> >
> > Signed-off-by: surenderpolsani
>
> I need a "real" name here, and in the from line please.
On Sun, Mar 26, 2017 at 06:58:24PM +0200, Alexandre Bailon wrote:
> Currently, the only hd controller supported by Greybus is the es2
> controller which only support is mainly a bridge between USB and UniPro.
> In order to use Greybus on devices that do not support UniPro,
> add a the Greybus netli
On Sun, Mar 26, 2017 at 06:58:24PM +0200, Alexandre Bailon wrote:
> Currently, the only hd controller supported by Greybus is the es2
> controller which only support is mainly a bridge between USB and UniPro.
> In order to use Greybus on devices that do not support UniPro,
> add a the Greybus netli
On Sat, Apr 15, 2017 at 11:57:26AM +0530, surenderpolsani wrote:
> kernel coding style doesn't allow the return statement
> in void function.
>
> Signed-off-by: surenderpolsani
I need a "real" name here, and in the from line please. Use what you
use to sign documents.
thanks,
greg k-h
___
On Tue, Apr 11, 2017 at 10:19:08AM +0200, Jakub Jedelsky wrote:
> Fixing warnings found by sparse on rtl8192u/ieee80211.
>
> drivers/staging/rtl8192u/ieee80211//ieee80211_rx.c:1318:45: warning:
> incorrect type in assignment (different base types)
> drivers/staging/rtl8192u/ieee80211//ieee80211_r
On Thu, Apr 13, 2017 at 08:14:23AM +0530, Aditya Shankar wrote:
> On Tue, 11 Apr 2017 19:35:46 +0200
> Greg KH wrote:
>
> > On Tue, Apr 11, 2017 at 10:11:43PM +0530, Aditya Shankar wrote:
> > > Change the config packet format used in handle_set_wfi_drv_handler()
> > > to align the host driver wit
On Tue, Apr 11, 2017 at 10:11:43PM +0530, Aditya Shankar wrote:
> Change the config packet format used in handle_set_wfi_drv_handler()
> to align the host driver with the new format used in the wilc firmware.
>
> The change updates the format in which the host driver provides the
> firmware with t
On Tue, Apr 18, 2017 at 10:35:43AM +1000, Tobin C. Harding wrote:
> Driver SDIO code is currently in files name ks7010_sdio.[ch]. These
> names are not uniform with the rest of the files in this driver. This
> driver only covers a single chipset, the file prefix does not add any
> extra information
On Wed, Mar 29, 2017 at 10:50:08AM +0300, Haim Daniel wrote:
> isp_capture_defs.h: clean up ERROR: Macros with complex values should be
> enclosed in parentheses
>
> Signed-off-by: Haim Daniel
> ---
> .../pci/atomisp2/css2400/css_2401_csi2p_system/hrt/isp_capture_defs.h | 2
> +-
> 1 file ch
> On Mon, 6 Mar 2017 15:38:29 -0600
> Bjorn Helgaas wrote:
>
> > [+cc Hyper-V folks, -cc others]
> >
> > On Mon, Mar 06, 2017 at 04:21:04PM +0200, Elena Reshetova wrote:
> > > refcount_t type and corresponding API should be
> > > used instead of atomic_t when the variable is used as
> > > a ref
On Tue, 2017-04-18 at 10:33 +0200, Greg KH wrote:
> On Tue, Apr 18, 2017 at 01:24:37AM -0700, Chewie Lin wrote:
> > Removed the usb_device_reset(), replace with call to usb_reset_device()
> > directly. Plus it removes the confusing function name and addressed
> > the checkpatch warning as well by
On Apr 15, 2017, at 18:48, skanda.kash...@gmail.com wrote:
>
> From: Skanda Guruanand
>
> The struct lu_dirpage elements in lustre_idl.h file are modified to
> __le64 and __le32 types since the elements are always converted from
> litte endian to processor native format in mdc_request.c file.
>
On Apr 13, 2017, at 03:24, Craig Inches wrote:
>
> This resolves a checkpatch warning that "Single statement macros should
> not use a do {} while (0) loop" by removing the loop and adjusting line
> length accordingly.
>
> Signed-off-by: Craig Inches
I don't think there was any particular reas
On Thu, 2017-04-13 at 09:40 -0700, Steve Longerbeam wrote:
[...]
> >> @@ -804,12 +804,29 @@ static void prp_try_fmt(struct prp_priv *priv,
> >> &sdformat->format.height,
> >> infmt->height / 4, MAX_H_SRC,
> >>
Hi!
> That self-referencing mux-controls property looks a bit superfluous:
>
> mux: video-multiplexer {
> mux-controls = <&mux>;
> };
>
> Other than that, I'm completely fine with splitting the compatible into
> something like video-mux-gpio and video-mux-mmio and reusi
On Tue, Apr 18, 2017 at 01:24:37AM -0700, Chewie Lin wrote:
> Removed the usb_device_reset(), replace with call to usb_reset_device()
> directly. Plus it removes the confusing function name and addressed
> the checkpatch warning as well by swap string in the dev_warn() call with
> __func__ argum
Removed the usb_device_reset(), replace with call to usb_reset_device()
directly. Plus it removes the confusing function name and addressed
the checkpatch warning as well by swap string in the dev_warn() call with
__func__ argument, instead of explicitly calling the function name in
the string:
Hi,
This is a simple patch as a part of learning about kernel device driver
in the Eudyptula challenge. thanks again for your time!
linsh
Chewie Lin (1):
drivers/staging/vt6656/main_usb.c: usb_device_reset
drivers/staging/vt6656/main_usb.c | 15 ---
1 file changed, 4 insertions(+
Hi Pavel,
On Fri, 2017-04-14 at 22:32 +0200, Pavel Machek wrote:
> Hi!
>
> > > The MUX framework is already in linux-next. Could you use that instead of
> > > adding new driver + bindings that are not compliant with the MUX
> > > framework?
> > > I don't think it'd be much of a change in terms o
87 matches
Mail list logo
