[PATCH] staging: wilc1000: Fix sparse warning in wilc_wfi_cfgoperations.c

2017-03-19 Thread Jacob Zachariah
Fix the following warning reported by sparse: drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2006:51: warning: incorrect type in assignment (different base types) drivers/staging/wilc1000/wilc_wfi_cfgoperations.c:2006:51:expected unsigned short [unsigned] [assigned] [usertype] ht_capa_inf

RE: [PATCH] HV: properly delay KVP packets when negotiation is in progress

2017-03-19 Thread Long Li
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Friday, March 17, 2017 9:16 AM > To: Long Li > Cc: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > ; de...@linuxdriverproject.org; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH] HV: properly

[PATCH] staging: speakup: Fix alignment with parenthesis.

2017-03-19 Thread Arushi Singhal
This patch fixes the warnings reported by checkpatch.pl for please use a blank line after function/struct/union/enum declarations. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/speakup_apollo.c | 2 +- drivers/staging/speakup/speakup_decext.c | 4 ++-- 2 files changed, 3 insertions(+

[PATCH] staging: speakup: Match alignment with open parenthesis.

2017-03-19 Thread Arushi Singhal
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 2 +- drivers/staging/speakup/selection.c | 2 +- drivers/staging/speakup/serialio.c | 2 +- drivers/staging/speakup/speakup_acntpc.c |

Re: [PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

2017-03-19 Thread Mauro Carvalho Chehab
Em Sun, 19 Mar 2017 10:04:28 -0700 Michael Zoran escreveu: > On Sun, 2017-03-19 at 13:58 -0300, Mauro Carvalho Chehab wrote: > > Em Fri, 17 Mar 2017 17:34:36 -0700 > > Eric Anholt escreveu: > > > > > Mauro Carvalho Chehab writes: > > > > > > > Em Wed, 15 Mar 2017 18:46:24 -0700 > > > > Mi

[staging:staging-testing 393/537] drivers/staging/media/atomisp/pci/atomisp2/atomisp_v4l2.c:267:12: error: 'atomisp_restore_iunit_reg' defined but not used

2017-03-19 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: a729782e2d444d51ee21052fd0db076d3fd4955f commit: 49637a458b61629672a8ae19fdae2058c64815cf [393/537] staging: media: atomisp: remove '.' from pci Makefile config: x86_64-randconfig-x019-03200710 (att

Re: [Outreachy kernel] [PATCH v5] staging: Use buf_lock instead of mlock and Refactor code

2017-03-19 Thread SIMRAN SINGHAL
On Mon, Mar 20, 2017 at 2:13 AM, Jonathan Cameron wrote: > On 19/03/17 17:14, Gargi Sharma wrote: >> On Sun, Mar 19, 2017 at 6:20 PM, simran singhal >> wrote: >>> The IIO subsystem is redefining iio_dev->mlock to be used by >>> the IIO core only for protecting device operating mode changes. >>> i

Re: [Outreachy kernel] [PATCH v5] staging: Use buf_lock instead of mlock and Refactor code

2017-03-19 Thread Jonathan Cameron
On 19/03/17 17:14, Gargi Sharma wrote: > On Sun, Mar 19, 2017 at 6:20 PM, simran singhal > wrote: >> The IIO subsystem is redefining iio_dev->mlock to be used by >> the IIO core only for protecting device operating mode changes. >> ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes. >> >>

[PATCH v6] staging: Use buf_lock instead of mlock and Refactor code

2017-03-19 Thread simran singhal
The IIO subsystem is redefining iio_dev->mlock to be used by the IIO core only for protecting device operating mode changes. ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes. In this driver, mlock was being used to protect hardware state changes. Replace it with buf_lock in the devices

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

2017-03-19 Thread Steve Longerbeam
On 03/19/2017 08:22 AM, Russell King - ARM Linux wrote: On Thu, Mar 09, 2017 at 08:53:18PM -0800, Steve Longerbeam wrote: From: Philipp Zabel The csi_try_crop call in set_fmt should compare the cropping rectangle to the currently set input format, not to the previous input format. Are we re

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Steve Longerbeam
On 03/19/2017 11:51 AM, Russell King - ARM Linux wrote: On Sun, Mar 19, 2017 at 11:37:15AM -0700, Steve Longerbeam wrote: On 03/19/2017 05:14 AM, Russell King - ARM Linux wrote: Right now, CSI doesn't do that - it only looks at the width, height, code, and field. Correct, there is currently

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Russell King - ARM Linux
On Sun, Mar 19, 2017 at 11:37:15AM -0700, Steve Longerbeam wrote: > On 03/19/2017 05:14 AM, Russell King - ARM Linux wrote: > >Right now, CSI doesn't do that - it only looks at the width, height, > >code, and field. > > Correct, there is currently no propagation of the colorimetry > parameters (co

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Steve Longerbeam
On 03/19/2017 05:14 AM, Russell King - ARM Linux wrote: On Sat, Mar 18, 2017 at 12:58:27PM -0700, Steve Longerbeam wrote: On 03/18/2017 12:22 PM, Russell King - ARM Linux wrote: 0:00:01.955927879 20954 0x15ffe90 INFOv4l2 gstv4l2object.c:3811:gst_v4l2_object_get_caps: pro

Re: [Outreachy kernel] [PATCH] staging: impedance-analyzer: ad5933: Remove unnecessary goto

2017-03-19 Thread SIMRAN SINGHAL
On Sun, Mar 19, 2017 at 11:26 PM, Julia Lawall wrote: > > > On Sun, 19 Mar 2017, simran singhal wrote: > >> Remove unnecessary goto. >> >> Signed-off-by: simran singhal >> --- >> drivers/staging/iio/impedance-analyzer/ad5933.c | 10 -- >> 1 file changed, 4 insertions(+), 6 deletions(-) >

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Russell King - ARM Linux
On Sun, Mar 19, 2017 at 10:54:22AM -0700, Steve Longerbeam wrote: > > > On 03/19/2017 03:38 AM, Russell King - ARM Linux wrote: > >On Sat, Mar 18, 2017 at 12:58:27PM -0700, Steve Longerbeam wrote: > >>Right, imx-media-capture.c (the "standard" v4l2 user interface module) > >>is not implementing V

Re: [Outreachy kernel] Re: [PATCH] staging: iio: ade7753: replace mlock with driver private lock

2017-03-19 Thread Gargi Sharma
On Mon, Mar 13, 2017 at 5:30 PM, Lars-Peter Clausen wrote: > On 03/12/2017 02:32 PM, simran singhal wrote: >> The IIO subsystem is redefining iio_dev->mlock to be used by >> the IIO core only for protecting device operating mode changes. >> ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* mod

Re: [Outreachy kernel] [PATCH] staging: impedance-analyzer: ad5933: Remove unnecessary goto

2017-03-19 Thread Julia Lawall
On Sun, 19 Mar 2017, simran singhal wrote: > Remove unnecessary goto. > > Signed-off-by: simran singhal > --- > drivers/staging/iio/impedance-analyzer/ad5933.c | 10 -- > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c >

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Steve Longerbeam
On 03/19/2017 03:38 AM, Russell King - ARM Linux wrote: On Sat, Mar 18, 2017 at 12:58:27PM -0700, Steve Longerbeam wrote: Right, imx-media-capture.c (the "standard" v4l2 user interface module) is not implementing VIDIOC_ENUM_FRAMESIZES. It should, but it can only return the single frame size t

[PATCH] staging: impedance-analyzer: ad5933: Remove unnecessary goto

2017-03-19 Thread simran singhal
Remove unnecessary goto. Signed-off-by: simran singhal --- drivers/staging/iio/impedance-analyzer/ad5933.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c index 29766

[PATCH] staging: speakup: Simplify the NULL comparisons

2017-03-19 Thread Arushi Singhal
Fixed coding style for null comparisons in speakup driver to be more consistant with the rest of the kernel coding style. Replaced 'x != NULL' with 'x' and 'x = NULL' with '!x'. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/fakekey.c | 2 +- drivers/staging/speakup/main.c| 32 ++

Re: [Outreachy kernel] [PATCH v5] staging: Use buf_lock instead of mlock and Refactor code

2017-03-19 Thread Gargi Sharma
On Sun, Mar 19, 2017 at 6:20 PM, simran singhal wrote: > The IIO subsystem is redefining iio_dev->mlock to be used by > the IIO core only for protecting device operating mode changes. > ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes. > > In this driver, mlock was being used to protect

Re: [Outreachy kernel] Re: [PATCH] staging: iio: ade7753: replace mlock with driver private lock

2017-03-19 Thread Jonathan Cameron
On 19/03/17 13:16, Gargi Sharma wrote: > On Sun, Mar 19, 2017 at 4:01 PM, Jonathan Cameron wrote: >> On 17/03/17 09:32, Gargi Sharma wrote: >>> On Mon, Mar 13, 2017 at 5:30 PM, Lars-Peter Clausen wrote: On 03/12/2017 02:32 PM, simran singhal wrote: > The IIO subsystem is redefining

Re: [PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

2017-03-19 Thread Michael Zoran
On Sun, 2017-03-19 at 13:58 -0300, Mauro Carvalho Chehab wrote: > Em Fri, 17 Mar 2017 17:34:36 -0700 > Eric Anholt escreveu: > > > Mauro Carvalho Chehab writes: > > > > > Em Wed, 15 Mar 2017 18:46:24 -0700 > > > Michael Zoran escreveu: > > > > > > > On Wed, 2017-03-15 at 22:08 -0300, Mauro Ca

[PATCH] staging: speakup: Removed Unnecessary parentheses.

2017-03-19 Thread Arushi Singhal
Unnecessary parentheses are removed to improve readability. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/kobjects.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c index afb61e153592..ca8547

Re: [PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

2017-03-19 Thread Mauro Carvalho Chehab
Em Fri, 17 Mar 2017 17:34:36 -0700 Eric Anholt escreveu: > Mauro Carvalho Chehab writes: > > > Em Wed, 15 Mar 2017 18:46:24 -0700 > > Michael Zoran escreveu: > > > >> On Wed, 2017-03-15 at 22:08 -0300, Mauro Carvalho Chehab wrote: > >> > >> > No, I didn't. Thanks! Applied it but, unfortunatel

Re: [PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

2017-03-19 Thread Michael Zoran
> > Since the API is completely documented, I see no reason we or > > anybody > > couldn't essentially rewrite the driver while it's in staging.  I > > just > > think it would be best for everyone if the new version was a drop > > in > > replacement for the original version.  Essential an enhancem

Re: [Outreachy kernel] [PATCH v3] staging: sm750fb: Code readability is improved

2017-03-19 Thread Geert Uytterhoeven
On Sun, Mar 19, 2017 at 4:52 PM, Arushi Singhal wrote: > On Sun, Mar 19, 2017 at 7:34 PM, Geert Uytterhoeven > wrote: >> >> On Sun, Mar 19, 2017 at 2:11 PM, Julia Lawall >> wrote: >> > On Sun, 19 Mar 2017, Arushi Singhal wrote: >> >> New variables are added to make the code more readable. >> >>

[PATCH v4] staging: sm750fb: Code readability is improved

2017-03-19 Thread Arushi Singhal
New variables are added to make the code more readable. Signed-off-by: Arushi Singhal --- changes in v4 -try to make the code much more readable. - defined the variable at the top of a block. --- drivers/staging/sm750fb/ddk750_mode.c | 57 +++ 1 file changed, 3

Re: [PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

2017-03-19 Thread Russell King - ARM Linux
On Thu, Mar 09, 2017 at 08:53:18PM -0800, Steve Longerbeam wrote: > From: Philipp Zabel > > The csi_try_crop call in set_fmt should compare the cropping rectangle > to the currently set input format, not to the previous input format. Are we really sure that the cropping support is implemented co

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Russell King - ARM Linux
On Sun, Mar 19, 2017 at 05:00:08PM +0200, Vladimir Zapolskiy wrote: > On 03/19/2017 04:22 PM, Russell King - ARM Linux wrote: > > On Sun, Mar 19, 2017 at 02:21:10PM +, Russell King - ARM Linux wrote: > >> There's a good reason why I dumped a full debug log using GST_DEBUG=*:9, > >> analysed it

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Vladimir Zapolskiy
On 03/19/2017 04:22 PM, Russell King - ARM Linux wrote: > On Sun, Mar 19, 2017 at 02:21:10PM +, Russell King - ARM Linux wrote: >> There's a good reason why I dumped a full debug log using GST_DEBUG=*:9, >> analysed it for the cause of the failure, and tried several different >> pipelines, incl

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Russell King - ARM Linux
On Sun, Mar 19, 2017 at 10:33:25AM -0400, Nicolas Dufresne wrote: > Le dimanche 19 mars 2017 à 00:54 +, Russell King - ARM Linux a > écrit : > > > > > > In practice, I have the impression there is a fair reason why > > > framerate > > > enumeration isn't implemented (considering there is only

Re: [PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

2017-03-19 Thread Stefan Wahren
> Michael Zoran hat am 19. März 2017 um 12:38 geschrieben: > > ... > > Sorry, I simply meant that I was hoping the comments would focus on > changes I made to the driver not the original version. I don't want > things to get mixed up between what I wrote and what Dave Stevenson > wrote. This i

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Nicolas Dufresne
Le dimanche 19 mars 2017 à 14:21 +, Russell King - ARM Linux a écrit : > > Can it be a point of failure? > > There's a good reason why I dumped a full debug log using > GST_DEBUG=*:9, > analysed it for the cause of the failure, and tried several different > pipelines, including the standard ba

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Nicolas Dufresne
Le dimanche 19 mars 2017 à 09:55 +, Russell King - ARM Linux a écrit : > 2) would it also make sense to allow gstreamer's v4l2src to try > setting >    a these parameters, and only fail if it's unable to set it?  IOW, > if >    I use: > > gst-launch-1.0 v4l2src device=/dev/video10 ! \ >   

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Nicolas Dufresne
Le dimanche 19 mars 2017 à 00:54 +, Russell King - ARM Linux a écrit : > > > > In practice, I have the impression there is a fair reason why > > framerate > > enumeration isn't implemented (considering there is only 1 valid > > rate). > > That's actually completely incorrect. > > With the ca

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Russell King - ARM Linux
On Sun, Mar 19, 2017 at 02:21:10PM +, Russell King - ARM Linux wrote: > There's a good reason why I dumped a full debug log using GST_DEBUG=*:9, > analysed it for the cause of the failure, and tried several different > pipelines, including the standard bayer2rgb plugin. > > Please don't blame

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Russell King - ARM Linux
On Sun, Mar 19, 2017 at 03:57:56PM +0200, Vladimir Zapolskiy wrote: > Hi Russell, > > On 03/18/2017 10:43 PM, Russell King - ARM Linux wrote: > > On Sat, Mar 18, 2017 at 12:58:27PM -0700, Steve Longerbeam wrote: > >> Can you share your gstreamer pipeline? For now, until > >> VIDIOC_ENUM_FRAMESIZES

Re: [Outreachy kernel] [PATCH v3] staging: sm750fb: Code readability is improved

2017-03-19 Thread Geert Uytterhoeven
On Sun, Mar 19, 2017 at 2:11 PM, Julia Lawall wrote: > On Sun, 19 Mar 2017, Arushi Singhal wrote: >> New variables are added to make the code more readable. >> >> Signed-off-by: Arushi Singhal >> --- >> changes in v3 >> -try to make the code much more readable. >> >> drivers/staging/sm750fb/dd

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Vladimir Zapolskiy
Hi Russell, On 03/18/2017 10:43 PM, Russell King - ARM Linux wrote: > On Sat, Mar 18, 2017 at 12:58:27PM -0700, Steve Longerbeam wrote: >> Can you share your gstreamer pipeline? For now, until >> VIDIOC_ENUM_FRAMESIZES is implemented, try a pipeline that >> does not attempt to specify a frame rate

Re: [Outreachy kernel] [PATCH v5] staging: sm750fb: Remove typedefs from structures and enum

2017-03-19 Thread Julia Lawall
On Sun, 19 Mar 2017, Arushi Singhal wrote: > This patch removes typedefs from structure and enum and renames them as per > kernel coding standards. Greg asked for one structure/enum to be done at a time. julia > > Signed-off-by: Arushi Singhal > --- > changes in v5 > - make the commit mess

[PATCH v5] staging: sm750fb: Remove typedefs from structures and enum

2017-03-19 Thread Arushi Singhal
This patch removes typedefs from structure and enum and renames them as per kernel coding standards. Signed-off-by: Arushi Singhal --- changes in v5 - make the commit message more relevant. - remove prefix and suffix underscore. drivers/staging/sm750fb/ddk750_mode.c | 6 +++--- drivers/stag

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-19 Thread Pavel Machek
On Fri 2017-03-17 11:42:03, Russell King - ARM Linux wrote: > On Tue, Mar 14, 2017 at 08:55:36AM +0100, Hans Verkuil wrote: > > We're all very driver-development-driven, and userspace gets very little > > attention in general. So before just throwing in the towel we should take > > a good look at t

Re: [Outreachy kernel] Re: [PATCH] staging: iio: ade7753: replace mlock with driver private lock

2017-03-19 Thread Gargi Sharma
On Sun, Mar 19, 2017 at 4:01 PM, Jonathan Cameron wrote: > On 17/03/17 09:32, Gargi Sharma wrote: >> On Mon, Mar 13, 2017 at 5:30 PM, Lars-Peter Clausen wrote: >>> >>> On 03/12/2017 02:32 PM, simran singhal wrote: The IIO subsystem is redefining iio_dev->mlock to be used by the IIO core

[PATCH v2 2/2] staging: speakup: spaces preferred around operator

2017-03-19 Thread Arushi Singhal
Fixed the checkpatch.pl issues like: CHECK: spaces preferred around that '&' (ctx:VxV) CHECK: spaces preferred around that '|' (ctx:VxV) CHECK: spaces preferred around that '-' (ctx:VxV) CHECK: spaces preferred around that '+' (ctx:VxV) etc. Signed-off-by: Arushi Singhal --- changes in v2 -no ch

[PATCH v2 1/2] staging: speakup: Moved OR operator to previous line.

2017-03-19 Thread Arushi Singhal
Moved logical OR operator to previous line to fix the following checkpatch issue: CHECK: Logical continuations should be on the previous line. Signed-off-by: Arushi Singhal --- changes in v2 -change the commit message and subject. drivers/staging/speakup/main.c | 8 1 file changed,

[PATCH v2 0/2] staging:speakup: Multiple checkpatch issues,

2017-03-19 Thread Arushi Singhal
Improve readability by fixing multiple checkpatch.pl issues in speakup driver. Arushi Singhal (2): staging: speakup: Moved OR operator to previous line. staging: speakup: spaces preferred around operator drivers/staging/speakup/main.c | 8 drivers/staging/speakup/speakup.

Re: [Outreachy kernel] [PATCH v3] staging: sm750fb: Code readability is improved

2017-03-19 Thread Julia Lawall
On Sun, 19 Mar 2017, Arushi Singhal wrote: > New variables are added to make the code more readable. > > Signed-off-by: Arushi Singhal > --- > changes in v3 > -try to make the code much more readable. > > drivers/staging/sm750fb/ddk750_mode.c | 61 > --- > 1

[PATCH v3] staging: sm750fb: Code readability is improved

2017-03-19 Thread Arushi Singhal
New variables are added to make the code more readable. Signed-off-by: Arushi Singhal --- changes in v3 -try to make the code much more readable. drivers/staging/sm750fb/ddk750_mode.c | 61 --- 1 file changed, 35 insertions(+), 26 deletions(-) diff --git a/dr

[PATCH v5] staging: Use buf_lock instead of mlock and Refactor code

2017-03-19 Thread simran singhal
The IIO subsystem is redefining iio_dev->mlock to be used by the IIO core only for protecting device operating mode changes. ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes. In this driver, mlock was being used to protect hardware state changes. Replace it with buf_lock in the devices

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Russell King - ARM Linux
On Sat, Mar 18, 2017 at 12:58:27PM -0700, Steve Longerbeam wrote: > On 03/18/2017 12:22 PM, Russell King - ARM Linux wrote: > >0:00:01.955927879 20954 0x15ffe90 INFOv4l2 > >gstv4l2object.c:3811:gst_v4l2_object_get_caps: probed caps: > >video/x-bayer, format=(string)rggb, fram

Re: [Outreachy kernel] [PATCH 1/2] staging: speakup: Moved AND operator to previous line.

2017-03-19 Thread Julia Lawall
On Sun, 19 Mar 2017, Arushi Singhal wrote: > Moved logical AND operator to previous line to fix the following > checkpatch issue: You seem to have AND and OR confused. AND is &&, OR is ||. This patch is about OR, not AND. julia > > CHECK: Logical continuations should be on the previous line

Re: [PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

2017-03-19 Thread Michael Zoran
On Sun, 2017-03-19 at 11:39 +0100, Stefan Wahren wrote: > Hi Michael, > > > Michael Zoran hat am 19. März 2017 um 05:42 > > geschrieben: > > > > > > On Sat, 2017-03-18 at 14:23 +0100, Stefan Wahren wrote: > > > > Michael Zoran hat am 17. März 2017 um > > > > 16:22 > > > > geschrieben: > > > >

Re: [PATCH] Staging: iio: resolver: Fix warning, statements should start on a tabstop

2017-03-19 Thread Jonathan Cameron
On 16/03/17 14:28, Miguel Robles wrote: > Fix checkpatch warning: > Statements should start on a tabstop. > > Signed-off-by: Miguel Robles Applied with the part name added to the patch title. Jonathan > --- > drivers/staging/iio/resolver/ad2s1210.c | 4 ++-- > 1 file changed, 2 insertions(+), 2

[PATCH] staging: dgnc: fix printk warnings in dgnc_tty.c

2017-03-19 Thread abshkbh
From: Abhishek Bhardwaj Use __func__ to print dgnc_tty_send_xchar function name. Signed-off-by: Abhishek Bhardwaj --- drivers/staging/dgnc/dgnc_tty.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c index

Re: [PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

2017-03-19 Thread Stefan Wahren
Hi Michael, > Michael Zoran hat am 19. März 2017 um 05:42 geschrieben: > > > On Sat, 2017-03-18 at 14:23 +0100, Stefan Wahren wrote: > > > Michael Zoran hat am 17. März 2017 um 16:22 > > > geschrieben: > > > > > > > > > From: Dave Stevenson > > > > > > Pi3 and Compute Module 3 have a GPIO

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Russell King - ARM Linux
On Sat, Mar 18, 2017 at 12:58:27PM -0700, Steve Longerbeam wrote: > Right, imx-media-capture.c (the "standard" v4l2 user interface module) > is not implementing VIDIOC_ENUM_FRAMESIZES. It should, but it can only > return the single frame size that the pipeline has configured (the mbus > format of t

Re: [Outreachy kernel] Re: [PATCH] staging: iio: ade7753: replace mlock with driver private lock

2017-03-19 Thread Jonathan Cameron
On 17/03/17 09:32, Gargi Sharma wrote: > On Mon, Mar 13, 2017 at 5:30 PM, Lars-Peter Clausen wrote: >> >> On 03/12/2017 02:32 PM, simran singhal wrote: >>> The IIO subsystem is redefining iio_dev->mlock to be used by >>> the IIO core only for protecting device operating mode changes. >>> ie. Chang

Re: [PATCH v4] staging: Use buf_lock instead of mlock and Refactor code

2017-03-19 Thread SIMRAN SINGHAL
On Sun, Mar 19, 2017 at 3:45 PM, Jonathan Cameron wrote: > On 18/03/17 18:44, simran singhal wrote: >> The IIO subsystem is redefining iio_dev->mlock to be used by >> the IIO core only for protecting device operating mode changes. >> ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes. >>

Re: outreachy/moving a driver out of staging

2017-03-19 Thread Michael Zoran
On Sun, 2017-03-19 at 09:15 +, Russell King - ARM Linux wrote: > On Sun, Mar 19, 2017 at 12:37:47AM -0700, Michael Zoran wrote: > > I just noticed this e-mail.  What exactly is the requirement to get > > a > > driver or subsystem out of staging? > > This is why each driver in staging is suppos

Re: [PATCH v4] staging: Use buf_lock instead of mlock and Refactor code

2017-03-19 Thread Jonathan Cameron
On 18/03/17 18:44, simran singhal wrote: > The IIO subsystem is redefining iio_dev->mlock to be used by > the IIO core only for protecting device operating mode changes. > ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes. > > In this driver, mlock was being used to protect hardware stat

Re: [Outreachy kernel] [PATCH v2] staging: iio: ade7753: replace mlock with driver private lock

2017-03-19 Thread Jonathan Cameron
On 18/03/17 18:46, SIMRAN SINGHAL wrote: > On Sat, Mar 18, 2017 at 11:51 PM, Jonathan Cameron wrote: >> On 18/03/17 17:34, SIMRAN SINGHAL wrote: >>> On Thu, Mar 16, 2017 at 3:23 AM, Jonathan Cameron wrote: On 13/03/17 19:53, Alison Schofield wrote: > On Mon, Mar 13, 2017 at 10:01:07PM +0

Re: [PATCH v5 00/39] i.MX Media Driver

2017-03-19 Thread Russell King - ARM Linux
On Sat, Mar 18, 2017 at 08:41:14PM -0400, Nicolas Dufresne wrote: > Along with the norm fallback, GStreamer could could also consider the > currently set framerate as returned by VIDIOC_G_PARM. At the same time, > implementing that enumeration shall be straightforward, and will make a > large amoun

Re: outreachy/moving a driver out of staging

2017-03-19 Thread Russell King - ARM Linux
On Sun, Mar 19, 2017 at 12:37:47AM -0700, Michael Zoran wrote: > I just noticed this e-mail. What exactly is the requirement to get a > driver or subsystem out of staging? This is why each driver in staging is supposed to have a TODO file listing each point that needs to be addressed, and when ea

Re: [PATCH 4/5] staging: bcm2835-camera: Fix TODO issue #4 where camera doesn't start if vchiq isn't connected.

2017-03-19 Thread kbuild test robot
/bcm2835-camera-Correct-port_parameter_get-return-value/20170319-112320 config: tile-allyesconfig (attached as .config) compiler: tilegx-linux-gcc (GCC) 4.6.2 reproduce: wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin

Re: outreachy/moving a driver out of staging

2017-03-19 Thread Michael Zoran
On Thu, 2017-03-09 at 22:20 +0100, Greg KH wrote: > On Thu, Mar 09, 2017 at 01:56:49PM -0700, Stephen Warren wrote: > > On 03/09/2017 01:51 PM, Scott Branden wrote: > > > Hi Julia, > > > > > > On 17-03-09 12:36 PM, Julia Lawall wrote: > > > > Hello, > > > > > > > > I discussed the issue of outrea

[PATCH 0/2] staging:speakup: Multiple checkpatch issues.

2017-03-19 Thread Arushi Singhal
Improve readability by fixing multiple checkpatch.pl issues in speakup driver. Arushi Singhal (2): staging: speakup: Moved AND operator to previous line. staging: speakup: spaces preferred around operator drivers/staging/speakup/main.c | 8 drivers/staging/speakup/speaku

[PATCH 1/2] staging: speakup: Moved AND operator to previous line.

2017-03-19 Thread Arushi Singhal
Moved logical AND operator to previous line to fix the following checkpatch issue: CHECK: Logical continuations should be on the previous line. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/st

[PATCH 2/2] staging: speakup: spaces preferred around operator

2017-03-19 Thread Arushi Singhal
Fixed the checkpatch.pl issues like: CHECK: spaces preferred around that '&' (ctx:VxV) CHECK: spaces preferred around that '|' (ctx:VxV) CHECK: spaces preferred around that '-' (ctx:VxV) CHECK: spaces preferred around that '+' (ctx:VxV) etc. Signed-off-by: Arushi Singhal --- drivers/staging/spea

Re: [PATCH 3/6] staging: bcm2835-firmware-gpio: Expand DT options for driver

2017-03-19 Thread Michael Zoran
On Sat, 2017-03-18 at 14:24 +0100, Stefan Wahren wrote: > > Michael Zoran hat am 17. März 2017 um 16:22 > > geschrieben: > > > > > > This change adds the following optional DT properties: > > > > number-gpios: Number of GPIOs the device should expose > > gpio-base: GPIO base that is registered

Re: [PATCH 4/5] staging: bcm2835-camera: Fix TODO issue #4 where camera doesn't start if vchiq isn't connected.

2017-03-19 Thread kbuild test robot
/bcm2835-camera-Correct-port_parameter_get-return-value/20170319-112320 config: i386-allmodconfig (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by