The semaphore 'lock' in 'pwrctrl_priv' is used as a simple mutex, so it
should be written as one. Semaphores are going away in the future.
_enter_pwrlock was using down_interruptible(), so the lock could be broken
by sending a signal. This could be a bug, because nothing checks the return
code here
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Sunday, August 21, 2016 2:05 PM
> To: Kershner, David A
> Cc: cor...@lwn.net; t...@linutronix.de; mi...@redhat.com;
> h...@zytor.com; Arfvidson, Erik ; Sell, Timothy
> C ; hof...@osadl.org; dzic...@redhat.com;
The dgnc_maxcps_room() function must be called only for print device.
The if-statement for checking print device checks before calling
dgnc_maxcps_room() and also this function doesn't need to have any
data except channel_t.
Signed-off-by: Daeseok Youn
---
V2: update subject line from "change a p
2016-08-22 0:55 GMT+09:00 Greg KH :
> On Fri, Aug 19, 2016 at 10:04:52AM +0900, Daeseok Youn wrote:
>> The dgnc_maxcps_room() function must be called only for print device.
>> The if-statement for checking print device checks before calling
>> maxcps_room() and also this function doesn't need to ha
This patch fixes all checkpatch occurences of
"CHECK: spaces preferred around that '{+,-,*,/,|,<<,>>,&}' (ctx:VxV)"
in Lustre code.
Signed-off-by: Emoly Liu
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lu_object.h | 3 ++-
.../lustre/lustre/include/lustre/lustre_idl.h
This patch fixes most of checkpatch occurences of
"CHECK: Alignment should match open parenthesis"
in Lustre code.
Signed-off-by: Emoly Liu
Signed-off-by: Oleg Drokin
---
.../staging/lustre/include/linux/libcfs/libcfs.h | 6 +-
.../lustre/include/linux/libcfs/libcfs_debug.h | 10 +-
..
Here are the three patches rebased after merge conflict
with some other patches that were accepted first.
Oleg Drokin (3):
staging/lustre: Add spaces preferred around that '{+,-,*,/,|,<<,>>,&}'
staging/lustre: Make alignment match open parenthesis
staging/lustre: Remove unused cp_error from
cp_error member is not really set anywhere, so kill
it and the only printing user of it too.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/cl_object.h | 2 --
drivers/staging/lustre/lustre/obdclass/cl_page.c | 4 ++--
2 files changed, 2 insertions(+), 4 deletions(-)
diff
On Fri, Jun 10, 2016 at 11:23:56PM -0400, David Kershner wrote:
> visorbus is currently located at drivers/staging/visorbus,
> this patch moves it to drivers/virt.
>
> Signed-off-by: David Kershner
> Reviewed-by: Tim Sell
> ---
> drivers/staging/unisys/Kconfig
On Wed, Jun 15, 2016 at 10:35:22PM +0200, Arnd Bergmann wrote:
> Compiling the rtlwifi drivers for ARM with gcc -Wextra warns about lots of
> incorrect code that results from 'char' being unsigned here, e.g.
>
> staging/rtl8192e/rtl8192e/r8192E_phy.c:1072:36: error: comparison is always
> false d
On Tue, Aug 02, 2016 at 08:05:30PM +0200, Shiva Kerdel wrote:
> Fixed spaces around operators to fix their coding style issues.
>
> Signed-off-by: Shiva Kerdel
> ---
> drivers/staging/rtl8723au/core/rtw_xmit.c | 24
> 1 file changed, 12 insertions(+), 12 deletions(-)
Do
On Thu, Jun 02, 2016 at 09:54:10AM +0530, Binoy Jayan wrote:
> The semaphore 'lock' in 'pwrctrl_priv' is used as a simple mutex, so it
> should be written as one. Semaphores are going away in the future.
> _enter_pwrlock was using down_interruptible(), so the lock could be broken
> by sending a sig
On Tue, Aug 09, 2016 at 01:34:57AM -0400, Lidza Louina wrote:
> The code did not lock the &pcmdpriv->terminate_cmdthread_sema before using it.
> The code had an up() where a down() should've been. This patch fixes that.
>
> Signed-off-by: Lidza Louina
> ---
> drivers/staging/rtl8188eu/core/rtw_c
On Sun, Jun 12, 2016 at 07:00:41PM +0530, Rithvik Patibandla wrote:
> The following patch fixes format of some comments.
>
> Signed-off-by: Rithvik Patibandla
> ---
> drivers/staging/sm750fb/ddk750_chip.c | 71
> +++
> 1 file changed, 38 insertions(+), 33 deletio
On Fri, Aug 19, 2016 at 10:05:19AM +0900, Daeseok Youn wrote:
> The whole code in dgnc_maxcps_room() function surrounds with
> one if-statement for checking channel's maxcps and buffer size.
> I tried to separate the logic for this function from if-condition.
>
> Signed-off-by: Daeseok Youn
> ---
On Thu, Jul 14, 2016 at 01:06:09PM -0400, Javier Martinez Canillas wrote:
> The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
> built-in or as a module, use that macro instead of open coding the same.
>
> Signed-off-by: Javier Martinez Canillas
> Acked-by: David Daney
> -
On Wed, Aug 17, 2016 at 03:59:09PM +0200, Robin Naundorf wrote:
> Fix 'line over 80 characters' checkpatch.pl
> warning
>
> Signed-off-by: Robin Naundorf
> ---
> drivers/staging/dgnc/dgnc_driver.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Someone else sent this same patch just bef
On Wed, May 25, 2016 at 11:37:35PM -0700, Bhushan Gopala Reddy wrote:
> Fixed coding style issue
>
> Signed-off-by: Bhushan Gopala Reddy
You need to be more specific in the changelog please.
Also, this was NAKed by the maintainer the last time it came up, so I
can't take it...
thanks,
greg k-
On Fri, Aug 19, 2016 at 10:04:52AM +0900, Daeseok Youn wrote:
> The dgnc_maxcps_room() function must be called only for print device.
> The if-statement for checking print device checks before calling
> maxcps_room() and also this function doesn't need to have any
> data except channel_t.
>
> Sign
On Thu, May 26, 2016 at 07:25:22PM -, Michal Suchanek wrote:
> Some SPI controllers can transfer only small piece of data at a time.
> Since SPI core gained a function to get the maximum transfer length use
> it.
>
> Signed-off-by: Michal Suchanek
> Acked-by: Noralf Trønnes
> ---
>
> Teste
On Thu, Aug 18, 2016 at 07:27:31PM -0600, Ben LeMasurier wrote:
> This fixes remaining checkpatch.pl "Alignment should match open
> parenthesis" issues.
>
> Signed-off-by: Ben LeMasurier
> ---
> drivers/staging/android/ion/ion.c | 42
> +-
> drivers/staging/
On Sat, Aug 20, 2016 at 06:20:00PM +0300, Claudiu Beznea wrote:
> This patch improves code from p80211req.c file by removing
> duplicate code, by keeping count of returning code of
> the called functions and also aesthetically.
>
> Signed-off-by: Claudiu Beznea
> ---
> drivers/staging/wlan-ng/p8
On Mon, Aug 08, 2016 at 08:46:20PM +0300, Claudiu Beznea wrote:
> This patch removes unused code from wlan-ng driver.
>
> Signed-off-by: Claudiu Beznea
> ---
> drivers/staging/wlan-ng/p80211types.h | 43
> ---
> 1 file changed, 43 deletions(-)
>
> diff --git a/d
On Fri, Jun 10, 2016 at 11:23:54PM -0400, David Kershner wrote:
> Update include/linux to include the s-Par associated common include
> header files needed for the s-Par visorbus.
>
> Since we have now moved the include directories over to
> include/linux/visorbus this patch makes all of the visor
On Sat, Aug 06, 2016 at 08:20:16PM +0300, Claudiu Beznea wrote:
> This patch fix "line over 80 characters" checkpatch.pl
> warnings. In cfg80211.c file some of these warnings
> were fixed by adding duplicate code in a separate
> function.
>
> Signed-off-by: Claudiu Beznea
> ---
> drivers/staging
On Sat, Jul 30, 2016 at 07:11:45PM +0300, Claudiu Beznea wrote:
> This patch suppress "do not add new typedefs" checkpatch.pl
> warnings. After this suppression some lines needs to be
> changed to avoid new checkpatch.pl complains (e.g. 80
> chars per line checkpatch.pl warning)
>
> Signed-off-by:
On Tue, Aug 02, 2016 at 05:13:14PM +0530, shyam saini wrote:
> Remove the explicit NULL comparison and rewrite in a compact form using
> Coccinelle
>
> Signed-off-by: shyam saini
> ---
> drivers/staging/i4l/pcbit/callbacks.c | 4 ++--
> drivers/staging/i4l/pcbit/capi.c | 18 +-
On Sat, Jun 11, 2016 at 10:10:50PM +0100, Sudip Mukherjee wrote:
> return is not a function so no need to use the parenthesis.
>
> Signed-off-by: Sudip Mukherjee
> ---
> drivers/staging/i4l/icn/icn.c | 16
> 1 file changed, 8 insertions(+), 8 deletions(-)
Not all patches in thi
On Wed, Aug 10, 2016 at 02:04:54PM -0700, Markus Mayer wrote:
> After introducing generic strltolower() and strtolower(), spk_strlwr()
> is no longer needed.
>
> Signed-off-by: Markus Mayer
> Acked-by: Samuel Thibault
> Acked-by: Chris Brannon
> ---
> drivers/staging/speakup/kobjects.c| 3
On Sun, Jul 10, 2016 at 12:47:29PM -0400, Alec Missine wrote:
> Signed-off-by: Alec Missine
> ---
> drivers/staging/dgnc/dgnc_driver.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I can't take patches with no changelog text at all, sorry.
greg k-h
On Tue, Jun 21, 2016 at 08:17:14AM -0700, Greg KH wrote:
> On Tue, Jun 21, 2016 at 07:35:24AM +0800, Icenowy Zheng wrote:
> > The driver is only a working port of a badly written driver extracted from
> > an old and vendor-specified kernel source.
> > I cannot promise the code style (although I di
On Mon, Jul 25, 2016 at 11:25:25PM +0100, Colin King wrote:
> From: Colin Ian King
>
> We need to add parentheses around ternary operations because currently
> the expression SDF_READABLE | (it->options[2] == 1) always evaluates to
> true, meaning s->subdev_flags is always assigned SDF_DIFF. Putt
On Sat, Jul 30, 2016 at 01:04:55PM -0700, Nadim almas wrote:
> This patch compresses two lines in to a single line in file
> cb_pcidas.c
> if immediate return statement is found. It also removes variable
> bytes_written as it is no longer needed.
>
> It is done using script Coccinelle. And coccine
On Fri, Aug 19, 2016 at 01:09:35PM +0200, Christian Gromm wrote:
> This patch moves the initialization of the idr structure towards the end
> of the module's init routine. This keeps the code compact and eliminates
> the need of having to call ida_destroy() in case the function exits with
> an exce
On Tue, Aug 16, 2016 at 04:24:05PM -0400, Anson Jacob wrote:
> fix checkpatch.pl warning
> Prefer 'unsigned int' to bare use of 'unsigned'
>
> Signed-off-by: Anson Jacob
> ---
> drivers/staging/lustre/lustre/include/cl_object.h | 14 +++---
> 1 file changed, 7 insertions(+), 7 deletions(
On Sat, Aug 20, 2016 at 05:34:29PM -0400, Oleg Drokin wrote:
> cp_error member is not really set anywhere, so kill
> it and the only printing user of it too.
>
> Signed-off-by: Oleg Drokin
> ---
> drivers/staging/lustre/lustre/include/cl_object.h | 2 --
> drivers/staging/lustre/lustre/obdclass/
On Sat, Aug 20, 2016 at 05:34:28PM -0400, Oleg Drokin wrote:
> From: Emoly Liu
>
> This patch fixes most of checkpatch occurences of
> "CHECK: Alignment should match open parenthesis"
> in Lustre code.
>
> Signed-off-by: Emoly Liu
> Signed-off-by: Oleg Drokin
> ---
Doesn't apply :(
_
On Sat, Aug 20, 2016 at 05:34:26PM -0400, Oleg Drokin wrote:
> From: Emoly Liu
>
> This patch fixes all checkpatch occurences of
> "CHECK: spaces preferred around that '{+,-,*,/,|,<<,>>,&}' (ctx:VxV)"
> in Lustre code.
>
> Signed-off-by: Emoly Liu
> Signed-off-by: Oleg Drokin
> ---
This patch
From: Markus Elfring
Date: Sun, 21 Aug 2016 11:30:57 +0200
Reuse existing functionality from memdup_user() instead of keeping
duplicate source code.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/staging/lustre/lustre/llite/dir.c | 12 +++--
39 matches
Mail list logo
