Hi All,
On Thu, Jun 23, 2016 at 11:14 PM, Colin King wrote:
> From: Colin Ian King
>
> trivial fix to spelling mistake in dev_err messages
>
> Signed-off-by: Colin Ian King
Looks right to me.
Reviewed-by: Julian Calaby
Thanks,
--
Julian Calaby
Email: julian.cal...@gmail.com
Profile: http
On 24/06/16 00:54, Julian Calaby wrote:
> Hi Luis,
>
> On Fri, Jun 24, 2016 at 9:50 AM, Luis de Bethencourt
> wrote:
>> On 24/06/16 00:15, Julian Calaby wrote:
>>> Hi Joe,
>>>
>>> On Fri, Jun 24, 2016 at 5:24 AM, Joe Perches wrote:
On Thu, 2016-06-23 at 18:57 +0100, Luis de Bethencourt wrot
Hi Luis,
On Fri, Jun 24, 2016 at 9:50 AM, Luis de Bethencourt
wrote:
> On 24/06/16 00:15, Julian Calaby wrote:
>> Hi Joe,
>>
>> On Fri, Jun 24, 2016 at 5:24 AM, Joe Perches wrote:
>>> On Thu, 2016-06-23 at 18:57 +0100, Luis de Bethencourt wrote:
hif_drv->usr_scan_req.net.net_info[i] contain
On 24/06/16 00:15, Julian Calaby wrote:
> Hi Joe,
>
> On Fri, Jun 24, 2016 at 5:24 AM, Joe Perches wrote:
>> On Thu, 2016-06-23 at 18:57 +0100, Luis de Bethencourt wrote:
>>> hif_drv->usr_scan_req.net.net_info[i] contains found_net_info structs
>>> which have the following element:
>>> u8 bssid[6
Hi Joe,
On Fri, Jun 24, 2016 at 5:24 AM, Joe Perches wrote:
> On Thu, 2016-06-23 at 18:57 +0100, Luis de Bethencourt wrote:
>> hif_drv->usr_scan_req.net.net_info[i] contains found_net_info structs
>> which have the following element:
>> u8 bssid[6];
> []
>> I am aware this patch gives a few check
On 23/06/16 20:24, Joe Perches wrote:
> On Thu, 2016-06-23 at 18:57 +0100, Luis de Bethencourt wrote:
>> hif_drv->usr_scan_req.net.net_info[i] contains found_net_info structs
>> which have the following element:
>> u8 bssid[6];
> []
>> I am aware this patch gives a few checkpatch.pl warnings about
- Original Message -
From: oleg.dro...@intel.com
To: lidza.lou...@oracle.com
Cc: de...@driverdev.osuosl.org, gre...@linuxfoundation.org,
lustre-de...@lists.lustre.org
Sent: Thursday, June 23, 2016 12:50:01 PM GMT -08:00 US/Canada Pacific
Subject: Re: [lustre-devel] [PATCH v2] staging/lust
On Jun 23, 2016, at 3:27 PM, Lidza Louina wrote:
>
> - Original Message -
> From: oleg.dro...@intel.com
> To: lidza.lou...@oracle.com
> Cc: gre...@linuxfoundation.org, lustre-de...@lists.lustre.org,
> de...@driverdev.osuosl.org, andreas.dil...@intel.com
> Sent: Thursday, June 23, 2016 1
On Thu, 2016-06-23 at 18:57 +0100, Luis de Bethencourt wrote:
> hif_drv->usr_scan_req.net.net_info[i] contains found_net_info structs
> which have the following element:
> u8 bssid[6];
[]
> I am aware this patch gives a few checkpatch.pl warnings about lines being
> over 80 characters. Fixing that
- Original Message -
From: oleg.dro...@intel.com
To: lidza.lou...@oracle.com
Cc: gre...@linuxfoundation.org, lustre-de...@lists.lustre.org,
de...@driverdev.osuosl.org, andreas.dil...@intel.com
Sent: Thursday, June 23, 2016 12:14:28 PM GMT -08:00 US/Canada Pacific
Subject: Re: [lustre-deve
On Jun 23, 2016, at 2:56 PM, Lidza Louina wrote:
> The code attempted to add an unsigned int to a an unsigned 64-bit
> integer. This patch makes the code use the correct type of int to
> suppress a smatch warning.
I think you might want to update the commit message too, because
it does not reall
The code attempted to add an unsigned int to a an unsigned 64-bit
integer. This patch makes the code use the correct type of int to
suppress a smatch warning.
Signed-off-by: Lidza Louina
---
drivers/staging/lustre/lnet/lnet/api-ni.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --g
- Original Message -
From: oleg.dro...@intel.com
To: lidza.lou...@oracle.com
Cc: de...@driverdev.osuosl.org, andreas.dil...@intel.com,
lustre-de...@lists.lustre.org, gre...@linuxfoundation.org
Sent: Thursday, June 23, 2016 11:11:06 AM GMT -08:00 US/Canada Pacific
Subject: Re: [lustre-deve
On Jun 23, 2016, at 2:07 PM, Lidza Louina wrote:
> The smatch warning was "drivers/staging/lustre/lnet/lnet/api-ni.c:516
> lnet_res_lh_initialize() warn: should '1 << ibits' be a 64 bit type?"
I think you misinterpreted it, it has nothing to do with the addition.
What it actually means is:
1 i
- Original Message -
From: oleg.dro...@intel.com
To: lidza.lou...@oracle.com
Cc: gre...@linuxfoundation.org, lustre-de...@lists.lustre.org,
de...@driverdev.osuosl.org, andreas.dil...@intel.com
Sent: Thursday, June 23, 2016 10:52:24 AM GMT -08:00 US/Canada Pacific
Subject: Re: [lustre-deve
hif_drv->usr_scan_req.net.net_info[i] contains found_net_info structs
which have the following element:
u8 bssid[6];
pstrNetworkInfo, of type network_info, also contains an u8 array named
bssid.
request->ssids is an array of cfg80211_ssid structs. Making ssid:
u8 ssid[IEEE80211_MAX_SSID_LEN];
In
NAK.
On Jun 23, 2016, at 1:24 PM, Lidza Louina wrote:
> The code attempted to add an unsigned int to a an unsigned 64-bit
> integer. This patch casts the unsigned regular int to suppress
> smatch warnings.
>
> Signed-off-by: Lidza Louina
> ---
> drivers/staging/lustre/lnet/lnet/api-ni.c | 2 +-
The code attempted to add an unsigned int to a an unsigned 64-bit
integer. This patch casts the unsigned regular int to suppress
smatch warnings.
Signed-off-by: Lidza Louina
---
drivers/staging/lustre/lnet/lnet/api-ni.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/
A change to the usb gadget core allowed certain API functions to be
part of a loadable module, which breaks having emxx_udc built-in:
drivers/staging/built-in.o: In function `nbu2ss_drv_probe':
(.text+0x2428): undefined reference to `usb_ep_set_maxpacket_limit'
The original patch already fixed to
On Wednesday, June 22, 2016 2:34:33 PM CEST Arnd Bergmann wrote:
> A change to the usb gadget core allowed certain API functions to be
> part of a loadable module, which breaks having emxx_udc built-in:
>
> drivers/staging/built-in.o: In function `nbu2ss_drv_probe':
> (.text+0x2428): undefined ref
2016-06-23 Emil Velikov :
> Hi Gustavo,
>
> On 20 June 2016 at 16:53, Gustavo Padovan wrote:
> > - - port libsync tests to kselftest
>
> I believe the tests haven't landed yet right, so this should stay right ?
Yes, you are right. That part is still missing in upstream.
Gustavo
__
From: Colin Ian King
trivial fix to spelling mistake in dev_err messages
Signed-off-by: Colin Ian King
---
drivers/staging/wilc1000/wilc_sdio.c | 2 +-
drivers/staging/wilc1000/wilc_spi.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_sdio
If there was an error, returning -EINVAL is more appropriate than -1.
Signed-off-by: Luis de Bethencourt
Reviewed-by: Julian Calaby
---
drivers/staging/wilc1000/wilc_debugfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_debugfs.c
b/driv
The common format to check if a function returned an error pointer is to
use PTR_ERR(). Instead of ERR_PTR() which is used to return said errors.
Signed-off-by: Luis de Bethencourt
Reviewed-by: Julian Calaby
---
drivers/staging/wilc1000/wilc_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 d
From: Stefan Wolz
Deleted unnecessary newlines and added whitespaces around operators.
Signed-off-by: Stefan Wolz
Signed-off-by: Christian Halder
Signed-off-by: Sebastian Handwerker
---
drivers/staging/sm750fb/sm750_hw.c | 26 +-
1 file changed, 9 insertions(+), 17 de
From: Stefan Wolz
Fixed alignment in multiline declarations.
Signed-off-by: Stefan Wolz
Signed-off-by: Christian Halder
Signed-off-by: Sebastian Handwerker
---
drivers/staging/sm750fb/sm750_hw.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/staging
From: Stefan Wolz
Fixed multiline comments to meet style standards,
fixed typos and split comment lines over 80 characters.
Signed-off-by: Stefan Wolz
Signed-off-by: Christian Halder
Signed-off-by: Sebastian Handwerker
---
drivers/staging/sm750fb/sm750_hw.c | 48 +
From: Stefan Wolz
Split lines over 80 characters and separated assignments.
Signed-off-by: Stefan Wolz
Signed-off-by: Christian Halder
Signed-off-by: Sebastian Handwerker
---
drivers/staging/sm750fb/sm750_hw.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/
Hello,
we made some style fixes for the file drivers/staging/sm750fb/sm750_hw.
There are 4 patches included:
Patch 1 corrects alignment of multiline statements,
patch 2 deletes some newlines and adds whitespaces around operators,
patch 3 fixes some typos and style problems in comments and
patch 4
Hi Luis,
On Thu, Jun 23, 2016 at 9:25 PM, Luis de Bethencourt
wrote:
> On 23/06/16 02:29, Julian Calaby wrote:
>> Hi All,
>>
>> On Wed, Jun 22, 2016 at 10:39 PM, Luis de Bethencourt
>> wrote:
>>> The common format to check if a function returned an error pointer is to
>>> use PTR_ERR(). Instead
On 23/06/16 02:29, Julian Calaby wrote:
> Hi All,
>
> On Wed, Jun 22, 2016 at 10:39 PM, Luis de Bethencourt
> wrote:
>> The common format to check if a function returned an error pointer is to
>> use PTR_ERR(). Instead of ERR_PTR() which is used to return said errors.
>>
>> Also, if there was an
On Thursday, June 23, 2016 11:11:49 AM CEST Binoy Jayan wrote:
>
> Thank you Arnd for patiently reviewing this patch series multiple times and
> apologies to everyone for spamming you inboxes with a patch (v3) that does
> not even build. It was due to an uncommited change in my git repo before
> g
On (06/22/16 11:27), Ganesh Mahendran wrote:
[..]
> > > Signed-off-by: Ganesh Mahendran
> > > ---
> > > drivers/staging/android/lowmemorykiller.c | 12
> > > 1 file changed, 8 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/staging/android/lowmemorykiller.c
> > > b/d
33 matches
Mail list logo
