[PATCH V1 1/3] docs: dts: Add documentation for hi6220 SoC ION node

2015-10-09 Thread Chen Feng
Documentation for hi6220 SoC ION node Signed-off-by: Chen Feng Signed-off-by: Yu Dongbin --- .../devicetree/bindings/staging/ion/hi6220-ion.txt | 31 ++ 1 file changed, 31 insertions(+) create mode 100644 Documentation/devicetree/bindings/staging/ion/hi6220-ion.txt diff --

[PATCH V1 2/3] taging: android: ion: Add ion driver for Hi6220 SoC platform

2015-10-09 Thread Chen Feng
Add ion support for hi6220 SoC platform. Signed-off-by: Chen Feng Signed-off-by: Yu Dongbin --- drivers/staging/android/ion/Kconfig| 7 + drivers/staging/android/ion/Makefile | 1 + drivers/staging/android/ion/hisilicon/Kconfig | 5 + drivers/staging/and

[PATCH V1 3/3] arm64: dts: Add dts files to enable ION on Hi6220 SoC.

2015-10-09 Thread Chen Feng
Add ION node to enable ION on hi6220 SoC platform Signed-off-by: Chen Feng Signed-off-by: Yu Dongbin --- arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 + arch/arm64/boot/dts/hisilicon/hi6220-ion.dtsi | 20 2 files changed, 21 insertions(+) create mode 100644 arch/ar

[PATCH 3/3] staging: rtl8188eu: BITn macro replaced by BIT(n) in hal/rtl8188e_hal_init.c

2015-10-09 Thread Ivan Safonov
This patch replace BITn macro to BIT(n). Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 26 --- 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/rtl8188eu/

[PATCH 2/3] staging: rtl8188eu: bugfix: correct channels range is set in Hal_ReadTxPowerInfo88E

2015-10-09 Thread Ivan Safonov
Correct channels range is 1..14 (numbering from 1) but not 0..13. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c b/drivers/stagin

[PATCH 1/3] staging: rtl8188eu: 5 GHz channel groups removed from /hal/rtl8188e_hal_init.c

2015-10-09 Thread Ivan Safonov
Unnecessary channel groups for 5 GHz removed from Hal_GetChnlGroup88E and it transformed to pretty get_channel_group(const u8 channel). Also removed code for 5 GHz frequency in Hal_ReadPowerValueFromPROM_8188E. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c |

[PATCH 0/3] staging: rtl8188eu: unnecessary 5 GHz code removed

2015-10-09 Thread Ivan Safonov
This patchset removes unnecessary code for 5 GHz channels (> 14), fixes channels range for FOR operator (channels are belong to 1..14 interval), and replace BITn macro to BIT(n). Ivan Safonov (3): staging: rtl8188eu: 5 GHz channel groups removed from /hal/rtl8188e_hal_init.c staging: rtl81

Re: [PATCH 2/3] staging: android: ion: Add ion driver for Hi6220 SoC platform

2015-10-09 Thread chenfeng
On 2015/10/9 16:58, Dan Carpenter wrote: > On Fri, Oct 09, 2015 at 11:53:32AM +0300, Dan Carpenter wrote: >>> +out: >> >> Labels named "out" are bug prone because handling everything is harder >> than using named labels and unwinding one step at a time. The bug here >> is that we don't call ion_

[PATCH] Staging: most: Fix typo in staging/most

2015-10-09 Thread Masanari Iida
This patch fix spelling typo found in most Signed-off-by: Masanari Iida --- drivers/staging/most/Documentation/ABI/sysfs-class-most.txt | 2 +- drivers/staging/most/hdm-dim2/Kconfig | 2 +- drivers/staging/most/hdm-usb/hdm_usb.c | 4 ++-- 3 files change

Re: [RESEND] mfd: rtsx: add support for rts522A

2015-10-09 Thread 敬锐
Hi Lee Sorry for bother you, but I still can't see this patch applied. Is there something wrong? Regards. micky. On 07/08/2015 03:38 PM, Lee Jones wrote: > On Wed, 08 Jul 2015, 敬锐 wrote: > >> >> On 07/07/2015 07:46 PM, Lee Jones wrote: >>> On Mon, 29 Jun 2015, micky_ch...@realsil.com.cn wrote: >>

[PATCH] staging: r8188eu: Add _enter_critical_mutex() error handling

2015-10-09 Thread Alexey Khoroshilov
_enter_critical_mutex() is a simple call to mutex_lock_interruptible(), but there is no error handling code for it. The patch removes wrapper _enter_critical_mutex() and adds error handling for mutex_lock_interruptible(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-

[PATCH] staging: comedi: adv_pci1724: prefer using the BIT macro

2015-10-09 Thread H Hartley Sweeten
As suggested by checkpatch.pl, use the BIT macro to define the register bits. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1724.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/stag

[PATCH] staging: comedi: adv_pci1723: prefer using the BIT macro

2015-10-09 Thread H Hartley Sweeten
As suggested by checkpatch.pl, use the BIT macro to define the register bits. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1723.c | 33 +++- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git

[PATCH 6/6] staging: comedi: adv_pci1710: rename private data member 'ai_et_MuxVal'

2015-10-09 Thread H Hartley Sweeten
Rename thie CamelCase member of the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/adv_pci1710.c b/

[PATCH 5/6] staging: comedi: adv_pci1710: tidy up PCI1720_* register defines

2015-10-09 Thread H Hartley Sweeten
The PCI-1720 board is supported by this driver but uses a different register map. For aesthetics, rename the defines to match the PCI171X_* format. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 41 ++---

[PATCH 4/6] staging: comedi: adv_pci1710: tidy up remaining PCI171x_* registers

2015-10-09 Thread H Hartley Sweeten
Rename these CamelCase defines. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 93 ++-- 1 file changed, 47 insertions(+), 46 deletions(-) diff --git a/drivers/staging/comedi/drivers/adv_pci1710.

[PATCH 3/6] staging: comedi: adv_pci1710: tidy up control register and bits

2015-10-09 Thread H Hartley Sweeten
Rename the CamelCase and use the BIT macro to define the bits. Also, rename the associated CamelCase members of the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 78 ++-- 1 file ch

[PATCH 2/6] staging: comedi: adv_pci1710: tidy up status register and bits

2015-10-09 Thread H Hartley Sweeten
Rename the CamelCase and use the BIT macro to define the bits. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 32 +--- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/drivers/stag

[PATCH 1/6] staging: comedi: adv_pci1710: tidy up multi-line comments

2015-10-09 Thread H Hartley Sweeten
Reformat the multi-line comments in the kernel CodingStyle. And refactor them to follow the normal format for comedi drivers. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1710.c | 53 ++-- 1 file change

[PATCH 0/6] staging: comedi: adv_pci1710: fix checkpatch.pl issues

2015-10-09 Thread H Hartley Sweeten
Fix the checkpatch.pl issues in this driver. H Hartley Sweeten (6): staging: comedi: adv_pci1710: tidy up multi-line comments staging: comedi: adv_pci1710: tidy up status register and bits staging: comedi: adv_pci1710: tidy up control register and bits staging: comedi: adv_pci1710: tidy up

[PATCH 3/3] staging: comedi: adq12b: usleep_range is preferred over udelay

2015-10-09 Thread H Hartley Sweeten
Fix checkpatch.pl issue: CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt Replace the udelay() with usleep_range() with a reasonable upper limit. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/dr

[PATCH 0/3] staging: comedi: adq12b: fix checkpatch.pl issues

2015-10-09 Thread H Hartley Sweeten
Fix the checkpatch.pl issues in this driver. H Hartley Sweeten (3): staging: comedi: adq12b: tidy up multi-line comments staging: comedi: adq12b: prefer using the BIT macro staging: comedi: adq12b: usleep_range is preferred over udelay drivers/staging/comedi/drivers/adq12b.c | 136

[PATCH 1/3] staging: comedi: adq12b: tidy up multi-line comments

2015-10-09 Thread H Hartley Sweeten
Reformat the multi-line comments in the kernel CodingStyle. And refactor them to follow the normal format for comedi drivers. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adq12b.c | 124 ++-- 1 file change

[PATCH 2/3] staging: comedi: adq12b: prefer using the BIT macro

2015-10-09 Thread H Hartley Sweeten
As suggested by checkpatch.pl, use the BIT macro to define the register bits. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adq12b.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/comedi

[PATCH 4/4] staging: comedi: adl_pci9111: fix alignment issue

2015-10-09 Thread H Hartley Sweeten
Use a local variable for the 'devpriv->ai_bounce_buffer' to shorten the lines in pci9111_handle_fifo_half_full() and gix the checkpath.pl issue about: CHECK: Alignment should match open parenthesis Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/come

[PATCH 3/4] staging: comedi: adl_pci9111: rename CamelCase parameters

2015-10-09 Thread H Hartley Sweeten
Rename the CamelCase parameters of plx9050_interrupt_control(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adl_pci9111.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/comedi/dr

[PATCH 2/4] staging: comedi: adl_pci9111: tidy up multi-line comments

2015-10-09 Thread H Hartley Sweeten
Reformat the multi-line comments in the kernel CodingStyle. Remove the unnecessary CHANGELOG information, git provided this better. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adl_pci9111.c | 104 --- 1 file

[PATCH 1/4] staging: comedi: adl_pci9111: prefer using the BIT macro

2015-10-09 Thread H Hartley Sweeten
As suggested by checkpatch.pl, use the BIT macro to define the register bits. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adl_pci9111.c | 41 ++-- 1 file changed, 20 insertions(+), 21 deletions(-) diff --git

[PATCH 0/4] staging: comedi: adl_pci9111: fix checkpatch.pl issues

2015-10-09 Thread H Hartley Sweeten
Fix the checkpatch.pl issues in this driver. H Hartley Sweeten (4): staging: comedi: adl_pci9111: prefer using the BIT macro staging: comedi: adl_pci9111: tidy up multi-line comments staging: comedi: adl_pci9111: rename CamelCase parameters staging: comedi: adl_pci9111: fix alignment issue

Re: [PATCH] staging: wilc1000: typo in WILC1000_DYNAMICALLY_ALLOCATE_MEMROY

2015-10-09 Thread Dan Carpenter
On Fri, Oct 09, 2015 at 09:19:07PM +0300, Stanislav Kholmanskikh wrote: > Looking at the code, it seems that "MEMROY" in the config option > name is a typo. It should be "MEMORY" instead. > > Changed the config option name accordingly. > > Signed-off-by: Stanislav Kholmanskikh Just delete it an

[PATCH] staging: wilc1000: typo in WILC1000_DYNAMICALLY_ALLOCATE_MEMROY

2015-10-09 Thread Stanislav Kholmanskikh
Looking at the code, it seems that "MEMROY" in the config option name is a typo. It should be "MEMORY" instead. Changed the config option name accordingly. Signed-off-by: Stanislav Kholmanskikh --- drivers/staging/wilc1000/Kconfig | 2 +- drivers/staging/wilc1000/Makefile | 2 +- 2 files chang

[PATCH 0/2] staging: comedi: adl_pci9118: fix checkpatch.pl issues

2015-10-09 Thread H Hartley Sweeten
Fix the checkpatch.pl issues in this driver. H Hartley Sweeten (2): staging: comedi: adl_pci9118: prefer using the BIT macro staging: comedi: adl_pci9118: rename Compute_and_setup_dma() drivers/staging/comedi/drivers/adl_pci9118.c | 64 ++-- 1 file changed, 32 inserti

[PATCH 1/2] staging: comedi: adl_pci9118: prefer using the BIT macro

2015-10-09 Thread H Hartley Sweeten
As suggested by checkpatch.pl, use the BIT macro to define the register bits. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adl_pci9118.c | 58 ++-- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git

[PATCH 2/2] staging: comedi: adl_pci9118: rename Compute_and_setup_dma()

2015-10-09 Thread H Hartley Sweeten
Rename this CamelCase function. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adl_pci9118.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c b/drivers/staging/come

[PATCH] staging: comedi: adl_pci6208: prefer using the BIT macro

2015-10-09 Thread H Hartley Sweeten
As suggested by checkpatch.pl, use the BIT macro to define the register bits. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adl_pci6208.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drive

[PATCH] staging: comedi: addi_apci_3xxx: prefer using the BIT macro

2015-10-09 Thread H Hartley Sweeten
As suggested by checkpatch.pl, use the BIT macro to define the register bits. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/addi_apci_3xxx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/com

[PATCH] staging: comedi: addi_apci_3120: prefer using the BIT macro

2015-10-09 Thread H Hartley Sweeten
As suggested by checkpatch.pl, use the BIT macro to define the register bits. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/addi_apci_3120.c | 54 + 1 file changed, 28 insertions(+), 26 deletions(-) diff --git

[PATCH 2/2] staging: comedi: addi_apci_2032: document the spinlock_t definition

2015-10-09 Thread H Hartley Sweeten
Add some comments to the private data tp quiet the checkpatch.pl issue about: CHECK: spinlock_t definition without comment Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- We might be able to just use comedi_subdevice 'spin_lock' instead and remove the 'spinlock' from

[PATCH 1/2] staging: comedi: addi_apci_2032: prefer using the BIT macro

2015-10-09 Thread H Hartley Sweeten
As suggested by checkpatch.pl, use the BIT macro to define the register bits. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/addi_apci_2032.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/stagin

[PATCH 0/2] staging: comedi: addi_apci_2032: fix checkpatch.pl issues

2015-10-09 Thread H Hartley Sweeten
Minor cleanup to address the checkpatch.pl issues. H Hartley Sweeten (2): staging: comedi: addi_apci_2032: prefer using the BIT macro staging: comedi: addi_apci_2032: document the spinlock_t definition drivers/staging/comedi/drivers/addi_apci_2032.c | 16 1 file changed, 8 i

[PATCH] staging: comedi: addi_apci_1032: prefer using the BIT macro

2015-10-09 Thread H Hartley Sweeten
As suggested by checkpatch.pl, use the BIT macro to define the register bits. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/addi_apci_1032.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/co

RE: [PATCH 0/6] staging: comedi: fix some minor issues with file poll op

2015-10-09 Thread Hartley Sweeten
On Friday, October 09, 2015 4:27 AM, Ian Abbott wrote: > A few changes for the "poll" file operation to avoid poll-waiting on the > same subdevice for both read and write (patch 1), avoid allocating write > buffer space unnecessarily and possibly inappropriately (patch 4), > consider whether any ac

RE: [PATCH 6/6] staging: comedi: don't use mutex when polling file

2015-10-09 Thread Hartley Sweeten
On Friday, October 09, 2015 4:27 AM, Ian Abbott wrote: > The main mutex in a comedi device can get held for quite a while when > processing comedi instructions, so for performance reasons, the "read" > and "write" file operations do not use it; they use use the > `attach_lock` rwsemaphore to protec

Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

2015-10-09 Thread Dan Carpenter
On Wed, Sep 30, 2015 at 12:34:33PM +0300, Dan Carpenter wrote: > On Tue, Sep 29, 2015 at 10:24:59PM +0200, Tillmann Heidsieck wrote: > > On Mon, Sep 28, 2015 at 09:56:19AM -0500, Larry Finger wrote: > > > The primary requirement for moving a driver out of staging is that it use > > > mac80211. No a

Re: [PATCH 02/10] Drivers: hv: utils: run polling callback always in interrupt context

2015-10-09 Thread Olaf Hering
On Fri, Oct 09, Vitaly Kuznetsov wrote: > Olaf Hering writes: > > > On Thu, Oct 08, KY Srinivasan wrote: > > > >> > yes, but after doing fcopy_respond_to_host(). I'd suggest we leave the > >> > check in place, better safe than sorry. > >> > >> Agreed; Olaf, if it is ok with you, I can fix it up

[PATCH] staging: wilc1000: fix memory leak on mgmt_tx on error return path

2015-10-09 Thread Colin King
From: Colin Ian King Static analysis with cppcheck found the following memory leak: [drivers/staging/wilc1000/linux_mon.c:255]: (error) Memory leak: mgmt_tx Free mgmt_tx on the error return path when mgmt_tx->buff fails to be allocated. Signed-off-by: Colin Ian King --- drivers/staging/wilc1

[PATCH 5/6] staging: comedi: check command started by file being polled

2015-10-09 Thread Ian Abbott
Currently, the "poll" file operation checks if an asynchronous "read" (or "write" command is active on the "read" (or "write" subdevice, but does not consider whether the command was started from the file object being polled. Since that is the only file object able to read (or write) data, take it

[PATCH 3/6] staging: comedi: add new comedi_buf_write_n_available()

2015-10-09 Thread Ian Abbott
Add a new function `comedi_buf_write_n_available()` to return the amount of buffer space available for writing, including space already allocated by `comedi_buf_write_alloc()` plus any unallocated space available. This is currently just for internal use by the comedi core, so is not exported. Sign

[PATCH 4/6] staging: comedi: don't allocate buffer space when polling for write

2015-10-09 Thread Ian Abbott
When handling the "poll" file operation and checking for `POLLOUT`, don't allocate space from the buffer for writing, just check that space is available for writing. That check is done after checking that an asynchronous "write" command is running on the subdevice. Allocating the buffer space bef

[PATCH 6/6] staging: comedi: don't use mutex when polling file

2015-10-09 Thread Ian Abbott
The main mutex in a comedi device can get held for quite a while when processing comedi instructions, so for performance reasons, the "read" and "write" file operations do not use it; they use use the `attach_lock` rwsemaphore to protect against the comedi device becoming detached at an inopportune

[PATCH 0/6] staging: comedi: fix some minor issues with file poll op

2015-10-09 Thread Ian Abbott
A few changes for the "poll" file operation to avoid poll-waiting on the same subdevice for both read and write (patch 1), avoid allocating write buffer space unnecessarily and possibly inappropriately (patch 4), consider whether any active commands belong to the current file object (patch 5), and

[PATCH 1/6] staging: comedi: don't poll_wait on same subdevice twice

2015-10-09 Thread Ian Abbott
Comedi subdevices that support asynchronous acquisition commands have a wait queue head used for blocking reads or writes and for the poll file operation. The comedi device may have several subdevices that support "read" and/or "write" commands, but each open file object has at most one "read" sub

[PATCH 2/6] staging: comedi: rename comedi_buf_write_n_available

2015-10-09 Thread Ian Abbott
Rename the local function `comedi_buf_write_n_available()` to `comedi_buf_write_n_unalloc()`. It is the amount of unallocated space available in the buffer that is available to be allocated for writing and does not include the space that has already been allocated for writing. This is unlike the

Re: [PATCH 02/10] Drivers: hv: utils: run polling callback always in interrupt context

2015-10-09 Thread Vitaly Kuznetsov
Olaf Hering writes: > On Thu, Oct 08, KY Srinivasan wrote: > >> > yes, but after doing fcopy_respond_to_host(). I'd suggest we leave the >> > check in place, better safe than sorry. >> >> Agreed; Olaf, if it is ok with you, I can fix it up and send. > > I will retest with this part reverted. I t

Re: [PATCH 2/3] staging: android: ion: Add ion driver for Hi6220 SoC platform

2015-10-09 Thread xuyiping
On 2015/10/8 15:55, Chen Feng wrote: Signed-off-by: Chen Feng Signed-off-by: Yu Dongbin --- drivers/staging/android/ion/Kconfig| 7 + drivers/staging/android/ion/Makefile | 1 + drivers/staging/android/ion/hisilicon/Kconfig | 5 + drivers/staging/

[PATCH v3 3/3] staging: rtl8188eu: spaces preferred around that + inserted

2015-10-09 Thread Ivan Safonov
This patch inserts spaces preferred around that '+' found by checkpatch. Signed-off-by: Ivan Safonov --- Changes in v2: - inserted description to this patch, - added Signed-off record. Changes in v3: - Signed-off before cut-off. drivers/staging/rtl8188eu/hal/bb_cfg.c | 8 1 file

[PATCH v3 2/3] staging: rtl8188eu: ARRAY_SIZE instead of sizeof/sizeof used

2015-10-09 Thread Ivan Safonov
This patch inserts ARRAY_SIZE instead of sizeof(type array[])/sizeof(type). Signed-off-by: Ivan Safonov --- Changes in v2: - inserted description to this patch. Changes in v3: - Signed-off before cut-off. drivers/staging/rtl8188eu/hal/bb_cfg.c | 8 1 file changed, 4 insertions(+),

[PATCH v3 1/3] staging: rtl8188eu: unused macro read_nexp_pair removed

2015-10-09 Thread Ivan Safonov
This patch removes unused macro read_nexp_pair. Signed-off-by: Ivan Safonov --- Changes in v2: - added description to this patch. Changes in v3: - Signed-off before cut-off. drivers/staging/rtl8188eu/hal/bb_cfg.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8

[PATCH v3 0/3] staging: rtl8188eu: ARRAY_SIZE instead of sizeof/sizeof and some code cleanups

2015-10-09 Thread Ivan Safonov
This patchset: - removes unused macro read_nexp_pair, - inserts ARRAY_SIZE instead of sizeof(type array[])/sizeof(type), - inserts spaces preferred around that '+' found by checkpatch. --- Changes in v2: - some patches aggregated into this patchset, - added description to all patches. ---

Re: [PATCH 2/3] staging: android: ion: Add ion driver for Hi6220 SoC platform

2015-10-09 Thread Dan Carpenter
On Fri, Oct 09, 2015 at 11:53:32AM +0300, Dan Carpenter wrote: > > +out: > > Labels named "out" are bug prone because handling everything is harder > than using named labels and unwinding one step at a time. The bug here > is that we don't call ion_device_destroy(). > > > + for (i = 0; i < num

Re: [PATCH V2] staging: dgnc: Remove dgnc_ports_state_show

2015-10-09 Thread Dan Carpenter
On Fri, Oct 09, 2015 at 09:50:58AM +0100, Salah Triki wrote: > On Thu Oct 8 07:22:58 UTC 2015, dan carpenter wrote: > >On Thu, Oct 08, 2015 at 07:26:37AM +0100, Salah Triki wrote: > >> dgnc_ports_state_show is removed, since it exposes ports status which > >> help an adversary to > >> plan an attac

Re: [PATCH 2/3] staging: android: ion: Add ion driver for Hi6220 SoC platform

2015-10-09 Thread Dan Carpenter
On Thu, Oct 08, 2015 at 03:55:12PM +0800, Chen Feng wrote: > Signed-off-by: Chen Feng > Signed-off-by: Yu Dongbin > --- > drivers/staging/android/ion/Kconfig| 7 + > drivers/staging/android/ion/Makefile | 1 + > drivers/staging/android/ion/hisilicon/Kconfig

Re: [PATCH V2] staging: dgnc: Remove dgnc_ports_state_show

2015-10-09 Thread Salah Triki
On Thu Oct 8 07:22:58 UTC 2015, dan carpenter wrote: >On Thu, Oct 08, 2015 at 07:26:37AM +0100, Salah Triki wrote: >> dgnc_ports_state_show is removed, since it exposes ports status which >> help an adversary to >> plan an attack. > >No. It doesn't export anything harmful and it only is readable b

Re: [PATCH v2 3/3] staging: rtl8188eu: spaces preferred around that + inserted

2015-10-09 Thread Dan Carpenter
On Fri, Oct 09, 2015 at 12:40:47AM +0700, Ivan Safonov wrote: > This patch inserts spaces preferred around that '+' found by checkpatch. > --- > Changes in v2: > - inserted description to this patch, > - added Signed-off record. > > Signed-off-by: Ivan Safonov > --- You put the signoff under

Re: [PATCH 08/14] staging: wilc1000: remove typedef from tstrStatistics

2015-10-09 Thread Dan Carpenter
On Fri, Oct 09, 2015 at 11:16:28AM +0300, Dan Carpenter wrote: > I feel like the name 'statistics' is very vague. I guess it's so vague > that it's unlikely anyone else will try use it... > A lot of these are pretty vague. But I guess it's probably ok... Nevermind me. regards, dan carpenter _

Re: [PATCH 08/14] staging: wilc1000: remove typedef from tstrStatistics

2015-10-09 Thread Dan Carpenter
I feel like the name 'statistics' is very vague. I guess it's so vague that it's unlikely anyone else will try use it... regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/

Re: [PATCH 02/10] Drivers: hv: utils: run polling callback always in interrupt context

2015-10-09 Thread Olaf Hering
On Thu, Oct 08, KY Srinivasan wrote: > > yes, but after doing fcopy_respond_to_host(). I'd suggest we leave the > > check in place, better safe than sorry. > > Agreed; Olaf, if it is ok with you, I can fix it up and send. I will retest with this part reverted. I think without two code paths ente

Re: [PATCH 0/3] staging: sm750fb: remove sii164 DVI controller support

2015-10-09 Thread Sudip Mukherjee
On Thu, Oct 08, 2015 at 09:11:07PM +0100, Mike Rapoport wrote: > Hi Sudip, > > On Thu, Oct 08, 2015 at 11:46:28AM +0530, Sudip Mukherjee wrote: > > On Tue, Oct 06, 2015 at 04:49:13PM +0100, Mike Rapoport wrote: > > > Currently the sii164 DVI controller support is unused anywhere in the > > > rest