On Fri, Oct 02, 2015 at 07:56:28AM +0900, Chaehyun Lim wrote:
> On Fri, Oct 2, 2015 at 12:40 AM, Dan Carpenter
> wrote:
> > On Thu, Oct 01, 2015 at 10:43:55PM +0900, Chaehyun Lim wrote:
> >> This patch replaces int8_t with s8 that is a preferred type.
> >>
> >
> > It would be better to just use i
The ->read_xxx() methods are all passed the page number the NAND controller
is supposed to read, but ->write_xxx() do not have such a parameter.
This is a problem if we want to properly implement data
scrambling/randomization in order to mitigate MLC sensibility to repeated
pattern: to prevent bit
This is a patch to correct block comment formatting in two
instances in ieee80211_crypt_ccmp.c
Signed-off-by: Mike Dupuis
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee8021
This is a patch to fix up instances where quoted strings are split
across multiple lines in several instances in ieee80211_crypt_ccmp.c
Signed-off-by: Mike Dupuis
---
.../rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 27 +-
1 file changed, 11 insertions(+), 16 deletions(-)
This is a series of patches to correct several checkpatch.pl warnings
and errors in ieee80211_crypt_ccmp.c.
Checkpatch.pl before/after summary:
before: total: 2 errors, 23 warnings, 23 checks, 474 lines checked
after: total: 0 errors, 10 warnings, 27 checks, 469 lines checked
Mike Dupuis (5):
This is a patch to correct indentation in one instance in
ieee80211_crypt_ccmp.c
Signed-off-by: Mike Dupuis
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c
This is a patch to add missing lines after variable decalarations
in two functions in ieee80211_crypt_ccmp.c
Signed-off-by: Mike Dupuis
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211
This is a patch to move open braces to the appropriate lines in
two instances in ieee80211_crypt_ccmp.c
Signed-off-by: Mike Dupuis
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee
From: Glen Lee
This patch removes unused variable real_ndev.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_netdevice.h
b/drivers/staging/wilc1000/wilc_wfi_
From: Glen Lee
This patch removes function pointer cfg_init and call the function
wilc_wlan_cfg_init instead. Remove static from function declaration.
After removing cfg_init, the struct wilc_cfg_func_t is useless so just delete
it and it's related codes.
Signed-off-by: Glen Lee
Signed-off-by:
From: Glen Lee
This patch removes function pointer rx_indicate and just call the function
wilc_wlan_cfg_indicate_rx instead. Remove static from the function
declration.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/wilc_wlan.c | 2 +-
drivers/staging/wilc100
From: Glen Lee
Remove function pointer cfg_wid_get and call the function
wilc_wlan_cfg_get_wid instead. Remove static from the function declaration.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/wilc_wlan.c | 2 +-
drivers/staging/wilc1000/wilc_wlan.h |
From: Glen Lee
This patch removes function pointer cfg_wid_set and call the function
wilc_wlan_cfg_set_wid instead. Remove static from the function declaration.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/wilc_wlan.c | 5 +++--
drivers/staging/wilc1000/wil
From: Glen Lee
This patch removes cfg_wid_get_val and call the function
wilc_wlan_cfg_get_wid_value. Remove static from the function declaration.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/wilc_wlan.c | 2 +-
drivers/staging/wilc1000/wilc_wlan.h | 1 -
This patch removes typedef from enumerated types defined in
coreconfigurator.c file and also changes their names to avoid CamelCase
naming convention as shown:
- tenuBasicFrmType to basic_frame_type
- tenuFrmSubtype to sub_frame_type
- tenuInfoElemID to info_element_id
Signed-off-by: Tony Cho
--
From: Glen Lee
This patch removes undefined DEBUG_MODE and it's related codes.
We won't use this at the moment.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/linux_wlan.c | 63 ---
1 file changed, 63 deletions(-)
diff --git a/dri
From: Glen Lee
This patch removes unused variable already_claim and hWILCWFIDrv_2.
Signed-off-by: Glen Lee
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_netdevice.h
b/drivers/st
This patch removes unused structure, tstrconfigPktInfo from the
coreconfigurator.c file.
Signed-off-by: Tony Cho
---
drivers/staging/wilc1000/coreconfigurator.c | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/wilc1000/coreconfigurator.c
b/drivers/staging/wilc1000/core
On Thu, Oct 01, 2015 at 09:34:51PM +0200, Boris Brezillon wrote:
> The ->read_xxx() methods are all passed the page number the NAND controller
> is supposed to read, but ->write_xxx() do not have such a parameter.
>
> This is a problem if we want to properly implement data
> scrambling/randomizati
Hey,
Hope you are doing well!
We provide email marketing service to a number of businesses.
We can help your business reach the next level and generate more business
leads.
Please contact us so I can go over options for you.
Thanks and regards,
Jensen Lewis
Contact: mihuiyu...@sina.com
___
This is a PCMCIA driver and interrupts are always shared. Detect if
the hardware did not produce the interrupt and return IRQ_NONE so
that other drivers might handle it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c
Reformat the multi-line comments in the kernel CodingStyle.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 83 +++-
1 file changed, 37 insertions(+), 46 deletions(-)
diff --git a/drivers/staging
Reorder the register map defines so that each register define is
followed by its bit defines.
For aesthetics, change all the register offsets to hex values and
use the BIT macro to define the register bits.
Also for aesthetics, move the DAQP_FIFO_SIZE and private data
definition after the registe
Interrupts are only needed by this driver to support the analog input async
commands. Don't hook up the command support if pcmcia_request_irq() fails
instead of completely failing the (*auto_attach).
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/com
Fix the checkpatch.pl issues about:
CHECK: spaces preferred around that '<<' (ctx:VxV)
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/s
For aesthetics, define a macro for the pacer clock options and rename
the CamelCase.
Remove the unnecessary local variable in daqp_ai_cmd() used to set the
control register.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/quatech_daqp_
Use the comedi_offset_munge() helper to do the offset binary to two's
complement conversion when writing a new analog output value.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 8 +++-
1 file changed, 3 insert
Introduce a helper function for the common code used to clear any
pending interrupts.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 52
1 file changed, 25 insertions(+), 27 deletions(-)
di
The data link between the D/A data port and the D/A converter is a serial
link. The serial link requires about 8ms to complete a transfer. Use the
comedi_timeout() helper to ensure that there is not a previous transfer
still happening before trying to write new data to the channel.
For aesthetics,
The interrupt handler is now only used for the ai async command.
Remove the unnecessary 'interrupt_mode' from the private data and
tidy up the interrupt handler.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 70 +++
Introduce a helper function to get a two's complement sample from
the FIFO and munge it to the offset binary format that comedi uses.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
v2: as pointed out by the kbuild test robot (less than a hour after
posting the se
The comedi (*insn_read) functions are supposed to do simple one-shot
reading of an analog input channel. Currently this driver enables
interrupts and uses wait_for_completion_interruptible() to allow the
interrupt routine to let the analog input (*insn_read) know that
the end-of-conversion has occu
Make sure interrupts are disabled and the event flags are cleared when
the analog input async command is canceled.
Remove the unnecessary calls to stop any running conversions in the
(*insn_read) and (*do_cmd) functions. The comedi core will only call
these functions if the subdevice is not busy (
Clarify the scan list programming a bit by refactoring this function to program
the entire scan list instead of just a single entry. Move the necessary reset
of the scan list into this function. Rename the function.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
dri
According to the users manual, the conversion timing (scanrate) is fixed
to 100, 50, or 25 kHz. The pacer clock is then used to trigger each scan.
Currently this driver tries to fake other conversion speeds by always
sampling the inputs at 100 kHz and using the pacer clock to trigger each
conversi
Following is the cleanup series for the comedi quatech_daqp_cs PCMCIA
driver.
v2: fix patch 08/17 as pointed out by the kbuild test robot
daqp_ai_get_sample() should be static
H Hartley Sweeten (17):
staging: comedi: quatech_daqp_cs: there are 4 digital outputs
staging: comedi: quatech_da
This board has 4 digital inputs not 1. Fix the subdevice init.
The digital input lines are shared with other functions. Add a
comment about this.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 13 -
1 f
This board has 4 digital outputs not 1. Fix the subdevice init.
The digital output lines are used for the external channel selection
when the expansion mode is enabled. Add a comment about this.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/
On Fri, Oct 2, 2015 at 12:40 AM, Dan Carpenter wrote:
> On Thu, Oct 01, 2015 at 10:43:55PM +0900, Chaehyun Lim wrote:
>> This patch replaces int8_t with s8 that is a preferred type.
>>
>
> It would be better to just use int.
I always appreciate your comment. I've sent a patch before after
changin
From: Vitaly Kuznetsov
Storvsc driver needs to ensure there are no 'holes' in the presented
sg list (all segments in the middle of the list need to be of PAGE_SIZE).
When a hole is detected storvsc driver creates a 'bounce sgl' without
holes and copies data over with copy_{to,from}_bounce_buffer(
> -Original Message-
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Tuesday, September 29, 2015 6:34 AM
> To: James E.J. Bottomley ; KY Srinivasan
>
> Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; oher...@suse.com;
> jbottom.
On Thu, 1 Oct 2015 20:04:17 +0200
Boris Brezillon wrote:
> The ->read_xxx() methods are all passed the page number the NAND controller
> is supposed to read, but ->write_xxx() do not have such a parameter.
>
> This is a problem if we want to properly implement data
> scrambling/randomization in
The ->read_xxx() methods are all passed the page number the NAND controller
is supposed to read, but ->write_xxx() do not have such a parameter.
This is a problem if we want to properly implement data
scrambling/randomization in order to mitigate MLC sensibility to repeated
pattern: to prevent bit
On Thursday, October 01, 2015 11:38 AM, kbuild test robot wrote:
> Hi Hartley,
>
> [auto build test results on v4.3-rc3 -- if it's inappropriate base, please
> ignore]
>
> reproduce:
> # apt-get install sparse
> make ARCH=x86_64 allmodconfig
> make C=1 CF=-D__CHECK_ENDIAN__
Change the MODULE_DESCRIPTION to something more usefull than the
generic "Comedi low-level driver".
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcm3724.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/st
For aesthetics, rename the register map defines so they have namespace
associated with the driver and use the BIT macro to define the bits.
Add the missing defines for the registers and use them to remove the
magic values from the driver.
Add a comment about the extra registers to explain why thi
Reformat the multi-line comments in the kernel CodingStyle.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcm3724.c | 44 ++--
1 file changed, 19 insertions(+), 25 deletions(-)
diff --git a/drivers/staging
Some minor cleanup to the comedi pcm3724 PC/104 legacy driver.
H Hartley Sweeten (3):
staging: comedi: pcm3724: tidy up multi-line comments
staging: comedi: pcm3724: tidy up register map defines
staging: comedi: pcm3724: update the MODULE_DESCRIPTION
drivers/staging/comedi/drivers/pcm3724.
Signed-off-by: Fengguang Wu
---
quatech_daqp_cs.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
index 23c79e3..96471fc 100644
--- a/drivers/staging/comedi/drivers/qua
Hi Hartley,
[auto build test results on v4.3-rc3 -- if it's inappropriate base, please
ignore]
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
>> drivers/staging/comedi/drivers/
Hi Boris,
[auto build test results on next-20151001 -- if it's inappropriate base, please
ignore]
config: i386-randconfig-s1-201539 (attached as .config)
reproduce:
git checkout 425b29816a0dba028eef09be5cb531a187e256a1
# save the attached .config to linux build tree
On Thu, 1 Oct 2015 10:17:50 -0700
Brian Norris wrote:
> On Mon, Aug 24, 2015 at 07:10:19PM +0200, Boris Brezillon wrote:
> > The ->read_xxx() methods are all passed the page number the NAND controller
> > is supposed to read, but ->write_xxx() do not have such a parameter.
> >
> > This is a prob
Fix the checkpatch.pl issues.
Signed-off-by: H Hartley Sweeten
---
drivers/staging/comedi/drivers/8255.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/comedi/drivers/8255.h
b/drivers/staging/comedi/drivers/8255.h
index 41823de..55a67af 100644
-
The ->read_xxx() methods are all passed the page number the NAND controller
is supposed to read, but ->write_xxx() do not have such a parameter.
This is a problem if we want to properly implement data
scrambling/randomization in order to mitigate MLC sensibility to repeated
pattern: to prevent bit
This is a PCMCIA driver and interrupts are always shared. Detect if
the hardware did not produce the interrupt and return IRQ_NONE so
that other drivers might handle it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c
Reformat the multi-line comments in the kernel CodingStyle.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 83 +++-
1 file changed, 37 insertions(+), 46 deletions(-)
diff --git a/drivers/staging
Reorder the register map defines so that each register define is
followed by its bit defines.
For aesthetics, change all the register offsets to hex values and
use the BIT macro to define the register bits.
Also for aesthetics, move the DAQP_FIFO_SIZE and private data
definition after the registe
Interrupts are only needed by this driver to support the analog input async
commands. Don't hook up the command support if pcmcia_request_irq() fails
instead of completely failing the (*auto_attach).
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/com
Introduce a helper function for the common code used to clear any
pending interrupts.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 52
1 file changed, 25 insertions(+), 27 deletions(-)
di
Fix the checkpatch.pl issues about:
CHECK: spaces preferred around that '<<' (ctx:VxV)
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/s
For aesthetics, define a macro for the pacer clock options and rename
the CamelCase.
Remove the unnecessary local variable in daqp_ai_cmd() used to set the
control register.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/quatech_daqp_
Use the comedi_offset_munge() helper to do the offset binary to two's
complement conversion when writing a new analog output value.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 8 +++-
1 file changed, 3 insert
The data link between the D/A data port and the D/A converter is a serial
link. The serial link requires about 8ms to complete a transfer. Use the
comedi_timeout() helper to ensure that there is not a previous transfer
still happening before trying to write new data to the channel.
For aesthetics,
Introduce a helper function to get a two's complement sample from
the FIFO and munge it to the offset binary format that comedi uses.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 23 ---
1 file
Make sure interrupts are disabled and the event flags are cleared when
the analog input async command is canceled.
Remove the unnecessary calls to stop any running conversions in the
(*insn_read) and (*do_cmd) functions. The comedi core will only call
these functions if the subdevice is not busy (
Clarify the scan list programming a bit by refactoring this function to program
the entire scan list instead of just a single entry. Move the necessary reset
of the scan list into this function. Rename the function.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
dri
The comedi (*insn_read) functions are supposed to do simple one-shot
reading of an analog input channel. Currently this driver enables
interrupts and uses wait_for_completion_interruptible() to allow the
interrupt routine to let the analog input (*insn_read) know that
the end-of-conversion has occu
The interrupt handler is now only used for the ai async command.
Remove the unnecessary 'interrupt_mode' from the private data and
tidy up the interrupt handler.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 70 +++
According to the users manual, the conversion timing (scanrate) is fixed
to 100, 50, or 25 kHz. The pacer clock is then used to trigger each scan.
Currently this driver tries to fake other conversion speeds by always
sampling the inputs at 100 kHz and using the pacer clock to trigger each
conversi
This board has 4 digital inputs not 1. Fix the subdevice init.
The digital input lines are shared with other functions. Add a
comment about this.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 13 -
1 f
Following is the cleanup series for the comedi quatech_daqp_cs PCMCIA
driver.
H Hartley Sweeten (17):
staging: comedi: quatech_daqp_cs: there are 4 digital outputs
staging: comedi: quatech_daqp_cs: there are 4 digital inputs
staging: comedi: quatech_daqp_cs: fix ai cmd timing
staging: come
This board has 4 digital outputs not 1. Fix the subdevice init.
The digital output lines are used for the external channel selection
when the expansion mode is enabled. Add a comment about this.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/
On 30.09.2015 14:12, Luis de Bethencourt wrote:
> wstats->qual.noise is of type uint8, so it shouldn't be assigned a
> negative number. Assigning it 0x100 - 100, which is the equivalent
> to -100 dBm when IW_QUAL_DBM is set.
>
> Signed-off-by: Luis de Bethencourt
> ---
> drivers/staging/rtl8192e
On Mon, Aug 24, 2015 at 07:10:19PM +0200, Boris Brezillon wrote:
> The ->read_xxx() methods are all passed the page number the NAND controller
> is supposed to read, but ->write_xxx() do not have such a parameter.
>
> This is a problem if we want to properly implement data
> scrambling/randomizati
On Thu, Oct 01, 2015 at 05:07:43PM +0200, Boris Brezillon wrote:
> On Mon, 24 Aug 2015 19:10:19 +0200
> Boris Brezillon wrote:
>
> > The ->read_xxx() methods are all passed the page number the NAND controller
> > is supposed to read, but ->write_xxx() do not have such a parameter.
> >
> > This i
From: Tim Sell
Registration of visorinput_open() and visorinput_close() for each device
allow us to eliminate unnecessary activity when nobody in user-land
cares.
Signed-off-by: Tim Sell
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorinput/visorinput.c | 55
From: Tim Sell
do_key() is no longer needed.
Signed-off-by: Tim Sell
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorinput/visorinput.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/unisys/visorinput/visorinput.c
b/drive
From: Tim Sell
Just a simple search and replace in the comments.
Signed-off-by: Tim Sell
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorinput/visorinput.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/unisys/visorinput/visorinput.c
b
From: Tim Sell
This visorhid driver provides a Human Interface Device, but is not at all
using HID, the protocol. It's a plain input driver, so for clarity, it is
being renamed to visorinput.
Signed-off-by: Tim Sell
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/Documentation/overv
From: Tim Sell
Multi-line comments were modified to conform to kernel conventions:
/*
* multi-line
* comments
*/
doc-test /** */ for some comments was removed.
Signed-off-by: Tim Sell
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorinput/visorinput.c | 47 ++
From: Tim Sell
Add the renamed driver to the Kconfig.
Signed-off-by: Tim Sell
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorinput/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visorinput/Kconfig
b/drivers/staging/unisys/vis
From: Tim Sell
Removes a cursor positioning hack that no longer seems to be required.
Signed-off-by: Tim Sell
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorinput/visorinput.c | 12
1 file changed, 12 deletions(-)
diff --git a/drivers/staging/unisys/visorinput/vis
This patch series contains a series of changes requested by Benjamin
Tissoires from Red Hat, after he reviewed the module for us.
Most importantly, the module is renamed from visorhid to visorinput,
since it is not a HID driver.
Tim Sell (13):
staging: unisys: visorhid: correctly map keys with
From: Tim Sell
BUS_HOST wasn't really appropriate, so I changed to BUS_VIRTUAL, which is
what virtio uses.
Signed-off-by: Tim Sell
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorinput/visorinput.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/s
From: Tim Sell
This also gave me a warning with the assignment:
visorinput_dev->keycode = visorkbd_keycode;
because input_dev->keycode is NOT static but visorkbd_keycode now is, so
I went ahead and also added logic to stash away non-static copies of
visorkbd_keycode[] and visorkbd_ext_keyco
From: Tim Sell
The most-noticed key that wasn't being mapped correctly was Right-Alt,
which is the AltGr key on many non-US keyboards, used to select many
extended characters.
Signed-off-by: Tim Sell
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorhid/visorhid.c | 10 +++---
From: Tim Sell
In order to be more consistent with kernel conventions used elsewhere,
I have re-ordered declarations in visorinput.c to follow this general
order (where possible):
* #defines
* struct/enum/union declarations
* static declarations (const if possible for all of them)
* forward funct
From: Tim Sell
keyboardchannel.h and mousechannel.h are now included within
visorinput.c directly.
Signed-off-by: Tim Sell
Signed-off-by: Benjamin Romer
---
.../staging/unisys/visorinput/keyboardchannel.h| 32 -
drivers/staging/unisys/visorinput/mousechannel.h | 33 -
From: Tim Sell
No need for serio.h to be included.
Signed-off-by: Tim Sell
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorhid/visorhid.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/unisys/visorhid/visorhid.c
b/drivers/staging/unisys/visorhid/visorhid.c
i
Properly handle the return value from queue_delayed_work() - it's a
bool, not an int, so using a less than comparison isn't appropriate.
This mistake was found by David Binderman .
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorbus/periodic_work.c | 8
1 file changed, 4
From: David Kershner
We don't need the list of devices, we can loop through the one
provided by the network api and filter on ours.
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visornic/visornic_main.c | 13 -
1 file changed, 13 deletions(
From: David Kershner
devnum pool and devnum are no longer needed.
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visornic/visornic_main.c | 26 -
1 file changed, 26 deletions(-)
diff --git a/drivers/staging/unisys/visornic/visor
From: David Kershner
The net device already has a name, so use that instead.
Signed-off-by: David Kershner
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visornic/visornic_main.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/unisys/visornic/visornic_main.c
b
This patch series cleans up redundant variables and structures in
visornic, and fixes a mistake in handling the return value from
queue_delayed_work().
Benjamin Romer (1):
staging: unisys: correctly handle return value from
queue_delayed_work()
David Kershner (3):
staging: unisys: remove
On Thu, Oct 01, 2015 at 10:43:55PM +0900, Chaehyun Lim wrote:
> This patch replaces int8_t with s8 that is a preferred type.
>
It would be better to just use int.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driver
On Thu, Oct 01, 2015 at 03:00:12PM +0200, Lars Svensson wrote:
> Member screen_base in struct fb_info is declared __iomem causing
> a sparse warning as below when passed to vfree(). This adds typecast
> (__force void *) to silence the warning.
>
> fbtft-core.c:922:39: warning: incorrect type in ar
> Why not just reject it earlier instead of allocating more data?
I agree on your point.
But we have to make different mechanism for that and my patch is only
to fix the current code.
regards
___
devel mailing list
de...@linuxdriverproject.org
http://dri
Hi Brian,
On Mon, 24 Aug 2015 19:10:19 +0200
Boris Brezillon wrote:
> The ->read_xxx() methods are all passed the page number the NAND controller
> is supposed to read, but ->write_xxx() do not have such a parameter.
>
> This is a problem if we want to properly implement data
> scrambling/rando
On Thu, Oct 01, 2015 at 09:11:31AM +0530, Ronit Halder wrote:
> The existing dgap_parsefile() rejects invalid config file.
> But before we know that config file is invalid a lot of memory leak
> can happen. Removing the chances of memory leak won't heart anyone.
>
Why not just reject it earlier i
This patch replaces s32Error with result to avoid camelcase.
Signed-off-by: Chaehyun Lim
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
b/drivers/staging/wilc1000
1 - 100 of 129 matches
Mail list logo
