Re: [PATCH v3 1/1] staging: dgnc: take lock when storing value in dgnc_po ll_tick

2015-09-24 Thread Sudip Mukherjee
On Thu, Sep 24, 2015 at 08:28:50PM +0100, Salah Triki wrote: > On Wed, Sep 23, 2015 at 11:37:37AM +0530, Sudip Mukherjee wrote: > > On Wed, Sep 23, 2015 at 03:28:07AM +0100, Salah Triki wrote: > > > dgnc_poll_tick is declared global, so dgnc_driver_pollrate_store needs to > > > take the > > > lock

Re: [PATCH 04/37] staging/lustre: tracefile: use 64-bit seconds

2015-09-24 Thread Drokin, Oleg
On Sep 24, 2015, at 3:46 AM, Arnd Bergmann wrote: > On Thursday 24 September 2015 04:02:09 Drokin, Oleg wrote: >>> The lustre tracefile has a timestamp defined as >>> >>> __u32 ph_sec; >>> __u64 ph_usec; >>> >>> which seems completely backwards, as the microsecond portion of >>> a tim

Re: [lustre-devel] [PATCH 32/37] staging/lustre: use 64-bit times for exp_last_request_time

2015-09-24 Thread Drokin, Oleg
On Sep 24, 2015, at 9:07 PM, Drokin, Oleg wrote: > > On Sep 24, 2015, at 4:15 PM, Arnd Bergmann wrote: > Anyway this does remove a lot of stuff that we don't really need in the > client, > I'll try to get it built and tested just to make sure it does not really > break anything

Re: [lustre-devel] [PATCH 32/37] staging/lustre: use 64-bit times for exp_last_request_time

2015-09-24 Thread Drokin, Oleg
On Sep 24, 2015, at 4:15 PM, Arnd Bergmann wrote: Anyway this does remove a lot of stuff that we don't really need in the client, I'll try to get it built and tested just to make sure it does not really break anything (unfortunately it does not seem to apply cleanly to t

[PATCH v2 10/12] staging: comedi: rtd520: tidy up block comments

2015-09-24 Thread H Hartley Sweeten
Use the preferred block command style. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/rtd520.c | 68 + 1 file changed, 36 insertions(+), 32 deletions(-) diff --git a/drivers/staging/comedi/drivers/rtd52

[PATCH v2 11/12] staging: comedi: rtd520: use DIV_ROUND_CLOSEST and DIV_ROUND_UP macros

2015-09-24 Thread H Hartley Sweeten
Use the macros to clarify the divisor calculations. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/rtd520.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/rtd520.c b/drivers/stag

[PATCH v2 12/12] staging: comedi: rtd520: hook up 8254 timer/counter subdevice

2015-09-24 Thread H Hartley Sweeten
There is a standard 8254 Timer/Counter device on the board. Hook up the subdevice for the user. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/Kconfig | 1 + drivers/staging/comedi/drivers/rtd520.c | 112 ++--

[PATCH v2 08/12] staging: comedi: rtd520: fix rtd_ao_winsn()

2015-09-24 Thread H Hartley Sweeten
The "comedi range and offset conversions" in this function is incorrect. According to the hardware manual, the DAC registers are defined as: | D15 | D14-D03 | D02 | | D01 | D00 | | Sign | 12-bit data | (see manual) | The extended 'Sign' bit is only used for bipolar ranges to ind

[PATCH v2 09/12] staging: comedi: rtd520: remove unnecessary function desc. block comments

2015-09-24 Thread H Hartley Sweeten
These function description comments are cut-and-paste cruft from the old skeleton driver. Remove them. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/rtd520.c | 30 -- 1 file changed, 30 deletions(-) diff -

[PATCH v2 07/12] staging: comedi: rtd520: convert DAC register defines to macros

2015-09-24 Thread H Hartley Sweeten
For aesthetics, convert the defines for the various DAC registers into macros that take the comedi channel and return the correct offset. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/rtd520.c | 33 - 1

[PATCH v2 06/12] staging: comedi: rtd520: remove unnecessary comments from rtd_ao_winsn()

2015-09-24 Thread H Hartley Sweeten
These comments are cut-and-paste from the old skeleton driver. Remove them. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/rtd520.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/rtd520.c b/drive

[PATCH v2 04/12] staging: comedi: rtd520: rename rtd520Boards

2015-09-24 Thread H Hartley Sweeten
For aesthetics, rename this CamelCase array. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/rtd520.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/comedi/drivers/rtd520.c b/drivers/staging/c

[PATCH v2 03/12] staging: comedi: rtd529: usleep_range is preferred over udelay

2015-09-24 Thread H Hartley Sweeten
Fix checkpatch issue: "CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt". `udelay()` is only used in the firmware upload process. Replace them with `usleep_range()` with a reasonable upper limit. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kr

[PATCH v2 02/12] staging: comedi: rtd520: fix logical continuations

2015-09-24 Thread H Hartley Sweeten
Fix the checkpatch.pl issues about: CHECK: Logical continuations should be on the previous line Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/rtd520.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH v2 05/12] staging: comedi: rtd520: move constants to right side of comparisons

2015-09-24 Thread H Hartley Sweeten
Fix the checkpatch.pl issues about: WARNING: Comparisons should place the constant on the right side of the test Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/rtd520.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions

[PATCH v2 01/12] staging: comedi: rtd520: prefer using the BIT macro

2015-09-24 Thread H Hartley Sweeten
Use the BIT macro to define the register bits. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/rtd520.c | 54 - 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/drivers/staging/comedi/drive

[PATCH v2 00/12] staging: comedi: rtd520: tidy up driver

2015-09-24 Thread H Hartley Sweeten
Tidy up this driver and fix all the checkpatch.pl issues. v2: fix patch 08/12 based on comments from Ian Abbott add patch 12/12 to hook up the 8254 timer/counter H Hartley Sweeten (12): staging: comedi: rtd520: prefer using the BIT macro staging: comedi: rtd520: fix logical continuations

Re: [PATCH v11 3/4] add FPGA manager core

2015-09-24 Thread Pavel Machek
Hi! > > Of course, the maintainer gets the last word regardless of what anyone > > else thinks. > > > > Generally, minimal code is better. Trying to future proof code is a > > waste of time because you can't predict what will happen in the future. > > It's way more likely that some pointer you n

Re: [PATCH v11 3/4] add FPGA manager core

2015-09-24 Thread atull
On Thu, 24 Sep 2015, Dan Carpenter wrote: > Of course, the maintainer gets the last word regardless of what anyone > else thinks. > > Generally, minimal code is better. Trying to future proof code is a > waste of time because you can't predict what will happen in the future. > It's way more like

Re: [PATCH v11 3/4] add FPGA manager core

2015-09-24 Thread atull
On Wed, 23 Sep 2015, Josh Cartwright wrote: > On Wed, Sep 23, 2015 at 12:10:13PM -0500, atull wrote: > > On Tue, 22 Sep 2015, Josh Cartwright wrote: > [..] > > > > +struct fpga_manager *of_fpga_mgr_get(struct device_node *node) > > > > +{ > > > > + struct fpga_manager *mgr; > > > > + s

Re: [PATCH 32/37] staging/lustre: use 64-bit times for exp_last_request_time

2015-09-24 Thread Arnd Bergmann
On Thursday 24 September 2015 19:03:12 Drokin, Oleg wrote: > On Sep 24, 2015, at 2:54 PM, Arnd Bergmann wrote: > > On Thursday 24 September 2015 16:01:40 Drokin, Oleg wrote: > >> On Sep 24, 2015, at 11:18 AM, Arnd Bergmann wrote: > >>> On Thursday 24 September 2015 03:55:20 Drokin, Oleg wrote: > >>

[PATCH] staging: fsl-mc: Moved kernel-doc comments to .c files

2015-09-24 Thread J. German Rivera
Moved kernel-doc comments for non-inline functions from header files to .c files. Signed-off-by: J. German Rivera --- This patch depends on the patch series posted at http://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg980804.html. drivers/staging/fsl-mc/bus/dpbp.c | 202 +

Re: [PATCH v3 1/1] staging: dgnc: take lock when storing value in dgnc_po ll_tick

2015-09-24 Thread Salah Triki
On Wed, Sep 23, 2015 at 11:37:37AM +0530, Sudip Mukherjee wrote: > On Wed, Sep 23, 2015 at 03:28:07AM +0100, Salah Triki wrote: > > dgnc_poll_tick is declared global, so dgnc_driver_pollrate_store needs to > > take the > > lock dgnc_poll_lock before modifying this variable. dgnc_poll_lock is the >

[PATCH 6/6] Staging: rtl8712: xmit_linux.c: Coding style warning fix for block comment

2015-09-24 Thread Punit Vara
This patch is to the xmit_linux.c file that fixes up following warnings generated by checkpatch.pl tool : -Block comments use a trailing */ on a separate line Signed-off-by: Punit Vara --- drivers/staging/rtl8712/xmit_linux.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a

[PATCH 4/6] Staging: rtl8712: wifi.h: Coding style warning fix for block comment

2015-09-24 Thread Punit Vara
This patch is to the wifi.h file that fixes up following warnings generated by checkpatch.pl tool : -Block comments use a trailing */ on a separate line -Block comments use a * on subsequent lines Signed-off-by: Punit Vara --- drivers/staging/rtl8712/wifi.h | 35 ---

[PATCH 5/6] Staging: rtl8712: wlan_bssdef.h: Coding style warnings fix for block comments

2015-09-24 Thread Punit Vara
This patch is to the wlan_bssdef.h file that fixes up following warnings generated by checkpatch.pl : -Block comments use a trailing */ on a separate line -Block comments use a * on subsequent lines Signed-off-by: Punit Vara --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +++- 1 file ch

[PATCH 3/6] Staging: rtl8712: usb_intf.c: Coding style warnings fix for block comments

2015-09-24 Thread Punit Vara
This patch is to the usb_intf.c file that fixes up following warnings generated by checkpatch.pl : -Block comments use a trailing */ on a separate line Signed-off-by: Punit Vara --- drivers/staging/rtl8712/usb_intf.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git

Re: [PATCH 32/37] staging/lustre: use 64-bit times for exp_last_request_time

2015-09-24 Thread Drokin, Oleg
On Sep 24, 2015, at 2:54 PM, Arnd Bergmann wrote: > On Thursday 24 September 2015 16:01:40 Drokin, Oleg wrote: >> >> On Sep 24, 2015, at 11:18 AM, Arnd Bergmann wrote: >> >>> On Thursday 24 September 2015 03:55:20 Drokin, Oleg wrote: On Sep 23, 2015, at 3:13 PM, Arnd Bergmann wrote:

[PATCH 2/6] Staging: rtl8712: usb_halinit.c: Coding style warning fix for block comment

2015-09-24 Thread Punit Vara
This patch is to the usb_halinit.c file that fixes up following warnings generated by checkpatch.pl : -Block comments use a trailing */ on a separate line Signed-off-by: Punit Vara --- drivers/staging/rtl8712/usb_halinit.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dr

[PATCH 1/6] Staging: rtl8712: rtl871x_xmit.h: Coding style warnings fix for block comments

2015-09-24 Thread Punit Vara
This patch is to the rtl871x_xmit.h file that fixes up following warnings generated by checkpatch.pl : -Block comments use a trailing */ on a separate line Signed-off-by: Punit Vara --- drivers/staging/rtl8712/rtl871x_xmit.h | 12 1 file changed, 8 insertions(+), 4 deletions(-) di

Re: [PATCH 32/37] staging/lustre: use 64-bit times for exp_last_request_time

2015-09-24 Thread Arnd Bergmann
On Thursday 24 September 2015 16:01:40 Drokin, Oleg wrote: > > On Sep 24, 2015, at 11:18 AM, Arnd Bergmann wrote: > > > On Thursday 24 September 2015 03:55:20 Drokin, Oleg wrote: > >> On Sep 23, 2015, at 3:13 PM, Arnd Bergmann wrote: > >> > >>> The last request time is stored as an 'unsigned lon

RE: [PATCH v2 6/6] staging: fsl-mc: up-rev dprc binary interface to v4.0

2015-09-24 Thread Jose Rivera
> -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Wednesday, September 23, 2015 4:27 AM > To: Rivera Jose-B46482 > Cc: gre...@linuxfoundation.org; a...@arndb.de; > de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org; Yoder Stuart- > B08248; katz Ita

Dear customer:

2015-09-24 Thread Mr. Raymond Goodman
Dear customer: This is Mr. Raymond Goodman from western union Head office here in Benin Du Republic. We presently send your first payment of $5000 this morning from our office, so you are requested to contact Head office now with full information where you want your first payment to be transfe

RE: [PATCH 08/11] staging: comedi: rtd520: tidy up rtd_ao_winsn()

2015-09-24 Thread Hartley Sweeten
On Thursday, September 24, 2015 10:57 AM, Ian Abbott wrote: > On 24/09/15 18:43, Ian Abbott wrote: >> On 24/09/15 18:20, Hartley Sweeten wrote: >>> I guess the sign bit would also need to be extended for the bipolar >>> values. So: >>> >>>for (i = 0; i < insn->n; ++i) { >>> unsigned

Re: [PATCH 08/11] staging: comedi: rtd520: tidy up rtd_ao_winsn()

2015-09-24 Thread Ian Abbott
On 24/09/15 18:43, Ian Abbott wrote: On 24/09/15 18:20, Hartley Sweeten wrote: I guess the sign bit would also need to be extended for the bipolar values. So: for (i = 0; i < insn->n; ++i) { unsigned int val = data[i]; /* bipolar ranges use 2's complement values */

Re: [PATCH 08/11] staging: comedi: rtd520: tidy up rtd_ao_winsn()

2015-09-24 Thread Ian Abbott
On 24/09/15 18:20, Hartley Sweeten wrote: On Thursday, September 24, 2015 4:00 AM, Ian Abbott wrote: On 23/09/15 20:16, H Hartley Sweeten wrote: For aesthetics, rename this function and tidy it up a bit. Use the comedi_range_is_bipolar() and comedi_offset_munge() helpers to handle the 2's com

RE: [PATCH 08/11] staging: comedi: rtd520: tidy up rtd_ao_winsn()

2015-09-24 Thread Hartley Sweeten
On Thursday, September 24, 2015 4:00 AM, Ian Abbott wrote: > On 23/09/15 20:16, H Hartley Sweeten wrote: >> For aesthetics, rename this function and tidy it up a bit. >> >> Use the comedi_range_is_bipolar() and comedi_offset_munge() helpers >> to handle the 2's complement munging. >> >> Save the r

randconfig build error with next-20150924, in drivers/staging/rdma/hfi1

2015-09-24 Thread Jim Davis
Building with the attached random configuration file, warning: (INTEL_SOC_DTS_IOSF_CORE && PUNIT_ATOM_DEBUG) selects IOSF_MBI which has unmet direct dependencies (PCI) warning: (SND_SOC_INTEL_BYTCR_RT5640_MACH && SND_SOC_INTEL_CHT_BSW_RT5672_MACH && SND_SOC_INTEL_CHT_BSW_RT5645_MACH && SND_SOC_INT

Re: [PATCH] Staging: rtl8712: rtl871x_mp.h: Coding style warnings fix for block comment

2015-09-24 Thread punit vara
On Thu, Sep 24, 2015 at 4:52 PM, Dan Carpenter wrote: > On Thu, Sep 24, 2015 at 03:57:22PM +0530, Sudip Mukherjee wrote: >> On Thu, Sep 24, 2015 at 12:00:01PM +0300, Dan Carpenter wrote: >> > On Thu, Sep 24, 2015 at 01:54:22AM +0530, Punit Vara wrote: >> > > This is a patch to the rtl871x_mp.h tha

Re: [PATCH 13/13] Staging: rtl8712: Coding style warning fix for block comment

2015-09-24 Thread punit vara
On Thu, Sep 24, 2015 at 9:55 AM, Sudip Mukherjee wrote: > On Wed, Sep 23, 2015 at 11:22:09PM +0530, punit vara wrote: >> On Wed, Sep 23, 2015 at 10:25 PM, punit vara wrote: >> > Thank you very much sir I will definitely follow that. I have seen so >> > many people fixing patches over here. Now I

Re: [PATCH] Staging: rtl8712: rtl871x_io.h: Coding style warning fix for block comments

2015-09-24 Thread punit vara
On Thu, Sep 24, 2015 at 11:25 AM, Sudip Mukherjee wrote: > On Thu, Sep 24, 2015 at 01:22:33AM +0530, Punit Vara wrote: >> This patch is to the rtl871x_io.h file that fixes up following warning >> reported by checkpatch.pl : >> >> Signed-off-by: Punit Vara >> --- > You missed copying the warning a

Re: [PATCH 32/37] staging/lustre: use 64-bit times for exp_last_request_time

2015-09-24 Thread Drokin, Oleg
On Sep 24, 2015, at 11:18 AM, Arnd Bergmann wrote: > On Thursday 24 September 2015 03:55:20 Drokin, Oleg wrote: >> On Sep 23, 2015, at 3:13 PM, Arnd Bergmann wrote: >> >>> The last request time is stored as an 'unsigned long', which is >>> good enough until 2106, but it is then converted to 'lon

Re: [PATCH 32/37] staging/lustre: use 64-bit times for exp_last_request_time

2015-09-24 Thread Arnd Bergmann
On Thursday 24 September 2015 03:55:20 Drokin, Oleg wrote: > On Sep 23, 2015, at 3:13 PM, Arnd Bergmann wrote: > > > The last request time is stored as an 'unsigned long', which is > > good enough until 2106, but it is then converted to 'long' in > > some places, which overflows in 2038. > > > >

Re: [PATCH 06/19] staging: media: omap4iss: fix handling platform_get_irq result

2015-09-24 Thread Dan Carpenter
On Thu, Sep 24, 2015 at 04:00:14PM +0200, Andrzej Hajda wrote: > Hi, > > To avoid problems with too many mail recipients I have sent whole > patchset only to LKML. Anyway patches have no dependencies. > I'm pretty sure mailman or whatever counts CCs as recipients as well. regards, dan carpenter

[PATCH v5] staging: unisys: Add s-Par visorhba

2015-09-24 Thread Benjamin Romer
From: David Kershner This driver create a host bus adapter device when s-Par sends a device create message to create a storage adapter on the visorbus. When the message is received by visorbus, the visorhba_probe function is called and the hba device is created and managed by the visorhba driver.

[PATCH 06/19] staging: media: omap4iss: fix handling platform_get_irq result

2015-09-24 Thread Andrzej Hajda
The function can return negative value. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 Signed-off-by: Andrzej Hajda --- Hi, To avoid problems with too many mail

Re: [PATCH] staging: sm750fb: replace twoToPowerOfx with shift operator

2015-09-24 Thread Michał Kępień
> The function twoToPowerOfx that iteratively caclulates the power of 2 > may be replaced with shift operator calculates > -inline unsigned int twoToPowerOfx(unsigned long x) > -{ > - unsigned long i; > - unsigned long result = 1; > - > - for (i = 1; i <= x; i++) > - resul

[PATCH] staging: sm750fb: replace twoToPowerOfx with shift operator

2015-09-24 Thread Mike Rapoport
The function twoToPowerOfx that iteratively caclulates the power of 2 may be replaced with shift operator Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_chip.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_c

Re: [PATCH v2 1/3] staging: sm7xxfb: move sm712fb out of staging

2015-09-24 Thread Tomi Valkeinen
On 02/09/15 15:48, Sudip Mukherjee wrote: > Now I am getting confused. :( > Since this has already been merged I guess we need to maintain it now. Oh, ok. I thought it was still in staging. I haven't been able to follow the list properly lately... Well, in theory we could still revert it, as it

Re: [PATCH] Staging: rtl8712: rtl871x_mp.h: Coding style warnings fix for block comment

2015-09-24 Thread Dan Carpenter
On Thu, Sep 24, 2015 at 03:57:22PM +0530, Sudip Mukherjee wrote: > On Thu, Sep 24, 2015 at 12:00:01PM +0300, Dan Carpenter wrote: > > On Thu, Sep 24, 2015 at 01:54:22AM +0530, Punit Vara wrote: > > > This is a patch to the rtl871x_mp.h that fixes up following warnings > > > reported by checkpatch.p

Re: [PATCH 00/11] staging: comedi: rtd520: tidy up driver

2015-09-24 Thread Ian Abbott
On 23/09/15 20:16, H Hartley Sweeten wrote: Tidy up this driver and fix all the checkpatch.pl issues. H Hartley Sweeten (11): staging: comedi: rtd520: prefer using the BIT macro staging: comedi: rtd520: fix logical continuations staging: comedi: rtd529: usleep_range is preferred over ud

Re: [PATCH 08/11] staging: comedi: rtd520: tidy up rtd_ao_winsn()

2015-09-24 Thread Ian Abbott
On 23/09/15 20:16, H Hartley Sweeten wrote: For aesthetics, rename this function and tidy it up a bit. Use the comedi_range_is_bipolar() and comedi_offset_munge() helpers to handle the 2's complement munging. Save the readback value after the conversion is complete. Signed-off-by: H Hartley Sw

Re: [PATCH] Staging: rtl8712: rtl871x_mp.h: Coding style warnings fix for block comment

2015-09-24 Thread Sudip Mukherjee
On Thu, Sep 24, 2015 at 12:00:01PM +0300, Dan Carpenter wrote: > On Thu, Sep 24, 2015 at 01:54:22AM +0530, Punit Vara wrote: > > This is a patch to the rtl871x_mp.h that fixes up following warnings > > reported by checkpatch.pl : > > > > -Block comments use a trailing */ on a separate line > > >

[PATCH 13/15] staging: wilc1000: remove mutex txq_cs and it's related codes

2015-09-24 Thread Glen Lee
mutex txq_cs is never used in the driver. txq_cs, txq_critical_section and txq_lock have same pointer so just delete them and it's related codes. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 5 - drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 - drivers/stag

[PATCH 07/15] staging: wilc1000: remove pointer variable of g_linux_wlan->txq_event

2015-09-24 Thread Glen Lee
Remove variable txq_wait and txq_wait_event which are pointer varialbe of g_linux_wlan->txq_event. No need to have extra pointer varialbe. Just use g_linux_wlan->txq_event. Remove os_context.txq_wait_event, txq_wait and it's related codes. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/lin

[PATCH 15/15] staging: wilc1000: remove variable cif_func

2015-09-24 Thread Glen Lee
This patch removes variable cif_func and use mac_cfg directly. No need to have another pointer variable. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/wilc_wlan.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/driv

[PATCH 12/15] staging: wilc1000: remove variable rx_buffer_size

2015-09-24 Thread Glen Lee
This patch removes two variables rx_buffer_size and use LINUX_RX_SIZE as argument. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 3 --- drivers/staging/wilc1000/wilc_wlan.c| 9 ++--- drivers/staging/wilc1000/wilc_wlan_if.h | 3 --- 3 files changed, 2 insertions(+)

[PATCH 10/15] staging: wilc1000: remove pointer varialbes of hif_cs

2015-09-24 Thread Glen Lee
Remove hif_lock and hif_critical_section which are pointer of g_linux_wlan->hif_cs. Remove also it's related codes. Just use mutex varialbe g_linux_wlan->hif_cs. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 1 - drivers/staging/wilc1000/wilc_wlan.c| 10 -- d

[PATCH 14/15] staging: wilc1000: remove function pointer os_wait

2015-09-24 Thread Glen Lee
This patch removes function pointer os_wait which is pointer of linux_wlan_lock_timeout and just call the real name function directly. Remove also static from linux_wlan_lock_timeout declaration. As os_wait is deleted, structure wilc_wlan_os_func_t is useless. Delete wilc_wlan_os_func_t, os_func an

[PATCH 11/15] staging: wilc1000: remove variable tx_buffer_size

2015-09-24 Thread Glen Lee
This patch removes unnecessary two variables tx_buffer_size and just use LINUX_TX_SIZE as argument. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 1 - drivers/staging/wilc1000/wilc_wlan.c| 6 ++ drivers/staging/wilc1000/wilc_wlan_if.h | 1 - 3 files changed, 2 ins

[PATCH 09/15] staging: wilc1000: remove pointer variables of txq_add_to_head_cs

2015-09-24 Thread Glen Lee
This patch removes txq_add_to_head_critical_section and txq_add_to_head_lock which are pointer of g_linux_wlan->txq_add_to_head_cs. Just use g_linux_wlan->txq_add_to_head_cs as argument of function. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 3 --- drivers/staging/wil

[PATCH 06/15] staging: wilc1000: use g_linux_wlan->rxq_cs for function arguemnt

2015-09-24 Thread Glen Lee
Use mutex variable g_linux_wlan->rxq_cs instead of pointer varialbe. No need to make extra pointer variable for the mutex. Remove rxq_critical_section, rxq_lock and it's related codes. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 1 - drivers/staging/wilc1000/wilc_wlan.

[PATCH 04/15] staging: wilc1000: remove function pointer os_debug

2015-09-24 Thread Glen Lee
This patch removes os_debug and call linux_wlan_dbg function instead of os_debug. Delete static from the linux_wlan_dbg. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 3 +-- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 + drivers/staging/wilc1000/wilc_wlan.c

[PATCH 05/15] staging: wilc1000: use g_linux_wlan->txq_spinlock not the pointer of it

2015-09-24 Thread Glen Lee
Use spinlock variable g_linux_wlan->txq_spinlock itself instead of g_wlan.txq_spinlock which is pointer of g_linux_wlan->txq_spinlock. Delete os_context.txq_spin_lock, g_wlan.txq_spinlock and it's related codes. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 2 -- d

[PATCH 08/15] staging: wilc1000: remove pointer varialbe cfg_wait and cfg_wait_event

2015-09-24 Thread Glen Lee
This patch removes cfg_wait and cfg_wait_event which are pointer of g_linux_wlan->cfg_event. No need to have pointer varialbe of it. Just use g_linux_wlan->cfg_event. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 2 -- drivers/staging/wilc1000/wilc_wlan.c| 14 +++

[PATCH 02/15] staging: wilc1000: remove function pointer mac_indicate

2015-09-24 Thread Glen Lee
No need for a pointer to a function. Just call linux_wlan_mac_indicate. Remove mac_indicate and also wilc_wlan_indicate_func_t since no members in it. Variable indicate_func is not used so delete it and related codes. Finally remove static from the function linux_wlan_mac_indicate. Signed-off-by:

[PATCH 03/15] staging: wilc1000: remove function pointer rx_complete

2015-09-24 Thread Glen Lee
just call the function linux_wlan_rx_complete directly. No need for a pointer to the functions. Remove rx_complete, wilc_wlan_net_func_t and net_func which are not used anymore. Finally remove static from the function linux_wlan_rx_complete. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/l

[PATCH 01/15] staging: wilc1000: remove function pointer rx_indicate

2015-09-24 Thread Glen Lee
This patch removes function pointer rx_indicate and call the function frmw_to_linux directly. Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 2 -- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 + drivers/staging/wilc1000/wilc_wlan.c | 11 +-- d

Re: [PATCH] Staging: rtl8712: rtl871x_mp.h: Coding style warnings fix for block comment

2015-09-24 Thread Dan Carpenter
On Thu, Sep 24, 2015 at 01:54:22AM +0530, Punit Vara wrote: > This is a patch to the rtl871x_mp.h that fixes up following warnings > reported by checkpatch.pl : > > -Block comments use a trailing */ on a separate line > > Signed-off-by: Punit Vara > --- > drivers/staging/rtl8712/rtl871x_mp.h |

Re: [PATCH 0/3] staging/wlan-ng: fix buffer overflow and clean up redundant code

2015-09-24 Thread Dan Carpenter
Looks good. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 19/37] staging/lustre: use 64-bit time for procfs output

2015-09-24 Thread Arnd Bergmann
On Thursday 24 September 2015 10:40:09 Sudip Mukherjee wrote: > On Wed, Sep 23, 2015 at 09:13:42PM +0200, Arnd Bergmann wrote: > > This time is only printed in procfs, and can be easily converted > > to 64-bit to avoid overflowing on 32-bit systems in 2038. > > > > Signed-off-by: Arnd Bergmann >

Re: [PATCH v11 3/4] add FPGA manager core

2015-09-24 Thread Dan Carpenter
Of course, the maintainer gets the last word regardless of what anyone else thinks. Generally, minimal code is better. Trying to future proof code is a waste of time because you can't predict what will happen in the future. It's way more likely that some pointer you never expected to be NULL will

Re: [PATCH 04/37] staging/lustre: tracefile: use 64-bit seconds

2015-09-24 Thread Arnd Bergmann
On Thursday 24 September 2015 04:02:09 Drokin, Oleg wrote: > > The lustre tracefile has a timestamp defined as > > > > __u32 ph_sec; > > __u64 ph_usec; > > > > which seems completely backwards, as the microsecond portion of > > a time stamp will always fit into a __u32 value, while th

[PATCH V2] staging: rtl8723au: Remove unneeded endianness conversions

2015-09-24 Thread Lars Svensson
Fixing Sparse warnings in rtw_security.c. When checking crc, both actual and expected value was converted to cpu endianness before comparing, causing sparse warnings as below. Since the values are read from the buffer in correct byte order the extra conversions should not be needed. Thanks to Larr